Chris Smith
73b689959b
Remove PMD rules for empty constructors.
Dagger requires @Inject annotated blank constructors in some
cases, which our PMD rules are complaining about.
Change-Id: I969b974c91cc5faacb6a95daabc2567322293fd3
Reviewed-on: http://gerrit.dmdirc.com/2646
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 vuotta sitten
b87e3ba335
Update copyright for 2013
Change-Id: Idf38f5027a92166daf99039de75b759d47431de1
Reviewed-on: http://gerrit.dmdirc.com/2607
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
11 vuotta sitten
48111fcd24
Fix checkstyle errors in teamcity
Change-Id: Ib74a9e3f9363391015ca51fead607be7820ba7c5
Reviewed-on: http://gerrit.dmdirc.com/2582
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
11 vuotta sitten
Chris Smith
b7fce148c2
Get rid of all non-P1 rules so PMD output is less difficult to debug
Change-Id: Id0695cffe60edc19dd0a7c35782ba029cf7adb7f
Reviewed-on: http://gerrit.dmdirc.com/2380
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
12 vuotta sitten
56d1406cdd
UpdateCopyright.sh now matches some more things that we missed before.
When matching lines, check for the word "DMDirc" in the header aswell so as not to change other peoples copyright.
Change-Id: Ibb44871d3c75e12bfc8acd8410d6043910d072c5
Reviewed-on: http://gerrit.dmdirc.com/2301
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
12 vuotta sitten
52577a8878
IMO these would be better picked up by code review, too many false positives.
Change-Id: I3cbcafd8dfa863cdaaa8123974b869b2f7a2e3db
Reviewed-on: http://gerrit.dmdirc.com/2111
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
13 vuotta sitten
Chris Smith
8465351131
Local variables must be final where appropriate. Yay.
Change-Id: I472c5dba1dd01c8cd37a58b314cebd60c4583857
Depends-On: Ied3a5a2d993bd74c04eaa357bcbef7218871f529
Reviewed-on: http://gerrit.dmdirc.com/2083
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
13 vuotta sitten
Chris Smith
bced15855a
Use isEmpty()
Change-Id: I2552cd3e56688e05a25c67d84b1f4e345e7f64cb
Depends-On: Ia3516d14e1031901c763fbf2c0530e179b30efeb
Reviewed-on: http://gerrit.dmdirc.com/2085
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 vuotta sitten
d04e2bea4f
Change header?
Change-Id: I635e0d111ed182713132145e4d5fb1654f776ec4
Reviewed-on: http://gerrit.dmdirc.com/2071
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 vuotta sitten
6dcc08ddeb
Up priority of yet another rule
Change-Id: Ifc7a19c6691e9f21b2e30264e12ac106028407cb
Reviewed-on: http://gerrit.dmdirc.com/2064
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 vuotta sitten
734e5c29c4
Force replacing vector with list
Change-Id: Id4fecd1e331a27ca02667786da75f2a643938b8a
Reviewed-on: http://gerrit.dmdirc.com/2056
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
13 vuotta sitten
f1528d1b24
Up priority of PMD optimiseToArray check
Change-Id: I976739a2bff459d95834f6333bca7139631de402
Reviewed-on: http://gerrit.dmdirc.com/2054
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
13 vuotta sitten
Chris Smith
bb70d16d7b
Remove unused private fields
Make having unused fields or formal params a PMD error
Change-Id: Ief1c8e499af7e3a43328046dc140ba941d8cb010
Depends-On: I970b49db0abac46d15a11e2b71dc0b50bd3a8faf
Reviewed-on: http://gerrit.dmdirc.com/2034
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
13 vuotta sitten
Chris Smith
2c840ab707
Remove unused ctors
Make unused ctors a PMD error
Change-Id: I10f7350e9435179e1c6f89e01233778ddffa648a
Reviewed-on: http://gerrit.dmdirc.com/2029
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
13 vuotta sitten
Chris Smith
26f45e3ab4
Another stab at fixing teamcity-info.xml
Change-Id: I41c318644eada710c78812260a8397fddd924465
Reviewed-on: http://gerrit.dmdirc.com/1787
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 vuotta sitten
Chris Smith
4e24305adc
Fiddling with clover XSL to make it output valid teamcity files
Change-Id: I30a88fcd2bab38346dacd02ae9773ffd94ed19c4
Reviewed-on: http://gerrit.dmdirc.com/1786
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 vuotta sitten
Chris Smith
eecd56d8b8
Add ant target and XSL to make teamcity report from clover
Change-Id: Ibace6a7b302586afb8c430d80f36341f424f983e
Reviewed-on: http://gerrit.dmdirc.com/1780
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
13 vuotta sitten
decf547f64
Reduce the severity of line length checking in checkstyle
Change-Id: I002b0bcc66ae2d8fd299dd8ca584278975a692cd
Reviewed-on: http://gerrit.dmdirc.com/1758
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 vuotta sitten
3b732be850
Allow undeclared RTE in javadoc checks
Change-Id: I0fbb91e1f8820f50ec0ae272abd17e698ea958ae
Reviewed-on: http://gerrit.dmdirc.com/1753
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 vuotta sitten
Chris Smith
b9bab1811e
New checkstyle rules
Change-Id: Ia48c476c7abc2da714626aa80d1fe46d567a269f
Reviewed-on: http://gerrit.dmdirc.com/1749
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 vuotta sitten
Chris Smith
6b6cec7c83
Checkstyle stuff
Remove targets for individual weird bits of the codebase
Add in code from submodules
Include checkstyle jar in the lib directory
Update rules for checkstyle 5.3
Change-Id: I85b5a53165fcef05bb176d4f5e93aa6ae3cf562a
Reviewed-on: http://gerrit.dmdirc.com/1747
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 vuotta sitten
Chris Smith
47af8cd7ce
PMD fixes and rule updates
Lots more rules treated as errors now
Change-Id: Ie8065d958bd4fbd7cccb1c06aefbc459cfde01c3
Reviewed-on: http://gerrit.dmdirc.com/1746
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 vuotta sitten
fd83b6b2a9
Update Copyright
Change-Id: I7f63fdd02ea0109fe31e55c44b078edae3862f32
Reviewed-on: http://gerrit.dmdirc.com/1726
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 vuotta sitten
Chris Smith
dd28ec1684
Custom DMDirc PMD checks
Change-Id: Ifca632fd9afab2f2e291b1ac5d6cce3bb255756c
Reviewed-on: http://gerrit.dmdirc.com/1577
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 vuotta sitten
Chris Smith
bb22afed5c
Add minimal PMD ruleset and build target
Change-Id: I91a99b0e6cc6ae6feb7d80f853d60aa0f5c26d9a
Reviewed-on: http://gerrit.dmdirc.com/1575
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 vuotta sitten
Chris Smith
440606618e
PMD fixes
Fix package names
Include submodules
Show generation timestamp at end of report
Change-Id: I1d4bb04840f5631369e96ef2d43ea5dd08a82634
Reviewed-on: http://gerrit.dmdirc.com/1337
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
14 vuotta sitten
b691b14491
Update the copyright date on all files.
UpdateCopyright.sh now works out the year automatically.
UpdateCopyright.sh now ignores .git aswell as .svn
UpdateCopyright.sh now excludes Binary Files from being matched during the initial search, rather than as an afterthought.
Change-Id: I2cfc56851a4217a4c85cbc7361c7a90421aae717
Reviewed-on: http://gerrit.dmdirc.com/202
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Tested-by: Shane Mc Cormack <shane@dmdirc.com >
14 vuotta sitten
ad6cddbba0
Update copyright header to 2009
15 vuotta sitten
Chris Smith
5eafeb64ae
Remove old build files
git-svn-id: http://svn.dmdirc.com/trunk@4591 00569f92 -eb28-0410-84fd-f71c24880f
15 vuotta sitten
Chris Smith
f8f10cfaf7
Build-file fiddlage. Does not impact functionality.
git-svn-id: http://svn.dmdirc.com/trunk@4588 00569f92 -eb28-0410-84fd-f71c24880f
15 vuotta sitten
061d241d09
Put findbugs output in separate dir for bamboo
git-svn-id: http://svn.dmdirc.com/trunk@4310 00569f92 -eb28-0410-84fd-f71c24880f
16 vuotta sitten
Chris Smith
8ff5bfd3dc
Clean and compile before running reports
git-svn-id: http://svn.dmdirc.com/trunk@4299 00569f92 -eb28-0410-84fd-f71c24880f
16 vuotta sitten
Chris Smith
0d1ac53ca4
Make PMD ignore AvoidFinalLocalVariable rule, which would appear to suck balls
git-svn-id: http://svn.dmdirc.com/trunk@4294 00569f92 -eb28-0410-84fd-f71c24880f
16 vuotta sitten
Chris Smith
3539f63724
Get rid of stupid delete-xml-files task
git-svn-id: http://svn.dmdirc.com/trunk@4293 00569f92 -eb28-0410-84fd-f71c24880f
16 vuotta sitten
792f53c860
Merge changes from renji
git-svn-id: http://svn.dmdirc.com/trunk@4291 00569f92 -eb28-0410-84fd-f71c24880f
16 vuotta sitten
Chris Smith
912f18f2e8
Checkstyle's global report doesn't include MiG layout
git-svn-id: http://svn.dmdirc.com/trunk@3965 00569f92 -eb28-0410-84fd-f71c24880f
16 vuotta sitten
Chris Smith
46ba750f21
Remove "design for extension" from checkstyle checks
git-svn-id: http://svn.dmdirc.com/trunk@3964 00569f92 -eb28-0410-84fd-f71c24880f
16 vuotta sitten
0e96a879a7
Import changes from renji
git-svn-id: http://svn.dmdirc.com/trunk@3857 00569f92 -eb28-0410-84fd-f71c24880f
16 vuotta sitten
cefa9ae0fe
Updating files from sora
git-svn-id: http://svn.dmdirc.com/trunk@3157 00569f92 -eb28-0410-84fd-f71c24880f
16 vuotta sitten
882e9e735d
Updated copyright header on all files.
2006-2007 -> 2006-2008
git-svn-id: http://svn.dmdirc.com/trunk@3151 00569f92 -eb28-0410-84fd-f71c24880f
16 vuotta sitten
07072ed4dd
Updated reports to reflect identities package name change
git-svn-id: http://svn.dmdirc.com/trunk@1702 00569f92 -eb28-0410-84fd-f71c24880f
17 vuotta sitten
ea4c9cbc16
Fixed report generation on webserver
git-svn-id: http://svn.dmdirc.com/trunk@1614 00569f92 -eb28-0410-84fd-f71c24880f
17 vuotta sitten
780c9cd150
Added findbugs ant task
git-svn-id: http://svn.dmdirc.com/trunk@1467 00569f92 -eb28-0410-84fd-f71c24880f
17 vuotta sitten
ba7afe401b
Added PMD and CPD reports
git-svn-id: http://svn.dmdirc.com/trunk@1456 00569f92 -eb28-0410-84fd-f71c24880f
17 vuotta sitten
6c3708aea1
Moved com.dmdirc imports to the top of the import list in style checks
git-svn-id: http://svn.dmdirc.com/trunk@1398 00569f92 -eb28-0410-84fd-f71c24880f
17 vuotta sitten
67e7fd1341
Fixed ant etc, Package rename should be compelte now
git-svn-id: http://svn.dmdirc.com/trunk@1301 00569f92 -eb28-0410-84fd-f71c24880f
17 vuotta sitten
5c2056e36e
Only have DMDirc checks for checkstyle now
git-svn-id: http://svn.dmdirc.com/trunk@1288 00569f92 -eb28-0410-84fd-f71c24880f
17 vuotta sitten
3a8035a83e
Removed avoid inline conditionals
git-svn-id: http://svn.dmdirc.com/trunk@646 00569f92 -eb28-0410-84fd-f71c24880f
17 vuotta sitten
846ea95070
no longer using deprecated task name <style>
git-svn-id: http://svn.dmdirc.com/trunk@638 00569f92 -eb28-0410-84fd-f71c24880f
17 vuotta sitten
9f7355a02d
Changed setIcon name
Removed magic number checks
git-svn-id: http://svn.dmdirc.com/trunk@613 00569f92 -eb28-0410-84fd-f71c24880f
17 vuotta sitten
Chris Smith
Shane Mc Cormack