Add minimal PMD ruleset and build target

Change-Id: I91a99b0e6cc6ae6feb7d80f853d60aa0f5c26d9a
Reviewed-on: http://gerrit.dmdirc.com/1575
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Greg Holmes <greg@dmdirc.com>

build-reports.xml

@@ -156,7 +156,22 @@
             <ruleset>checkstyle/pmd_checks.xml</ruleset>
             <formatter type="xml" toFile="reports/report-pmd.xml" linkPrefix="http://pmd.sourceforge.net/xref/"/>
             <fileset dir="src/" includes="com/dmdirc/**/*.java" />
-            <fileset dir="modules/plugins/src/" includes="com/dmdirc/**/*.java"/>
+            <fileset dir="modules/plugins/src/" includes="com/dmdirc/**/*.java" excludes="**/commons/*.java"/>
+            <fileset dir="modules/util/src/" includes="com/dmdirc/**/*.java"/>
+            <fileset dir="modules/parser/src/" includes="com/dmdirc/**/*.java"/>
+        </pmd>
+        <xslt in="reports/report-pmd.xml" style="checkstyle/pmd.xslt" out="reports/report-pmd.html" />
+    </target>
+
+    <target name="pmd-minimal" description="Run PMD with minimal ruleset.">
+        <taskdef name="pmd" classpath="lib/pmd-4.2.5.jar:lib/jaxen-1.1.1.jar:lib/asm-3.1.jar"
+                         classname="net.sourceforge.pmd.ant.PMDTask" />
+        <pmd shortFilenames="true">
+
+            <ruleset>checkstyle/pmd_minimal.xml</ruleset>
+            <formatter type="xml" toFile="reports/report-pmd.xml" linkPrefix="http://pmd.sourceforge.net/xref/"/>
+            <fileset dir="src/" includes="com/dmdirc/**/*.java" />
+            <fileset dir="modules/plugins/src/" includes="com/dmdirc/**/*.java" excludes="**/commons/*.java"/>
             <fileset dir="modules/util/src/" includes="com/dmdirc/**/*.java"/>
             <fileset dir="modules/parser/src/" includes="com/dmdirc/**/*.java"/>
         </pmd>

checkstyle/pmd_minimal.xml

@@ -0,0 +1,74 @@
+<?xml version="1.0"?>
+<ruleset name="DMDirc PMD checks"
+	 xmlns="http://pmd.sf.net/ruleset/1.0.0"
+	 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	 xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 http://pmd.sf.net/ruleset_xml_schema.xsd"
+	 xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd">
+	<description>DMDirc minimal PMD checks.</description>
+	
+	<rule ref="rulesets/basic.xml">
+		<exclude name="EmptyCatchBlock"/> <!-- ! -->
+	</rule>
+	<rule ref="rulesets/braces.xml"/>
+	<rule ref="rulesets/clone.xml"/>
+	<rule ref="rulesets/controversial.xml">
+		<exclude name="DataflowAnomalyAnalysis"/>
+                <exclude name="OnlyOneReturn"/>
+                <exclude name="NullAssignment"/>
+                <exclude name="UnnecessaryConstructor"/>
+		<exclude name="AvoidFinalLocalVariable"/>
+		<exclude name="AssignmentInOperand"/>
+		<exclude name="CallSuperInConstructor"/>
+		<exclude name="DefaultPackage"/> <!-- ! -->
+		<exclude name="AvoidUsingVolatile"/>
+		<exclude name="BooleanInversion"/>
+		<exclude name="AvoidUsingNativeCode"/>
+		<exclude name="AvoidUsingShortType"/>
+	</rule>
+	<rule ref="rulesets/design.xml">
+		<exclude name="AvoidDeeplyNestedIfStmts"/>
+		<exclude name="ConstructorCallsOverridableMethod"/>
+		<exclude name="TooFewBranchesForASwitchStatement"/>
+		<exclude name="SwitchStmtsShouldHaveDefault"/>
+		<exclude name="UseLocaleWithCaseConversions"/>
+		<exclude name="AvoidSynchronizedAtMethodLevel"/> <!-- ! -->
+		<exclude name="ImmutableField"/> <!-- ! -->
+		<exclude name="SimpleDateFormatNeedsLocale"/>
+		<exclude name="EmptyMethodInAbstractClassShouldBeAbstract"/>
+		<exclude name="PositionLiteralsFirstInComparisons"/>
+	</rule>
+	<rule ref="rulesets/finalizers.xml"/>
+	<rule ref="rulesets/imports.xml"/>
+        <rule ref="rulesets/javabeans.xml">
+                <exclude name="BeanMembersShouldSerialize"/>
+        </rule>
+	<rule ref="rulesets/junit.xml"/>
+	<rule ref="rulesets/logging-java.xml">
+		<exclude name="SystemPrintln"/>
+	</rule>
+	<rule ref="rulesets/migrating.xml">
+		<exclude name="JUnit4TestShouldUseTestAnnotation"/>
+	</rule>
+	<rule ref="rulesets/naming.xml">
+                <exclude name="ShortVariable"/>
+                <exclude name="LongVariable"/>
+                <exclude name="AbstractNaming"/>
+		<exclude name="AvoidFieldNameMatchingMethodName"/>
+        </rule>
+	<rule ref="rulesets/optimizations.xml">
+                <exclude name="AvoidInstantiatingObjectsInLoops"/>
+		<exclude name="UseStringBufferForStringAppends"/>
+		<exclude name="LocalVariableCouldBeFinal"/> <!-- ! -->
+		<exclude name="MethodArgumentCouldBeFinal"/> <!-- ! -->
+		<exclude name="AddEmptyString"/>
+        </rule>
+	<rule ref="rulesets/strings.xml">
+                <exclude name="AvoidDuplicateLiterals"/>
+        </rule>
+	<rule ref="rulesets/sunsecure.xml">
+		<exclude name="MethodReturnsInternalArray"/> <!-- ! -->
+		<exclude name="ArrayIsStoredDirectly"/> <!-- ! -->
+	</rule>
+	<rule ref="rulesets/typeresolution.xml"/>
+	<rule ref="rulesets/unusedcode.xml"/>
+</ruleset>