Remove unused ctors

Make unused ctors a PMD error

Change-Id: I10f7350e9435179e1c6f89e01233778ddffa648a
Reviewed-on: http://gerrit.dmdirc.com/2029
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

checkstyle/pmd_checks.xml

@@ -61,7 +61,7 @@
 <rule ref="rulesets/codesize.xml/NcssConstructorCount"><priority>4</priority></rule>
 <rule ref="rulesets/codesize.xml/TooManyMethods"><priority>3</priority></rule>
 
-<rule ref="rulesets/controversial.xml/UnnecessaryConstructor"><priority>2</priority></rule>
+<rule ref="rulesets/controversial.xml/UnnecessaryConstructor"><priority>1</priority></rule>
 <rule ref="rulesets/controversial.xml/NullAssignment"><priority>3</priority></rule>
 <rule ref="rulesets/controversial.xml/UnusedModifier"><priority>1</priority></rule>
 <rule ref="rulesets/controversial.xml/AssignmentInOperand"><priority>2</priority></rule>

src/com/dmdirc/config/ConfigTarget.java

@@ -69,11 +69,6 @@ public class ConfigTarget implements Comparable<ConfigTarget>, Serializable {
     /** The user-defined ordering for this target. */
     protected int order = 50000;
 
-    /** Creates a new instance of ConfigTarget. */
-    public ConfigTarget() {
-        //Do nothing.
-    }
-
     /**
      * Sets the ordering value for this target. Lower means higher preference.
      *

src/com/dmdirc/logger/DMDircExceptionHandler.java

@@ -28,11 +28,6 @@ package com.dmdirc.logger;
 public final class DMDircExceptionHandler implements
         Thread.UncaughtExceptionHandler {
 
-    /** Instantiates the Exception handler. */
-    public DMDircExceptionHandler() {
-        super();
-    }
-
     /** {@inheritDoc} */
     @Override
     public void uncaughtException(final Thread t, final Throwable e) {

src/com/dmdirc/ui/input/AdditionalTabTargets.java

@@ -43,12 +43,6 @@ public final class AdditionalTabTargets extends ArrayList<String> {
     private List<TabCompletionType> includes
             = new ArrayList<TabCompletionType>(Arrays.asList(TabCompletionType.values()));
 
-    /** Initialises the AdditionalTabTargets. */
-    public AdditionalTabTargets() {
-        super();
-        //Do nothing
-    }
-
     /**
      * Determines if the specified type of completion should be used.
      *

src/com/dmdirc/updater/UpdateChecker.java

@@ -111,13 +111,6 @@ public final class UpdateChecker implements Runnable {
         COMPONENTS.add(new DefaultsComponent());
     }
 
-    /**
-     * Instantiates an Updatechecker.
-     */
-    public UpdateChecker() {
-        //Ignore
-    }
-
     /** {@inheritDoc} */
     @Override
     public void run() {