Remove unused private fields

Make having unused fields or formal params a PMD error

Change-Id: Ief1c8e499af7e3a43328046dc140ba941d8cb010
Depends-On: I970b49db0abac46d15a11e2b71dc0b50bd3a8faf
Reviewed-on: http://gerrit.dmdirc.com/2034
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

checkstyle/pmd_checks.xml

@@ -220,9 +220,9 @@
 <rule ref="rulesets/typeresolution.xml/UnusedImports"><priority>1</priority></rule>
 <rule ref="rulesets/typeresolution.xml/SignatureDeclareThrowsException"><priority>1</priority></rule>
 
-<rule ref="rulesets/unusedcode.xml/UnusedPrivateField"><priority>2</priority></rule>
+<rule ref="rulesets/unusedcode.xml/UnusedPrivateField"><priority>1</priority></rule>
 <rule ref="rulesets/unusedcode.xml/UnusedLocalVariable"><priority>1</priority></rule>
 <rule ref="rulesets/unusedcode.xml/UnusedPrivateMethod"><priority>1</priority></rule>
-<rule ref="rulesets/unusedcode.xml/UnusedFormalParameter"><priority>2</priority></rule>
+<rule ref="rulesets/unusedcode.xml/UnusedFormalParameter"><priority>1</priority></rule>
 
 </ruleset>

src/com/dmdirc/config/CipherUtils.java

@@ -52,9 +52,6 @@ import net.miginfocom.Base64;
  */
 public abstract class CipherUtils {
 
-    /** Singleton instance. */
-    private static CipherUtils me;
-
     /** Salt. */
     private static final byte[] SALT = {
         (byte) 0xA9, (byte) 0x9B, (byte) 0xC8, (byte) 0x32,

test/com/dmdirc/ui/WindowManagerTest.java

@@ -44,7 +44,7 @@ public class WindowManagerTest {
     public void testAddRoot() {
         final WindowManager manager = new WindowManager();
         final FrameListener tfm = mock(FrameListener.class);
-        final Window parent = new DummyInputWindow(new TestWritableFrameContainer(512, DummyInputWindow.class), null);
+        final Window parent = new DummyInputWindow(new TestWritableFrameContainer(512, DummyInputWindow.class));
 
         manager.addListener(tfm);
 
@@ -61,8 +61,8 @@ public class WindowManagerTest {
     public void testAddChild() {
         final WindowManager manager = new WindowManager();
         final FrameListener tfm = mock(FrameListener.class);
-        final Window parent = new DummyInputWindow(new TestWritableFrameContainer(512, DummyInputWindow.class), null);
-        final Window child = new DummyInputWindow(new TestWritableFrameContainer(512, DummyInputWindow.class), null);
+        final Window parent = new DummyInputWindow(new TestWritableFrameContainer(512, DummyInputWindow.class));
+        final Window child = new DummyInputWindow(new TestWritableFrameContainer(512, DummyInputWindow.class));
         manager.addWindow(parent.getContainer());
         manager.addListener(tfm);
 
@@ -76,7 +76,7 @@ public class WindowManagerTest {
     public void testRemoveRoot() {
         final WindowManager manager = new WindowManager();
         final FrameListener tfm = mock(FrameListener.class);
-        final Window parent = new DummyInputWindow(new TestWritableFrameContainer(512, DummyInputWindow.class), null);
+        final Window parent = new DummyInputWindow(new TestWritableFrameContainer(512, DummyInputWindow.class));
         manager.addWindow(parent.getContainer());
         manager.addListener(tfm);
 
@@ -89,8 +89,8 @@ public class WindowManagerTest {
     public void testRemoveChild() {
         final WindowManager manager = new WindowManager();
         final FrameListener tfm = mock(FrameListener.class);
-        final Window parent = new DummyInputWindow(new TestWritableFrameContainer(512, DummyInputWindow.class), null);
-        final Window child = new DummyInputWindow(new TestWritableFrameContainer(512, DummyInputWindow.class), null);
+        final Window parent = new DummyInputWindow(new TestWritableFrameContainer(512, DummyInputWindow.class));
+        final Window child = new DummyInputWindow(new TestWritableFrameContainer(512, DummyInputWindow.class));
         manager.addWindow(parent.getContainer());
         manager.addWindow(parent.getContainer(), child.getContainer());
         manager.addListener(tfm);
@@ -107,8 +107,8 @@ public class WindowManagerTest {
     public void testRemoveFrameManager() {
         final WindowManager manager = new WindowManager();
         final FrameListener tfm = mock(FrameListener.class);
-        final Window parent = new DummyInputWindow(new TestWritableFrameContainer(512, DummyInputWindow.class), null);
-        final Window child = new DummyInputWindow(new TestWritableFrameContainer(512, DummyInputWindow.class), null);
+        final Window parent = new DummyInputWindow(new TestWritableFrameContainer(512, DummyInputWindow.class));
+        final Window child = new DummyInputWindow(new TestWritableFrameContainer(512, DummyInputWindow.class));
         manager.addWindow(parent.getContainer());
 
         manager.addListener(tfm);