Use isEmpty()

Change-Id: I2552cd3e56688e05a25c67d84b1f4e345e7f64cb
Depends-On: Ia3516d14e1031901c763fbf2c0530e179b30efeb
Reviewed-on: http://gerrit.dmdirc.com/2085
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

checkstyle/pmd_checks.xml

@@ -120,7 +120,7 @@
 <rule ref="rulesets/design.xml/AvoidConstantsInterface"><priority>1</priority></rule>
 <rule ref="rulesets/design.xml/UnsynchronizedStaticDateFormatter"><priority>1</priority></rule>
 <rule ref="rulesets/design.xml/PreserveStackTrace"><priority>1</priority></rule>
-<rule ref="rulesets/design.xml/UseCollectionIsEmpty"><priority>2</priority></rule>
+<rule ref="rulesets/design.xml/UseCollectionIsEmpty"><priority>1</priority></rule>
 <rule ref="rulesets/design.xml/ClassWithOnlyPrivateConstructorsShouldBeFinal"><priority>2</priority></rule>
 <rule ref="rulesets/design.xml/EmptyMethodInAbstractClassShouldBeAbstract"><priority>2</priority></rule>
 <rule ref="rulesets/design.xml/SingularField"><priority>2</priority></rule>

src/com/dmdirc/plugins/PluginManager.java

@@ -166,7 +166,7 @@ public class PluginManager implements ActionListener {
 
         if (fallback) {
             final List<Service> servicesType = getServicesByType(type);
-            if (servicesType.size() > 0) {
+            if (!servicesType.isEmpty()) {
                 final Service service = servicesType.get(0);
                 return getServiceProvider(type, service.getName());
             }