mirror
/
DMDirc-Client
mirror of https://github.com/DMDirc/DMDirc.git
Watch 1
Star 0
Fork 0
Code Issues 0 Releases 49 Wiki Activity
Browse Source

Get rid of all non-P1 rules so PMD output is less difficult to debug 

Change-Id: Id0695cffe60edc19dd0a7c35782ba029cf7adb7f
Reviewed-on: http://gerrit.dmdirc.com/2380
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>
tags/0.6.7rc1
Chris Smith 12 years ago
parent
7751284c41
commit
b7fce148c2
1 changed files with 0 additions and 80 deletions
Split View Show Diff Stats
  1. 0
    80
      checkstyle/pmd_checks.xml

+ 0
- 80
checkstyle/pmd_checks.xml View File 

@@ -6,7 +6,6 @@
6 6 
          xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd">
7 7 
         <description>DMDirc minimal PMD checks.</description>
8 8
9 
-<rule ref="rulesets/basic.xml/EmptyCatchBlock"><priority>3</priority></rule>
10 9 
 <rule ref="rulesets/basic.xml/EmptyIfStmt"><priority>1</priority></rule>
11 10 
 <rule ref="rulesets/basic.xml/EmptyWhileStmt"><priority>1</priority></rule>
12 11 
 <rule ref="rulesets/basic.xml/EmptyTryBlock"><priority>1</priority></rule>
 
@@ -19,7 +18,6 @@
19 18 
 <rule ref="rulesets/basic.xml/DoubleCheckedLocking"><priority>1</priority></rule>
20 19 
 <rule ref="rulesets/basic.xml/ReturnFromFinallyBlock"><priority>1</priority></rule>
21 20 
 <rule ref="rulesets/basic.xml/EmptySynchronizedBlock"><priority>1</priority></rule>
22 
-<rule ref="rulesets/basic.xml/UnnecessaryReturn"><priority>2</priority></rule>
23 21 
 <rule ref="rulesets/basic.xml/EmptyStaticInitializer"><priority>1</priority></rule>
24 22 
 <rule ref="rulesets/basic.xml/UnconditionalIfStatement"><priority>1</priority></rule>
25 23 
 <rule ref="rulesets/basic.xml/EmptyStatementNotInLoop"><priority>1</priority></rule>
 
@@ -32,11 +30,8 @@
32 30 
 <rule ref="rulesets/basic.xml/UselessOperationOnImmutable"><priority>1</priority></rule>
33 31 
 <rule ref="rulesets/basic.xml/MisplacedNullCheck"><priority>1</priority></rule>
34 32 
 <rule ref="rulesets/basic.xml/UnusedNullCheckInEquals"><priority>1</priority></rule>
35 
-<rule ref="rulesets/basic.xml/AvoidThreadGroup"><priority>2</priority></rule>
36 33 
 <rule ref="rulesets/basic.xml/BrokenNullCheck"><priority>1</priority></rule>
37 34 
 <rule ref="rulesets/basic.xml/BigIntegerInstantiation"><priority>1</priority></rule>
38 
-<rule ref="rulesets/basic.xml/AvoidUsingOctalValues"><priority>2</priority></rule>
39 
-<rule ref="rulesets/basic.xml/AvoidUsingHardCodedIP"><priority>4</priority></rule>
40 35 
 <rule ref="rulesets/basic.xml/AvoidMultipleUnaryOperators"><priority>1</priority></rule>
41 36 
 <rule ref="rulesets/basic.xml/EmptyInitializer"><priority>1</priority></rule>
42 37 
 
@@ -45,87 +40,34 @@
45 40 
 <rule ref="rulesets/braces.xml/IfElseStmtsMustUseBraces"><priority>1</priority></rule>
46 41 
 <rule ref="rulesets/braces.xml/ForLoopsMustUseBraces"><priority>1</priority></rule>
47 42
48 
-<rule ref="rulesets/clone.xml/ProperCloneImplementation"><priority>2</priority></rule>
49 
-<rule ref="rulesets/clone.xml/CloneThrowsCloneNotSupportedException"><priority>2</priority></rule>
50 
-<rule ref="rulesets/clone.xml/CloneMethodMustImplementCloneable"><priority>2</priority></rule>
51 
-
52 
-<rule ref="rulesets/codesize.xml/NPathComplexity"><priority>2</priority></rule>
53 
-<rule ref="rulesets/codesize.xml/ExcessiveMethodLength"><priority>2</priority></rule>
54 
-<rule ref="rulesets/codesize.xml/ExcessiveParameterList"><priority>2</priority></rule>
55 
-<rule ref="rulesets/codesize.xml/ExcessiveClassLength"><priority>2</priority></rule>
56 
-<rule ref="rulesets/codesize.xml/CyclomaticComplexity"><priority>2</priority></rule>
57 
-<rule ref="rulesets/codesize.xml/ExcessivePublicCount"><priority>5</priority></rule>
58 
-<rule ref="rulesets/codesize.xml/TooManyFields"><priority>5</priority></rule>
59 
-<rule ref="rulesets/codesize.xml/NcssMethodCount"><priority>4</priority></rule>
60 
-<rule ref="rulesets/codesize.xml/NcssTypeCount"><priority>4</priority></rule>
61 
-<rule ref="rulesets/codesize.xml/NcssConstructorCount"><priority>4</priority></rule>
62 
-<rule ref="rulesets/codesize.xml/TooManyMethods"><priority>3</priority></rule>
63 
-
64 43 
 <rule ref="rulesets/controversial.xml/UnnecessaryConstructor"><priority>1</priority></rule>
65 
-<rule ref="rulesets/controversial.xml/NullAssignment"><priority>3</priority></rule>
66 44 
 <rule ref="rulesets/controversial.xml/UnusedModifier"><priority>1</priority></rule>
67 
-<rule ref="rulesets/controversial.xml/AssignmentInOperand"><priority>2</priority></rule>
68 45 
 <rule ref="rulesets/controversial.xml/DontImportSun"><priority>1</priority></rule>
69 
-<rule ref="rulesets/controversial.xml/SuspiciousOctalEscape"><priority>3</priority></rule>
70 
-<rule ref="rulesets/controversial.xml/CallSuperInConstructor"><priority>2</priority></rule>
71 46 
 <rule ref="rulesets/controversial.xml/UnnecessaryParentheses"><priority>1</priority></rule>
72 
-<rule ref="rulesets/controversial.xml/DefaultPackage"><priority>2</priority></rule>
73 
-<rule ref="rulesets/controversial.xml/BooleanInversion"><priority>3</priority></rule>
74 
-<rule ref="rulesets/controversial.xml/AvoidUsingShortType"><priority>3</priority></rule>
75 
-<rule ref="rulesets/controversial.xml/AvoidUsingVolatile"><priority>3</priority></rule>
76 
-<rule ref="rulesets/controversial.xml/AvoidAccessibilityAlteration"><priority>2</priority></rule>
77 
-<rule ref="rulesets/controversial.xml/DoNotCallGarbageCollectionExplicitly"><priority>3</priority></rule>
78 
-
79 
-<rule ref="rulesets/coupling.xml/CouplingBetweenObjects"><priority>3</priority></rule>
80 
-<rule ref="rulesets/coupling.xml/ExcessiveImports"><priority>3</priority></rule>
81 
-<rule ref="rulesets/coupling.xml/LooseCoupling"><priority>2</priority></rule>
82 47
83 
-<rule ref="rulesets/design.xml/UseSingleton"><priority>2</priority></rule>
84 48 
 <rule ref="rulesets/design.xml/SimplifyBooleanReturns"><priority>1</priority></rule>
85 49 
 <rule ref="rulesets/design.xml/SimplifyBooleanExpressions"><priority>1</priority></rule>
86 
-<rule ref="rulesets/design.xml/AvoidDeeplyNestedIfStmts"><priority>4</priority></rule>
87 50 
 <rule ref="rulesets/design.xml/AvoidReassigningParameters"><priority>1</priority></rule>
88 
-<rule ref="rulesets/design.xml/SwitchDensity"><priority>3</priority></rule>
89 
-<rule ref="rulesets/design.xml/ConstructorCallsOverridableMethod"><priority>4</priority></rule>
90 
-<rule ref="rulesets/design.xml/AccessorClassGeneration"><priority>3</priority></rule>
91 51 
 <rule ref="rulesets/design.xml/FinalFieldCouldBeStatic"><priority>1</priority></rule>
92 52 
 <rule ref="rulesets/design.xml/CloseResource"><priority>1</priority></rule>
93 53 
 <rule ref="rulesets/design.xml/NonStaticInitializer"><priority>1</priority></rule>
94 
-<rule ref="rulesets/design.xml/DefaultLabelNotLastInSwitchStmt"><priority>4</priority></rule>
95 
-<rule ref="rulesets/design.xml/NonCaseLabelInSwitchStatement"><priority>4</priority></rule>
96 54 
 <rule ref="rulesets/design.xml/OptimizableToArrayCall"><priority>1</priority></rule>
97 55 
 <rule ref="rulesets/design.xml/BadComparison"><priority>1</priority></rule>
98 56 
 <rule ref="rulesets/design.xml/EqualsNull"><priority>1</priority></rule>
99 
-<rule ref="rulesets/design.xml/ConfusingTernary"><priority>2</priority></rule>
100 57 
 <rule ref="rulesets/design.xml/InstantiationToGetClass"><priority>1</priority></rule>
101 58 
 <rule ref="rulesets/design.xml/IdempotentOperations"><priority>1</priority></rule>
102 
-<rule ref="rulesets/design.xml/SimpleDateFormatNeedsLocale"><priority>5</priority></rule>
103 
-<rule ref="rulesets/design.xml/ImmutableField"><priority>2</priority></rule>
104 
-<rule ref="rulesets/design.xml/UseLocaleWithCaseConversions"><priority>5</priority></rule>
105 
-<rule ref="rulesets/design.xml/AvoidProtectedFieldInFinalClass"><priority>2</priority></rule>
106 59 
 <rule ref="rulesets/design.xml/AssignmentToNonFinalStatic"><priority>1</priority></rule>
107 60 
 <rule ref="rulesets/design.xml/MissingStaticMethodInNonInstantiatableClass"><priority>1</priority></rule>
108 
-<rule ref="rulesets/design.xml/AvoidSynchronizedAtMethodLevel"><priority>4</priority></rule>
109 
-<rule ref="rulesets/design.xml/MissingBreakInSwitch"><priority>4</priority></rule>
110 61 
 <rule ref="rulesets/design.xml/UseNotifyAllInsteadOfNotify"><priority>1</priority></rule>
111 62 
 <rule ref="rulesets/design.xml/AvoidInstanceofChecksInCatchClause"><priority>1</priority></rule>
112 
-<rule ref="rulesets/design.xml/AbstractClassWithoutAbstractMethod"><priority>5</priority></rule>
113 63 
 <rule ref="rulesets/design.xml/SimplifyConditional"><priority>1</priority></rule>
114 
-<rule ref="rulesets/design.xml/CompareObjectsWithEquals"><priority>3</priority></rule>
115 
-<rule ref="rulesets/design.xml/PositionLiteralsFirstInComparisons"><priority>3</priority></rule>
116 64 
 <rule ref="rulesets/design.xml/UnnecessaryLocalBeforeReturn"><priority>1</priority></rule>
117 65 
 <rule ref="rulesets/design.xml/NonThreadSafeSingleton"><priority>1</priority></rule>
118 
-<rule ref="rulesets/design.xml/UncommentedEmptyMethod"><priority>2</priority></rule>
119 66 
 <rule ref="rulesets/design.xml/UncommentedEmptyConstructor"><priority>1</priority></rule>
120 67 
 <rule ref="rulesets/design.xml/AvoidConstantsInterface"><priority>1</priority></rule>
121 68 
 <rule ref="rulesets/design.xml/UnsynchronizedStaticDateFormatter"><priority>1</priority></rule>
122 69 
 <rule ref="rulesets/design.xml/PreserveStackTrace"><priority>1</priority></rule>
123 70 
 <rule ref="rulesets/design.xml/UseCollectionIsEmpty"><priority>1</priority></rule>
124 
-<rule ref="rulesets/design.xml/ClassWithOnlyPrivateConstructorsShouldBeFinal"><priority>2</priority></rule>
125 
-<rule ref="rulesets/design.xml/EmptyMethodInAbstractClassShouldBeAbstract"><priority>2</priority></rule>
126 
-<rule ref="rulesets/design.xml/SingularField"><priority>2</priority></rule>
127 
-<rule ref="rulesets/design.xml/ReturnEmptyArrayRatherThanNull"><priority>2</priority></rule>
128 
-<rule ref="rulesets/design.xml/AbstractClassWithoutAnyMethod"><priority>2</priority></rule>
129 71
130 72 
 <rule ref="rulesets/finalizers.xml/EmptyFinalizer"><priority>1</priority></rule>
131 73 
 <rule ref="rulesets/finalizers.xml/FinalizeOnlyCallsSuperFinalize"><priority>1</priority></rule>
 
@@ -138,15 +80,9 @@
138 80 
 <rule ref="rulesets/imports.xml/DontImportJavaLang"><priority>1</priority></rule>
139 81 
 <rule ref="rulesets/imports.xml/UnusedImports"><priority>1</priority></rule>
140 82 
 <rule ref="rulesets/imports.xml/ImportFromSamePackage"><priority>1</priority></rule>
141 
-<rule ref="rulesets/imports.xml/TooManyStaticImports"><priority>4</priority></rule>
142 
-
143 
-<rule ref="rulesets/javabeans.xml/BeanMembersShouldSerialize"><priority>5</priority></rule>
144 
-<rule ref="rulesets/javabeans.xml/MissingSerialVersionUID"><priority>5</priority></rule>
145 83
146 84 
 <rule ref="rulesets/logging-java.xml/MoreThanOneLogger"><priority>1</priority></rule>
147 85 
 <rule ref="rulesets/logging-java.xml/LoggerIsNotStaticFinal"><priority>1</priority></rule>
148 
-<rule ref="rulesets/logging-java.xml/SystemPrintln"><priority>2</priority></rule>
149 
-<rule ref="rulesets/logging-java.xml/AvoidPrintStackTrace"><priority>2</priority></rule>
150 86
151 87 
 <rule ref="rulesets/migrating.xml/ReplaceVectorWithList"><priority>1</priority></rule>
152 88 
 <rule ref="rulesets/migrating.xml/ReplaceHashtableWithMap"><priority>1</priority></rule>
 
@@ -158,7 +94,6 @@
158 94 
 <rule ref="rulesets/migrating.xml/ShortInstantiation"><priority>1</priority></rule>
159 95 
 <rule ref="rulesets/migrating.xml/LongInstantiation"><priority>1</priority></rule>
160 96
161 
-<rule ref="rulesets/naming.xml/ShortMethodName"><priority>2</priority></rule>
162 97 
 <rule ref="rulesets/naming.xml/VariableNamingConventions"><priority>1</priority></rule>
163 98 
 <rule ref="rulesets/naming.xml/MethodNamingConventions"><priority>1</priority></rule>
164 99 
 <rule ref="rulesets/naming.xml/ClassNamingConventions"><priority>1</priority></rule>
 
@@ -167,18 +102,13 @@
167 102 
 <rule ref="rulesets/naming.xml/SuspiciousHashcodeMethodName"><priority>1</priority></rule>
168 103 
 <rule ref="rulesets/naming.xml/SuspiciousConstantFieldName"><priority>1</priority></rule>
169 104 
 <rule ref="rulesets/naming.xml/SuspiciousEqualsMethodName"><priority>1</priority></rule>
170 
-<rule ref="rulesets/naming.xml/AvoidFieldNameMatchingTypeName"><priority>2</priority></rule>
171 
-<rule ref="rulesets/naming.xml/AvoidFieldNameMatchingMethodName"><priority>2</priority></rule>
172 105 
 <rule ref="rulesets/naming.xml/NoPackage"><priority>1</priority></rule>
173 106 
 <rule ref="rulesets/naming.xml/PackageCase"><priority>1</priority></rule>
174 
-<rule ref="rulesets/naming.xml/BooleanGetMethodName"><priority>2</priority></rule>
175 107
176 108 
 <rule ref="rulesets/optimizations.xml/LocalVariableCouldBeFinal"><priority>1</priority></rule>
177 109 
 <rule ref="rulesets/optimizations.xml/MethodArgumentCouldBeFinal"><priority>1</priority></rule>
178 
-<rule ref="rulesets/optimizations.xml/AvoidInstantiatingObjectsInLoops"><priority>3</priority></rule>
179 110 
 <rule ref="rulesets/optimizations.xml/UseArrayListInsteadOfVector"><priority>1</priority></rule>
180 111 
 <rule ref="rulesets/optimizations.xml/SimplifyStartsWith"><priority>1</priority></rule>
181 
-<rule ref="rulesets/optimizations.xml/UseStringBufferForStringAppends"><priority>3</priority></rule>
182 112 
 <rule ref="rulesets/optimizations.xml/UseArraysAsList"><priority>1</priority></rule>
183 113 
 <rule ref="rulesets/optimizations.xml/AvoidArrayLoops"><priority>1</priority></rule>
184 114 
 <rule ref="rulesets/optimizations.xml/UnnecessaryWrapperObjectCreation"><priority>1</priority></rule>
 
@@ -189,13 +119,10 @@
189 119 
 <rule ref="rulesets/strictexception.xml/ExceptionAsFlowControl"><priority>1</priority></rule>
190 120 
 <rule ref="rulesets/strictexception.xml/AvoidCatchingNPE"><priority>1</priority></rule>
191 121 
 <rule ref="rulesets/strictexception.xml/AvoidThrowingRawExceptionTypes"><priority>1</priority></rule>
192 
-<rule ref="rulesets/strictexception.xml/AvoidThrowingNullPointerException"><priority>3</priority></rule>
193 
-<rule ref="rulesets/strictexception.xml/AvoidRethrowingException"><priority>2</priority></rule>
194 122 
 <rule ref="rulesets/strictexception.xml/DoNotExtendJavaLangError"><priority>1</priority></rule>
195 123 
 <rule ref="rulesets/strictexception.xml/DoNotThrowExceptionInFinally"><priority>1</priority></rule>
196 124 
 <rule ref="rulesets/strictexception.xml/AvoidThrowingNewInstanceOfSameException"><priority>1</priority></rule>
197 125
198 
-<rule ref="rulesets/strings.xml/AvoidDuplicateLiterals"><priority>3</priority></rule>
199 126 
 <rule ref="rulesets/strings.xml/StringInstantiation"><priority>1</priority></rule>
200 127 
 <rule ref="rulesets/strings.xml/StringToString"><priority>1</priority></rule>
201 128 
 <rule ref="rulesets/strings.xml/InefficientStringBuffering"><priority>1</priority></rule>
 
@@ -204,17 +131,10 @@
204 131 
 <rule ref="rulesets/strings.xml/AppendCharacterWithChar"><priority>1</priority></rule>
205 132 
 <rule ref="rulesets/strings.xml/UseIndexOfChar"><priority>1</priority></rule>
206 133 
 <rule ref="rulesets/strings.xml/InefficientEmptyStringCheck"><priority>1</priority></rule>
207 
-<rule ref="rulesets/strings.xml/InsufficientStringBufferDeclaration"><priority>3</priority></rule>
208 134 
 <rule ref="rulesets/strings.xml/UselessStringValueOf"><priority>1</priority></rule>
209 135 
 <rule ref="rulesets/strings.xml/StringBufferInstantiationWithChar"><priority>1</priority></rule>
210 136 
 <rule ref="rulesets/strings.xml/UseEqualsToCompareStrings"><priority>1</priority></rule>
211 
-<rule ref="rulesets/strings.xml/AvoidStringBufferField"><priority>2</priority></rule>
212 
-
213 
-<rule ref="rulesets/sunsecure.xml/MethodReturnsInternalArray"><priority>3</priority></rule>
214 
-<rule ref="rulesets/sunsecure.xml/ArrayIsStoredDirectly"><priority>3</priority></rule>
215 137
216 
-<rule ref="rulesets/typeresolution.xml/LooseCoupling"><priority>2</priority></rule>
217 
-<rule ref="rulesets/typeresolution.xml/CloneMethodMustImplementCloneable"><priority>3</priority></rule>
218 138 
 <rule ref="rulesets/typeresolution.xml/UnusedImports"><priority>1</priority></rule>
219 139 
 <rule ref="rulesets/typeresolution.xml/SignatureDeclareThrowsException"><priority>1</priority></rule>
220 140

Write Preview
Loading…
Cancel
Save