Chris Smith
2460492633
Rename PMD ruleset, update PMD.
Codacy looks for ruleset.xml, so give it what it wants.
Bump PMD version to the one used by Codacy, for consistency.
7 anos atrás
Chris Smith
6ae693893d
Enable PMD in gradle + apply fixes.
Change-Id: I3665cac8af833da793ca418953d934cc3a333459
Depends-On: I348b37a14097439f8a56b0a671794410e46201ca
Depends-On: Ifc4aa601de14ca2526646f499f60329ed7c5935e
Reviewed-on: http://gerrit.dmdirc.com/3939
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 anos atrás
Chris Smith
1adc13ce67
Move all report config into etc/.
This was previously all under checkstyle/ which is weird as there's
a whole bunch of non-checkstyle stuff. Move everything into the nice
etc/ folder to keep it out of the way and sanely organised.
Change-Id: I0df52e8eddc6588c775a5173b624144807f1e59a
Reviewed-on: http://gerrit.dmdirc.com/3102
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 anos atrás
Chris Smith
1797fea82f
Bye bye, badly implemented rule.
Change-Id: Iab3c332ddb5cfd816cc0792af53f9be8d47e2679
Reviewed-on: http://gerrit.dmdirc.com/2935
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 anos atrás
Chris Smith
73b689959b
Remove PMD rules for empty constructors.
Dagger requires @Inject annotated blank constructors in some
cases, which our PMD rules are complaining about.
Change-Id: I969b974c91cc5faacb6a95daabc2567322293fd3
Reviewed-on: http://gerrit.dmdirc.com/2646
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 anos atrás
Chris Smith
b7fce148c2
Get rid of all non-P1 rules so PMD output is less difficult to debug
Change-Id: Id0695cffe60edc19dd0a7c35782ba029cf7adb7f
Reviewed-on: http://gerrit.dmdirc.com/2380
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
12 anos atrás
52577a8878
IMO these would be better picked up by code review, too many false positives.
Change-Id: I3cbcafd8dfa863cdaaa8123974b869b2f7a2e3db
Reviewed-on: http://gerrit.dmdirc.com/2111
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
13 anos atrás
Chris Smith
8465351131
Local variables must be final where appropriate. Yay.
Change-Id: I472c5dba1dd01c8cd37a58b314cebd60c4583857
Depends-On: Ied3a5a2d993bd74c04eaa357bcbef7218871f529
Reviewed-on: http://gerrit.dmdirc.com/2083
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
13 anos atrás
Chris Smith
bced15855a
Use isEmpty()
Change-Id: I2552cd3e56688e05a25c67d84b1f4e345e7f64cb
Depends-On: Ia3516d14e1031901c763fbf2c0530e179b30efeb
Reviewed-on: http://gerrit.dmdirc.com/2085
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 anos atrás
6dcc08ddeb
Up priority of yet another rule
Change-Id: Ifc7a19c6691e9f21b2e30264e12ac106028407cb
Reviewed-on: http://gerrit.dmdirc.com/2064
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 anos atrás
734e5c29c4
Force replacing vector with list
Change-Id: Id4fecd1e331a27ca02667786da75f2a643938b8a
Reviewed-on: http://gerrit.dmdirc.com/2056
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
13 anos atrás
f1528d1b24
Up priority of PMD optimiseToArray check
Change-Id: I976739a2bff459d95834f6333bca7139631de402
Reviewed-on: http://gerrit.dmdirc.com/2054
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
13 anos atrás
Chris Smith
bb70d16d7b
Remove unused private fields
Make having unused fields or formal params a PMD error
Change-Id: Ief1c8e499af7e3a43328046dc140ba941d8cb010
Depends-On: I970b49db0abac46d15a11e2b71dc0b50bd3a8faf
Reviewed-on: http://gerrit.dmdirc.com/2034
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
13 anos atrás
Chris Smith
2c840ab707
Remove unused ctors
Make unused ctors a PMD error
Change-Id: I10f7350e9435179e1c6f89e01233778ddffa648a
Reviewed-on: http://gerrit.dmdirc.com/2029
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
13 anos atrás
Chris Smith
47af8cd7ce
PMD fixes and rule updates
Lots more rules treated as errors now
Change-Id: Ie8065d958bd4fbd7cccb1c06aefbc459cfde01c3
Reviewed-on: http://gerrit.dmdirc.com/1746
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 anos atrás
Chris Smith
dd28ec1684
Custom DMDirc PMD checks
Change-Id: Ifca632fd9afab2f2e291b1ac5d6cce3bb255756c
Reviewed-on: http://gerrit.dmdirc.com/1577
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 anos atrás
Chris Smith
0d1ac53ca4
Make PMD ignore AvoidFinalLocalVariable rule, which would appear to suck balls
git-svn-id: http://svn.dmdirc.com/trunk@4294 00569f92 -eb28-0410-84fd-f71c24880f
16 anos atrás
ba7afe401b
Added PMD and CPD reports
git-svn-id: http://svn.dmdirc.com/trunk@1456 00569f92 -eb28-0410-84fd-f71c24880f
17 anos atrás
Chris Smith
Greg Holmes