Chris Smith
80124721b5
Ditch the internal numerical-based logic.
Change-Id: I68ba6e40767eacbfcd9d1099a27c81e544995ea1
Reviewed-on: http://gerrit.dmdirc.com/3959
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 9 Jahren
Chris Smith
1ec843d735
Add tests for prefix mode mamager.
Change-Id: I66662eddf73c570a0f59e4ffd0f84ab5da15d195
Reviewed-on: http://gerrit.dmdirc.com/3958
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 9 Jahren
Chris Smith
4b0ca5eeae
Forgot to move the processor tests.
Change-Id: I2ef9044106b59be12f4156e4524ee4299f9651f9
Reviewed-on: http://gerrit.dmdirc.com/3957
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 9 Jahren
Chris Smith
f1adab8673
Remove external usages of prefix mode bitmaps.
Prefix modes are now stored as a string, with the most important
mode at the start (e.g. "ohv").
Change-Id: Ie51e6bf8bf7a46e80295ed5cf000ffb4b0195e0b
Reviewed-on: http://gerrit.dmdirc.com/3954
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 9 Jahren
Chris Smith
254baff399
PMD fixes
Change-Id: Ifc4aa601de14ca2526646f499f60329ed7c5935e
Reviewed-on: http://gerrit.dmdirc.com/3937
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 9 Jahren
077e65c71e
Update Copyright to 2014
Change-Id: Iad5e74e45bb052f65b761ce8e334b571838edc10
Reviewed-on: http://gerrit.dmdirc.com/2978
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 10 Jahren
6864a35fa2
Java 7 conversions
Change-Id: Id834157281c02302bfe6f71201042712144b22ff
Reviewed-on: http://gerrit.dmdirc.com/2894
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
vor 10 Jahren
Chris Smith
1130b835a6
Add some range checking.
Change-Id: I907f185d82fb4f7273eb5341acd100815688c4f2
Fixes-issue: CLIENT-406
Reviewed-on: http://gerrit.dmdirc.com/2813
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 10 Jahren
807ad3358b
Update copyright for 2013
Change-Id: I1c711ca0525af9a78cbd7c07876eaf6cc91c1434
Reviewed-on: http://gerrit.dmdirc.com/2604
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 11 Jahren
cb1c1ad110
Add support for "CAP" extension.
(See: http://www.leeh.co.uk/draft-mitchell-irc-capabilities-02.html )
Change-Id: I9aaf2877770f86a93c9f8c525bea6315a7a8802b
Reviewed-on: http://gerrit.dmdirc.com/2541
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 11 Jahren
Chris Smith
9932008461
Decode IRC lines a bit better
We no longer truncate lines if there's a character which
can't be coded for in unicode, which stops lots of other
breakage.
Change-Id: I1886703fc7f6e4d2076da4e4bd3b9aa60e8bc051
Fixes-Issue: CLIENT-353
Reviewed-on: http://gerrit.dmdirc.com/2414
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 12 Jahren
afbd2870b3
Update copyright for 2012
Change-Id: Ie7236e561d04eed00576a8ff6b43228106d3bff5
Reviewed-on: http://gerrit.dmdirc.com/2288
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 12 Jahren
34d65f9ba9
Parser should accept multiple spaces between parameters. Fixes issue #CLIENT-319
Change-Id: I170c9512ef6407ebe210e22318c7ad052e1b4265
Reviewed-on: http://gerrit.dmdirc.com/2250
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
vor 12 Jahren
Chris Smith
1d570b9c5e
IRCParser/test fixes.
Add @ChildImplementations to TestParser
- Should fix the billion unit test failures per night
Release semaphores even if we break due to lack of error checking
Make TestParser set some sensible-ish ping values
Change-Id: I0918114380f2c22de5d7c9574714ae9e1f098b12
Reviewed-on: http://gerrit.dmdirc.com/2196
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 12 Jahren
Chris Smith
b060ac76d8
Remove ServerInfo as it's no longer used
Change-Id: Idb0ae6117d519803be4ff9bfa9773cb0e2a8eaf1
Reviewed-on: http://gerrit.dmdirc.com/2185
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
vor 12 Jahren
Chris Smith
0acd459e7e
Make IRCParser use BaseParser
Change-Id: I1b20a8f11d7c806cea5038599f7342627217652b
Depends-On: I7abcc2478ae104dfa5807934a5a249c4f5386773
Reviewed-on: http://gerrit.dmdirc.com/2183
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 12 Jahren
Chris Smith
43c5d3ee62
Parser tidying
Remove public non-final fields in favour of getters
Remove some unused and some useless methods
Change-Id: I3c0841494242da9a7c3a73f776b783965e6619fb
Reviewed-on: http://gerrit.dmdirc.com/2182
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 12 Jahren
Chris Smith
7429b67662
Remove unused stuff from ServerInfo
Change-Id: Id2c55d69befbbbc1738ad7debb05d0a4d43a8396
Reviewed-on: http://gerrit.dmdirc.com/2181
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 12 Jahren
54b06f4058
Fix unit test following Change-Id: If5a89ca2450e2583005045af60bdfc00b2a88765
Test is testing for invalid behaviour:
20:52:08 | <@Dataforce > I can't remember why we decided it was a bug
20:52:43 | <@Dataforce > It was to do with kicking simon and him coming back too fast or something
20:52:54 | <@Dataforce > oh, i remember
20:53:22 | <@Dataforce > kick simon, and then immediately kick him again - hes there, then he leaves, then hes there, Q sends a mode, then he is removed, Qs mode arrives
Not sure how the change made it through gerrit when it failed a test, but oh well.
Change-Id: I8bc45eee36c4d741e5df6c732704eee4bd60ea63
Reviewed-on: http://gerrit.dmdirc.com/2169
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 12 Jahren
002b8b2aa2
Change header?
Change-Id: I4a4bd2f45c18759bced41fc0aec1e570f11dfa6f
Reviewed-on: http://gerrit.dmdirc.com/2073
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
vor 13 Jahren
Chris Smith
8e226f7b85
Parser style fixes
Change-Id: I0d6efb9cee6138a23e309726ec6e71943f0c2863
Reviewed-on: http://gerrit.dmdirc.com/1974
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 13 Jahren
28cd8696e7
Store a URI in ServerInfo instead of a load of values
Fixes CLIENT-208
Change-Id: I958789f26b90f28129f22566addb63e5a5d23603
Reviewed-on: http://gerrit.dmdirc.com/1925
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
vor 13 Jahren
Chris Smith
ba65d14741
Make IRCStringConverter use an enum sensibly
Fixes CLIENT-135
Change-Id: I5f326523ff031c0996996f0efad6c8e5d7278c7f
Reviewed-on: http://gerrit.dmdirc.com/1859
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 13 Jahren
Chris Smith
8bed9eb8fa
Parser base abstraction/tidying
Depends-On: I3bfbb811a5b5055d8dbe511a0390c3413d133292
Depends-On: I4ff484e8a2597017283eea557170c4aeb2029faa
Change-Id: I694d18a653ca8c3e3cad9d0e766e2fd207e615e9
Reviewed-on: http://gerrit.dmdirc.com/1854
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 13 Jahren
Chris Smith
92943485f7
Unit test for IRC Reader
Change-Id: Ib2b5179775c4d6580382691d77fbd3318da28d16
Reviewed-on: http://gerrit.dmdirc.com/1776
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 13 Jahren
f5c407dad2
Update Copyright
Change-Id: I4a6c51789e37e0f96967344c98010ee7ff760506
Reviewed-on: http://gerrit.dmdirc.com/1723
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
vor 13 Jahren
Chris Smith
df92212200
Initial work on sane transcoding for the IRC parser
Issue 1754
Change-Id: I3cdc794dce1df63686d3b161e78a316983b872ca
Reviewed-on: http://gerrit.dmdirc.com/1505
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
vor 13 Jahren
Chris Smith
b2a61ceabf
Style fixes
Change-Id: I920ca1847ac1af6cf3a13e891e6340f68c6abb91
Reviewed-on: http://gerrit.dmdirc.com/1335
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
vor 14 Jahren
Chris Smith
acde4c2d05
Style fixes
Change-Id: I51d0e3c7975740b1ede5d6226639022bd15a482a
Reviewed-on: http://gerrit.dmdirc.com/1328
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
vor 14 Jahren
Chris Smith
ef07448f3c
Fix parser unit tests
Change-Id: Ib72cf14a74262dee7c4ac32e879e80bde1b5f2d5
Reviewed-on: http://gerrit.dmdirc.com/1237
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
Automatic-Compile: Chris Smith <chris@dmdirc.com >
vor 14 Jahren
Chris Smith
2e437b53b1
Minor random unit test changes
Change-Id: I08b50e4f6d5f419c9ab9f353fe944ba11cc79b34
Reviewed-on: http://gerrit.dmdirc.com/1071
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
vor 14 Jahren
Chris Smith
33c60f07de
Remove unit test that no longer makes sense and times out
Change-Id: Ia973c8cfa920cc74a8a3a2f7cce3a2ab63e2a54e
Reviewed-on: http://gerrit.dmdirc.com/776
Automatic-Compile: Chris Smith <chris@dmdirc.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
vor 14 Jahren
Chris Smith
b228887aa6
Move ircd tests out of IRCParser
Change-Id: Icc7020010a2998db5f1fc99fb7c8da48d1577178
Reviewed-on: http://gerrit.dmdirc.com/773
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
vor 14 Jahren
Chris Smith
15b1195268
Remove unit test which seems pointless and may be timing out
Change-Id: I35a912bfb569b741a14a253ea34ccb8ca5ceface
Reviewed-on: http://gerrit.dmdirc.com/770
Automatic-Compile: Gregory Holmes <greg@dmdirc.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
vor 14 Jahren
Chris Smith
b86cd763a3
Split the parser tests up a bit
Change-Id: I152811c41ad338412a878b2dcb8cbec19e3eb115
Reviewed-on: http://gerrit.dmdirc.com/640
Automatic-Compile: Shane Mc Cormack <shane@dmdirc.com >
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
vor 14 Jahren
379fed1795
Fix unit tests.
Change-Id: Ic5fe088387c4d67035dc578de31ffd02ddda5941
Reviewed-on: http://gerrit.dmdirc.com/623
Automatic-Compile: Shane Mc Cormack <shane@dmdirc.com >
Automatic-Compile: Gregory Holmes <greg@dmdirc.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
vor 14 Jahren
Chris Smith
07b4660ed5
Remove unused and non-existant import
Change-Id: I569fd757b31e9892b1db40a91a16d2b1dca3b680
Reviewed-on: http://gerrit.dmdirc.com/467
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Tested-by: Shane Mc Cormack <shane@dmdirc.com >
vor 14 Jahren
Chris Smith
3ac2bf9d29
Down with dodgy harness classes, up with mocks!
Change-Id: I48ceb58b942dfb017e8698d4b9bca5a1e11dfb61
Reviewed-on: http://gerrit.dmdirc.com/462
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Tested-by: Shane Mc Cormack <shane@dmdirc.com >
vor 14 Jahren
Chris Smith
e749bc70ff
Unit test changes
Move parser test harness to parser module
Change-Id: Ic4003a54acfcadd2c0a52978bb3e4acd5c91dedd
Reviewed-on: http://gerrit.dmdirc.com/455
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Tested-by: Shane Mc Cormack <shane@dmdirc.com >
vor 14 Jahren
Chris Smith
47d260fec6
Update unit tests
Change-Id: Ia1d836951e1b4004f7c94f64c5c0b0dd2788e07e
Reviewed-on: http://gerrit.dmdirc.com/359
Reviewed-by: Gregory Holmes <greboid@dmdirc.com >
Tested-by: Gregory Holmes <greboid@dmdirc.com >
vor 14 Jahren
8020751b37
Update the copyright date on all files.
Change-Id: I581861c8c8743cb835c45d128c4b4768372de807
Reviewed-on: http://gerrit.dmdirc.com/201
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Tested-by: Shane Mc Cormack <shane@dmdirc.com >
vor 14 Jahren
7f07e023bd
Add tests
vor 15 Jahren
Chris Smith
Shane Mc Cormack