IRCParser/test fixes.

Add @ChildImplementations to TestParser
- Should fix the billion unit test failures per night
Release semaphores even if we break due to lack of error checking
Make TestParser set some sensible-ish ping values

Change-Id: I0918114380f2c22de5d7c9574714ae9e1f098b12
Reviewed-on: http://gerrit.dmdirc.com/2196
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

src/com/dmdirc/parser/irc/IRCParser.java

@@ -1915,15 +1915,19 @@ public class IRCParser extends BaseParser implements SecureParser,
     protected void startPingTimer() {
         pingTimerSem.acquireUninterruptibly();
 
-        setPingNeeded(false);
-        if (pingTimer != null) {
-            pingTimer.cancel();
-        }
-        pingTimer = new Timer("IRCParser pingTimer");
-        pingTimer.schedule(new PingTimer(this, pingTimer), 0, getPingTimerInterval());
-        pingCountDown = 1;
+        try {
+            setPingNeeded(false);
 
-        pingTimerSem.release();
+            if (pingTimer != null) {
+                pingTimer.cancel();
+            }
+
+            pingTimer = new Timer("IRCParser pingTimer");
+            pingTimer.schedule(new PingTimer(this, pingTimer), 0, getPingTimerInterval());
+            pingCountDown = 1;
+        } finally {
+            pingTimerSem.release();
+        }
     }
 
     /**

test/com/dmdirc/harness/parser/TestParser.java

@@ -22,6 +22,7 @@
 
 package com.dmdirc.harness.parser;
 
+import com.dmdirc.parser.common.ChildImplementations;
 import com.dmdirc.parser.common.MyInfo;
 import com.dmdirc.parser.common.QueuePriority;
 import com.dmdirc.parser.interfaces.Parser;
@@ -32,6 +33,11 @@ import java.util.ArrayList;
 import java.util.List;
 import java.util.Timer;
 
+@ChildImplementations({
+    IRCChannelClientInfo.class,
+    IRCChannelInfo.class,
+    IRCClientInfo.class
+})
 public class TestParser extends IRCParser implements Parser {
 
     public final List<String> sentLines = new ArrayList<String>();
@@ -43,11 +49,15 @@ public class TestParser extends IRCParser implements Parser {
     public TestParser() {
         super(buildURI());
         currentSocketState = SocketState.OPEN;
+        setPingTimerFraction(10);
+        setPingTimerInterval(60000);
     }
 
     public TestParser(MyInfo myDetails, URI address) {
         super(myDetails, address);
         currentSocketState = SocketState.OPEN;
+        setPingTimerFraction(10);
+        setPingTimerInterval(60000);
     }
 
     private static URI buildURI() {