Browse Source

Update unit tests

Change-Id: Ia1d836951e1b4004f7c94f64c5c0b0dd2788e07e
Reviewed-on: http://gerrit.dmdirc.com/359
Reviewed-by: Gregory Holmes <greboid@dmdirc.com>
Tested-by: Gregory Holmes <greboid@dmdirc.com>
tags/0.6.3
Chris Smith 14 years ago
parent
commit
47d260fec6
1 changed files with 14 additions and 16 deletions
  1. 14
    16
      test/com/dmdirc/parser/irc/IRCParserTest.java

+ 14
- 16
test/com/dmdirc/parser/irc/IRCParserTest.java View File

@@ -36,10 +36,8 @@ import com.dmdirc.harness.parser.TestIPrivateMessage;
36 36
 import com.dmdirc.harness.parser.TestIPrivateAction;
37 37
 import com.dmdirc.parser.interfaces.callbacks.AuthNoticeListener;
38 38
 import com.dmdirc.parser.common.CallbackNotFoundException;
39
-import com.dmdirc.parser.interfaces.callbacks.AwayStateListener;
40 39
 import com.dmdirc.parser.interfaces.callbacks.CallbackInterface;
41 40
 import com.dmdirc.parser.interfaces.callbacks.ChannelKickListener;
42
-
43 41
 import com.dmdirc.parser.interfaces.callbacks.ConnectErrorListener;
44 42
 import com.dmdirc.parser.interfaces.callbacks.ErrorInfoListener;
45 43
 import com.dmdirc.parser.interfaces.callbacks.NumericListener;
@@ -48,12 +46,14 @@ import com.dmdirc.parser.interfaces.callbacks.PrivateActionListener;
48 46
 import com.dmdirc.parser.interfaces.callbacks.PrivateCtcpListener;
49 47
 import com.dmdirc.parser.interfaces.callbacks.PrivateMessageListener;
50 48
 import com.dmdirc.parser.interfaces.callbacks.ServerErrorListener;
49
+
50
+import java.net.URI;
51
+import java.net.URISyntaxException;
51 52
 import java.util.Arrays;
52 53
 import java.util.Collection;
53 54
 
54 55
 import javax.net.ssl.TrustManager;
55 56
 
56
-import org.junit.Ignore;
57 57
 import org.junit.Test;
58 58
 import static org.junit.Assert.*;
59 59
 import static org.mockito.Mockito.*;
@@ -128,14 +128,13 @@ public class IRCParserTest {
128 128
     }
129 129
 
130 130
     @Test
131
-    public void testSendConnectionStrings1() {
132
-        final ServerInfo serverInfo = new ServerInfo("irc.testing.dmdirc", 6667, "");
131
+    public void testSendConnectionStrings1() throws URISyntaxException {
133 132
         final MyInfo myInfo = new MyInfo();
134 133
         myInfo.setNickname("Nickname");
135 134
         myInfo.setRealname("Real name");
136 135
         myInfo.setUsername("Username");
137 136
 
138
-        final TestParser parser = new TestParser(myInfo, serverInfo);
137
+        final TestParser parser = new TestParser(myInfo, new URI("irc://irc.testing.dmdirc:6667/"));
139 138
         parser.sendConnectionStrings();
140 139
 
141 140
         assertEquals(2, parser.sentLines.size());
@@ -147,19 +146,18 @@ public class IRCParserTest {
147 146
         assertEquals("First token should be USER", "USER", userParts[0]);
148 147
         assertEquals("USER should contain username", myInfo.getUsername().toLowerCase(),
149 148
                 userParts[1].toLowerCase());
150
-        assertEquals("USER should contain server name", serverInfo.getHost(), userParts[3]);
149
+        assertEquals("USER should contain server name", "irc.testing.dmdirc", userParts[3]);
151 150
         assertEquals("USER should contain real name", "Real name", userParts[4]);
152 151
     }
153 152
 
154 153
     @Test
155
-    public void testSendConnectionStrings2() {
156
-        final ServerInfo serverInfo = new ServerInfo("irc.testing.dmdirc", 6667, "password");
154
+    public void testSendConnectionStrings2() throws URISyntaxException {
157 155
         final MyInfo myInfo = new MyInfo();
158 156
         myInfo.setNickname("Nickname");
159 157
         myInfo.setRealname("Real name");
160 158
         myInfo.setUsername("Username");
161 159
 
162
-        final TestParser parser = new TestParser(myInfo, serverInfo);
160
+        final TestParser parser = new TestParser(myInfo, new URI("irc://password@irc.testing.dmdirc:6667/"));
163 161
         parser.sendConnectionStrings();
164 162
 
165 163
         assertEquals(3, parser.sentLines.size());
@@ -493,8 +491,8 @@ public class IRCParserTest {
493 491
     }
494 492
     
495 493
     @Test
496
-    public void testIllegalPort1() {
497
-        final TestParser tp = new TestParser(new MyInfo(), new ServerInfo("127.0.0.1", 0, ""));
494
+    public void testIllegalPort1() throws URISyntaxException {
495
+        final TestParser tp = new TestParser(new MyInfo(), new URI("irc://127.0.0.1:0/"));
498 496
         final TestIConnectError tiei = new TestIConnectError();
499 497
         tp.getCallbackManager().addCallback(ConnectErrorListener.class, tiei);
500 498
         tp.runSuper();
@@ -502,8 +500,8 @@ public class IRCParserTest {
502 500
     }
503 501
     
504 502
     @Test
505
-    public void testIllegalPort2() {
506
-        final TestParser tp = new TestParser(new MyInfo(), new ServerInfo("127.0.0.1", 1, ""));
503
+    public void testIllegalPort2() throws URISyntaxException {
504
+        final TestParser tp = new TestParser(new MyInfo(), new URI("irc://127.0.0.1:1/"));
507 505
         final TestIConnectError tiei = new TestIConnectError();
508 506
         tp.getCallbackManager().addCallback(ConnectErrorListener.class, tiei);
509 507
         tp.runSuper();
@@ -511,8 +509,8 @@ public class IRCParserTest {
511 509
     }    
512 510
     
513 511
     @Test
514
-    public void testIllegalPort3() {
515
-        final TestParser tp = new TestParser(new MyInfo(), new ServerInfo("127.0.0.1", 65570, ""));
512
+    public void testIllegalPort3() throws URISyntaxException {
513
+        final TestParser tp = new TestParser(new MyInfo(), new URI("irc://127.0.0.1:65570/"));
516 514
         final TestIConnectError tiei = new TestIConnectError();
517 515
         tp.getCallbackManager().addCallback(ConnectErrorListener.class, tiei);
518 516
         tp.runSuper();

Loading…
Cancel
Save