Change-Id: I6a0f9b362087677004f0ea21c5841f2eef15d04b
Reviewed-on: http://gerrit.dmdirc.com/2271
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: I1dada61297eca27526cddf6ad182683c133bd094
Reviewed-on: http://gerrit.dmdirc.com/2270
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Change-Id: I5394a1c6119568b82a2e65cb3bd97ede08817172
Reviewed-on: http://gerrit.dmdirc.com/2269
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

The parser now defines some new methods:
  - connect()
  - connect(threadName)
  - interrupt()

connect([threadName]) is responsible for creating any required threads
for the parser to run in and maintaining them internally.
interrupt() allows for interrupting these thread if they exist and if
required.

A new base class for parsers has been added to accomodate this with
minimum changes required elsewhere - ThreadedParser which BaseParser
now extends.

ThreadedParser handles the creation of a single controlThread and allows
interrupting it, and also defines an abstract void run() method (which
all existing parsers will already have from extending runnable in the
past) which is used by the controlThread.

Change-Id: Ib3e884407181adc362394b23fe59f8e3b401d692
Depends-On: I5ef8ea1e988fe9591df0054ad0016c409fc34b3f
Depends-On: I90ac61d56eb623165d3c4211f1c3247fcba823c8
Reviewed-on: http://gerrit.dmdirc.com/2255
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Port now defaults to 6667 if none is specified.
compareURI also now takes username/password into consideration if one is given to it to compare to (different password could be a different server, for example in the case of bouncers)
Fix StringIndexOutOfBoundsException when using a server that does timestamped IRC. (Fixes issue #CLIENT-326)

Change-Id: I61151b953b29df6dc12ec19f3c43f8cf7a6a37ed
Reviewed-on: http://gerrit.dmdirc.com/2248
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Change-Id: I170c9512ef6407ebe210e22318c7ad052e1b4265
Reviewed-on: http://gerrit.dmdirc.com/2250
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Fixes #CLIENT-318

The logic was already there, there just wasn't a group for it to make it easy.

Change-Id: I25976c3436961de8d4c2e243c5d14d58762e9222
Reviewed-on: http://gerrit.dmdirc.com/2251
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Add utility method for sending messages with trailing args

Change-Id: I4ccb6f240a62575ab030fcfe5dab82b12cffba17
Reviewed-on: http://gerrit.dmdirc.com/2225
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: I090d07a1b786ae74e604ed0d6644d3f07405bc90
Reviewed-on: http://gerrit.dmdirc.com/2216
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Issue: CLIENT-48
Change-Id: I43aeb1bd963eb5a2c01fa7442681b71a75bbcca2
Reviewed-on: http://gerrit.dmdirc.com/2202
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Issue: CLIENT-48
Change-Id: I6af72c73a4370f5a49315a7a9789a18ea199a888
Reviewed-on: http://gerrit.dmdirc.com/2201
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Issue: CLIENT-48
Change-Id: Id47a386356c7b08883cfbe326bcf2826f0b97adf
Depends-On: I8eb9a68ad651554123c7254c8357e916db57557e
Reviewed-on: http://gerrit.dmdirc.com/2200
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Add @ChildImplementations to TestParser
- Should fix the billion unit test failures per night
Release semaphores even if we break due to lack of error checking
Make TestParser set some sensible-ish ping values

Change-Id: I0918114380f2c22de5d7c9574714ae9e1f098b12
Reviewed-on: http://gerrit.dmdirc.com/2196
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: Idb0ae6117d519803be4ff9bfa9773cb0e2a8eaf1
Reviewed-on: http://gerrit.dmdirc.com/2185
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>

Change-Id: I1b20a8f11d7c806cea5038599f7342627217652b
Depends-On: I7abcc2478ae104dfa5807934a5a249c4f5386773
Reviewed-on: http://gerrit.dmdirc.com/2183
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Remove public non-final fields in favour of getters
Remove some unused and some useless methods

Change-Id: I3c0841494242da9a7c3a73f776b783965e6619fb
Reviewed-on: http://gerrit.dmdirc.com/2182
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: Id2c55d69befbbbc1738ad7debb05d0a4d43a8396
Reviewed-on: http://gerrit.dmdirc.com/2181
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: I6a37f6955728aa732dcf0ba27bfa25749f250b3d
Depends-On: Ia23869ff1259e460f3389a425fc9e0e4a0a31955
Fixes-issue: CLIENT-311
Reviewed-on: http://gerrit.dmdirc.com/2179
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

 - This is used for backbuffer support in DFBnc, we currently only care about timestamps in
   ProcessMessage, everything else will just use the current time in their callbacks as before.

Change-Id: I248bfd4d72800465ba4b06331261a8519690c3d5
Reviewed-on: http://gerrit.dmdirc.com/2172
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Test is testing for invalid behaviour:

20:52:08 | <@Dataforce> I can't remember why we decided it was a bug
20:52:43 | <@Dataforce> It was to do with kicking simon and him coming back too fast or something
20:52:54 | <@Dataforce> oh, i remember
20:53:22 | <@Dataforce> kick simon, and then immediately kick him again - hes there, then he leaves, then hes there, Q sends a mode, then he is removed, Qs mode arrives

Not sure how the change made it through gerrit when it failed a test, but oh well.

Change-Id: I8bc45eee36c4d741e5df6c732704eee4bd60ea63
Reviewed-on: http://gerrit.dmdirc.com/2169
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Ignore modes for clients not on the channel.

Change-Id: If5a89ca2450e2583005045af60bdfc00b2a88765
Reviewed-on: http://gerrit.dmdirc.com/2138
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: Ic893051d84bc4ab47274b2bf9c967db8ba951eea
Depends-On: Iece6afe9fba02126f203cb1aecd702bc9303b981
Reviewed-on: http://gerrit.dmdirc.com/2133
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: I4c4264721c1f484033cf7307b95b4436720b0677
Reviewed-on: http://gerrit.dmdirc.com/2121
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: I4a4bd2f45c18759bced41fc0aec1e570f11dfa6f
Reviewed-on: http://gerrit.dmdirc.com/2073
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Change-Id: Id3d5ebb13b84543834aecd6374e70e56c526f4c3
Reviewed-on: http://gerrit.dmdirc.com/2059
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Change-Id: I149964132ab7debdd5282c8a7e26d701a695b47c
Reviewed-on: http://gerrit.dmdirc.com/2030
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: Icc4de20b0617f9962853e8c9fe66737d6a5b9297
Reviewed-on: http://gerrit.dmdirc.com/2003
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Issue CLIENT-209

Change-Id: I802cf467f0c4f41f6316ddba5451069b0bbaa0c5
Depends-On: Ibf3e3a2f03270089849d9943a535e022245e0f44
Reviewed-on: http://gerrit.dmdirc.com/1998
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: I09a4f22fc43a549aa3c9d0fd8794061d7feb31cb
Reviewed-on: http://gerrit.dmdirc.com/2001
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: Ib43769c82b0a5ca1a0ac3bd6fd91e4105b0c2a87
Depends-On: I7178085b05baaf1923f0d41e936c863e4f79a0aa
Reviewed-on: http://gerrit.dmdirc.com/1991
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: Iafa0b38ea0f1f4dc39d153b9f6f8646389676ed5
Depends-On: I41638fedc08dbebdb89e8ad9f872536db5d3091f
Reviewed-on: http://gerrit.dmdirc.com/1983
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>

Change-Id: Ie91dc5f95b405c3664884b830bbc47dfeb282790
Reviewed-on: http://gerrit.dmdirc.com/1978
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: Ia1d78711f050f6938753a1e8e1dd5dd8b1457b5d
Reviewed-on: http://gerrit.dmdirc.com/1977
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: I0d6efb9cee6138a23e309726ec6e71943f0c2863
Reviewed-on: http://gerrit.dmdirc.com/1974
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: I8f9ac8a39b3af592f4a334193434c57f86eec8ee
Reviewed-on: http://gerrit.dmdirc.com/1965
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Fixes CLIENT-208

Change-Id: I958789f26b90f28129f22566addb63e5a5d23603
Reviewed-on: http://gerrit.dmdirc.com/1925
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Chris Smith <chris@dmdirc.com>

Change-Id: I8d5ef39beb4b578c791062350b6e15d2bf7e0814
Reviewed-on: http://gerrit.dmdirc.com/1920
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Fixes CLIENT-135

Change-Id: I5f326523ff031c0996996f0efad6c8e5d7278c7f
Reviewed-on: http://gerrit.dmdirc.com/1859
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Depends-On: I3bfbb811a5b5055d8dbe511a0390c3413d133292
Depends-On: I4ff484e8a2597017283eea557170c4aeb2029faa
Change-Id: I694d18a653ca8c3e3cad9d0e766e2fd207e615e9
Reviewed-on: http://gerrit.dmdirc.com/1854
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Fixes CLIENT-67

Change-Id: Ifcb8deacd3c571f3f6a30eae11199078bcc8db35
Reviewed-on: http://gerrit.dmdirc.com/1804
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>

Change-Id: Ib2b5179775c4d6580382691d77fbd3318da28d16
Reviewed-on: http://gerrit.dmdirc.com/1776
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: Ief34fb1ecf4f5e393fb839f2100b8492e26155a9
Reviewed-on: http://gerrit.dmdirc.com/1745
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Change-Id: I0125f179b3f6e5fb44b5fd707a54997695ec8e0a
Reviewed-on: http://gerrit.dmdirc.com/1741
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Change-Id: I4a6c51789e37e0f96967344c98010ee7ff760506
Reviewed-on: http://gerrit.dmdirc.com/1723
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Change-Id: I45b496d084e722850810736d468f4bb3f9602151
Reviewed-on: http://gerrit.dmdirc.com/1705
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Chris Smith <chris@dmdirc.com>

Change-Id: I949a47729994e3f185be47935dfff6fb0554f935
Reviewed-on: http://gerrit.dmdirc.com/1704
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Chris Smith <chris@dmdirc.com>

IRCReader now ignores '\r' characters, and terminates lines at '\n'

Fixes issue CLIENT-138

Change-Id: Ia7593f031c0cfd5c6b605884eabef0ef0e3330cf
Reviewed-on: http://gerrit.dmdirc.com/1703
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: Ifd55c3c04740aa88f349aae5abee7fa817b82e39
Reviewed-on: http://gerrit.dmdirc.com/1692
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Chris Smith <chris@dmdirc.com>

Change-Id: Ie1c567acb7726cf11a95c56a4fb044e5b36e0fcf
Reviewed-on: http://gerrit.dmdirc.com/1665
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: I0e2a8e1ae5f3e0595446b980a2c6c3ceb28c3238
Reviewed-on: http://gerrit.dmdirc.com/1659
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Greg Holmes <greg@dmdirc.com>