Ver código fonte

PMD Fixes for parser.

Change-Id: I45b496d084e722850810736d468f4bb3f9602151
Reviewed-on: http://gerrit.dmdirc.com/1705
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Chris Smith <chris@dmdirc.com>
tags/0.6.5
Greg Holmes 13 anos atrás
pai
commit
e70c98fcea

+ 1
- 1
src/com/dmdirc/parser/common/CallbackManager.java Ver arquivo

@@ -24,7 +24,7 @@ package com.dmdirc.parser.common;
24 24
 
25 25
 import com.dmdirc.parser.interfaces.Parser;
26 26
 import com.dmdirc.parser.interfaces.SpecificCallback;
27
-import com.dmdirc.parser.interfaces.callbacks.*;
27
+import com.dmdirc.parser.interfaces.callbacks.*; //NOPMD
28 28
 
29 29
 import java.util.HashMap;
30 30
 import java.util.Map;

+ 1
- 1
src/com/dmdirc/parser/irc/IRCParser.java Ver arquivo

@@ -32,7 +32,7 @@ import com.dmdirc.parser.common.SystemEncoder;
32 32
 import com.dmdirc.parser.interfaces.Encoder;
33 33
 import com.dmdirc.parser.interfaces.EncodingParser;
34 34
 import com.dmdirc.parser.interfaces.SecureParser;
35
-import com.dmdirc.parser.interfaces.callbacks.*;
35
+import com.dmdirc.parser.interfaces.callbacks.*; //NOPMD
36 36
 import com.dmdirc.parser.irc.IRCReader.ReadLine;
37 37
 import com.dmdirc.parser.irc.outputqueue.OutputQueue;
38 38
 

+ 7
- 3
src/com/dmdirc/parser/irc/Logging.java Ver arquivo

@@ -77,7 +77,7 @@ public class Logging {
77 77
     private final boolean isAvailable;
78 78
 
79 79
     /** "Log" object if available. */
80
-    private Object log = null;
80
+    private Object log;
81 81
 
82 82
     /**
83 83
      * Get an instance of Logging.
@@ -85,8 +85,12 @@ public class Logging {
85 85
      * @return The instance of Logging
86 86
      */
87 87
     public static Logging getLogging() {
88
-        if (me == null) { me = new Logging(); }
89
-        return me;
88
+        synchronized (Logging.class) {
89
+            if (me == null) {
90
+                me = new Logging();
91
+            }
92
+            return me;
93
+        }
90 94
     }
91 95
 
92 96
     /** Create a new Logging. */

Carregando…
Cancelar
Salvar