Change-Id: I0f247f1fd7ecfd434777845d194812a219246319
Reviewed-on: http://gerrit.dmdirc.com/2507
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: I7f7aae8a819f464a99ee3f0169ca2258bf046997
Reviewed-on: http://gerrit.dmdirc.com/2526
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: Ib1038c0d46b0c1f2de15050bb772fe519417d7bd
Reviewed-on: http://gerrit.dmdirc.com/2534
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>

Previously it added an object as a callback target even if it didn't implement the callback handler, this was pointless and stupid, now it checks.

Change-Id: I24ce9f063a0f1f95e84ad2ae28a67e335cd63afe
Reviewed-on: http://gerrit.dmdirc.com/2519
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: I399f70e589c94570c2e9e96c8d2a92a66448e627
Reviewed-on: http://gerrit.dmdirc.com/2518
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: I56e7ab284abb91e22bf5c35b73035302a85b45b4
Reviewed-on: http://gerrit.dmdirc.com/2513
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: I3ac4dcb46143d29ce2f3304f5cf81d3e4e3943c3
Reviewed-on: http://gerrit.dmdirc.com/2510
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: Id91f50347ce9a63ebbfa0be1792c0feba7348d87
Reviewed-on: http://gerrit.dmdirc.com/2503
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Change-Id: I460645e88ba7b5614dc8b2ac83870941cfb7dc52
Reviewed-on: http://gerrit.dmdirc.com/2497
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: I85a6a95916a03ff4766a4319653a1fb929747566
Reviewed-on: http://gerrit.dmdirc.com/2494
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Change-Id: Ib29494e43a7271f8511bc7f733534aae47aea8b2
Fixes-Issue: CLIENT-367
Reviewed-on: http://gerrit.dmdirc.com/2481
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

We no longer truncate lines if there's a character which
can't be coded for in unicode, which stops lots of other
breakage.

Change-Id: I1886703fc7f6e4d2076da4e4bd3b9aa60e8bc051
Fixes-Issue: CLIENT-353
Reviewed-on: http://gerrit.dmdirc.com/2414
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: I92f7184110dec669bf9f4aa09dab0a07245f164e
Reviewed-on: http://gerrit.dmdirc.com/2384
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: I75ef7125aeefbddbf612629db37743a06ef72834
Reviewed-on: http://gerrit.dmdirc.com/2366
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: I3959753c4342b3fd1c774134ec35b6129add7503
Reviewed-on: http://gerrit.dmdirc.com/2364
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: I04b90827b4ea4bcffd8f1a917d9e83fd87cf1505
Reviewed-on: http://gerrit.dmdirc.com/2355
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: Icaec05f28e8ae949660345f85a40ce2e5ad4a6d1
Reviewed-on: http://gerrit.dmdirc.com/2350
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: I1bf4b2f43ecde3faed72a8034d2f83e04f00f01d
Reviewed-on: http://gerrit.dmdirc.com/2345
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: I3e417aceb4dbecf9afd2968afd3525879643e795
Reviewed-on: http://gerrit.dmdirc.com/2341
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: I85d6b3a7126cfd735d04618ba692abe35fe11ceb
Reviewed-on: http://gerrit.dmdirc.com/2328
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Change-Id: I08bf01b126722ed56ef94dda8a29191d1399866b
Reviewed-on: http://gerrit.dmdirc.com/2322
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

jgit-describe only supports 1 subdir atm, so for now we still need to shell out once.

Change-Id: I1cdbfd09abe2f515b78732e98203c52772a724c6
Reviewed-on: http://gerrit.dmdirc.com/2299
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Change-Id: Ie7236e561d04eed00576a8ff6b43228106d3bff5
Reviewed-on: http://gerrit.dmdirc.com/2288
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: I3903374f9941e74bfd222650110d6e91d0899b31
Reviewed-on: http://gerrit.dmdirc.com/2272
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: I6a0f9b362087677004f0ea21c5841f2eef15d04b
Reviewed-on: http://gerrit.dmdirc.com/2271
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: I1dada61297eca27526cddf6ad182683c133bd094
Reviewed-on: http://gerrit.dmdirc.com/2270
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Change-Id: I5394a1c6119568b82a2e65cb3bd97ede08817172
Reviewed-on: http://gerrit.dmdirc.com/2269
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

The parser now defines some new methods:
  - connect()
  - connect(threadName)
  - interrupt()

connect([threadName]) is responsible for creating any required threads
for the parser to run in and maintaining them internally.
interrupt() allows for interrupting these thread if they exist and if
required.

A new base class for parsers has been added to accomodate this with
minimum changes required elsewhere - ThreadedParser which BaseParser
now extends.

ThreadedParser handles the creation of a single controlThread and allows
interrupting it, and also defines an abstract void run() method (which
all existing parsers will already have from extending runnable in the
past) which is used by the controlThread.

Change-Id: Ib3e884407181adc362394b23fe59f8e3b401d692
Depends-On: I5ef8ea1e988fe9591df0054ad0016c409fc34b3f
Depends-On: I90ac61d56eb623165d3c4211f1c3247fcba823c8
Reviewed-on: http://gerrit.dmdirc.com/2255
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Port now defaults to 6667 if none is specified.
compareURI also now takes username/password into consideration if one is given to it to compare to (different password could be a different server, for example in the case of bouncers)
Fix StringIndexOutOfBoundsException when using a server that does timestamped IRC. (Fixes issue #CLIENT-326)

Change-Id: I61151b953b29df6dc12ec19f3c43f8cf7a6a37ed
Reviewed-on: http://gerrit.dmdirc.com/2248
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Change-Id: I170c9512ef6407ebe210e22318c7ad052e1b4265
Reviewed-on: http://gerrit.dmdirc.com/2250
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Fixes #CLIENT-318

The logic was already there, there just wasn't a group for it to make it easy.

Change-Id: I25976c3436961de8d4c2e243c5d14d58762e9222
Reviewed-on: http://gerrit.dmdirc.com/2251
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Add utility method for sending messages with trailing args

Change-Id: I4ccb6f240a62575ab030fcfe5dab82b12cffba17
Reviewed-on: http://gerrit.dmdirc.com/2225
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: I090d07a1b786ae74e604ed0d6644d3f07405bc90
Reviewed-on: http://gerrit.dmdirc.com/2216
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Issue: CLIENT-48
Change-Id: I43aeb1bd963eb5a2c01fa7442681b71a75bbcca2
Reviewed-on: http://gerrit.dmdirc.com/2202
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Issue: CLIENT-48
Change-Id: I6af72c73a4370f5a49315a7a9789a18ea199a888
Reviewed-on: http://gerrit.dmdirc.com/2201
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Issue: CLIENT-48
Change-Id: Id47a386356c7b08883cfbe326bcf2826f0b97adf
Depends-On: I8eb9a68ad651554123c7254c8357e916db57557e
Reviewed-on: http://gerrit.dmdirc.com/2200
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Add @ChildImplementations to TestParser
- Should fix the billion unit test failures per night
Release semaphores even if we break due to lack of error checking
Make TestParser set some sensible-ish ping values

Change-Id: I0918114380f2c22de5d7c9574714ae9e1f098b12
Reviewed-on: http://gerrit.dmdirc.com/2196
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: Idb0ae6117d519803be4ff9bfa9773cb0e2a8eaf1
Reviewed-on: http://gerrit.dmdirc.com/2185
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>

Change-Id: I1b20a8f11d7c806cea5038599f7342627217652b
Depends-On: I7abcc2478ae104dfa5807934a5a249c4f5386773
Reviewed-on: http://gerrit.dmdirc.com/2183
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Remove public non-final fields in favour of getters
Remove some unused and some useless methods

Change-Id: I3c0841494242da9a7c3a73f776b783965e6619fb
Reviewed-on: http://gerrit.dmdirc.com/2182
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: Id2c55d69befbbbc1738ad7debb05d0a4d43a8396
Reviewed-on: http://gerrit.dmdirc.com/2181
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: I6a37f6955728aa732dcf0ba27bfa25749f250b3d
Depends-On: Ia23869ff1259e460f3389a425fc9e0e4a0a31955
Fixes-issue: CLIENT-311
Reviewed-on: http://gerrit.dmdirc.com/2179
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

 - This is used for backbuffer support in DFBnc, we currently only care about timestamps in
   ProcessMessage, everything else will just use the current time in their callbacks as before.

Change-Id: I248bfd4d72800465ba4b06331261a8519690c3d5
Reviewed-on: http://gerrit.dmdirc.com/2172
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Test is testing for invalid behaviour:

20:52:08 | <@Dataforce> I can't remember why we decided it was a bug
20:52:43 | <@Dataforce> It was to do with kicking simon and him coming back too fast or something
20:52:54 | <@Dataforce> oh, i remember
20:53:22 | <@Dataforce> kick simon, and then immediately kick him again - hes there, then he leaves, then hes there, Q sends a mode, then he is removed, Qs mode arrives

Not sure how the change made it through gerrit when it failed a test, but oh well.

Change-Id: I8bc45eee36c4d741e5df6c732704eee4bd60ea63
Reviewed-on: http://gerrit.dmdirc.com/2169
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Ignore modes for clients not on the channel.

Change-Id: If5a89ca2450e2583005045af60bdfc00b2a88765
Reviewed-on: http://gerrit.dmdirc.com/2138
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: Ic893051d84bc4ab47274b2bf9c967db8ba951eea
Depends-On: Iece6afe9fba02126f203cb1aecd702bc9303b981
Reviewed-on: http://gerrit.dmdirc.com/2133
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: I4c4264721c1f484033cf7307b95b4436720b0677
Reviewed-on: http://gerrit.dmdirc.com/2121
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: I4a4bd2f45c18759bced41fc0aec1e570f11dfa6f
Reviewed-on: http://gerrit.dmdirc.com/2073
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Change-Id: Id3d5ebb13b84543834aecd6374e70e56c526f4c3
Reviewed-on: http://gerrit.dmdirc.com/2059
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Change-Id: I149964132ab7debdd5282c8a7e26d701a695b47c
Reviewed-on: http://gerrit.dmdirc.com/2030
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager