Change-Id: I635e0d111ed182713132145e4d5fb1654f776ec4
Reviewed-on: http://gerrit.dmdirc.com/2071
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Make having unused fields or formal params a PMD error

Change-Id: Ief1c8e499af7e3a43328046dc140ba941d8cb010
Depends-On: I970b49db0abac46d15a11e2b71dc0b50bd3a8faf
Reviewed-on: http://gerrit.dmdirc.com/2034
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Make unused ctors a PMD error

Change-Id: I10f7350e9435179e1c6f89e01233778ddffa648a
Reviewed-on: http://gerrit.dmdirc.com/2029
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Fixes CLIENT-249

Depends-On: I02f3803fe1d3cce0a2b958fd11f3711965d8cfd3
Change-Id: Ib675bf702ed50b90649aafa8dcba67dd4ff35986
Reviewed-on: http://gerrit.dmdirc.com/1958
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: If63e94dcf0aec9e9aa99e84f9962879fca46051f
Reviewed-on: http://gerrit.dmdirc.com/1931
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: I9f382ab3d7b078fb759cbaca618bec5d21b8b5d9
Reviewed-on: http://gerrit.dmdirc.com/1919
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Depends-On: I65a4cbe48f772dc7e400d585b1bfab15521fdd12
Change-Id: Ib499b44b594fa6dd85ac65fba5b95f16beb23c48
Reviewed-on: http://gerrit.dmdirc.com/1872
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>

Issue CLIENT-26

Depends-On: Ied8d9e0cf06819326a469e715c6925af8fd22b5a

Change-Id: I69c5fd43b97244343b824aa7c2cf1d8bb71ba741
Reviewed-on: http://gerrit.dmdirc.com/1835
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Chris Smith <chris@dmdirc.com>

Depends-On: Ic938a7785a30477f47074e574ec8311723d803a9

Change-Id: I5ebf0bd52682cd0b1798d1b1b54353e5e65e793f
Reviewed-on: http://gerrit.dmdirc.com/1838
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Chris Smith <chris@dmdirc.com>

Issue CLIENT-26

Change-Id: Id1c32eb2e1b0b0be8a51563becaed0c1ff443180
Reviewed-on: http://gerrit.dmdirc.com/1834
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Change-Id: I9b5c03d7a9800d067af232101ea05f338a05101b
Reviewed-on: http://gerrit.dmdirc.com/1788
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Fixes CLIENT-68

Change-Id: I3d5b8625f202c7914c76a62100145597ef9fe523
Reviewed-on: http://gerrit.dmdirc.com/1779
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>

Change-Id: I94a245fd1824ba6a5c8c32e66a45a0c9be806aa1
Reviewed-on: http://gerrit.dmdirc.com/1750
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Change-Id: I7f63fdd02ea0109fe31e55c44b078edae3862f32
Reviewed-on: http://gerrit.dmdirc.com/1726
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Change-Id: I34118f2593a0499cd5d912b554158b4a146a5394
Reviewed-on: http://gerrit.dmdirc.com/1709
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Change-Id: Ia8c864cc8abab3bfdcabeac30b41f6fb29233e73
Reviewed-on: http://gerrit.dmdirc.com/1689
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Chris Smith <chris@dmdirc.com>

Issue Client-76

Change-Id: I7beee0f6d6d3d17c549a884e641d444d8a56dfc1
Reviewed-on: http://gerrit.dmdirc.com/1686
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Chris Smith <chris@dmdirc.com>

Fixes CLIENT-111

Change-Id: Ic080e6513ac4dbbd5f37098061690cc68088b53d
Reviewed-on: http://gerrit.dmdirc.com/1614
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Fixes CLIENT-85

Change-Id: I4cf493f58536b792de4de68b91f5c8f2541a90a0
Reviewed-on: http://gerrit.dmdirc.com/1596
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Change-Id: Ied76e21fbf72039d47ec2b35b236149c13941645
Depends-On: Ia126a15b60e54c08c1e780676fe363821e9b7518
Reviewed-on: http://gerrit.dmdirc.com/1591
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Fixes CLIENT-92

Change-Id: Ic9196cc5cdc4b0570ee25009c5ab48b03e9faf60
Reviewed-on: http://gerrit.dmdirc.com/1585
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Fixes CLIENT-46

Depends-On: I8434b810ba3ee5548467c3fd2b72faed4046a586
Change-Id: I79e9a19acf452c831ee6e671f50b54e8f674f2cd
Reviewed-on: http://gerrit.dmdirc.com/1569
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Fixes issue 4415

Change-Id: I52c7f76361f8b2fe4ebd38b00795e28ca4eee9e5
Reviewed-on: http://gerrit.dmdirc.com/1460
Automatic-Compile: Gregory Holmes <greg@dmdirc.com>
Reviewed-by: Gregory Holmes <greg@dmdirc.com>

Fixes issue 4253

Change-Id: Ibb46a6a1ba5c62d525b65f55d39632b82e335539
Reviewed-on: http://gerrit.dmdirc.com/1455
Automatic-Compile: Gregory Holmes <greg@dmdirc.com>
Reviewed-by: Gregory Holmes <greg@dmdirc.com>

Fixes issue 4323

Change-Id: Id1873c4b16eb53e583f81b05d16a6f2b4daab8d5
Reviewed-on: http://gerrit.dmdirc.com/1437
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Chris Smith <chris@dmdirc.com>

Change-Id: I4b6f5d06fa1d9f36a9f3d436f71562e4590b19d9
Reviewed-on: http://gerrit.dmdirc.com/1366
Reviewed-by: Gregory Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Change-Id: Ieeea77c9dd4d9f0eb2714fd6ad15bed87a534c51
Reviewed-on: http://gerrit.dmdirc.com/1364
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Chris Smith <chris@dmdirc.com>

Change-Id: Ieb68e5058481d7fb734af51bfa886663eb00bd3d
Reviewed-on: http://gerrit.dmdirc.com/1349
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Gregory Holmes <greg@dmdirc.com>

Change-Id: Idffa6c2559bcc2112c9657b15349aa80579ab83a
Reviewed-on: http://gerrit.dmdirc.com/1336
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Gregory Holmes <greg@dmdirc.com>

Change-Id: Icfab1de147645d80a999c3678daf268e7e115066
Reviewed-on: http://gerrit.dmdirc.com/1331
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Gregory Holmes <greg@dmdirc.com>

Only save if something has changed
Allow adding new groups to ServerLists

Issue 41

Change-Id: Iad5aae82c709b9c0d646c8747997a2352dea7fd2
Reviewed-on: http://gerrit.dmdirc.com/1315
Reviewed-by: Gregory Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Change-Id: Ia24abd971f4b8fac5cbae9069fc962e1da26d1a4
Reviewed-on: http://gerrit.dmdirc.com/1238
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Issue 41

Change-Id: Ia3a38a768d0d53974dcca2d44e650e74b553b8dc
Reviewed-on: http://gerrit.dmdirc.com/1234
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Gregory Holmes <greg@dmdirc.com>

Highlights:

  - FrameContainers are now generic, according to their window type
  - Writable frame containers now handle their tab completers
  - Redirect plugin works again
  - Windows are no longer actively requested from the UI; the UI
    creates and adds them in response to events from the WindowManager

fixes issue 3997, fixes issue 4000, fixes issue 4012, fixes issue 4030
fixes issue 4027, fixes issue 4028, fixes issue 4029, fixes issue 4031
fixes issue 4032, fixes issue 4033

Change-Id: Ife307728e46bd3b6dcd189be6886ab8b6fbd9212
Reviewed-on: http://gerrit.dmdirc.com/1144
Reviewed-by: Gregory Holmes <greg@dmdirc.com>
Automatic-Compile: Gregory Holmes <greg@dmdirc.com>

fixes issue 3860

Change-Id: I5bd3b2b15f5da1d3740213677a5a2b23f35425ba
Reviewed-on: http://gerrit.dmdirc.com/1103
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

fixes issue 3919

Change-Id: Id6862ebbc85a8c4acc755a0defb0a30e8337becd
Reviewed-on: http://gerrit.dmdirc.com/1024
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Fixes issue 2672

Change-Id: I1afcd0e6ca81cc0235652dd0a8c4872f3a5c76c1
Reviewed-on: http://gerrit.dmdirc.com/972
Reviewed-by: Gregory Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Fixes issue 3791

Change-Id: I392a4ce291d554e730a74c9ff5d3c8e63556af86
Reviewed-on: http://gerrit.dmdirc.com/961
Reviewed-by: Gregory Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Related to issue 1279

Change-Id: I5feb28c328a5cd07f9e95647976cb5777ba047f4
Reviewed-on: http://gerrit.dmdirc.com/868
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Gregory Holmes <greg@dmdirc.com>

If a file exists with the same name as a directory we need to create, try
to rename it, or provide the user with a decent error, instead of failing
an assertion.

Fixes issue 3697

Change-Id: Ia9dca5b1f1207ec3cb90d833b43b00f6b59b1d29
Reviewed-on: http://gerrit.dmdirc.com/915
Reviewed-by: Gregory Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Change-Id: I36585648b134f38def4c641ed1218da517221495
Reviewed-on: http://gerrit.dmdirc.com/846
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>

Change-Id: Idaf5f21e20e9775cbb104c30bb2e51e5b947d0b5
Reviewed-on: http://gerrit.dmdirc.com/823
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Gregory Holmes <greg@dmdirc.com>

Don't pretend core objects are serializable when they're blatently not
Fix possible file handle leak in Identity

Change-Id: I5e0d167d64a9ab8cd708e63d6716e30ca33163f6
Reviewed-on: http://gerrit.dmdirc.com/820
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Gregory Holmes <greg@dmdirc.com>

Change-Id: I50c85748a8d1535b109307e22376f21a5f754cea
Reviewed-on: http://gerrit.dmdirc.com/819
Reviewed-by: Gregory Holmes <greg@dmdirc.com>
Automatic-Compile: Gregory Holmes <greg@dmdirc.com>

Change-Id: I9789484be344adaa831b25bde4619075b02f1814
Reviewed-on: http://gerrit.dmdirc.com/817
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Gregory Holmes <greg@dmdirc.com>

Change-Id: I0a4a231790ec29f6a9e33f73e184d34afcda1db3
Reviewed-on: http://gerrit.dmdirc.com/815
Automatic-Compile: Chris Smith <chris@dmdirc.com>
Reviewed-by: Chris Smith <chris@dmdirc.com>

Add new comchan notification targets

Fixes issue 3691
Fixes issue 3694

Change-Id: I7114829934f57a83212f0f27c10d8bc99dd828d9
Reviewed-on: http://gerrit.dmdirc.com/755
Reviewed-by: Gregory Holmes <greg@dmdirc.com>
Automatic-Compile: Gregory Holmes <greg@dmdirc.com>

Fixes issue 1340
Change-Id: I11fc96aa780199eb42dd30dfe70b20107dada052
Reviewed-on: http://gerrit.dmdirc.com/754
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Fixes deadlock when setting some options to their default values

Change-Id: Ibfb91261db177bc7cdcd8d9d594fecbed789b718
Reviewed-on: http://gerrit.dmdirc.com/732
Reviewed-by: Gregory Holmes <greg@dmdirc.com>
Automatic-Compile: Gregory Holmes <greg@dmdirc.com>

It's not a general purpose util, and will only be used by the config system.

Change-Id: I2d0ac5ea23d8b7d0fcda6e467ddcf4ac08bc520a
Reviewed-on: http://gerrit.dmdirc.com/731
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>