Chris Smith
d15111ddd3
Restructure to standard maven/gradle layout.
Stop swimming against the tide and accept what most of the rest of
the world does.
While it adds an annoying depth to the actual source code, it makes
the root directory nicer (no more 'test-res' dirs), means we don't
have to override the gradle config, and makes it nicer to work in
IDEA 2016.1.
8 vuotta sitten
Chris Smith
18cb00a6bc
Assorted tidying.
8 vuotta sitten
Chris Smith
e939448113
Remove some event-based errors.
9 vuotta sitten
Chris Smith
d93f44ed9d
Remove profile migration logic.
The "old" profiles were pre 0.6.3m1 - if anyone upgrades from that
long ago they'll just lose their profiles.
9 vuotta sitten
Chris Smith
538a202df7
Remove use of WeakList.
This is fairly trivial to implement with streams/lambdas,
no need to have our own hand-rolled list implementation
for it.
9 vuotta sitten
Chris Smith
0cd88dccbb
Remove BaseConfigProvider.
This just provided default implementations of most of the
ReadOnlyConfigProvider interface, which as of J8 we can
now just put in the interface itself.
9 vuotta sitten
9f3fcd1b59
2015!
9 vuotta sitten
e133f31685
Remove some more Logger usages.
9 vuotta sitten
Chris Smith
8c4160a590
Rewrite the ConfigFileBackedConfigProviderTest.
(aka the "IdentityTest")
Make it a lot less dumb, use a virtual FS so we can test reloading
and saving. Fix a bunch of bugs the tests highlighted.
Only things not really tested are the global config specific
behaviours.
Change-Id: I96448eb9c401ce864cd6f39fd95088a4a8a09727
Reviewed-on: http://gerrit.dmdirc.com/4015
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 vuotta sitten
Chris Smith
4b39af4679
Unused method.
Change-Id: Iab6e13ee15efe07027c93ad2a1edabdc88fdf306
Reviewed-on: http://gerrit.dmdirc.com/4011
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 vuotta sitten
Chris Smith
aefb110fff
Path-ify the IdentityManager.
Change-Id: Iaf2b64f2bd6dcf834e3621e26ae3ff6b81cdb2b4
Reviewed-on: http://gerrit.dmdirc.com/4007
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 vuotta sitten
Chris Smith
fb0ab89eb5
Style fixes
Change-Id: I7743e62ce70f3e4e0bc07c90aeb62279783f7af6
Reviewed-on: http://gerrit.dmdirc.com/4006
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 vuotta sitten
Chris Smith
6ae693893d
Enable PMD in gradle + apply fixes.
Change-Id: I3665cac8af833da793ca418953d934cc3a333459
Depends-On: I348b37a14097439f8a56b0a671794410e46201ca
Depends-On: Ifc4aa601de14ca2526646f499f60329ed7c5935e
Reviewed-on: http://gerrit.dmdirc.com/3939
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 vuotta sitten
Chris Smith
693264fb86
Make all the things final.
Change-Id: I0c128522391d4de8452c603fae89d260c1a34ec2
Reviewed-on: http://gerrit.dmdirc.com/3836
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 vuotta sitten
Chris Smith
b0d0c95be7
Propagate annotations around a bit.
Change-Id: Ia3e89a5d05bbefb5e0b73e1d2b97bd3e8e4e6392
Reviewed-on: http://gerrit.dmdirc.com/3797
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 vuotta sitten
Chris Smith
5321ea8492
Style/inspection fixes.
Change-Id: Icd1b2e56b740d27af85f82563f9eef06f33a1914
Reviewed-on: http://gerrit.dmdirc.com/3698
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 vuotta sitten
6c730e6ff2
Throw exceptions is we fail to delete config file based things.
Change-Id: I4fa54ebe8f4ff93c8fc33504af66338eda01d0b8
Depends-On: I752f5bebe42514f1dc21e1b77e1ee5a649f324f5
Depends-On: I9463e66dc39881bcc69b64b8900df1010683b0bc
Depends-On: I752f5bebe42514f1dc21e1b77e1ee5a649f324f5
Reviewed-on: http://gerrit.dmdirc.com/3503
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 vuotta sitten
Chris Smith
01fa9b6453
Bulk remove inheritDoc.
Change-Id: I06a0f4ced5eb0c8281e52a38b37a27779c5d571b
Reviewed-on: http://gerrit.dmdirc.com/3273
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 vuotta sitten
Chris Smith
912140c077
Remove singleton IdentityManager accessors.
Woohoo.
Change-Id: Ib5dfa40b37670633791a39cc166ef53aeb2c2e79
Fixes-Issue: CLIENT-423
Reviewed-on: http://gerrit.dmdirc.com/3145
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 vuotta sitten
Chris Smith
f538c53f86
Fully configure the NB formatter and let it loose.
Change-Id: I7e8052839daa79fa113b89fd0b8c1c892a605b73
Reviewed-on: http://gerrit.dmdirc.com/3122
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 vuotta sitten
2a277dafbf
Remove lombok
Change-Id: I90a6dd3137244f5edc63ce846b07b4720d098194
Reviewed-on: http://gerrit.dmdirc.com/2986
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 vuotta sitten
12b39dc0f8
Update Copyright to 2014
Change-Id: Id0904867640e49e12fca5c1c7c5b9e72c78e3a1b
Reviewed-on: http://gerrit.dmdirc.com/2976
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 vuotta sitten
Chris Smith
0b69247ea1
Rename some config classes.
Change-Id: Ieaa7897a5e0bf1168e5c2b4405585558e108ee52
Reviewed-on: http://gerrit.dmdirc.com/2781
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 vuotta sitten
Chris Smith
d8b3fcb15f
Few more Identity references.
Change-Id: I120bda4c85a31339180146761791fd341d6d4740
Reviewed-on: http://gerrit.dmdirc.com/2778
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 vuotta sitten
Chris Smith
d596e02ddc
Remove direct Identity usages.
Move static factory methods into IdentityFactory, and replace
almost every use of Identity with ConfigProvider.
Depends-On: I6a32f3592cb5fc3df99a23eee62ae961ce0fc143
Change-Id: I66b382d54b77ef030d88448e456a83eb98aca216
Reviewed-on: http://gerrit.dmdirc.com/2777
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 vuotta sitten
Chris Smith
a335bf1208
Use config interfaces where possible.
Change-Id: Iaabedda2fa68c4e5562bb069dcdf15fa0c3beeea
Depends-On: I5f140e89bfb8c57804d0a500bbc9f5c18555b0e9
Reviewed-on: http://gerrit.dmdirc.com/2768
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 vuotta sitten
Chris Smith
b354ebdb70
Move old config interfaces into config folder.
Change-Id: I8d791451ead4b37f9181a9741e127cbc8b514d46
Depends-On: I94416680dfa9f0ee4896f5a6518889c6eb891909
Reviewed-on: http://gerrit.dmdirc.com/2754
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 vuotta sitten
Chris Smith
b94d5390ae
Introduce interfaces for identities/configmanagers
Change-Id: If8ead3ae7d8c4997d6735b9ffa871f699bceed27
Reviewed-on: http://gerrit.dmdirc.com/2752
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 vuotta sitten
b87e3ba335
Update copyright for 2013
Change-Id: Idf38f5027a92166daf99039de75b759d47431de1
Reviewed-on: http://gerrit.dmdirc.com/2607
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
11 vuotta sitten
792f3cc7dc
Make main less static.
Don't ask Main for the config directory.
Remove getMain() from Main.
Everything that needs a main now either gets given it, or asks something else.
Unfortunately, a few more dependencies on the static IdentityManager.getIdentityManager()
were introduced, but they can be tackled separately.
Fix unit tests for the above.
Change-Id: I9e42ac7f74453b739209a681d0a31f50c1be2a04
Depends-On: Ib5a9fdea5a2e25d5471d0b849f4f65fa0286d1f8
Reviewed-on: http://gerrit.dmdirc.com/2520
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
11 vuotta sitten
Chris Smith
ac16253f43
Use slf4j not java logging
Sprinkle lombok and config binding around
Change-Id: Ie4daf4451ed7e252e033ebf3bc59f6a606523a82
Reviewed-on: http://gerrit.dmdirc.com/2331
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
12 vuotta sitten
d26602c9dc
Update Copyright for 2012
Change-Id: I0d40c3ac86b9e06fad3f29bc36612b4162e54d1c
Reviewed-on: http://gerrit.dmdirc.com/2287
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 vuotta sitten
Chris Smith
5c64a29c45
Deprecations
Change-Id: I1aa33d6e360f6050b02b7fe3f7db1312451c93fb
Reviewed-on: http://gerrit.dmdirc.com/2282
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 vuotta sitten
Chris Smith
ebbd1daff5
Import fixing!
Change-Id: Ia90cb759b0777cf8d30eb6bfe30a5bece0105d24
Reviewed-on: http://gerrit.dmdirc.com/2281
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 vuotta sitten
Chris Smith
a7a57eca29
Fix fallout from util changes
Change-Id: I0bfd2dc61096dd9670b269463c27d9b00fd9a917
Depends-On: I6d0665e57f6e0e2ff2fb6a18742acb99010e79bf
Depends-On: Ia8de3c1a5fdc1eb9cfaa8b29a32bb3efb6d8ce6f
Reviewed-on: http://gerrit.dmdirc.com/2242
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 vuotta sitten
d04e2bea4f
Change header?
Change-Id: I635e0d111ed182713132145e4d5fb1654f776ec4
Reviewed-on: http://gerrit.dmdirc.com/2071
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 vuotta sitten
Chris Smith
77b570a30f
Style fixes
Change-Id: If63e94dcf0aec9e9aa99e84f9962879fca46051f
Reviewed-on: http://gerrit.dmdirc.com/1931
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 vuotta sitten
Chris Smith
f2018c541b
Remove trailing spaces
Change-Id: I9f382ab3d7b078fb759cbaca618bec5d21b8b5d9
Reviewed-on: http://gerrit.dmdirc.com/1919
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 vuotta sitten
acdd8268bc
Remove deprecations.
Depends-On: Ic938a7785a30477f47074e574ec8311723d803a9
Change-Id: I5ebf0bd52682cd0b1798d1b1b54353e5e65e793f
Reviewed-on: http://gerrit.dmdirc.com/1838
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 vuotta sitten
fd83b6b2a9
Update Copyright
Change-Id: I7f63fdd02ea0109fe31e55c44b078edae3862f32
Reviewed-on: http://gerrit.dmdirc.com/1726
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 vuotta sitten
Chris Smith
39693ea024
Rework how config sources handle invalid and disabled settings
Fixes CLIENT-46
Depends-On: I8434b810ba3ee5548467c3fd2b72faed4046a586
Change-Id: I79e9a19acf452c831ee6e671f50b54e8f674f2cd
Reviewed-on: http://gerrit.dmdirc.com/1569
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 vuotta sitten
Chris Smith
829e2addb0
Random style fixes
Change-Id: Ieb68e5058481d7fb734af51bfa886663eb00bd3d
Reviewed-on: http://gerrit.dmdirc.com/1349
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 vuotta sitten
Chris Smith
5d584f2068
Style fixes
Change-Id: Idffa6c2559bcc2112c9657b15349aa80579ab83a
Reviewed-on: http://gerrit.dmdirc.com/1336
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 vuotta sitten
Chris Smith
f9aa3e308c
Work on server lists
Only save if something has changed
Allow adding new groups to ServerLists
Issue 41
Change-Id: Iad5aae82c709b9c0d646c8747997a2352dea7fd2
Reviewed-on: http://gerrit.dmdirc.com/1315
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
14 vuotta sitten
Chris Smith
a193a7985b
Server list core merge
Issue 41
Change-Id: Ia3a38a768d0d53974dcca2d44e650e74b553b8dc
Reviewed-on: http://gerrit.dmdirc.com/1234
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 vuotta sitten
Chris Smith
73a2fb41aa
More style changes
Change-Id: Idaf5f21e20e9775cbb104c30bb2e51e5b947d0b5
Reviewed-on: http://gerrit.dmdirc.com/823
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 vuotta sitten
Chris Smith
77569b8666
More style improvements
Don't pretend core objects are serializable when they're blatently not
Fix possible file handle leak in Identity
Change-Id: I5e0d167d64a9ab8cd708e63d6716e30ca33163f6
Reviewed-on: http://gerrit.dmdirc.com/820
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 vuotta sitten
Chris Smith
5a8238e4d8
Don't hold locks while calling identity listeners
Fixes deadlock when setting some options to their default values
Change-Id: Ibfb91261db177bc7cdcd8d9d594fecbed789b718
Reviewed-on: http://gerrit.dmdirc.com/732
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
Automatic-Compile: Gregory Holmes <greg@dmdirc.com >
14 vuotta sitten
Chris Smith
a76a8b74da
Identity.unsetOption no longer holds locks when firing callbacks
Fixes issue 3554
Change-Id: I821cedf03f2eb0d32fbb158f417c604875103d94
Reviewed-on: http://gerrit.dmdirc.com/552
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Automatic-Compile: Gregory Holmes <greboid@dmdirc.com >
14 vuotta sitten
Chris Smith
3743933255
Fix some stupid if statements
Change-Id: Iee71ab2849b5ebb2b7bdd944ea3aac8cdfe0981a
Reviewed-on: http://gerrit.dmdirc.com/340
Reviewed-by: Gregory Holmes <greboid@dmdirc.com >
Tested-by: Gregory Holmes <greboid@dmdirc.com >
14 vuotta sitten
Chris Smith
Shane Mc Cormack