Make all the things final.

Change-Id: I0c128522391d4de8452c603fae89d260c1a34ec2
Reviewed-on: http://gerrit.dmdirc.com/3836
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

src/com/dmdirc/Main.java

@@ -158,7 +158,7 @@ public class Main {
         }
 
         try {
-            ClientModule clientModule = new ClientModule();
+            final ClientModule clientModule = new ClientModule();
             final ObjectGraph graph = ObjectGraph.create(clientModule);
             clientModule.setObjectGraph(graph);
 

src/com/dmdirc/ServerManager.java

@@ -245,7 +245,7 @@ public class ServerManager implements ServerFactory {
         if (server.getState().isDisconnected()) {
             server.connect(uri, profile);
         } else {
-            Collection<? extends ChannelJoinRequest> joinRequests =
+            final Collection<? extends ChannelJoinRequest> joinRequests =
                     server.getParser().extractChannels(uri);
             server.join(joinRequests.toArray(new ChannelJoinRequest[joinRequests.size()]));
         }

src/com/dmdirc/ServerStatus.java

@@ -42,7 +42,7 @@ public class ServerStatus {
     /** The current state of the server. */
     private ServerState state = ServerState.DISCONNECTED;
     /** A history of transactions for debugging purposes. */
-    private RollingList<String> history = new RollingList<>(10);
+    private final RollingList<String> history = new RollingList<>(10);
     /** A list of known parser hashcodes. */
     private final List<Integer> parsers = new ArrayList<>();
 

src/com/dmdirc/actions/Action.java

@@ -425,10 +425,10 @@ public class Action extends ActionModel implements ConfigChangeListener {
      * @return True if the condition is valid, false otherwise
      */
     private boolean readCondition(final Map<String, String> data) {
-        int arg;
+        final int arg;
         ActionComponent component = null;
-        ActionComparison comparison;
-        String target;
+        final ActionComparison comparison;
+        final String target;
         String starget = null;
 
         // ------ Read the argument
@@ -502,7 +502,7 @@ public class Action extends ActionModel implements ConfigChangeListener {
      */
     private ActionComponent readComponent(final Map<String, String> data, final int arg) {
         final String componentName = data.get("component");
-        ActionComponent component;
+        final ActionComponent component;
 
         if (componentName.indexOf('.') == -1) {
             component = actionController.getComponent(componentName);

src/com/dmdirc/actions/ActionSubstitutor.java

@@ -243,7 +243,7 @@ public class ActionSubstitutor {
                     ? new CommandArguments(commandController, (String) args[2])
                     : new CommandArguments(commandController, Arrays.asList((String[]) args[2]));
 
-            int start;
+            final int start;
             int end;
 
             start = end = Integer.parseInt(numberMatcher.group(1)) - 1;

src/com/dmdirc/actions/ConditionTree.java

@@ -257,7 +257,7 @@ public final class ConditionTree {
                 final ConditionTree third = readTerm(myStack);
 
                 if (third != null && second instanceof Character) {
-                    OPERATION op;
+                    final OPERATION op;
 
                     if ((Character) second == '&') {
                         op = OPERATION.AND;

src/com/dmdirc/actions/metatypes/ActionEvents.java

@@ -36,9 +36,9 @@ public enum ActionEvents implements ActionMetaType {
     /** Action event type. */
     ACTION_DELETED(new String[]{"Action group", "Action name"}, ActionGroup.class, String.class);
     /** The names of the arguments for this meta type. */
-    private String[] argNames;
+    private final String[] argNames;
     /** The classes of the arguments for this meta type. */
-    private Class<?>[] argTypes;
+    private final Class<?>[] argTypes;
 
     /**
      * Creates a new instance of this meta-type.

src/com/dmdirc/actions/metatypes/ChannelEvents.java

@@ -60,9 +60,9 @@ public enum ChannelEvents implements ActionMetaType {
     CHANNEL_SOURCED_EVENT_WITH_VICTIM(new String[]{"channel", "user", "victim", "message"},
             Channel.class, ChannelClientInfo.class, ChannelClientInfo.class, String.class);
     /** The names of the arguments for this meta type. */
-    private String[] argNames;
+    private final String[] argNames;
     /** The classes of the arguments for this meta type. */
-    private Class<?>[] argTypes;
+    private final Class<?>[] argTypes;
 
     /**
      * Creates a new instance of this meta-type.

src/com/dmdirc/actions/metatypes/ClientEvents.java

@@ -65,9 +65,9 @@ public enum ClientEvents implements ActionMetaType {
     UNKNOWN_COMMAND(new String[]{"source", "command", "arguments"}, FrameContainer.class,
             String.class, String[].class);
     /** The names of the arguments for this meta type. */
-    private String[] argNames;
+    private final String[] argNames;
     /** The classes of the arguments for this meta type. */
-    private Class<?>[] argTypes;
+    private final Class<?>[] argTypes;
 
     /**
      * Creates a new instance of this meta-type.

src/com/dmdirc/actions/metatypes/LinkEvents.java

@@ -37,9 +37,9 @@ public enum LinkEvents implements ActionMetaType {
     /** Nickname link clicked. */
     NICKNAME_CLICKED(new String[]{"Window", "Nickname"}, Window.class, String.class);
     /** The names of the arguments for this meta type. */
-    private String[] argNames;
+    private final String[] argNames;
     /** The classes of the arguments for this meta type. */
-    private Class<?>[] argTypes;
+    private final Class<?>[] argTypes;
 
     /**
      * Creates a new instance of this meta-type.

src/com/dmdirc/actions/metatypes/PluginEvents.java

@@ -33,9 +33,9 @@ public enum PluginEvents implements ActionMetaType {
     /** Plugin event type. */
     PLUGIN_EVENT(new String[]{"plugin"}, PluginInfo.class);
     /** The names of the arguments for this meta type. */
-    private String[] argNames;
+    private final String[] argNames;
     /** The classes of the arguments for this meta type. */
-    private Class<?>[] argTypes;
+    private final Class<?>[] argTypes;
 
     /**
      * Creates a new instance of this meta-type.

src/com/dmdirc/actions/metatypes/QueryEvents.java

@@ -39,9 +39,9 @@ public enum QueryEvents implements ActionMetaType {
     QUERY_SOURCED_EVENT_WITH_ARG(new String[]{"query", "source", "message"}, Query.class,
             ClientInfo.class, String.class);
     /** The names of the arguments for this meta type. */
-    private String[] argNames;
+    private final String[] argNames;
     /** The classes of the arguments for this meta type. */
-    private Class<?>[] argTypes;
+    private final Class<?>[] argTypes;
 
     /**
      * Creates a new instance of this meta-type.

src/com/dmdirc/actions/metatypes/ServerEvents.java

@@ -56,9 +56,9 @@ public enum ServerEvents implements ActionMetaType {
     /** Server event type. */
     SERVER_EVENT(new String[]{"server"}, Connection.class);
     /** The names of the arguments for this meta type. */
-    private String[] argNames;
+    private final String[] argNames;
     /** The classes of the arguments for this meta type. */
-    private Class<?>[] argTypes;
+    private final Class<?>[] argTypes;
 
     /**
      * Creates a new instance of this meta-type.

src/com/dmdirc/commandline/RemoteServer.java

@@ -68,7 +68,7 @@ public class RemoteServer implements RemoteInterface {
      * Binds to the RMI registry so that other clients may find this remote server.
      */
     public void bind() {
-        RemoteInterface stub;
+        final RemoteInterface stub;
 
         try {
             stub = (RemoteInterface) UnicastRemoteObject.exportObject(this, 0);

src/com/dmdirc/commandparser/PopupManager.java

@@ -103,7 +103,7 @@ public class PopupManager {
      */
     private PopupMenuItem getItem(final String item,
             final PopupType type, final AggregateConfigProvider configManager) {
-        PopupMenuItem res;
+        final PopupMenuItem res;
 
         if ("-".equals(item)) {
             res = new PopupMenuItem(commandController);

src/com/dmdirc/commandparser/commands/flags/CommandFlagHandler.java

@@ -103,7 +103,7 @@ public class CommandFlagHandler {
         int offset;
         for (offset = 0; offset < arguments.getArguments().length; offset++) {
             final String arg = arguments.getArguments()[offset];
-            String name;
+            final String name;
 
             if (arg.startsWith("--")
                     && flags.containsKey(name = arg.substring(2).toLowerCase())) {

src/com/dmdirc/commandparser/commands/global/Help.java

@@ -120,7 +120,7 @@ public class Help extends Command implements IntelligentCommand {
      */
     private void showCommand(final FrameContainer origin, final boolean isSilent,
             final String name) {
-        Map.Entry<CommandInfo, Command> command;
+        final Map.Entry<CommandInfo, Command> command;
 
         if (name.length() > 0 && name.charAt(0) == getController().getCommandChar()) {
             command = getController().getCommand(name.substring(1));

src/com/dmdirc/commandparser/commands/global/OpenWindow.java

@@ -122,7 +122,7 @@ public class OpenWindow extends Command implements IntelligentCommand {
                     ? args.getArgumentsAsString(start + 1) : args.getArguments()[start];
 
             if (window == null) {
-                CustomWindow newWindow;
+                final CustomWindow newWindow;
                 if (parent == null) {
                     newWindow = new CustomWindow(args.getArguments()[start], title,
                             configProvider, urlBuilder, eventBus);

src/com/dmdirc/config/BaseConfigProvider.java

@@ -75,7 +75,7 @@ public abstract class BaseConfigProvider implements ReadOnlyConfigProvider {
     @Override
     public boolean hasOptionString(final String domain, final String option,
             final Validator<String> validator) {
-        String value;
+        final String value;
 
         return hasOption(domain, option, validator)
                 && !(value = getOption(domain, option, validator)).isEmpty()
@@ -101,7 +101,7 @@ public abstract class BaseConfigProvider implements ReadOnlyConfigProvider {
     public String getOptionString(final String domain, final String option,
             final boolean required, final Validator<String> validator,
             final String... fallbacks) {
-        String value;
+        final String value;
 
         final Validator<String> newValidator = required && fallbacks.length == 0
                 ? ValidatorChain.<String>builder().addValidator(

src/com/dmdirc/config/ConfigFileBackedConfigProvider.java

@@ -313,7 +313,7 @@ public class ConfigFileBackedConfigProvider extends BaseConfigProvider implement
     @Override
     public void setOption(final String domain, final String option,
             final String value) {
-        String oldValue;
+        final String oldValue;
         boolean unset = false;
 
         synchronized (this) {

src/com/dmdirc/config/ConfigManager.java

@@ -246,7 +246,7 @@ class ConfigManager extends BaseConfigProvider implements ConfigChangeListener,
      * @return True if the identity applies, false otherwise
      */
     public boolean identityApplies(final ConfigProvider identity) {
-        String comp;
+        final String comp;
 
         switch (identity.getTarget().getType()) {
             case PROTOCOL:

src/com/dmdirc/config/IdentityManager.java

@@ -690,7 +690,7 @@ public class IdentityManager implements IdentityFactory, IdentityController {
      * @param configManager The manager to be initialised.
      */
     private void setUpConfigManager(final ConfigManager configManager) {
-        List<ConfigProvider> sources = getIdentitiesForManager(configManager);
+        final List<ConfigProvider> sources = getIdentitiesForManager(configManager);
 
         for (ConfigProvider identity : sources) {
             log.trace("Found {}", identity);

src/com/dmdirc/events/ChannelDisplayableUserEvent.java

@@ -51,7 +51,7 @@ public abstract class ChannelDisplayableUserEvent extends ChannelUserEvent imple
     }
 
     @Override
-    public void setDisplayFormat(String format) {
+    public void setDisplayFormat(final String format) {
         this.displayFormatRef.set(format);
     }
 

src/com/dmdirc/events/PluginEvent.java

@@ -29,7 +29,7 @@ import com.dmdirc.plugins.PluginInfo;
  */
 public abstract class PluginEvent extends DMDircEvent {
 
-    private PluginInfo plugin;
+    private final PluginInfo plugin;
 
     public PluginEvent(final PluginInfo plugin) {
         this.plugin = plugin;

src/com/dmdirc/logger/ErrorLevel.java

@@ -36,9 +36,9 @@ public enum ErrorLevel {
     /** Unknown priority error. */
     UNKNOWN("Unknown", "info");
     /** Error level string. */
-    private String value;
+    private final String value;
     /** Error level icon. */
-    private String icon;
+    private final String icon;
 
     /**
      * Instantiates the enum.

src/com/dmdirc/logger/ErrorManager.java

@@ -247,7 +247,7 @@ public class ErrorManager implements ConfigChangeListener {
      * @return True if a duplicate error has already been registered, false otherwise
      */
     protected boolean addError(final ProgramError error) {
-        int index;
+        final int index;
 
         synchronized (errors) {
             index = errors.indexOf(error);

src/com/dmdirc/plugins/PluginClassLoader.java

@@ -117,7 +117,7 @@ public class PluginClassLoader extends ClassLoader {
             }
         }
 
-        ResourceManager res;
+        final ResourceManager res;
         try {
             res = pluginInfo.getResourceManager();
         } catch (IOException ioe) {
@@ -151,7 +151,7 @@ public class PluginClassLoader extends ClassLoader {
         }
 
         // We are meant to be loading this one!
-        byte[] data;
+        final byte[] data;
         if (res.resourceExists(fileName)) {
             data = res.getResourceBytes(fileName);
         } else {

src/com/dmdirc/plugins/PluginInfo.java

@@ -121,7 +121,7 @@ public class PluginInfo implements Comparable<PluginInfo>, ServiceProvider {
         this.filename = new File(metadata.getPluginUrl().getPath()).getName();
         this.metaData = metadata;
 
-        ResourceManager res;
+        final ResourceManager res;
 
         try {
             res = getResourceManager();
@@ -222,8 +222,8 @@ public class PluginInfo implements Comparable<PluginInfo>, ServiceProvider {
         if (metaData.getParent() != null) {
             final PluginInfo parentInfo = metaData.getManager()
                     .getPluginInfoByName(metaData.getParent());
-            Plugin parent = parentInfo.getPlugin();
-            ObjectGraph parentGraph = parent.getObjectGraph();
+            final Plugin parent = parentInfo.getPlugin();
+            final ObjectGraph parentGraph = parent.getObjectGraph();
             if (parentGraph != null) {
                 return parentGraph;
             }

src/com/dmdirc/plugins/PluginMetaData.java

@@ -111,7 +111,7 @@ public class PluginMetaData {
     /** The URL to load the metadata from. */
     private final URL url;
     /** The parent plugin manager. */
-    private PluginManager manager;
+    private final PluginManager manager;
 
     /**
      * Creates a new meta data reader for a config file at the specified URL.

src/com/dmdirc/ui/input/AdditionalTabTargets.java

@@ -35,7 +35,7 @@ public final class AdditionalTabTargets extends ArrayList<String> {
     /** A version number for this class. */
     private static final long serialVersionUID = 1;
     /** Whether to include normal targets. */
-    private List<TabCompletionType> includes = new ArrayList<>(Arrays.asList(TabCompletionType.
+    private final List<TabCompletionType> includes = new ArrayList<>(Arrays.asList(TabCompletionType.
             values()));
 
     /**

src/com/dmdirc/ui/messages/ColourManager.java

@@ -49,7 +49,7 @@ public class ColourManager {
     /** Config manager to read settings from. */
     private final AggregateConfigProvider configManager;
     /** Actual colours we're using for the 16 IRC colours. */
-    private Colour[] ircColours = DEFAULT_COLOURS.clone();
+    private final Colour[] ircColours = DEFAULT_COLOURS.clone();
 
     /**
      * Creates a new instance of {@link ColourManager}.
@@ -149,7 +149,7 @@ public class ColourManager {
             return Colour.WHITE;
         }
 
-        Colour colour;
+        final Colour colour;
         try {
             colour = new Colour(
                     Integer.parseInt(hex.substring(0, 2), 16),

src/com/dmdirc/util/URIParser.java

@@ -70,7 +70,7 @@ public class URIParser {
         final String authority;
         final String host;
         final String portString;
-        int port;
+        final int port;
         final String path;
         final String query;
         final String fragment;
@@ -133,7 +133,7 @@ public class URIParser {
         }
 
         boolean ssl = false;
-        String host;
+        final String host;
         String pass = null;
         int port = -1;
 

src/com/dmdirc/util/resourcemanager/DMDircResourceManager.java

@@ -53,7 +53,7 @@ public final class DMDircResourceManager {
         final CodeSource codeSource = Main.class.getProtectionDomain().getCodeSource();
         try {
             final File jarFile = new File(codeSource.getLocation().toURI().getPath());
-            String jarDir;
+            final String jarDir;
             if (isRunningFromJar()) {
                 jarDir = jarFile.getParentFile().getPath();
             } else {

src/com/dmdirc/util/resourcemanager/ResourceManager.java

@@ -132,7 +132,7 @@ public abstract class ResourceManager {
             return false;
         }
 
-        File newDir;
+        final File newDir;
 
         if (usePath && resourceName.indexOf('/') > -1) {
             newDir = new File(directory,