Sfoglia il codice sorgente

Propagate annotations around a bit.

Change-Id: Ia3e89a5d05bbefb5e0b73e1d2b97bd3e8e4e6392
Reviewed-on: http://gerrit.dmdirc.com/3797
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
pull/1/head
Chris Smith 9 anni fa
parent
commit
b0d0c95be7
54 ha cambiato i file con 111 aggiunte e 53 eliminazioni
  1. 3
    1
      src/com/dmdirc/commandparser/aliases/AliasCommandHandler.java
  2. 2
    1
      src/com/dmdirc/commandparser/commands/channel/Ban.java
  3. 2
    1
      src/com/dmdirc/commandparser/commands/channel/Cycle.java
  4. 2
    1
      src/com/dmdirc/commandparser/commands/channel/Invite.java
  5. 2
    1
      src/com/dmdirc/commandparser/commands/channel/KickReason.java
  6. 2
    1
      src/com/dmdirc/commandparser/commands/channel/Mode.java
  7. 2
    1
      src/com/dmdirc/commandparser/commands/channel/Names.java
  8. 2
    1
      src/com/dmdirc/commandparser/commands/channel/Part.java
  9. 2
    1
      src/com/dmdirc/commandparser/commands/channel/SetNickColour.java
  10. 2
    1
      src/com/dmdirc/commandparser/commands/channel/ShowTopic.java
  11. 2
    1
      src/com/dmdirc/commandparser/commands/chat/Me.java
  12. 2
    1
      src/com/dmdirc/commandparser/commands/global/AliasCommand.java
  13. 2
    1
      src/com/dmdirc/commandparser/commands/global/AllServers.java
  14. 2
    1
      src/com/dmdirc/commandparser/commands/global/Clear.java
  15. 2
    1
      src/com/dmdirc/commandparser/commands/global/Echo.java
  16. 2
    1
      src/com/dmdirc/commandparser/commands/global/Exit.java
  17. 2
    1
      src/com/dmdirc/commandparser/commands/global/Help.java
  18. 2
    1
      src/com/dmdirc/commandparser/commands/global/Ifplugin.java
  19. 2
    1
      src/com/dmdirc/commandparser/commands/global/LoadPlugin.java
  20. 2
    1
      src/com/dmdirc/commandparser/commands/global/NewServer.java
  21. 2
    1
      src/com/dmdirc/commandparser/commands/global/Notify.java
  22. 2
    1
      src/com/dmdirc/commandparser/commands/global/OpenWindow.java
  23. 2
    1
      src/com/dmdirc/commandparser/commands/global/ReloadActions.java
  24. 2
    1
      src/com/dmdirc/commandparser/commands/global/ReloadIdentities.java
  25. 2
    1
      src/com/dmdirc/commandparser/commands/global/ReloadPlugin.java
  26. 2
    1
      src/com/dmdirc/commandparser/commands/global/SaveConfig.java
  27. 2
    1
      src/com/dmdirc/commandparser/commands/global/SetCommand.java
  28. 2
    1
      src/com/dmdirc/commandparser/commands/global/UnloadPlugin.java
  29. 2
    1
      src/com/dmdirc/commandparser/commands/server/AllChannels.java
  30. 2
    1
      src/com/dmdirc/commandparser/commands/server/Away.java
  31. 2
    1
      src/com/dmdirc/commandparser/commands/server/Back.java
  32. 2
    1
      src/com/dmdirc/commandparser/commands/server/ChangeServer.java
  33. 2
    1
      src/com/dmdirc/commandparser/commands/server/Ctcp.java
  34. 2
    1
      src/com/dmdirc/commandparser/commands/server/Disconnect.java
  35. 2
    1
      src/com/dmdirc/commandparser/commands/server/Ignore.java
  36. 2
    1
      src/com/dmdirc/commandparser/commands/server/JoinChannelCommand.java
  37. 2
    1
      src/com/dmdirc/commandparser/commands/server/Message.java
  38. 2
    1
      src/com/dmdirc/commandparser/commands/server/Nick.java
  39. 2
    1
      src/com/dmdirc/commandparser/commands/server/Notice.java
  40. 2
    1
      src/com/dmdirc/commandparser/commands/server/OpenQuery.java
  41. 2
    1
      src/com/dmdirc/commandparser/commands/server/Raw.java
  42. 3
    1
      src/com/dmdirc/commandparser/commands/server/RawServerCommand.java
  43. 2
    1
      src/com/dmdirc/commandparser/commands/server/Reconnect.java
  44. 2
    1
      src/com/dmdirc/commandparser/commands/server/Umode.java
  45. 2
    2
      src/com/dmdirc/config/ConfigFileBackedConfigProvider.java
  46. 3
    1
      src/com/dmdirc/config/ConfigTarget.java
  47. 1
    0
      src/com/dmdirc/events/ChannelTopicChangeEvent.java
  48. 1
    0
      src/com/dmdirc/events/UnknownCommandEvent.java
  49. 2
    1
      src/com/dmdirc/plugins/PluginInfo.java
  50. 1
    1
      src/com/dmdirc/ui/input/TabCompleter.java
  51. 3
    1
      src/com/dmdirc/ui/themes/Theme.java
  52. 3
    1
      src/com/dmdirc/updater/Version.java
  53. 2
    1
      src/com/dmdirc/updater/manager/DMDircUpdateManager.java
  54. 3
    1
      test/com/dmdirc/harness/TestCommandParser.java

+ 3
- 1
src/com/dmdirc/commandparser/aliases/AliasCommandHandler.java Vedi File

@@ -28,6 +28,8 @@ import com.dmdirc.commandparser.commands.Command;
28 28
 import com.dmdirc.commandparser.commands.context.CommandContext;
29 29
 import com.dmdirc.interfaces.CommandController;
30 30
 
31
+import javax.annotation.Nonnull;
32
+
31 33
 /**
32 34
  * {@link Command} implementation that handles an alias.
33 35
  */
@@ -41,7 +43,7 @@ public class AliasCommandHandler extends Command {
41 43
     }
42 44
 
43 45
     @Override
44
-    public void execute(final FrameContainer origin, final CommandArguments args,
46
+    public void execute(@Nonnull final FrameContainer origin, final CommandArguments args,
45 47
             final CommandContext context) {
46 48
         if (args.getArguments().length >= alias.getMinArguments()) {
47 49
             for (String line : alias.getSubstitution().split("\n")) {

+ 2
- 1
src/com/dmdirc/commandparser/commands/channel/Ban.java Vedi File

@@ -37,6 +37,7 @@ import com.dmdirc.parser.interfaces.ChannelClientInfo;
37 37
 import com.dmdirc.ui.input.AdditionalTabTargets;
38 38
 import com.dmdirc.ui.input.TabCompletionType;
39 39
 
40
+import javax.annotation.Nonnull;
40 41
 import javax.inject.Inject;
41 42
 
42 43
 /**
@@ -60,7 +61,7 @@ public class Ban extends Command implements IntelligentCommand {
60 61
     }
61 62
 
62 63
     @Override
63
-    public void execute(final FrameContainer origin,
64
+    public void execute(@Nonnull final FrameContainer origin,
64 65
             final CommandArguments args, final CommandContext context) {
65 66
         final Channel channel = ((ChannelCommandContext) context).getChannel();
66 67
 

+ 2
- 1
src/com/dmdirc/commandparser/commands/channel/Cycle.java Vedi File

@@ -34,6 +34,7 @@ import com.dmdirc.commandparser.commands.context.ChannelCommandContext;
34 34
 import com.dmdirc.commandparser.commands.context.CommandContext;
35 35
 import com.dmdirc.interfaces.CommandController;
36 36
 
37
+import javax.annotation.Nonnull;
37 38
 import javax.inject.Inject;
38 39
 
39 40
 /**
@@ -58,7 +59,7 @@ public class Cycle extends Command {
58 59
     }
59 60
 
60 61
     @Override
61
-    public void execute(final FrameContainer origin,
62
+    public void execute(@Nonnull final FrameContainer origin,
62 63
             final CommandArguments args, final CommandContext context) {
63 64
         final Channel channel = ((ChannelCommandContext) context).getChannel();
64 65
         channel.part(args.getArguments().length > 0 ? args.getArgumentsAsString()

+ 2
- 1
src/com/dmdirc/commandparser/commands/channel/Invite.java Vedi File

@@ -37,6 +37,7 @@ import com.dmdirc.commandparser.commands.context.CommandContext;
37 37
 import com.dmdirc.interfaces.CommandController;
38 38
 import com.dmdirc.parser.interfaces.ChannelInfo;
39 39
 
40
+import javax.annotation.Nonnull;
40 41
 import javax.inject.Inject;
41 42
 
42 43
 /**
@@ -63,7 +64,7 @@ public class Invite extends Command implements ExternalCommand {
63 64
     }
64 65
 
65 66
     @Override
66
-    public void execute(final FrameContainer origin,
67
+    public void execute(@Nonnull final FrameContainer origin,
67 68
             final CommandArguments args, final CommandContext context) {
68 69
         if (args.getArguments().length < 1) {
69 70
             sendLine(origin, args.isSilent(), FORMAT_ERROR,

+ 2
- 1
src/com/dmdirc/commandparser/commands/channel/KickReason.java Vedi File

@@ -38,6 +38,7 @@ import com.dmdirc.parser.interfaces.ChannelClientInfo;
38 38
 import com.dmdirc.ui.input.AdditionalTabTargets;
39 39
 import com.dmdirc.ui.input.TabCompletionType;
40 40
 
41
+import javax.annotation.Nonnull;
41 42
 import javax.inject.Inject;
42 43
 
43 44
 /**
@@ -63,7 +64,7 @@ public class KickReason extends Command implements IntelligentCommand {
63 64
     }
64 65
 
65 66
     @Override
66
-    public void execute(final FrameContainer origin,
67
+    public void execute(@Nonnull final FrameContainer origin,
67 68
             final CommandArguments args, final CommandContext context) {
68 69
         final Channel channel = ((ChannelCommandContext) context).getChannel();
69 70
         if (args.getArguments().length == 0) {

+ 2
- 1
src/com/dmdirc/commandparser/commands/channel/Mode.java Vedi File

@@ -40,6 +40,7 @@ import com.dmdirc.parser.interfaces.ChannelInfo;
40 40
 import com.dmdirc.ui.input.AdditionalTabTargets;
41 41
 import com.dmdirc.ui.input.TabCompletionType;
42 42
 
43
+import javax.annotation.Nonnull;
43 44
 import javax.inject.Inject;
44 45
 
45 46
 /**
@@ -65,7 +66,7 @@ public class Mode extends Command implements IntelligentCommand,
65 66
     }
66 67
 
67 68
     @Override
68
-    public void execute(final FrameContainer origin,
69
+    public void execute(@Nonnull final FrameContainer origin,
69 70
             final CommandArguments args, final CommandContext context) {
70 71
         final Channel channel = ((ChannelCommandContext) context).getChannel();
71 72
         final ChannelInfo cChannel = channel.getChannelInfo();

+ 2
- 1
src/com/dmdirc/commandparser/commands/channel/Names.java Vedi File

@@ -38,6 +38,7 @@ import com.dmdirc.commandparser.commands.context.CommandContext;
38 38
 import com.dmdirc.interfaces.CommandController;
39 39
 import com.dmdirc.ui.input.AdditionalTabTargets;
40 40
 
41
+import javax.annotation.Nonnull;
41 42
 import javax.inject.Inject;
42 43
 
43 44
 /**
@@ -63,7 +64,7 @@ public class Names extends Command implements IntelligentCommand,
63 64
     }
64 65
 
65 66
     @Override
66
-    public void execute(final FrameContainer origin,
67
+    public void execute(@Nonnull final FrameContainer origin,
67 68
             final CommandArguments args, final CommandContext context) {
68 69
         final Channel channel = ((ChannelCommandContext) context).getChannel();
69 70
         channel.getConnection().getParser().sendRawMessage("NAMES "

+ 2
- 1
src/com/dmdirc/commandparser/commands/channel/Part.java Vedi File

@@ -34,6 +34,7 @@ import com.dmdirc.commandparser.commands.context.ChannelCommandContext;
34 34
 import com.dmdirc.commandparser.commands.context.CommandContext;
35 35
 import com.dmdirc.interfaces.CommandController;
36 36
 
37
+import javax.annotation.Nonnull;
37 38
 import javax.inject.Inject;
38 39
 
39 40
 /**
@@ -58,7 +59,7 @@ public class Part extends Command {
58 59
     }
59 60
 
60 61
     @Override
61
-    public void execute(final FrameContainer origin,
62
+    public void execute(@Nonnull final FrameContainer origin,
62 63
             final CommandArguments args, final CommandContext context) {
63 64
         final Channel channel = ((ChannelCommandContext) context).getChannel();
64 65
         channel.part(args.getArguments().length > 0 ? args.getArgumentsAsString()

+ 2
- 1
src/com/dmdirc/commandparser/commands/channel/SetNickColour.java Vedi File

@@ -40,6 +40,7 @@ import com.dmdirc.ui.input.AdditionalTabTargets;
40 40
 import com.dmdirc.ui.input.TabCompletionType;
41 41
 import com.dmdirc.ui.messages.ColourManager;
42 42
 
43
+import javax.annotation.Nonnull;
43 44
 import javax.inject.Inject;
44 45
 
45 46
 /**
@@ -68,7 +69,7 @@ public class SetNickColour extends Command implements IntelligentCommand {
68 69
     }
69 70
 
70 71
     @Override
71
-    public void execute(final FrameContainer origin,
72
+    public void execute(@Nonnull final FrameContainer origin,
72 73
             final CommandArguments args, final CommandContext context) {
73 74
         final Channel channel = ((ChannelCommandContext) context).getChannel();
74 75
 

+ 2
- 1
src/com/dmdirc/commandparser/commands/channel/ShowTopic.java Vedi File

@@ -37,6 +37,7 @@ import com.dmdirc.commandparser.commands.context.CommandContext;
37 37
 import com.dmdirc.interfaces.CommandController;
38 38
 import com.dmdirc.parser.interfaces.ChannelInfo;
39 39
 
40
+import javax.annotation.Nonnull;
40 41
 import javax.inject.Inject;
41 42
 
42 43
 /**
@@ -61,7 +62,7 @@ public class ShowTopic extends Command implements ExternalCommand {
61 62
     }
62 63
 
63 64
     @Override
64
-    public void execute(final FrameContainer origin,
65
+    public void execute(@Nonnull final FrameContainer origin,
65 66
             final CommandArguments args, final CommandContext context) {
66 67
         final Channel channel = ((ChannelCommandContext) context).getChannel();
67 68
         if (args.getArguments().length == 0) {

+ 2
- 1
src/com/dmdirc/commandparser/commands/chat/Me.java Vedi File

@@ -35,6 +35,7 @@ import com.dmdirc.commandparser.commands.context.CommandContext;
35 35
 import com.dmdirc.interfaces.CommandController;
36 36
 import com.dmdirc.util.validators.ValidationResponse;
37 37
 
38
+import javax.annotation.Nonnull;
38 39
 import javax.inject.Inject;
39 40
 
40 41
 /**
@@ -59,7 +60,7 @@ public class Me extends Command implements ValidatingCommand {
59 60
     }
60 61
 
61 62
     @Override
62
-    public void execute(final FrameContainer origin,
63
+    public void execute(@Nonnull final FrameContainer origin,
63 64
             final CommandArguments args, final CommandContext context) {
64 65
         final MessageTarget target = ((ChatCommandContext) context).getChat();
65 66
         if (args.getArguments().length == 0) {

+ 2
- 1
src/com/dmdirc/commandparser/commands/global/AliasCommand.java Vedi File

@@ -39,6 +39,7 @@ import com.dmdirc.ui.input.TabCompleter;
39 39
 
40 40
 import com.google.common.base.Optional;
41 41
 
42
+import javax.annotation.Nonnull;
42 43
 import javax.inject.Inject;
43 44
 
44 45
 /**
@@ -73,7 +74,7 @@ public class AliasCommand extends Command implements IntelligentCommand {
73 74
     }
74 75
 
75 76
     @Override
76
-    public void execute(final FrameContainer origin,
77
+    public void execute(@Nonnull final FrameContainer origin,
77 78
             final CommandArguments args, final CommandContext context) {
78 79
         if (args.getArguments().length < 2) {
79 80
             showUsage(origin, args.isSilent(), "alias", "[--remove] <name> [command]");

+ 2
- 1
src/com/dmdirc/commandparser/commands/global/AllServers.java Vedi File

@@ -36,6 +36,7 @@ import com.dmdirc.interfaces.CommandController;
36 36
 import com.dmdirc.ui.input.AdditionalTabTargets;
37 37
 import com.dmdirc.ui.input.TabCompleter;
38 38
 
39
+import javax.annotation.Nonnull;
39 40
 import javax.inject.Inject;
40 41
 
41 42
 /**
@@ -63,7 +64,7 @@ public class AllServers extends Command implements IntelligentCommand {
63 64
     }
64 65
 
65 66
     @Override
66
-    public void execute(final FrameContainer origin,
67
+    public void execute(@Nonnull final FrameContainer origin,
67 68
             final CommandArguments args, final CommandContext context) {
68 69
         final String command = args.getArgumentsAsString();
69 70
 

+ 2
- 1
src/com/dmdirc/commandparser/commands/global/Clear.java Vedi File

@@ -33,6 +33,7 @@ import com.dmdirc.commandparser.commands.context.CommandContext;
33 33
 import com.dmdirc.interfaces.CommandController;
34 34
 import com.dmdirc.ui.input.AdditionalTabTargets;
35 35
 
36
+import javax.annotation.Nonnull;
36 37
 import javax.inject.Inject;
37 38
 
38 39
 /**
@@ -56,7 +57,7 @@ public class Clear extends Command implements IntelligentCommand {
56 57
     }
57 58
 
58 59
     @Override
59
-    public void execute(final FrameContainer origin,
60
+    public void execute(@Nonnull final FrameContainer origin,
60 61
             final CommandArguments args, final CommandContext context) {
61 62
         origin.getDocument().clear();
62 63
     }

+ 2
- 1
src/com/dmdirc/commandparser/commands/global/Echo.java Vedi File

@@ -45,6 +45,7 @@ import java.util.ArrayList;
45 45
 import java.util.Date;
46 46
 import java.util.List;
47 47
 
48
+import javax.annotation.Nonnull;
48 49
 import javax.inject.Inject;
49 50
 
50 51
 /**
@@ -81,7 +82,7 @@ public class Echo extends Command implements IntelligentCommand {
81 82
     }
82 83
 
83 84
     @Override
84
-    public void execute(final FrameContainer origin,
85
+    public void execute(@Nonnull final FrameContainer origin,
85 86
             final CommandArguments args, final CommandContext context) {
86 87
         final CommandFlagResult results = handler.process(origin, args);
87 88
 

+ 2
- 1
src/com/dmdirc/commandparser/commands/global/Exit.java Vedi File

@@ -32,6 +32,7 @@ import com.dmdirc.commandparser.commands.context.CommandContext;
32 32
 import com.dmdirc.interfaces.CommandController;
33 33
 import com.dmdirc.interfaces.LifecycleController;
34 34
 
35
+import javax.annotation.Nonnull;
35 36
 import javax.inject.Inject;
36 37
 
37 38
 /**
@@ -60,7 +61,7 @@ public class Exit extends Command {
60 61
     }
61 62
 
62 63
     @Override
63
-    public void execute(final FrameContainer origin,
64
+    public void execute(@Nonnull final FrameContainer origin,
64 65
             final CommandArguments args, final CommandContext context) {
65 66
         controller.quit(args.getArguments().length > 0 ? args.getArgumentsAsString()
66 67
                 : origin.getConfigManager().getOption("general", "closemessage"));

+ 2
- 1
src/com/dmdirc/commandparser/commands/global/Help.java Vedi File

@@ -40,6 +40,7 @@ import java.util.Collections;
40 40
 import java.util.List;
41 41
 import java.util.Map;
42 42
 
43
+import javax.annotation.Nonnull;
43 44
 import javax.inject.Inject;
44 45
 
45 46
 /**
@@ -65,7 +66,7 @@ public class Help extends Command implements IntelligentCommand {
65 66
     }
66 67
 
67 68
     @Override
68
-    public void execute(final FrameContainer origin,
69
+    public void execute(@Nonnull final FrameContainer origin,
69 70
             final CommandArguments args, final CommandContext context) {
70 71
         if (args.getArguments().length == 0) {
71 72
             showAllCommands(origin, args.isSilent());

+ 2
- 1
src/com/dmdirc/commandparser/commands/global/Ifplugin.java Vedi File

@@ -38,6 +38,7 @@ import com.dmdirc.plugins.PluginManager;
38 38
 import com.dmdirc.ui.input.AdditionalTabTargets;
39 39
 import com.dmdirc.ui.input.TabCompleter;
40 40
 
41
+import javax.annotation.Nonnull;
41 42
 import javax.inject.Inject;
42 43
 import javax.inject.Provider;
43 44
 
@@ -80,7 +81,7 @@ public class Ifplugin extends Command implements IntelligentCommand {
80 81
     }
81 82
 
82 83
     @Override
83
-    public void execute(final FrameContainer origin,
84
+    public void execute(@Nonnull final FrameContainer origin,
84 85
             final CommandArguments args, final CommandContext context) {
85 86
         if (args.getArguments().length <= 1) {
86 87
             showUsage(origin, args.isSilent(), "ifplugin", "<[!]plugin> <command>");

+ 2
- 1
src/com/dmdirc/commandparser/commands/global/LoadPlugin.java Vedi File

@@ -36,6 +36,7 @@ import com.dmdirc.plugins.PluginManager;
36 36
 import com.dmdirc.plugins.PluginMetaData;
37 37
 import com.dmdirc.ui.input.AdditionalTabTargets;
38 38
 
39
+import javax.annotation.Nonnull;
39 40
 import javax.inject.Inject;
40 41
 
41 42
 /**
@@ -63,7 +64,7 @@ public class LoadPlugin extends Command implements IntelligentCommand {
63 64
     }
64 65
 
65 66
     @Override
66
-    public void execute(final FrameContainer origin,
67
+    public void execute(@Nonnull final FrameContainer origin,
67 68
             final CommandArguments args, final CommandContext context) {
68 69
         if (args.getArguments().length == 0) {
69 70
             showUsage(origin, args.isSilent(), "loadplugin", "<plugin>");

+ 2
- 1
src/com/dmdirc/commandparser/commands/global/NewServer.java Vedi File

@@ -44,6 +44,7 @@ import com.dmdirc.util.URIParser;
44 44
 
45 45
 import java.net.URI;
46 46
 
47
+import javax.annotation.Nonnull;
47 48
 import javax.inject.Inject;
48 49
 
49 50
 /**
@@ -88,7 +89,7 @@ public class NewServer extends Command implements IntelligentCommand {
88 89
     }
89 90
 
90 91
     @Override
91
-    public void execute(final FrameContainer origin,
92
+    public void execute(@Nonnull final FrameContainer origin,
92 93
             final CommandArguments args, final CommandContext context) {
93 94
         if (args.getArguments().length == 0) {
94 95
             showUsage(origin, args.isSilent(), "newserver", "<host[:[+]port]> [password]");

+ 2
- 1
src/com/dmdirc/commandparser/commands/global/Notify.java Vedi File

@@ -35,6 +35,7 @@ import com.dmdirc.ui.Colour;
35 35
 import com.dmdirc.ui.input.AdditionalTabTargets;
36 36
 import com.dmdirc.ui.messages.ColourManager;
37 37
 
38
+import javax.annotation.Nonnull;
38 39
 import javax.inject.Inject;
39 40
 
40 41
 /**
@@ -62,7 +63,7 @@ public class Notify extends Command implements IntelligentCommand {
62 63
     }
63 64
 
64 65
     @Override
65
-    public void execute(final FrameContainer origin,
66
+    public void execute(@Nonnull final FrameContainer origin,
66 67
             final CommandArguments args, final CommandContext context) {
67 68
         if (args.getArguments().length == 0) {
68 69
             showUsage(origin, args.isSilent(), "notify", "<colour>");

+ 2
- 1
src/com/dmdirc/commandparser/commands/global/OpenWindow.java Vedi File

@@ -40,6 +40,7 @@ import com.dmdirc.ui.WindowManager;
40 40
 import com.dmdirc.ui.input.AdditionalTabTargets;
41 41
 import com.dmdirc.util.URLBuilder;
42 42
 
43
+import javax.annotation.Nonnull;
43 44
 import javax.inject.Inject;
44 45
 
45 46
 /**
@@ -86,7 +87,7 @@ public class OpenWindow extends Command implements IntelligentCommand {
86 87
     }
87 88
 
88 89
     @Override
89
-    public void execute(final FrameContainer origin,
90
+    public void execute(@Nonnull final FrameContainer origin,
90 91
             final CommandArguments args, final CommandContext context) {
91 92
         int start = 0;
92 93
         FrameContainer parent = null;

+ 2
- 1
src/com/dmdirc/commandparser/commands/global/ReloadActions.java Vedi File

@@ -34,6 +34,7 @@ import com.dmdirc.interfaces.ActionController;
34 34
 import com.dmdirc.interfaces.CommandController;
35 35
 import com.dmdirc.ui.input.AdditionalTabTargets;
36 36
 
37
+import javax.annotation.Nonnull;
37 38
 import javax.inject.Inject;
38 39
 
39 40
 /**
@@ -63,7 +64,7 @@ public final class ReloadActions extends Command implements IntelligentCommand {
63 64
     }
64 65
 
65 66
     @Override
66
-    public void execute(final FrameContainer origin,
67
+    public void execute(@Nonnull final FrameContainer origin,
67 68
             final CommandArguments args, final CommandContext context) {
68 69
         actionController.loadUserActions();
69 70
         sendLine(origin, args.isSilent(), FORMAT_OUTPUT, "Actions reloaded.");

+ 2
- 1
src/com/dmdirc/commandparser/commands/global/ReloadIdentities.java Vedi File

@@ -34,6 +34,7 @@ import com.dmdirc.interfaces.CommandController;
34 34
 import com.dmdirc.interfaces.config.IdentityController;
35 35
 import com.dmdirc.ui.input.AdditionalTabTargets;
36 36
 
37
+import javax.annotation.Nonnull;
37 38
 import javax.inject.Inject;
38 39
 
39 40
 /**
@@ -62,7 +63,7 @@ public class ReloadIdentities extends Command implements IntelligentCommand {
62 63
     }
63 64
 
64 65
     @Override
65
-    public void execute(final FrameContainer origin,
66
+    public void execute(@Nonnull final FrameContainer origin,
66 67
             final CommandArguments args, final CommandContext context) {
67 68
         identityController.loadUserIdentities();
68 69
 

+ 2
- 1
src/com/dmdirc/commandparser/commands/global/ReloadPlugin.java Vedi File

@@ -35,6 +35,7 @@ import com.dmdirc.plugins.PluginInfo;
35 35
 import com.dmdirc.plugins.PluginManager;
36 36
 import com.dmdirc.ui.input.AdditionalTabTargets;
37 37
 
38
+import javax.annotation.Nonnull;
38 39
 import javax.inject.Inject;
39 40
 
40 41
 /**
@@ -62,7 +63,7 @@ public class ReloadPlugin extends Command implements IntelligentCommand {
62 63
     }
63 64
 
64 65
     @Override
65
-    public void execute(final FrameContainer origin,
66
+    public void execute(@Nonnull final FrameContainer origin,
66 67
             final CommandArguments args, final CommandContext context) {
67 68
         if (args.getArguments().length == 0) {
68 69
             showUsage(origin, args.isSilent(), "reloadplugin", "<plugin>");

+ 2
- 1
src/com/dmdirc/commandparser/commands/global/SaveConfig.java Vedi File

@@ -34,6 +34,7 @@ import com.dmdirc.interfaces.CommandController;
34 34
 import com.dmdirc.interfaces.config.IdentityController;
35 35
 import com.dmdirc.ui.input.AdditionalTabTargets;
36 36
 
37
+import javax.annotation.Nonnull;
37 38
 import javax.inject.Inject;
38 39
 
39 40
 /**
@@ -62,7 +63,7 @@ public final class SaveConfig extends Command implements IntelligentCommand {
62 63
     }
63 64
 
64 65
     @Override
65
-    public void execute(final FrameContainer origin,
66
+    public void execute(@Nonnull final FrameContainer origin,
66 67
             final CommandArguments args, final CommandContext context) {
67 68
         identityController.saveAll();
68 69
 

+ 2
- 1
src/com/dmdirc/commandparser/commands/global/SetCommand.java Vedi File

@@ -45,6 +45,7 @@ import com.dmdirc.ui.input.AdditionalTabTargets;
45 45
 
46 46
 import java.util.List;
47 47
 
48
+import javax.annotation.Nonnull;
48 49
 import javax.inject.Inject;
49 50
 
50 51
 /**
@@ -100,7 +101,7 @@ public class SetCommand extends Command implements IntelligentCommand {
100 101
     }
101 102
 
102 103
     @Override
103
-    public void execute(final FrameContainer origin,
104
+    public void execute(@Nonnull final FrameContainer origin,
104 105
             final CommandArguments args, final CommandContext context) {
105 106
         final CommandFlagResult res = handler.process(origin, args);
106 107
 

+ 2
- 1
src/com/dmdirc/commandparser/commands/global/UnloadPlugin.java Vedi File

@@ -35,6 +35,7 @@ import com.dmdirc.plugins.PluginInfo;
35 35
 import com.dmdirc.plugins.PluginManager;
36 36
 import com.dmdirc.ui.input.AdditionalTabTargets;
37 37
 
38
+import javax.annotation.Nonnull;
38 39
 import javax.inject.Inject;
39 40
 
40 41
 /**
@@ -62,7 +63,7 @@ public class UnloadPlugin extends Command implements IntelligentCommand {
62 63
     }
63 64
 
64 65
     @Override
65
-    public void execute(final FrameContainer origin,
66
+    public void execute(@Nonnull final FrameContainer origin,
66 67
             final CommandArguments args, final CommandContext context) {
67 68
         if (args.getArguments().length == 0) {
68 69
             showUsage(origin, args.isSilent(), "unloadplugin", "<plugin>");

+ 2
- 1
src/com/dmdirc/commandparser/commands/server/AllChannels.java Vedi File

@@ -36,6 +36,7 @@ import com.dmdirc.interfaces.CommandController;
36 36
 import com.dmdirc.ui.input.AdditionalTabTargets;
37 37
 import com.dmdirc.ui.input.TabCompleter;
38 38
 
39
+import javax.annotation.Nonnull;
39 40
 import javax.inject.Inject;
40 41
 
41 42
 /**
@@ -59,7 +60,7 @@ public class AllChannels extends Command implements IntelligentCommand {
59 60
     }
60 61
 
61 62
     @Override
62
-    public void execute(final FrameContainer origin,
63
+    public void execute(@Nonnull final FrameContainer origin,
63 64
             final CommandArguments args, final CommandContext context) {
64 65
         final Server server = ((ServerCommandContext) context).getServer();
65 66
         final String command = args.getArgumentsAsString();

+ 2
- 1
src/com/dmdirc/commandparser/commands/server/Away.java Vedi File

@@ -34,6 +34,7 @@ import com.dmdirc.commandparser.commands.context.CommandContext;
34 34
 import com.dmdirc.commandparser.commands.context.ServerCommandContext;
35 35
 import com.dmdirc.interfaces.CommandController;
36 36
 
37
+import javax.annotation.Nonnull;
37 38
 import javax.inject.Inject;
38 39
 
39 40
 /**
@@ -57,7 +58,7 @@ public class Away extends Command {
57 58
     }
58 59
 
59 60
     @Override
60
-    public void execute(final FrameContainer origin,
61
+    public void execute(@Nonnull final FrameContainer origin,
61 62
             final CommandArguments args, final CommandContext context) {
62 63
         final Server server = ((ServerCommandContext) context).getServer();
63 64
         final String line = args.getArgumentsAsString();

+ 2
- 1
src/com/dmdirc/commandparser/commands/server/Back.java Vedi File

@@ -36,6 +36,7 @@ import com.dmdirc.commandparser.commands.context.ServerCommandContext;
36 36
 import com.dmdirc.interfaces.CommandController;
37 37
 import com.dmdirc.ui.input.AdditionalTabTargets;
38 38
 
39
+import javax.annotation.Nonnull;
39 40
 import javax.inject.Inject;
40 41
 
41 42
 /**
@@ -59,7 +60,7 @@ public class Back extends Command implements IntelligentCommand {
59 60
     }
60 61
 
61 62
     @Override
62
-    public void execute(final FrameContainer origin,
63
+    public void execute(@Nonnull final FrameContainer origin,
63 64
             final CommandArguments args, final CommandContext context) {
64 65
         final Server server = ((ServerCommandContext) context).getServer();
65 66
         server.getParser().getLocalClient().setBack();

+ 2
- 1
src/com/dmdirc/commandparser/commands/server/ChangeServer.java Vedi File

@@ -37,6 +37,7 @@ import com.dmdirc.util.URIParser;
37 37
 
38 38
 import java.net.URI;
39 39
 
40
+import javax.annotation.Nonnull;
40 41
 import javax.inject.Inject;
41 42
 
42 43
 /**
@@ -65,7 +66,7 @@ public class ChangeServer extends Command {
65 66
     }
66 67
 
67 68
     @Override
68
-    public void execute(final FrameContainer origin,
69
+    public void execute(@Nonnull final FrameContainer origin,
69 70
             final CommandArguments args, final CommandContext context) {
70 71
         if (args.getArguments().length == 0) {
71 72
             showUsage(origin, args.isSilent(), "server", "<host[:[+]port]> [password]");

+ 2
- 1
src/com/dmdirc/commandparser/commands/server/Ctcp.java Vedi File

@@ -37,6 +37,7 @@ import com.dmdirc.interfaces.CommandController;
37 37
 import com.dmdirc.ui.input.AdditionalTabTargets;
38 38
 import com.dmdirc.ui.input.TabCompletionType;
39 39
 
40
+import javax.annotation.Nonnull;
40 41
 import javax.inject.Inject;
41 42
 
42 43
 /**
@@ -61,7 +62,7 @@ public class Ctcp extends Command implements IntelligentCommand {
61 62
     }
62 63
 
63 64
     @Override
64
-    public void execute(final FrameContainer origin,
65
+    public void execute(@Nonnull final FrameContainer origin,
65 66
             final CommandArguments args, final CommandContext context) {
66 67
         final Server server = ((ServerCommandContext) context).getServer();
67 68
         if (args.getArguments().length < 2) {

+ 2
- 1
src/com/dmdirc/commandparser/commands/server/Disconnect.java Vedi File

@@ -33,6 +33,7 @@ import com.dmdirc.commandparser.commands.context.CommandContext;
33 33
 import com.dmdirc.commandparser.commands.context.ServerCommandContext;
34 34
 import com.dmdirc.interfaces.CommandController;
35 35
 
36
+import javax.annotation.Nonnull;
36 37
 import javax.inject.Inject;
37 38
 
38 39
 /**
@@ -56,7 +57,7 @@ public class Disconnect extends Command {
56 57
     }
57 58
 
58 59
     @Override
59
-    public void execute(final FrameContainer origin,
60
+    public void execute(@Nonnull final FrameContainer origin,
60 61
             final CommandArguments args, final CommandContext context) {
61 62
         final Server server = ((ServerCommandContext) context).getServer();
62 63
         final String line;

+ 2
- 1
src/com/dmdirc/commandparser/commands/server/Ignore.java Vedi File

@@ -41,6 +41,7 @@ import java.util.List;
41 41
 import java.util.regex.Pattern;
42 42
 import java.util.regex.PatternSyntaxException;
43 43
 
44
+import javax.annotation.Nonnull;
44 45
 import javax.inject.Inject;
45 46
 
46 47
 /**
@@ -64,7 +65,7 @@ public class Ignore extends Command implements IntelligentCommand {
64 65
     }
65 66
 
66 67
     @Override
67
-    public void execute(final FrameContainer origin,
68
+    public void execute(@Nonnull final FrameContainer origin,
68 69
             final CommandArguments args, final CommandContext context) {
69 70
         final Server server = ((ServerCommandContext) context).getServer();
70 71
 

+ 2
- 1
src/com/dmdirc/commandparser/commands/server/JoinChannelCommand.java Vedi File

@@ -46,6 +46,7 @@ import com.google.common.base.Optional;
46 46
 import java.util.ArrayList;
47 47
 import java.util.List;
48 48
 
49
+import javax.annotation.Nonnull;
49 50
 import javax.inject.Inject;
50 51
 
51 52
 import net.engio.mbassy.listener.Handler;
@@ -79,7 +80,7 @@ public class JoinChannelCommand extends Command implements IntelligentCommand {
79 80
     }
80 81
 
81 82
     @Override
82
-    public void execute(final FrameContainer origin,
83
+    public void execute(@Nonnull final FrameContainer origin,
83 84
             final CommandArguments args, final CommandContext context) {
84 85
         final Server server = ((ServerCommandContext) context).getServer();
85 86
         if (args.getArguments().length == 0) {

+ 2
- 1
src/com/dmdirc/commandparser/commands/server/Message.java Vedi File

@@ -39,6 +39,7 @@ import com.dmdirc.parser.interfaces.Parser;
39 39
 import com.dmdirc.ui.input.AdditionalTabTargets;
40 40
 import com.dmdirc.ui.input.TabCompletionType;
41 41
 
42
+import javax.annotation.Nonnull;
42 43
 import javax.inject.Inject;
43 44
 
44 45
 /**
@@ -64,7 +65,7 @@ public class Message extends Command implements IntelligentCommand,
64 65
     }
65 66
 
66 67
     @Override
67
-    public void execute(final FrameContainer origin,
68
+    public void execute(@Nonnull final FrameContainer origin,
68 69
             final CommandArguments args, final CommandContext context) {
69 70
         final Server server = ((ServerCommandContext) context).getServer();
70 71
         if (args.getArguments().length < 2) {

+ 2
- 1
src/com/dmdirc/commandparser/commands/server/Nick.java Vedi File

@@ -37,6 +37,7 @@ import com.dmdirc.interfaces.CommandController;
37 37
 import com.dmdirc.ui.input.AdditionalTabTargets;
38 38
 import com.dmdirc.ui.input.TabCompletionType;
39 39
 
40
+import javax.annotation.Nonnull;
40 41
 import javax.inject.Inject;
41 42
 
42 43
 /**
@@ -61,7 +62,7 @@ public class Nick extends Command implements IntelligentCommand {
61 62
     }
62 63
 
63 64
     @Override
64
-    public void execute(final FrameContainer origin,
65
+    public void execute(@Nonnull final FrameContainer origin,
65 66
             final CommandArguments args, final CommandContext context) {
66 67
         final Server server = ((ServerCommandContext) context).getServer();
67 68
         if (args.getArguments().length == 0) {

+ 2
- 1
src/com/dmdirc/commandparser/commands/server/Notice.java Vedi File

@@ -37,6 +37,7 @@ import com.dmdirc.interfaces.CommandController;
37 37
 import com.dmdirc.ui.input.AdditionalTabTargets;
38 38
 import com.dmdirc.ui.input.TabCompletionType;
39 39
 
40
+import javax.annotation.Nonnull;
40 41
 import javax.inject.Inject;
41 42
 
42 43
 /**
@@ -61,7 +62,7 @@ public class Notice extends Command implements IntelligentCommand {
61 62
     }
62 63
 
63 64
     @Override
64
-    public void execute(final FrameContainer origin,
65
+    public void execute(@Nonnull final FrameContainer origin,
65 66
             final CommandArguments args, final CommandContext context) {
66 67
         final Server server = ((ServerCommandContext) context).getServer();
67 68
         if (args.getArguments().length < 2) {

+ 2
- 1
src/com/dmdirc/commandparser/commands/server/OpenQuery.java Vedi File

@@ -39,6 +39,7 @@ import com.dmdirc.ui.input.AdditionalTabTargets;
39 39
 import com.dmdirc.ui.input.TabCompletionType;
40 40
 import com.dmdirc.ui.messages.Styliser;
41 41
 
42
+import javax.annotation.Nonnull;
42 43
 import javax.inject.Inject;
43 44
 
44 45
 /**
@@ -63,7 +64,7 @@ public class OpenQuery extends Command implements IntelligentCommand,
63 64
     }
64 65
 
65 66
     @Override
66
-    public void execute(final FrameContainer origin,
67
+    public void execute(@Nonnull final FrameContainer origin,
67 68
             final CommandArguments args, final CommandContext context) {
68 69
         if (args.getArguments().length == 0) {
69 70
             showUsage(origin, args.isSilent(), "query", "<target> <message>");

+ 2
- 1
src/com/dmdirc/commandparser/commands/server/Raw.java Vedi File

@@ -34,6 +34,7 @@ import com.dmdirc.commandparser.commands.context.CommandContext;
34 34
 import com.dmdirc.commandparser.commands.context.ServerCommandContext;
35 35
 import com.dmdirc.interfaces.CommandController;
36 36
 
37
+import javax.annotation.Nonnull;
37 38
 import javax.inject.Inject;
38 39
 
39 40
 /**
@@ -58,7 +59,7 @@ public class Raw extends Command {
58 59
     }
59 60
 
60 61
     @Override
61
-    public void execute(final FrameContainer origin,
62
+    public void execute(@Nonnull final FrameContainer origin,
62 63
             final CommandArguments args, final CommandContext context) {
63 64
         final Server server = ((ServerCommandContext) context).getServer();
64 65
         final String line = args.getArgumentsAsString();

+ 3
- 1
src/com/dmdirc/commandparser/commands/server/RawServerCommand.java Vedi File

@@ -33,6 +33,8 @@ import com.dmdirc.commandparser.commands.context.CommandContext;
33 33
 import com.dmdirc.commandparser.commands.context.ServerCommandContext;
34 34
 import com.dmdirc.interfaces.CommandController;
35 35
 
36
+import javax.annotation.Nonnull;
37
+
36 38
 /**
37 39
  * Implements a raw server command (i.e., a command that is sent to the server as-is.
38 40
  */
@@ -54,7 +56,7 @@ public class RawServerCommand extends Command implements CommandInfo {
54 56
     }
55 57
 
56 58
     @Override
57
-    public void execute(final FrameContainer origin,
59
+    public void execute(@Nonnull final FrameContainer origin,
58 60
             final CommandArguments args, final CommandContext context) {
59 61
         final Server server = ((ServerCommandContext) context).getServer();
60 62
         server.getParser().sendRawMessage(myName.toUpperCase() + " " + args.getArgumentsAsString());

+ 2
- 1
src/com/dmdirc/commandparser/commands/server/Reconnect.java Vedi File

@@ -33,6 +33,7 @@ import com.dmdirc.commandparser.commands.context.CommandContext;
33 33
 import com.dmdirc.commandparser.commands.context.ServerCommandContext;
34 34
 import com.dmdirc.interfaces.CommandController;
35 35
 
36
+import javax.annotation.Nonnull;
36 37
 import javax.inject.Inject;
37 38
 
38 39
 /**
@@ -56,7 +57,7 @@ public class Reconnect extends Command {
56 57
     }
57 58
 
58 59
     @Override
59
-    public void execute(final FrameContainer origin,
60
+    public void execute(@Nonnull final FrameContainer origin,
60 61
             final CommandArguments args, final CommandContext context) {
61 62
         final Server server = ((ServerCommandContext) context).getServer();
62 63
         final String line;

+ 2
- 1
src/com/dmdirc/commandparser/commands/server/Umode.java Vedi File

@@ -35,6 +35,7 @@ import com.dmdirc.commandparser.commands.context.CommandContext;
35 35
 import com.dmdirc.commandparser.commands.context.ServerCommandContext;
36 36
 import com.dmdirc.interfaces.CommandController;
37 37
 
38
+import javax.annotation.Nonnull;
38 39
 import javax.inject.Inject;
39 40
 
40 41
 /**
@@ -59,7 +60,7 @@ public class Umode extends Command {
59 60
     }
60 61
 
61 62
     @Override
62
-    public void execute(final FrameContainer origin,
63
+    public void execute(@Nonnull final FrameContainer origin,
63 64
             final CommandArguments args, final CommandContext context) {
64 65
         final Server server = ((ServerCommandContext) context).getServer();
65 66
         if (server.getState() != ServerState.CONNECTED) {

+ 2
- 2
src/com/dmdirc/config/ConfigFileBackedConfigProvider.java Vedi File

@@ -81,7 +81,7 @@ public class ConfigFileBackedConfigProvider extends BaseConfigProvider implement
81 81
      * @throws InvalidIdentityFileException Missing required properties
82 82
      * @throws IOException                  Input/output exception
83 83
      */
84
-    public ConfigFileBackedConfigProvider(final IdentityManager identityManager, final File file,
84
+    public ConfigFileBackedConfigProvider(@Nullable final IdentityManager identityManager, final File file,
85 85
             final boolean forceDefault) throws IOException, InvalidIdentityFileException {
86 86
         this.identityManager = identityManager;
87 87
         this.file = new ConfigFile(file);
@@ -123,7 +123,7 @@ public class ConfigFileBackedConfigProvider extends BaseConfigProvider implement
123 123
      * @param configFile      The config file to use
124 124
      * @param target          The target of this identity
125 125
      */
126
-    public ConfigFileBackedConfigProvider(final IdentityManager identityManager,
126
+    public ConfigFileBackedConfigProvider(@Nullable final IdentityManager identityManager,
127 127
             final ConfigFile configFile, final ConfigTarget target) {
128 128
         this.identityManager = identityManager;
129 129
         this.file = configFile;

+ 3
- 1
src/com/dmdirc/config/ConfigTarget.java Vedi File

@@ -24,6 +24,8 @@ package com.dmdirc.config;
24 24
 
25 25
 import java.io.Serializable;
26 26
 
27
+import javax.annotation.Nonnull;
28
+
27 29
 /**
28 30
  * Represents the target of a particular config source.
29 31
  * <p>
@@ -224,7 +226,7 @@ public class ConfigTarget implements Comparable<ConfigTarget>, Serializable {
224 226
      *         integer if this is more specific
225 227
      */
226 228
     @Override
227
-    public int compareTo(final ConfigTarget target) {
229
+    public int compareTo(@Nonnull final ConfigTarget target) {
228 230
         if (type.equals(target.getType())) {
229 231
             return target.getOrder() - order;
230 232
         } else {

+ 1
- 0
src/com/dmdirc/events/ChannelTopicChangeEvent.java Vedi File

@@ -53,6 +53,7 @@ public class ChannelTopicChangeEvent extends ChannelDisplayableEvent {
53 53
         return client;
54 54
     }
55 55
 
56
+    @Nullable
56 57
     public String getTopic() {
57 58
         return topic;
58 59
     }

+ 1
- 0
src/com/dmdirc/events/UnknownCommandEvent.java Vedi File

@@ -54,6 +54,7 @@ public class UnknownCommandEvent extends DMDircEvent implements DisplayableEvent
54 54
         this.arguments = arguments;
55 55
     }
56 56
 
57
+    @Nullable
57 58
     public FrameContainer getSource() {
58 59
         return source;
59 60
     }

+ 2
- 1
src/com/dmdirc/plugins/PluginInfo.java Vedi File

@@ -49,6 +49,7 @@ import java.util.Timer;
49 49
 import java.util.TimerTask;
50 50
 import java.util.TreeMap;
51 51
 
52
+import javax.annotation.Nonnull;
52 53
 import javax.inject.Provider;
53 54
 
54 55
 import org.slf4j.LoggerFactory;
@@ -933,7 +934,7 @@ public class PluginInfo implements Comparable<PluginInfo>, ServiceProvider {
933 934
 
934 935
     /** {@inheritDoc} */
935 936
     @Override
936
-    public int compareTo(final PluginInfo o) {
937
+    public int compareTo(@Nonnull final PluginInfo o) {
937 938
         return toString().compareTo(o.toString());
938 939
     }
939 940
 

+ 1
- 1
src/com/dmdirc/ui/input/TabCompleter.java Vedi File

@@ -81,7 +81,7 @@ public class TabCompleter {
81 81
     public TabCompleter(
82 82
             final CommandController commandController,
83 83
             final AggregateConfigProvider configManager,
84
-            final TabCompleter parent) {
84
+            @Nullable final TabCompleter parent) {
85 85
         this.parent = parent;
86 86
         this.commandController = commandController;
87 87
         this.configManager = configManager;

+ 3
- 1
src/com/dmdirc/ui/themes/Theme.java Vedi File

@@ -35,6 +35,8 @@ import java.io.File;
35 35
 import java.io.IOException;
36 36
 import java.io.InputStream;
37 37
 
38
+import javax.annotation.Nonnull;
39
+
38 40
 /**
39 41
  * Represents one theme file.
40 42
  */
@@ -201,7 +203,7 @@ public class Theme implements Comparable<Theme> {
201 203
     }
202 204
 
203 205
     @Override
204
-    public int compareTo(final Theme o) {
206
+    public int compareTo(@Nonnull final Theme o) {
205 207
         return getName().compareTo(o.getName());
206 208
     }
207 209
 

+ 3
- 1
src/com/dmdirc/updater/Version.java Vedi File

@@ -22,6 +22,8 @@
22 22
 
23 23
 package com.dmdirc.updater;
24 24
 
25
+import javax.annotation.Nonnull;
26
+
25 27
 /**
26 28
  * Describes a version of a component, either as an integer or as a String which corresponds to the
27 29
  * output of `git-describe --tags`.
@@ -72,7 +74,7 @@ public class Version implements Comparable<Version> {
72 74
 
73 75
     /** {@inheritDoc} */
74 76
     @Override
75
-    public int compareTo(final Version o) {
77
+    public int compareTo(@Nonnull final Version o) {
76 78
         if (o.intVersion > Integer.MIN_VALUE && this.intVersion > Integer.MIN_VALUE) {
77 79
             return this.intVersion - o.intVersion;
78 80
         } else if (o.strVersion == null && this.strVersion == null) {

+ 2
- 1
src/com/dmdirc/updater/manager/DMDircUpdateManager.java Vedi File

@@ -34,6 +34,7 @@ import java.util.concurrent.ThreadFactory;
34 34
 import java.util.concurrent.ThreadPoolExecutor;
35 35
 import java.util.concurrent.TimeUnit;
36 36
 
37
+import javax.annotation.Nonnull;
37 38
 import javax.inject.Inject;
38 39
 import javax.inject.Singleton;
39 40
 
@@ -93,7 +94,7 @@ public class DMDircUpdateManager extends CachingUpdateManagerImpl {
93 94
 
94 95
         /** {@inheritDoc} */
95 96
         @Override
96
-        public Thread newThread(final Runnable r) {
97
+        public Thread newThread(@Nonnull final Runnable r) {
97 98
             return new Thread(r, "Updater thread");
98 99
         }
99 100
 

+ 3
- 1
test/com/dmdirc/harness/TestCommandParser.java Vedi File

@@ -32,6 +32,8 @@ import com.dmdirc.commandparser.parsers.CommandParser;
32 32
 import com.dmdirc.interfaces.CommandController;
33 33
 import com.dmdirc.interfaces.config.AggregateConfigProvider;
34 34
 
35
+import javax.annotation.Nonnull;
36
+
35 37
 public class TestCommandParser extends CommandParser {
36 38
 
37 39
     private static final long serialVersionUID = 7073002401375438532L;
@@ -57,7 +59,7 @@ public class TestCommandParser extends CommandParser {
57 59
     }
58 60
 
59 61
     @Override
60
-    protected void executeCommand(FrameContainer origin, CommandInfo commandInfo, Command command,
62
+    protected void executeCommand(@Nonnull FrameContainer origin, CommandInfo commandInfo, Command command,
61 63
             CommandArguments args, CommandContext context) {
62 64
         executedCommand = command;
63 65
         wasSilent = args.isSilent();

Loading…
Annulla
Salva