Chris Smith
18e0c6b275
Tidy up some ColourManager refs and inject.
Change-Id: Ic3a60962dbfcebf195df000e38639619186c40b9
Reviewed-on: http://gerrit.dmdirc.com/2698
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
fe114fb56f
Remove some more TestMain references.
Rework how Logger/ErrorManager interact so they can be half
mocked out (or, at least, used in a thread-safe-ish manner).
Change-Id: Ia5899640bdc101793819dab88c3fe6038a759abb
Reviewed-on: http://gerrit.dmdirc.com/2695
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 gadus atpakaļ
Chris Smith
861fe41dfb
Fix tests that don't work in parallel.
Make the ColourManager into a proper class so it can have
dependencies, just like a real boy.
Change-Id: Ib49f046f7dee6f240cb0970603b4fcd3d71f3cba
Reviewed-on: http://gerrit.dmdirc.com/2696
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 gadus atpakaļ
Chris Smith
f0d929f391
Initialise the IdentityManager in Dagger.
No need for Main to do it - might as well get a fully-initialised
manager when we ask for one.
Change-Id: I55ed29bbc0270a5c610184572e58b0270055e0bc
Reviewed-on: http://gerrit.dmdirc.com/2690
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
c87f4de60a
Stop IdentityManager initialising itself.
Instead, have Main provide the instance which becomes the
singleton. This allows us to inject dependencies to it, and
construct it using dagger later, while keeping all of the
code that calls the static getIdentityManager() method working.
Change-Id: I4ceaa062c84509bed66824f39cca8e76d25d131c
Reviewed-on: http://gerrit.dmdirc.com/2677
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 gadus atpakaļ
Chris Smith
e6e61f2ef1
Remove deprecated, unused IdentityManager methods.
Change-Id: Ie13c6b0cfa8fa18dd3e089728beb015342d00fb0
Reviewed-on: http://gerrit.dmdirc.com/2675
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
fb756b921c
Remove Main reference from IdentityManager.
(There's nothing particularly wrong with this, but it keeps showing
up when I try to find usages of Main to remove.)
Change-Id: I291ca91fc7e80e9dab40befa31424d9d7e0b62d1
Reviewed-on: http://gerrit.dmdirc.com/2665
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 gadus atpakaļ
a7bd9a515e
Fix frame buffer trimming preferences.
Change-Id: I7047cfdc450d65ba4191db4d152559665015ad72
Reviewed-on: http://gerrit.dmdirc.com/2633
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
11 gadus atpakaļ
b87e3ba335
Update copyright for 2013
Change-Id: Idf38f5027a92166daf99039de75b759d47431de1
Reviewed-on: http://gerrit.dmdirc.com/2607
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
11 gadus atpakaļ
792f3cc7dc
Make main less static.
Don't ask Main for the config directory.
Remove getMain() from Main.
Everything that needs a main now either gets given it, or asks something else.
Unfortunately, a few more dependencies on the static IdentityManager.getIdentityManager()
were introduced, but they can be tackled separately.
Fix unit tests for the above.
Change-Id: I9e42ac7f74453b739209a681d0a31f50c1be2a04
Depends-On: Ib5a9fdea5a2e25d5471d0b849f4f65fa0286d1f8
Reviewed-on: http://gerrit.dmdirc.com/2520
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
11 gadus atpakaļ
62db47acbb
Tidy up unit Prefs stuff (and unit test!)
Change-Id: I428aa1596e7d41e6842175d805d88a4421c1b764
Depends-On: Id8e090709271b6a908bc56273b9ff8dfd180370d
Reviewed-on: http://gerrit.dmdirc.com/2452
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
12 gadus atpakaļ
Chris Smith
3031258c3b
Tidy the PrefrencesManager, add some basic unit tests
Change-Id: I908f44f84f8413d19950de6aebf419c1f747098a
Reviewed-on: http://gerrit.dmdirc.com/2431
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 gadus atpakaļ
Chris Smith
d4202ef90d
You can now unregister identity listeners! \o/
Change-Id: Idbe3fa49249f84cf31b4d42d041da27850e71061
Reviewed-on: http://gerrit.dmdirc.com/2411
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 gadus atpakaļ
Chris Smith
ac16253f43
Use slf4j not java logging
Sprinkle lombok and config binding around
Change-Id: Ie4daf4451ed7e252e033ebf3bc59f6a606523a82
Reviewed-on: http://gerrit.dmdirc.com/2331
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
12 gadus atpakaļ
Chris Smith
cc4f1e64e6
Pass fallbacks
Change-Id: Idabb6f5acc66dbdb09c8dfb4ab03a05469fd7359
Reviewed-on: http://gerrit.dmdirc.com/2315
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 gadus atpakaļ
Chris Smith
6ed85cc45a
Add support for ints to config binder
Change-Id: Id453f2448a149b5015a44fd6db4c59206743be16
Reviewed-on: http://gerrit.dmdirc.com/2314
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 gadus atpakaļ
d26602c9dc
Update Copyright for 2012
Change-Id: I0d40c3ac86b9e06fad3f29bc36612b4162e54d1c
Reviewed-on: http://gerrit.dmdirc.com/2287
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 gadus atpakaļ
Chris Smith
5c64a29c45
Deprecations
Change-Id: I1aa33d6e360f6050b02b7fe3f7db1312451c93fb
Reviewed-on: http://gerrit.dmdirc.com/2282
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 gadus atpakaļ
Chris Smith
ebbd1daff5
Import fixing!
Change-Id: Ia90cb759b0777cf8d30eb6bfe30a5bece0105d24
Reviewed-on: http://gerrit.dmdirc.com/2281
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 gadus atpakaļ
Chris Smith
d4507e0b3a
Deprecation fixes
Sprinkle some annotations over the CommandManager
More fiddling with NB7.1 settings
Change-Id: I2a0b751798249d4cc3e527f6d2e5525d1936f0e1
Reviewed-on: http://gerrit.dmdirc.com/2278
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 gadus atpakaļ
Chris Smith
0cdb831994
Add ConfigBinder for magical configuration goodness
Change-Id: Iba7923adacf3f342c84a3d5fdaa75e103c273f5a
Reviewed-on: http://gerrit.dmdirc.com/2258
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 gadus atpakaļ
Chris Smith
a7a57eca29
Fix fallout from util changes
Change-Id: I0bfd2dc61096dd9670b269463c27d9b00fd9a917
Depends-On: I6d0665e57f6e0e2ff2fb6a18742acb99010e79bf
Depends-On: Ia8de3c1a5fdc1eb9cfaa8b29a32bb3efb6d8ce6f
Reviewed-on: http://gerrit.dmdirc.com/2242
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 gadus atpakaļ
80871d51a7
Begin to remove deprecated IdentityManager methods
Change-Id: I7c24baa6f2e64302406e656a8931390aff9d3c9d
Depends-On: I1fc7086057871a9b5f5f6d0ec790ec28b7ee067f
Reviewed-on: http://gerrit.dmdirc.com/2203
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 gadus atpakaļ
Chris Smith
72b2a5a910
Initial work on an abstract colour representation.
Styliser still injects AWT Colors for simplicity at this stage.
Change-Id: I691b6dca615fd6a197712d9f11cedafdc9a8bc5d
Depends-On: I978e118b20c507cbc305d5ee5c6ecabf6d7454b8
Reviewed-on: http://gerrit.dmdirc.com/2187
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 gadus atpakaļ
Chris Smith
b45c51c81e
Make IdentityManager into a proper singleton
Extract a couple of interfaces
CLIENT-84
Change-Id: Iba5e8338e7e8099244a64dd8ddcc9fcfe64f37d2
Reviewed-on: http://gerrit.dmdirc.com/2157
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 gadus atpakaļ
Chris Smith
5b32bba262
Remove auto-maximise setting from prefs
Change-Id: I9dd18ed036e6c4e20a505b50e6e6b466e3418210
Fixes-issue: CLIENT-306
Reviewed-on: http://gerrit.dmdirc.com/2150
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 gadus atpakaļ
61c7913433
Remove UI specific preferences methods from UIController.
Fixes CLIENT-274
Change-Id: I58feef90e9a80ef54549b84b6370fe0378e16996
Depends-On: Ic341d8fe573e6e2c0a8da07bd02e41110e7668e9
Reviewed-on: http://gerrit.dmdirc.com/2102
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 gadus atpakaļ
a4031bdad2
Add getMetaData method to PluginInfo and use it
Change-Id: I0bf84a236b3d4a3a86bb3cdceadbfb972b7dec27
Reviewed-on: http://gerrit.dmdirc.com/2089
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 gadus atpakaļ
Chris Smith
6a06e9abae
Get rid of @author tags
Change-Id: Ib8d0b8886b769777267f0b757faea00787c149f7
Reviewed-on: http://gerrit.dmdirc.com/2080
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 gadus atpakaļ
d04e2bea4f
Change header?
Change-Id: I635e0d111ed182713132145e4d5fb1654f776ec4
Reviewed-on: http://gerrit.dmdirc.com/2071
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 gadus atpakaļ
Chris Smith
bb70d16d7b
Remove unused private fields
Make having unused fields or formal params a PMD error
Change-Id: Ief1c8e499af7e3a43328046dc140ba941d8cb010
Depends-On: I970b49db0abac46d15a11e2b71dc0b50bd3a8faf
Reviewed-on: http://gerrit.dmdirc.com/2034
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
13 gadus atpakaļ
Chris Smith
2c840ab707
Remove unused ctors
Make unused ctors a PMD error
Change-Id: I10f7350e9435179e1c6f89e01233778ddffa648a
Reviewed-on: http://gerrit.dmdirc.com/2029
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
13 gadus atpakaļ
a00342d935
Remove legacy hidequeries setting. Focus queries on open as required.
Fixes CLIENT-249
Depends-On: I02f3803fe1d3cce0a2b958fd11f3711965d8cfd3
Change-Id: Ib675bf702ed50b90649aafa8dcba67dd4ff35986
Reviewed-on: http://gerrit.dmdirc.com/1958
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
13 gadus atpakaļ
Chris Smith
77b570a30f
Style fixes
Change-Id: If63e94dcf0aec9e9aa99e84f9962879fca46051f
Reviewed-on: http://gerrit.dmdirc.com/1931
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 gadus atpakaļ
Chris Smith
f2018c541b
Remove trailing spaces
Change-Id: I9f382ab3d7b078fb759cbaca618bec5d21b8b5d9
Reviewed-on: http://gerrit.dmdirc.com/1919
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 gadus atpakaļ
Chris Smith
cc979023da
Deprecation/mass deletion
Depends-On: I65a4cbe48f772dc7e400d585b1bfab15521fdd12
Change-Id: Ib499b44b594fa6dd85ac65fba5b95f16beb23c48
Reviewed-on: http://gerrit.dmdirc.com/1872
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
13 gadus atpakaļ
00c4c9854b
Make PreferencesSettings take a ConfigManager and Identity
Issue CLIENT-26
Depends-On: Ied8d9e0cf06819326a469e715c6925af8fd22b5a
Change-Id: I69c5fd43b97244343b824aa7c2cf1d8bb71ba741
Reviewed-on: http://gerrit.dmdirc.com/1835
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 gadus atpakaļ
acdd8268bc
Remove deprecations.
Depends-On: Ic938a7785a30477f47074e574ec8311723d803a9
Change-Id: I5ebf0bd52682cd0b1798d1b1b54353e5e65e793f
Reviewed-on: http://gerrit.dmdirc.com/1838
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 gadus atpakaļ
9d87edf3b8
Add utility method to prefs setting to remove logic from UI
Issue CLIENT-26
Change-Id: Id1c32eb2e1b0b0be8a51563becaed0c1ff443180
Reviewed-on: http://gerrit.dmdirc.com/1834
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 gadus atpakaļ
Chris Smith
8eb818807b
Deprecation and style fixes
Change-Id: I9b5c03d7a9800d067af232101ea05f338a05101b
Reviewed-on: http://gerrit.dmdirc.com/1788
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 gadus atpakaļ
Chris Smith
7040726e21
Deprecate and stop using StringTranscoder
Fixes CLIENT-68
Change-Id: I3d5b8625f202c7914c76a62100145597ef9fe523
Reviewed-on: http://gerrit.dmdirc.com/1779
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
13 gadus atpakaļ
Chris Smith
68b0ed1d1f
Style fixes
Change-Id: I94a245fd1824ba6a5c8c32e66a45a0c9be806aa1
Reviewed-on: http://gerrit.dmdirc.com/1750
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 gadus atpakaļ
fd83b6b2a9
Update Copyright
Change-Id: I7f63fdd02ea0109fe31e55c44b078edae3862f32
Reviewed-on: http://gerrit.dmdirc.com/1726
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 gadus atpakaļ
Chris Smith
6a9856de74
Fix some stupidities
Change-Id: I34118f2593a0499cd5d912b554158b4a146a5394
Reviewed-on: http://gerrit.dmdirc.com/1709
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 gadus atpakaļ
a1c4dde046
Fix some PMD errors.
Change-Id: Ia8c864cc8abab3bfdcabeac30b41f6fb29233e73
Reviewed-on: http://gerrit.dmdirc.com/1689
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 gadus atpakaļ
78dbbe78fb
Add label preferences type.
Issue Client-76
Change-Id: I7beee0f6d6d3d17c549a884e641d444d8a56dfc1
Reviewed-on: http://gerrit.dmdirc.com/1686
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 gadus atpakaļ
Chris Smith
0747ce89ff
Force ConfigManagers to read version info from the version identity
Fixes CLIENT-111
Change-Id: Ic080e6513ac4dbbd5f37098061690cc68088b53d
Reviewed-on: http://gerrit.dmdirc.com/1614
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 gadus atpakaļ
Chris Smith
1214640654
Core support for defining channel/server-specific prefs
Fixes CLIENT-85
Change-Id: I4cf493f58536b792de4de68b91f5c8f2541a90a0
Reviewed-on: http://gerrit.dmdirc.com/1596
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 gadus atpakaļ
Chris Smith
33bae9d01d
Rename PreferencesManager to PreferencesDialogModel
Change-Id: Ied76e21fbf72039d47ec2b35b236149c13941645
Depends-On: Ia126a15b60e54c08c1e780676fe363821e9b7518
Reviewed-on: http://gerrit.dmdirc.com/1591
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 gadus atpakaļ
Chris Smith
22f7847e5c
Remove general.ui setting
Fixes CLIENT-92
Change-Id: Ic9196cc5cdc4b0570ee25009c5ab48b03e9faf60
Reviewed-on: http://gerrit.dmdirc.com/1585
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 gadus atpakaļ
Chris Smith
Greg Holmes