Val Lorentz
48f8c341d7
Implement draft/message-redaction (#2065)
* Makefile: Add dependencies between targets
* Implement draft/message-redaction for channels
Permission to use REDACT mirrors permission for 'HistServ DELETE'
* Error when the given targetmsg does not exist
* gofmt
* Add CanDelete enum type
* gofmt
* Add support for PMs
* Fix documentation of allow-individual-delete.
* Remove 'TODO: add configurable fallback'
slingamn says it's probably not desirable, and I'm on the fence.
Out of laziness, let's omit it for now, as it's not a regression
compared to '/msg HistServ DELETE'.
* Revert "Makefile: Add dependencies between targets"
This reverts commit 2182b1da69 .
---------
Co-authored-by: Val Lorentz <progval+git+ergo@progval.net >
1 vuosi sitten
Shivaram Lingamneni
00cfe98461
fix #2066
CHATHISTORY TARGETS response should not be in a batch unless the client has
explicitly requested the batch cap.
1 vuosi sitten
Shivaram Lingamneni
eeec481b8d
tweaks to NAMES implementation (#2058)
* tweaks to NAMES implementation
* tweak member caching
* add a benchmark for NAMES
1 vuosi sitten
Shivaram Lingamneni
eb83df420b
tweak KILL message
Remove `<no reason supplied>`, make default KILL anonymous
1 vuosi sitten
Shivaram Lingamneni
1da11ae8ae
implement draft/pre-away (#2044)
* implement draft/pre-away
* clean up some subtleties in auto-away aggregation.
* consistently apply auto-away only to always-on
* `AWAY *` should not produce user-visible changes wherever possible
1 vuosi sitten
Pratyush Desai
0653f90b4f
update response when killing alwayson targets
1 vuosi sitten
Shivaram Lingamneni
16e214e4fb
fix #2031
Sanitize the in-band error message from REHASH
1 vuosi sitten
Shivaram Lingamneni
f72a6fa011
round wait times to the nearest millisecond
1 vuosi sitten
Shivaram Lingamneni
7ce0636276
refactor of channel persistence to use UUIDs
1 vuosi sitten
Shivaram Lingamneni
77de026961
persistence broadcast needs a cap check
1 vuosi sitten
Shivaram Lingamneni
ae1de2554e
add persistence broadcasting
1 vuosi sitten
Shivaram Lingamneni
99d27ff737
initial implementation of draft/persistence
1 vuosi sitten
Shivaram Lingamneni
fa3de3e149
fix #1983
TAGMSG should not get automatic RPL_AWAY replies
1 vuosi sitten
Shivaram Lingamneni
825cdab67d
fix #1850
Add WHO responses for services
1 vuosi sitten
Shivaram Lingamneni
4e0d2d65e8
fix #1996
According to the de facto standard, `AWAY :\r\n` is equivalent to `AWAY\r\n`.
Our behavior was inconsistent before, now it consistently matches the de facto
standard.
1 vuosi sitten
Shivaram Lingamneni
68bd2d87e0
fix #1991
WHO <nickname> should not respect +i
1 vuosi sitten
Pratyush Desai
df234b842e
uban list explicitly shows indefinite durations
1 vuosi sitten
Shivaram Lingamneni
1d10eb934a
fix #1980
Sanitize ::1 to 0::1 in WHOX output
1 vuosi sitten
Shivaram Lingamneni
ef088373a8
only send MARKREAD to sessions with the read-marker cap
2 vuotta sitten
Shivaram Lingamneni
c3d4be45f1
fix timestamp syntax in MARKREAD
2 vuotta sitten
Shivaram Lingamneni
c5579a6a34
fix #1688
* Add ACCEPT-tracking functionality (authorizing users to send DMs
despite +R or other applicable restrictions)
* Sending a DM automatically accepts the recipient
* Add explicit ACCEPT command
2 vuotta sitten
Shivaram Lingamneni
b11dc1c84c
fix #1886
Add more clarify in NS INFO and SAREGISTER about unregistered nicknames
2 vuotta sitten
Shivaram Lingamneni
78548aa9df
add SAVERIFY command
Fixes #1924
2 vuotta sitten
Shivaram Lingamneni
2b8eb93c00
clean up magic numbers
2 vuotta sitten
Shivaram Lingamneni
61fd7a2534
fix the rest of #1933
`NICK :` pre-registration needs to be special-cased to immediately
send ERR_NONICKNAMEGIVEN (unlike erroneous nonempty nicknames,
which are processed when registration is complete)
2 vuotta sitten
Shivaram Lingamneni
2fb8b836db
fix #1928
LIST should not return ERR_NOSUCHCHANNEL for nonexistent channels
2 vuotta sitten
Shivaram Lingamneni
32f7868bfd
implement draft/read-marker capability
2 vuotta sitten
Shivaram Lingamneni
a549827f17
upgrade to go 1.18, use generics
2 vuotta sitten
William Rehwinkel
4010f3fc02
Fix #1911 +s channels don't appear in /list even though on the channel (#1923)
* Fix #1911 +s channels don't appear in /list even though on the channel
* use channel.HasClient instead of custom iterative checker
2 vuotta sitten
Shivaram Lingamneni
0afa7edffe
fix #1895
Include server start time in INFO output.
2 vuotta sitten
Shivaram Lingamneni
fcb86c54f7
fix #1906
Having the 'samode' capability made all KICK commands privileged. This appears
to have been introduced unintentionally by 42316bc04f and I can't find
any discussion of a rationale. Since this goes against our policy that all
ircop (as opposed to channel founder) privileges must be invoked explicitly
(e.g. SAJOIN, SAMODE), remove this.
2 vuotta sitten
Shivaram Lingamneni
dba5d3faae
show arbitrary IP in WHOX
This extends #1650 to cover WHO as well as WHOIS
2 vuotta sitten
Shivaram Lingamneni
d174b5aad6
add disambiguating numbers in translated strings
2 vuotta sitten
Shivaram Lingamneni
76f7748c8a
correctly account for nickname in CAP LS arithmetic
The arithmetic was assuming that the nickname is * (which it is
pre-registration). However, we were sending the actual nickname
post-registration. It would be simpler to always send *, but it
appears that the nickname is actually required by the spec:
>Replies from the server must [sic] contain the client identifier name or
>asterisk if one is not yet available.
2 vuotta sitten
Shivaram Lingamneni
f3f805acb8
send `*` for WHOX o (oplevel) instead of `0`
Jobe points out that 0 is a valid oplevel in some contexts,
* is a better placeholder for "unimplemented".
2 vuotta sitten
Shivaram Lingamneni
cb757c703d
change FAIL AUTHENTICATE VERIFICATION_REQUIRED to be a NOTE
See discussion on #1852
2 vuotta sitten
Shivaram Lingamneni
7d66368274
add FAIL AUTHENTICATE VERIFICATION_REQUIRED
From discussion with @emersion , this will help with UX if people try to
log into their unverified accounts.
2 vuotta sitten
Shivaram Lingamneni
9ff4047fa6
fix #1840
Account registrations pending verification should produce a logline and
send a sno.
2 vuotta sitten
Shivaram Lingamneni
bc5c2a1250
fix casefolding issue in muting RELAYMSG
Reported by @mogad0n ; the mute mask was being case-canonicalized,
but the RELAYMSG identifier wasn't being case-canonicalized before
the check.
2 vuotta sitten
Shivaram Lingamneni
2038763e10
fix #1730
`WHO #channel o` is supposed to return only server operators.
This is RFC1459 cruft; just return an empty list in this case.
2 vuotta sitten
Shivaram Lingamneni
62b2d0341e
fix #1831
RPL_ENDOFWHO should send the original, un-normalized mask
2 vuotta sitten
Shivaram Lingamneni
dc75b24d23
clarify comment on CAP byte arithmetic
2 vuotta sitten
Shivaram Lingamneni
4749d7e776
fix #1676, take 2
Ensure the pagination window is full by making sure that every history item
gets a replay line in CHATHISTORY output, even TAGMSG.
2 vuotta sitten
Shivaram Lingamneni
3ec5ffa340
Revert "fix #1676"
This reverts commit 5bbee02fe6 .
2 vuotta sitten
Shivaram Lingamneni
5bbee02fe6
fix #1676
Fix various pagination issues with CHATHISTORY; also undo #491
(msgid munging).
2 vuotta sitten
Alex Jaspersen
53a7e8c334
Send snomask for channel mode changes via SAMODE.
Fixes #1787
2 vuotta sitten
Shivaram Lingamneni
aa969b7ff7
fix #1530
Warn if the user sent, e.g., /QUOTE /SAMODE instead of /QUOTE SAMODE
2 vuotta sitten
Valentin Lorentz
a90fbf9f2c
Add missing argument to ERR_NEEDMOREPARAMS on USER commands.
Refs:
* other instances in the codebase
* https://defs.ircdocs.horse/defs/numerics.html#err-needmoreparams-461
* https://modern.ircdocs.horse/#errneedmoreparams-461
2 vuotta sitten
Valentin Lorentz
f33f41b0eb
Make kick messages default to the kicker name instead of the kicked
For consistency with RFC2812, Bahamut, Hybrid, Insp, Plexus4, Unreal.
https://datatracker.ietf.org/doc/html/rfc2812#section-3.2.8
At the expense of consistency with chary/solanum, irc2, and ircu2.
2 vuotta sitten
Shivaram Lingamneni
117401f293
fix SCRAM not supporting client IDs
reported by @Mikaela
2 vuotta sitten