Chris Smith
44bad31051
Make the prefix mode manager private.
Pass it in when needed.
Change-Id: I8709e9363bbd8f2811946839d03876c1308cf6d9
Reviewed-on: http://gerrit.dmdirc.com/3980
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 lat temu
Chris Smith
e1a4076e4a
Move IRCAuthenticator into common, rename.
Change-Id: I8fb851ccb0d260197ca996fe0f351dc983b747cd
Reviewed-on: http://gerrit.dmdirc.com/3977
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 lat temu
Chris Smith
aae0eebc0e
Move IPv4/6 selection down into BSAP.
Change-Id: I6563502da4e5ab76553ad413ea8eeb2d5afd6d29
Reviewed-on: http://gerrit.dmdirc.com/3974
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 lat temu
Chris Smith
591a91c782
Push some logic into BaseSocketAwareParser.
Make IRCParser extend the BSAP, and use that for creating new
sockets that respect bind IP/proxy settings.
Change-Id: I6d31b00552e9b65b8cece61de7ac94c3b099b8f4
Reviewed-on: http://gerrit.dmdirc.com/3973
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 lat temu
Chris Smith
fa2f9195d3
Fix bad log message.
Change-Id: I23ffe96dd8700d72f8c4481d53471c5687528279
Fixes-Issue: CLIENT-525
Reviewed-on: http://gerrit.dmdirc.com/3970
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 lat temu
Chris Smith
72d7f53b35
Add a test for removing modes.
Change-Id: I4d069ddb004f7da58f847002d5cec54ad2836f73
Reviewed-on: http://gerrit.dmdirc.com/3965
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 lat temu
Chris Smith
b72a5d72e8
Use a ModeManager for boolean chan modes.
Change-Id: Ie4986e34e3408a8906c99b0c318ccbe58c8d5019
Reviewed-on: http://gerrit.dmdirc.com/3964
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 lat temu
Chris Smith
4f6ce3bb3f
Use a ModeManager for boolean user modes.
Change-Id: Ia4b9a93b529e734b4d7c9194ee4db6f9c2175590
Reviewed-on: http://gerrit.dmdirc.com/3963
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 lat temu
Chris Smith
477509caba
Pull out non-prefix functionality.
Move mode-only functionality into ModeManager, which can then
be used for other types of modes.
Change-Id: I8309a2f235f70c7a101266744995efcce24e9c1d
Reviewed-on: http://gerrit.dmdirc.com/3962
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 lat temu
Chris Smith
91212829dd
Inspection fixes.
Change-Id: Ia00bd92064e27c5de0493b7377cf41b9541532b8
Reviewed-on: http://gerrit.dmdirc.com/3961
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 lat temu
Chris Smith
90164d89bf
Simplify some parser logic relating to prefix modes.
Change-Id: I1764d2e737e9b4f67d7422f6b90e5d11380393a3
Reviewed-on: http://gerrit.dmdirc.com/3960
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 lat temu
Chris Smith
80124721b5
Ditch the internal numerical-based logic.
Change-Id: I68ba6e40767eacbfcd9d1099a27c81e544995ea1
Reviewed-on: http://gerrit.dmdirc.com/3959
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 lat temu
Chris Smith
1ec843d735
Add tests for prefix mode mamager.
Change-Id: I66662eddf73c570a0f59e4ffd0f84ab5da15d195
Reviewed-on: http://gerrit.dmdirc.com/3958
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 lat temu
Chris Smith
4b0ca5eeae
Forgot to move the processor tests.
Change-Id: I2ef9044106b59be12f4156e4524ee4299f9651f9
Reviewed-on: http://gerrit.dmdirc.com/3957
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 lat temu
Chris Smith
f1adab8673
Remove external usages of prefix mode bitmaps.
Prefix modes are now stored as a string, with the most important
mode at the start (e.g. "ohv").
Change-Id: Ie51e6bf8bf7a46e80295ed5cf000ffb4b0195e0b
Reviewed-on: http://gerrit.dmdirc.com/3954
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 lat temu
Chris Smith
3208c0ae37
Add a manager for prefix modes.
This removes a tiny bit of the ugly logic in IRCParser and hides
it away slightly.
Change-Id: I66b2b17d302186b5e48c839f2fa276f1a2234f6b
Reviewed-on: http://gerrit.dmdirc.com/3953
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 lat temu
Chris Smith
0e461954b7
Move processors into their own package.
Make all package-private fields and methods they hackily touched
into public, for now.
Change-Id: Ica056a901535b0c0f503283d27ff5210fe625d26
Reviewed-on: http://gerrit.dmdirc.com/3952
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 lat temu
Chris Smith
20f3e950cb
Tidy up some common parser files.
Change-Id: I3ed34a6e2dc899c24ba39b198b748be7c0f1812c
Reviewed-on: http://gerrit.dmdirc.com/3951
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 lat temu
31d3ebc5be
Tidy up SRVRecord.
Adds an AutoCloseable version of InitialDirContext.
Fixes-Issue: CLIENT-521
Change-Id: I5248d2f50ec8da01c90fd607e72c5eac66451cf3
Reviewed-on: http://gerrit.dmdirc.com/3950
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 lat temu
Chris Smith
40422dd5b1
Tidy a little
Change-Id: I319dfca0531ee94ade26fae6980f7a38b33a9c48
Reviewed-on: http://gerrit.dmdirc.com/3945
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 lat temu
Chris Smith
254baff399
PMD fixes
Change-Id: Ifc4aa601de14ca2526646f499f60329ed7c5935e
Reviewed-on: http://gerrit.dmdirc.com/3937
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 lat temu
Chris Smith
91dcca4b37
Build file changes to support automatic publishing.
Change-Id: Ibb2517bcbcc9d1840328e04b5a315cb44f2823d5
Reviewed-on: http://gerrit.dmdirc.com/3900
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 lat temu
Chris Smith
05193afc49
Use same property names as the client.
Change-Id: Iba6286466d91708a0b519e3c51cafd4d017ad7db
Reviewed-on: http://gerrit.dmdirc.com/3899
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 lat temu
Chris Smith
6c246b5e6b
Remove redundant cast.
Change-Id: I09635df097c63ddef22462160a3c94f72772be40
Reviewed-on: http://gerrit.dmdirc.com/3881
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 lat temu
Chris Smith
ca4d10b564
Fix pointless array creation.
Change-Id: I5e57e40476bdfade587f3bb86d865e7eb2b3e29b
Reviewed-on: http://gerrit.dmdirc.com/3880
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 lat temu
Chris Smith
789029e740
Tidying.
Remove pointless super() calls.
Remove redundant interface decs.
Remove unnecessary enum annotations.
Change .length == 0 to .isEmpty.
Change-Id: Ic89c70772063157e970f046b1cd04980a60bc1a8
Reviewed-on: http://gerrit.dmdirc.com/3844
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 lat temu
Chris Smith
4d3eb87f06
Final a few things
Change-Id: I22300a4ec7a09ee30a1fbc4d6fb91ff049ca3e39
Reviewed-on: http://gerrit.dmdirc.com/3839
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 lat temu
Chris Smith
083cced6cc
Remove pointless inheritDocs.
Change-Id: I8e7e36bec9e6231f7596cd0a788649a27bdc8b1f
Reviewed-on: http://gerrit.dmdirc.com/3809
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 lat temu
Chris Smith
ef3add55bf
Tidying
Change-Id: If94166e179b88d1700ae7eb89c03d71e35df7f51
Reviewed-on: http://gerrit.dmdirc.com/3801
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 lat temu
Chris Smith
fee3a70bb9
Typo fix.
Change-Id: Ic2a1b97aa44e9168bae4a1e28941208e7711bb46
Reviewed-on: http://gerrit.dmdirc.com/3741
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 lat temu
Chris Smith
c0fb61da4f
Minor tidying.
Change-Id: I4d9c708ae950ae09cc7eb0bf14c8f424f791f5fe
Reviewed-on: http://gerrit.dmdirc.com/3687
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 lat temu
3ee6e16fe0
Handle callbacks imports better in the parser
Change-Id: Ib561477b4fbb5eeef0fa459a9bf20f7f37720f7b
Reviewed-on: http://gerrit.dmdirc.com/3618
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 lat temu
f21d923df2
Fix compiler warnings.
Change-Id: I3c7a6b5c9139928687422b0044e37c6ee975c00d
Reviewed-on: http://gerrit.dmdirc.com/3575
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 lat temu
73aae22605
Capabilities are not auth notices.
Change-Id: I686dd4b6cd64853eed4d407e3d10471ea1a0b7fd
Fixes-Issue: CLIENT-477
Reviewed-on: http://gerrit.dmdirc.com/3237
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 lat temu
077e65c71e
Update Copyright to 2014
Change-Id: Iad5e74e45bb052f65b761ce8e334b571838edc10
Reviewed-on: http://gerrit.dmdirc.com/2978
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 lat temu
b02cb4ddef
Add support for binding to IPv6 addresses.
Change-Id: Iaf88955e20a8797c0f20924ef343626a435af91f
Reviewed-on: http://gerrit.dmdirc.com/2970
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 lat temu
a7d737936a
Let proxies worry about which target to connect to, v4 or v6.
Change-Id: If346fc78ffb10e4302d129fd16386370398bec1d
Reviewed-on: http://gerrit.dmdirc.com/2971
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 lat temu
2c47c6ddcb
Fix formatting errors introduced in 6864a35fa2ca95b7dfbb1137a620e6fb33512c07
Change-Id: I7ed80c3e353e8f68f97928555e4f6e114a03b755
Reviewed-on: http://gerrit.dmdirc.com/2901
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 lat temu
6864a35fa2
Java 7 conversions
Change-Id: Id834157281c02302bfe6f71201042712144b22ff
Reviewed-on: http://gerrit.dmdirc.com/2894
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 lat temu
f05823ce1c
Tidy javadoc
Change-Id: If8c377f64b3b336203ab4d01aaaa0a731f0545a1
Reviewed-on: http://gerrit.dmdirc.com/2885
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 lat temu
53058f9df3
Add missing null check to OutputQueue when changing the enabled state of the queue.
Change-Id: I8e74b3d9a247c289c96cd22736bcc4636f222996
Reviewed-on: http://gerrit.dmdirc.com/2839
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 lat temu
Chris Smith
c15082c7b5
Make CHANTYPES handling somewhat sane.
Get rid of weird round-the-houses method of processing, and avoid
duplicating the value in a map and a field.
This fixes our handling of servers doing really stupid, theoretical
things like resetting the CHANTYPES they support. (And by "fixes"
I mean the parser will keep state, while everything else burns
around it.)
Change-Id: Ie4936f21e68e4bb1134e9be3f16932eef4ab086f
Reviewed-on: http://gerrit.dmdirc.com/2831
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
10 lat temu
Chris Smith
d94427df6b
Fix some warnings
Change-Id: Ib9222a1a0ddf182fe9c092fa2340c3954c251848
Reviewed-on: http://gerrit.dmdirc.com/2815
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 lat temu
Chris Smith
536bec635e
A List of Characters... AKA a String.
Change-Id: I4ee609a42962a025e022315e64d199d1a8ecf3ba
Reviewed-on: http://gerrit.dmdirc.com/2814
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 lat temu
Chris Smith
1130b835a6
Add some range checking.
Change-Id: I907f185d82fb4f7273eb5341acd100815688c4f2
Fixes-issue: CLIENT-406
Reviewed-on: http://gerrit.dmdirc.com/2813
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 lat temu
Chris Smith
dac7f08707
Tidy up the 004/005 processor a bit.
Introduce methods for handling individual bits, instead of having
a pair of giant if statements of doom.
Tidy some comments and formatting up at the same time.
This is functionally the same as it was before.
Change-Id: I83f09cb6c36be203d102c44188f90de2b0587e58
Reviewed-on: http://gerrit.dmdirc.com/2812
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 lat temu
d23d2d9c14
Bump java version, if allowed?
Change-Id: I69e3dde890fef13c31cf519523ce447a27ba29b9
Reviewed-on: http://gerrit.dmdirc.com/2701
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 lat temu
Chris Smith
64721a52b7
Fix build warnings.
Change-Id: Ia13810eaecc9b387247c17948190ed5ccb692e14
Reviewed-on: http://gerrit.dmdirc.com/2667
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 lat temu
1b2c2adeaf
Fix LICENCE file name and add AUTHORS file.
Change-Id: Idcb2ad40b09e56a43a4931e337fe097db8996aad
Reviewed-on: http://gerrit.dmdirc.com/2649
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 lat temu
807ad3358b
Update copyright for 2013
Change-Id: I1c711ca0525af9a78cbd7c07876eaf6cc91c1434
Reviewed-on: http://gerrit.dmdirc.com/2604
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
11 lat temu
Greg Holmes