Fix build warnings.

Change-Id: Ia13810eaecc9b387247c17948190ed5ccb692e14
Reviewed-on: http://gerrit.dmdirc.com/2667
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

src/com/dmdirc/parser/common/CallbackManager.java

@@ -341,7 +341,7 @@ public class CallbackManager {
      * @param callback The callback to retrieve
      * @return A proxy object which can be used to call the specified callback
      */
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings({"unchecked", "rawtypes"})
     public <T extends CallbackInterface> T getCallback(final Class<T> callback) {
         return (T) Proxy.newProxyInstance(getClass().getClassLoader(),
                 new Class[]{ callback }, new CallbackHandler(callback));

src/com/dmdirc/parser/common/SRVRecord.java

@@ -127,7 +127,7 @@ public class SRVRecord implements Comparable<SRVRecord> {
             final Attribute attr = new InitialDirContext(env).getAttributes(host, new String [] { "SRV" }).get("SRV");
 
             if (attr != null) {
-                final NamingEnumeration ne = attr.getAll();
+                final NamingEnumeration<?> ne = attr.getAll();
                 while (ne.hasMore()) {
                     try {
                         final SRVRecord record = new SRVRecord((String)ne.next());

src/com/dmdirc/parser/irc/IRCChannelInfo.java

@@ -167,7 +167,7 @@ public class IRCChannelInfo implements ChannelInfo {
                 if (!isOpped && serverType.isOpOnly(cTemp)) {
                     // IRCD doesn't allow non-ops to ask for these modes.
                     continue;
-                } else if (serverType == serverType.STARCHAT && cTemp == 'H') {
+                } else if (serverType == ServerType.STARCHAT && cTemp == 'H') {
                     // IRCD Denies the mode exists
                     continue;
                 }
@@ -280,7 +280,7 @@ public class IRCChannelInfo implements ChannelInfo {
      * Empty the channel (Remove all known channelclients).
      */
     protected void emptyChannel() {
-        IRCClientInfo cTemp = null;
+        IRCClientInfo cTemp;
         synchronized (clients) {
             for (IRCChannelClientInfo client : clients.values()) {
                 cTemp = client.getClient();
@@ -463,8 +463,8 @@ public class IRCChannelInfo implements ChannelInfo {
     public String getModes() {
         final StringBuilder sModes = new StringBuilder("+");
         final StringBuilder sModeParams = new StringBuilder();
-        String sTemp = "";
-        long nTemp = 0;
+        String sTemp;
+        long nTemp;
         final long nChanModes = this.getMode();
         for (char cTemp : parser.chanModesBool.keySet()) {
             nTemp = parser.chanModesBool.get(cTemp);
@@ -613,8 +613,8 @@ public class IRCChannelInfo implements ChannelInfo {
     @Override
     public void alterMode(final boolean add, final Character mode, final String parameter) {
         int modecount = 1;
-        int modeint = 0;
-        String modestr = "";
+        int modeint;
+        String modestr;
         if (parser.h005Info.containsKey("MODES")) {
             try {
                 modecount = Integer.parseInt(parser.h005Info.get("MODES"));

src/com/dmdirc/parser/irc/Logging.java

@@ -81,17 +81,15 @@ public class Logging {
     private Object log;
 
     /** Create a new Logging. */
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings({"unchecked", "rawtypes"})
     private Logging() {
-        boolean classExists = false;
         try {
-            Class factory = null;
+            Class<?> factory;
             // Check for classes
             Class.forName("org.apache.commons.logging.Log");
             factory = Class.forName("org.apache.commons.logging.LogFactory");
 
-            classExists = factory != null;
-            if (classExists) {
+            if (factory != null) {
                 final Method getLog = factory.getMethod("getLog", new Class[]{Class.class});
                 log = getLog.invoke(null, this.getClass());
             }
@@ -101,7 +99,7 @@ public class Logging {
         } catch (InvocationTargetException ite) {
         }
 
-        isAvailable = classExists && log != null;
+        isAvailable = log != null;
     }
 
     /**
@@ -126,7 +124,7 @@ public class Logging {
     public boolean levelEnabled(final LogLevel level) {
         if (isAvailable) {
             try {
-                final Method check = log.getClass().getMethod(level.getCheckMethodName(), new Class[0]);
+                final Method check = log.getClass().getMethod(level.getCheckMethodName());
                 return (Boolean) check.invoke(log, new Object[0]);
             } catch (NoSuchMethodException nsme) {
             } catch (IllegalAccessException iae) {
@@ -160,10 +158,10 @@ public class Logging {
         }
         try {
             if (throwable == null) {
-                final Method method = log.getClass().getMethod(level.getMethodName(), new Class[]{String.class});
+                final Method method = log.getClass().getMethod(level.getMethodName(), String.class);
                 method.invoke(log, new Object[]{message});
             } else {
-                final Method method = log.getClass().getMethod(level.getMethodName(), new Class[]{String.class, Throwable.class});
+                final Method method = log.getClass().getMethod(level.getMethodName(), String.class, Throwable.class);
                 method.invoke(log, new Object[]{message, throwable});
             }
         } catch (NoSuchMethodException nsme) {