Chris Smith
ae888ef208
Die, TestMain, die.
It's been horrible knowing you.
Change-Id: Icd8eaeb9c4e481013dfbfa34757455f8d9e852f8
Reviewed-on: http://gerrit.dmdirc.com/2788
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
1472299df3
Use injected ActionFactory everywhere.
Change-Id: I9593bfaf82ac22b629e9fde5380e08f3aa0eea86
Depends-On: Ifd939bc3411c8d738c893634f3143fe8132782c0
Reviewed-on: http://gerrit.dmdirc.com/2786
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
14da0a2938
Remove ConfigManager references.
Change-Id: I065a771ff81e565b37689f9d6ea82d4057cec2f1
Reviewed-on: http://gerrit.dmdirc.com/2779
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
d596e02ddc
Remove direct Identity usages.
Move static factory methods into IdentityFactory, and replace
almost every use of Identity with ConfigProvider.
Depends-On: I6a32f3592cb5fc3df99a23eee62ae961ce0fc143
Change-Id: I66b382d54b77ef030d88448e456a83eb98aca216
Reviewed-on: http://gerrit.dmdirc.com/2777
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
a335bf1208
Use config interfaces where possible.
Change-Id: Iaabedda2fa68c4e5562bb069dcdf15fa0c3beeea
Depends-On: I5f140e89bfb8c57804d0a500bbc9f5c18555b0e9
Reviewed-on: http://gerrit.dmdirc.com/2768
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
b354ebdb70
Move old config interfaces into config folder.
Change-Id: I8d791451ead4b37f9181a9741e127cbc8b514d46
Depends-On: I94416680dfa9f0ee4896f5a6518889c6eb891909
Reviewed-on: http://gerrit.dmdirc.com/2754
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
0620e3d432
Make all core commands provide a controller.
Change-Id: Iaf2c2fbc2ccc32aa8b05fd1a309fad524b2baf94
Reviewed-on: http://gerrit.dmdirc.com/2724
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
990b03ae2e
Fix some AliasWrapper references.
Remove HelpTest because it's a pretty lame test, not (and never
will be) an actual unit test, and a PITA to maintain.
Change-Id: Ibc15984a694a7b284e206ab337211ce471ac1913
Reviewed-on: http://gerrit.dmdirc.com/2706
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
18e0c6b275
Tidy up some ColourManager refs and inject.
Change-Id: Ic3a60962dbfcebf195df000e38639619186c40b9
Reviewed-on: http://gerrit.dmdirc.com/2698
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
fe114fb56f
Remove some more TestMain references.
Rework how Logger/ErrorManager interact so they can be half
mocked out (or, at least, used in a thread-safe-ish manner).
Change-Id: Ia5899640bdc101793819dab88c3fe6038a759abb
Reviewed-on: http://gerrit.dmdirc.com/2695
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 gadus atpakaļ
Chris Smith
b37b954647
Inject the CommandLoader.
Create a proper LifecycleController implementation that can be
injected, move the interface to the interfaces package, and
then inject the CommandLoader instead of creating it in Main.
Change-Id: I4236b4668301f585544c8c6a9f17c39771290ea5
Reviewed-on: http://gerrit.dmdirc.com/2688
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
68ce22ff7d
Pass IdentityManager into commands that use it.
Change-Id: Ieb89624746da92690df22b0938384141f42de8dd
Reviewed-on: http://gerrit.dmdirc.com/2676
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 gadus atpakaļ
Chris Smith
1afcf20413
Add interface for things that want to quit.
Allows us to pass in a sensible reference to things like the /exit
command, instead of a Main object or calling a method statically.
Change-Id: I3a794339cbf0c2052ff1d7bf377dacb6171bf1f7
Reviewed-on: http://gerrit.dmdirc.com/2662
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 gadus atpakaļ
Chris Smith
2e121ed421
Remove CommandManager.getMain().
Pass in the relevant dependencies in all cases except for the Quit
command, which does actually need a Main (but it can access it
statically, for now).
Change-Id: I056a0782b9d073622c04343ebba103d0880b9567
Reviewed-on: http://gerrit.dmdirc.com/2661
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 gadus atpakaļ
Shane Mc Cormack
b87e3ba335
Update copyright for 2013
Change-Id: Idf38f5027a92166daf99039de75b759d47431de1
Reviewed-on: http://gerrit.dmdirc.com/2607
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
11 gadus atpakaļ
Shane Mc Cormack
7b67f19db2
Revert "Continue main removal"
Revert "Begin work on removing CommandManager singleton"
This reverts commit e93538e9dc .
Change-Id: I8eb4f70f80292d66e3bdbe9f32766b5f427413c2
Depends-On: Iba86c7f2bf870684e0d41f88d82f16b43d43fe80
Reviewed-on: http://gerrit.dmdirc.com/2601
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
11 gadus atpakaļ
greboid
f9c93121a9
Begin work on removing CommandManager singleton
Change-Id: Ieb44f09699a2304fa5b07f474989823f02fc78b0
Depends-On: I04e90afc89211eee412a511b12baeedf0361b414
Reviewed-on: http://gerrit.dmdirc.com/2584
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
11 gadus atpakaļ
Shane Mc Cormack
792f3cc7dc
Make main less static.
Don't ask Main for the config directory.
Remove getMain() from Main.
Everything that needs a main now either gets given it, or asks something else.
Unfortunately, a few more dependencies on the static IdentityManager.getIdentityManager()
were introduced, but they can be tackled separately.
Fix unit tests for the above.
Change-Id: I9e42ac7f74453b739209a681d0a31f50c1be2a04
Depends-On: Ib5a9fdea5a2e25d5471d0b849f4f65fa0286d1f8
Reviewed-on: http://gerrit.dmdirc.com/2520
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 gadus atpakaļ
Chris Smith
a9631ebf02
Commands clean up
Reduce dependency on CommandManager singleton
Use Lombok and delete loads of boilerplate code
Change-Id: Id178d20df1838eef99abdc0c3ca12b6dbd2a062f
Reviewed-on: http://gerrit.dmdirc.com/2310
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 gadus atpakaļ
Chris Smith
9ff3b302a6
Move loading of core commands out of CommandManager
Change-Id: Id8a9fde29d189e1c3cd025a3b9f30f2b575a7280
Depends-On: I2838ac60f809408480d985123fde9427e1e5f0e4
Reviewed-on: http://gerrit.dmdirc.com/2309
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 gadus atpakaļ
Shane Mc Cormack
d26602c9dc
Update Copyright for 2012
Change-Id: I0d40c3ac86b9e06fad3f29bc36612b4162e54d1c
Reviewed-on: http://gerrit.dmdirc.com/2287
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 gadus atpakaļ
Chris Smith
5c64a29c45
Deprecations
Change-Id: I1aa33d6e360f6050b02b7fe3f7db1312451c93fb
Reviewed-on: http://gerrit.dmdirc.com/2282
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 gadus atpakaļ
Chris Smith
ebbd1daff5
Import fixing!
Change-Id: Ia90cb759b0777cf8d30eb6bfe30a5bece0105d24
Reviewed-on: http://gerrit.dmdirc.com/2281
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 gadus atpakaļ
Chris Smith
41304ccecb
More deprecation fixes
Change-Id: If418fcbcafa64857e6a656bee08fef7399b6a2e3
Reviewed-on: http://gerrit.dmdirc.com/2280
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 gadus atpakaļ
Chris Smith
2f4649f388
More deprecations go byebye
Change-Id: I4d171421aee23c200e65c1eec89fa21974d42160
Reviewed-on: http://gerrit.dmdirc.com/2160
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 gadus atpakaļ
Chris Smith
6dc3dcde13
Add a ServerFactory and unit test /newserver sanely
Change-Id: I5f2a3113c14d1822d50a17138f4b3e9bd0612a10
Reviewed-on: http://gerrit.dmdirc.com/2156
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 gadus atpakaļ
Greg Holmes
d04e2bea4f
Change header?
Change-Id: I635e0d111ed182713132145e4d5fb1654f776ec4
Reviewed-on: http://gerrit.dmdirc.com/2071
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 gadus atpakaļ
Chris Smith
7cd4171bf1
Add BasicCommandInfo and make core commands use it
Change-Id: I24e8daf8cc076d90328f7c38cf539420566bf14e
Fixes-Issue: CLIENT-262
Reviewed-on: http://gerrit.dmdirc.com/2009
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
13 gadus atpakaļ
Chris Smith
949770857a
Make CommandManager a singleton
CLIENT-84
Change-Id: I48182a9cd7c8f49612025ba208ae90d3bb19ee2b
Depends-On: Ib62d32dbfdadaf38930ceacf667ff533de047599
Reviewed-on: http://gerrit.dmdirc.com/1996
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 gadus atpakaļ
Chris Smith
198a1597cc
Rework FrameContainer/UI interaction
- FrameContainers are no longer parameterised
- Introduced notion of window "Components"
- Removed per-window interfaces - fixes CLIENT-218
Change-Id: Ieefbf2d1e157e3638dbe8fdedbd4f32642061329
Depends-On: Iecbb2941c99a3412dc2eb3b7f56fc584d2db483e
Reviewed-on: http://gerrit.dmdirc.com/1885
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 gadus atpakaļ
Chris Smith
4b8bf0c056
Unit tests
Change-Id: I1c1b4dab1b62c2d14879aace25fbf92d91f9629f
Reviewed-on: http://gerrit.dmdirc.com/1796
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 gadus atpakaļ
Shane Mc Cormack
fd83b6b2a9
Update Copyright
Change-Id: I7f63fdd02ea0109fe31e55c44b078edae3862f32
Reviewed-on: http://gerrit.dmdirc.com/1726
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 gadus atpakaļ
Greg Holmes
936792f136
Remove debug command from client, moved to a plugin.
Change-Id: I0828dd46c1315a4ae475d23a6152dc8183e1ab09
Reviewed-on: http://gerrit.dmdirc.com/1698
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 gadus atpakaļ
Chris Smith
da78032175
Add command flag utility classes and make /echo and /set use them.
Fixes CLIENT-119
Fixes CLIENT-120
Change-Id: I2e7ad2c3b8f0db591031fc281a24aa6627331a6e
Reviewed-on: http://gerrit.dmdirc.com/1680
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 gadus atpakaļ
Chris Smith
5d584f2068
Style fixes
Change-Id: Idffa6c2559bcc2112c9657b15349aa80579ab83a
Reviewed-on: http://gerrit.dmdirc.com/1336
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 gadus atpakaļ
Chris Smith
6e42762d67
Style fixes
Change-Id: Icfab1de147645d80a999c3678daf268e7e115066
Reviewed-on: http://gerrit.dmdirc.com/1331
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 gadus atpakaļ
Chris Smith
2edf699e02
Introduce command contexts.
Fixes issue 4152
Fixes issue 4002
Change-Id: I664124ecb0994a808e2de359a38507c3b5f16452
Reviewed-on: http://gerrit.dmdirc.com/1250
Automatic-Compile: Shane Mc Cormack <shane@dmdirc.com >
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
14 gadus atpakaļ
Chris Smith
f4bbdb48fe
Massive window changes.
Highlights:
- FrameContainers are now generic, according to their window type
- Writable frame containers now handle their tab completers
- Redirect plugin works again
- Windows are no longer actively requested from the UI; the UI
creates and adds them in response to events from the WindowManager
fixes issue 3997, fixes issue 4000, fixes issue 4012, fixes issue 4030
fixes issue 4027, fixes issue 4028, fixes issue 4029, fixes issue 4031
fixes issue 4032, fixes issue 4033
Change-Id: Ife307728e46bd3b6dcd189be6886ab8b6fbd9212
Reviewed-on: http://gerrit.dmdirc.com/1144
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
Automatic-Compile: Gregory Holmes <greg@dmdirc.com >
14 gadus atpakaļ
Chris Smith
5334959656
Commands now use containers not windows
Fixes issue 3998
Change-Id: I901ed80272a445f2bd303a01e842e6f50cc5ae04
Reviewed-on: http://gerrit.dmdirc.com/1116
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
Automatic-Compile: Gregory Holmes <greg@dmdirc.com >
14 gadus atpakaļ
Gregory Holmes
187d17230c
Fix the unit tests shane broke
Change-Id: I03af2311e541d60711d2cc801128764fe384d6e7
Reviewed-on: http://gerrit.dmdirc.com/206
Reviewed-by: Chris Smith <chris@dmdirc.com >
Tested-by: Gregory Holmes <greboid@dmdirc.com >
14 gadus atpakaļ
Shane Mc Cormack
b691b14491
Update the copyright date on all files.
UpdateCopyright.sh now works out the year automatically.
UpdateCopyright.sh now ignores .git aswell as .svn
UpdateCopyright.sh now excludes Binary Files from being matched during the initial search, rather than as an afterthought.
Change-Id: I2cfc56851a4217a4c85cbc7361c7a90421aae717
Reviewed-on: http://gerrit.dmdirc.com/202
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Tested-by: Shane Mc Cormack <shane@dmdirc.com >
14 gadus atpakaļ
Chris Smith
1a248277ae
Fix /mode command unit test
Change-Id: I30be0d8d9431fbff78ed1bbc0e3e56c19899f8ec
Reviewed-on: http://gerrit.dmdirc.com/113
Reviewed-by: Gregory Holmes <greboid@dmdirc.com >
Tested-by: Gregory Holmes <greboid@dmdirc.com >
14 gadus atpakaļ
Chris Smith
32cf9f348f
Update unit tests for URI changes
Change-Id: I0dd005540f126b40c4d7f61384236ec21cfe5730
Reviewed-on: http://gerrit.dmdirc.com/57
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Tested-by: Chris Smith <chris@dmdirc.com >
14 gadus atpakaļ
Chris Smith
f55a6902f2
Issue 2736.
15 gadus atpakaļ
Chris Smith
ed4593bf1e
Minor tidying, unbreak unit tests (apparently refactors don't apply to them?!)
15 gadus atpakaļ
Chris Smith
1b1dcbb8ce
Under 300 errors!
15 gadus atpakaļ
Chris Smith
54125d2f8e
Parser abstraction. What more do you want me to say?
15 gadus atpakaļ
Chris Smith
038fdfbd8f
Abstract CommandInfos somewhat
15 gadus atpakaļ
Chris Smith
c459267c1e
Added unit test for /kick
15 gadus atpakaļ
Chris Smith
ec1be119f6
Minor unit test changes
15 gadus atpakaļ