Unit tests

Change-Id: I1c1b4dab1b62c2d14879aace25fbf92d91f9629f
Reviewed-on: http://gerrit.dmdirc.com/1796
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Greg Holmes <greg@dmdirc.com>

test/com/dmdirc/commandparser/CommandArgumentsTest.java

@@ -22,10 +22,11 @@
 
 package com.dmdirc.commandparser;
 
+import java.util.Arrays;
+
 import com.dmdirc.config.IdentityManager;
 import com.dmdirc.config.InvalidIdentityFileException;
 
-import java.util.Arrays;
 import org.junit.BeforeClass;
 import org.junit.Test;
 import static org.junit.Assert.*;
@@ -37,6 +38,49 @@ public class CommandArgumentsTest {
         IdentityManager.load();
     }
 
+    /** Ensures the ctor which takes a collection builds the 'line' property. */
+    @Test
+    public void testCollectionCtorCreatesLine() {
+        final CommandArguments args = new CommandArguments(Arrays.asList(
+                "/command", "arg1", "arg2"));
+        assertEquals("/command arg1 arg2", args.getLine());
+    }
+
+    /** Ensures the ctor works with an empty collection. */
+    @Test
+    public void testCollectionCtorWithEmpty() {
+        final CommandArguments args = new CommandArguments(Arrays.asList(
+                new String[0]));
+        assertEquals("", args.getLine());
+    }
+
+    /** Ensures that getStrippedLine returns non-command lines as-is. */
+    @Test
+    public void testGetStrippedLineNormal() {
+        final CommandArguments args = new CommandArguments("blah blah");
+        assertEquals("blah blah", args.getStrippedLine());
+    }
+
+    /**
+     * Ensures that getStrippedLine returns command lines without the command
+     * char.
+     */
+    @Test
+    public void testGetStrippedLineCommand() {
+        final CommandArguments args = new CommandArguments("/blah blah");
+        assertEquals("blah blah", args.getStrippedLine());
+    }
+
+    /**
+     * Ensures that getStrippedLine returns silenced lines without the
+     * command or silence chars.
+     */
+    @Test
+    public void testGetStrippedLineSilenced() {
+        final CommandArguments args = new CommandArguments("/.blah blah");
+        assertEquals("blah blah", args.getStrippedLine());
+    }
+
     @Test
     public void testIsCommand() {
         assertTrue(new CommandArguments(CommandManager.getCommandChar() + "").isCommand());

test/com/dmdirc/commandparser/PopupMenuItemTest.java

@@ -0,0 +1,101 @@
+/*
+ * Copyright (c) 2006-2011 Chris Smith, Shane Mc Cormack, Gregory Holmes
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+package com.dmdirc.commandparser;
+
+import com.dmdirc.config.IdentityManager;
+
+import org.junit.BeforeClass;
+import org.junit.Test;
+import static org.junit.Assert.*;
+
+public class PopupMenuItemTest {
+
+    @BeforeClass
+    public static void setUpClass() throws Exception {
+        IdentityManager.load();
+    }
+
+    /**
+     * Tests a command which doesn't define an arity gets args substituted
+     * for a single target.
+     */
+    @Test
+    public void testUnaryCommandWithSingle() {
+        final PopupMenuItem item = new PopupMenuItem(null, 1, "foo %s");
+
+        assertEquals("/foo bar", item.getCommand(new Object[][]{{"bar"}}));
+    }
+
+    /**
+     * Tests a command which doesn't define an arity gets args substituted
+     * for multiple targets.
+     */
+    @Test
+    public void testUnaryCommandWithMultiple() {
+        final PopupMenuItem item = new PopupMenuItem(null, 1, "foo %s");
+
+        assertEquals("/foo bar\n/foo b\n/foo 2",
+                item.getCommand(new Object[][]{
+                    {"bar"}, {"b"}, {"2"},
+                }));
+    }
+
+    /**
+     * Tests a command which defines its arity as 1 gets args substituted
+     * for a single target.
+     */
+    @Test
+    public void testExplicitUnaryCommandWithSingle() {
+        final PopupMenuItem item = new PopupMenuItem(null, 1, "1:foo %s");
+
+        assertEquals("/foo bar", item.getCommand(new Object[][]{{"bar"}}));
+    }
+
+    /**
+     * Tests a command which defines its arity as 1 gets args substituted
+     * for multiple targets.
+     */
+    @Test
+    public void testExplicitUnaryCommandWithMultiple() {
+        final PopupMenuItem item = new PopupMenuItem(null, 1, "1:foo %s");
+
+        assertEquals("/foo bar\n/foo a\n/foo 1",
+                item.getCommand(new Object[][]{
+                    {"bar"}, {"a"}, {"1"},
+                }));
+    }
+
+    /**
+     * Tests a command which takes multiple arguments.
+     */
+    @Test
+    public void testMultipleCommand() {
+        final PopupMenuItem item = new PopupMenuItem(null, 2, "4:foo %s %s %s %s");
+
+        assertEquals("/foo 1 2 a b\n/foo bar baz",
+                item.getCommand(new Object[][]{
+                    {"1", "2"}, {"a", "b"}, {"bar", "baz"},
+                }).trim());
+    }
+
+}

test/com/dmdirc/commandparser/commands/channel/BanTest.java

@@ -22,11 +22,14 @@
 
 package com.dmdirc.commandparser.commands.channel;
 
+import com.dmdirc.parser.interfaces.ClientInfo;
 import com.dmdirc.Channel;
 import com.dmdirc.FrameContainer;
 import com.dmdirc.config.IdentityManager;
 import com.dmdirc.commandparser.CommandArguments;
 import com.dmdirc.commandparser.commands.context.ChannelCommandContext;
+import com.dmdirc.parser.interfaces.ChannelClientInfo;
+import com.dmdirc.parser.interfaces.ChannelInfo;
 
 import org.junit.BeforeClass;
 import org.junit.Test;
@@ -38,16 +41,53 @@ public class BanTest {
     public static void setUpClass() throws Exception {
         IdentityManager.load();
     }
-    
+
     private final Ban command = new Ban();
 
     @Test
     public void testUsage() {
         final FrameContainer<?> tiw = mock(FrameContainer.class);
         final Channel channel = mock(Channel.class);
-        command.execute(tiw, new CommandArguments("/ban"), 
+        command.execute(tiw, new CommandArguments("/ban"),
                 new ChannelCommandContext(null, command, channel));
-        
+
         verify(tiw).addLine(eq("commandUsage"), anyChar(), anyString(), anyString());
     }
+
+    /** Tests that the ban command uses the correct hostname if given a user. */
+    @Test
+    public void testKnownUser() {
+        final FrameContainer<?> container = mock(FrameContainer.class);
+        final ChannelInfo channelInfo = mock(ChannelInfo.class);
+        final ChannelClientInfo ccInfo = mock(ChannelClientInfo.class);
+        final ClientInfo clientInfo = mock(ClientInfo.class);
+        final Channel channel = mock(Channel.class);
+
+        when(channel.getChannelInfo()).thenReturn(channelInfo);
+        when(channelInfo.getChannelClient("user")).thenReturn(ccInfo);
+        when(ccInfo.getClient()).thenReturn(clientInfo);
+        when(clientInfo.getHostname()).thenReturn("my.host.name");
+
+        command.execute(container, new CommandArguments("/ban user"),
+                new ChannelCommandContext(null, command, channel));
+
+        verify(channelInfo).alterMode(true, 'b', "*!*@my.host.name");
+        verify(channelInfo).flushModes();
+    }
+
+    /** Tests that the ban command works if given a mask not a username. */
+    @Test
+    public void testHostmask() {
+        final FrameContainer<?> container = mock(FrameContainer.class);
+        final ChannelInfo channelInfo = mock(ChannelInfo.class);
+        final Channel channel = mock(Channel.class);
+
+        when(channel.getChannelInfo()).thenReturn(channelInfo);
+
+        command.execute(container, new CommandArguments("/ban *!*@my.host.name"),
+                new ChannelCommandContext(null, command, channel));
+
+        verify(channelInfo).alterMode(true, 'b', "*!*@my.host.name");
+        verify(channelInfo).flushModes();
+    }
 }