Add a way to get a FrameContainer from Connection.
At the moment Server is both a FrameContainer and a Connection, and
in most places we have to cast up to Server to do what we need to.
This adds a method to Connection to retrieve the associated
FrameContainer. Eventually they should be separate objects, with
the Connection implementation managing the parser and associated
state, and the FrameContainer modelling the window (providing
tab completers, line history, input handlers, etc).
Change-Id: I56c9a2bb9ad06e9e3ad911914b29a046959e30ea
Reviewed-on: http://gerrit.dmdirc.com/3431
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Move the functionality down into just FrameContainer. Callers can use
isWritable() to determine if the FrameContainer is writable, instead
of horrible instanceof/casting logic.
Change-Id: Iab58f1d2b9275ee3fc60d79e433e158bae784911
Depends-On: I52a09d5f5ad69c2bebafa58582a173f706515fa6
Reviewed-on: http://gerrit.dmdirc.com/3426
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Common methods from GroupChat pushed down into Chat.
Change-Id: I57a6edc40ec9628dec4d0734989917ae379eff19
Reviewed-on: http://gerrit.dmdirc.com/3423
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
There's no sane reason for this to be an abstract method - instead
just create the tab completer and pass it up to WritableFrameContainer.
Change-Id: Ifa80de021c22d2e302d4b66514923cd08c91cac4
Depends-On: I15ab9677fdbcb510ab87a69a07ce8ecb3a994f7f
Reviewed-on: http://gerrit.dmdirc.com/3422
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Pass in a ScheduledExecutorService and use it for who timers and
reconnect timers.
Only run the who timer when we're connected, not the whole time.
This stops the Server ctor starting a timer.
Change-Id: Iea92d7046f33eda7666b8a2b739374345e8ea20d
Reviewed-on: http://gerrit.dmdirc.com/3419
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Instead of returning either null or a topic, use Optional<>.
Change-Id: I9e8723fe0fe2b9209a401d33361f80fb832b9434
Depends-On: If0a0609ab778df22c02b8dc1d349da45b4b5b16f
Reviewed-on: http://gerrit.dmdirc.com/3415
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Rename confusing method name and add correctly functioning one.
This fixes portable mode when running from a jar only.
Change-Id: I8272e2ff2fe1c6d88d6f6c41c859eb2d2124e04c
Issue: CLIENT-496
Reviewed-on: http://gerrit.dmdirc.com/3401
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
These are events which are going to cause a line to be added to a
client window. They allow actions, plugins, or other listeners
to change the formatter line.
Eventually the UI model will just be able to listen for displayable
events on the local event bus to figure out what needs to be displayed.
Change-Id: Ia86c593df66f8bff13574714c45464a2634c02ba
Reviewed-on: http://gerrit.dmdirc.com/3390
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Formatters need to be passed as StringBuffers to actions first.
This allows actions/plugins to change the formatters, e.g. changing
to a highlight formatter.
Change-Id: I98e55a2e2d88d423fd49d33508a225faa91a61b2
Fixes-Issue: CLIENT-486
Reviewed-on: http://gerrit.dmdirc.com/3377
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Use the right method when checking bundled plugins
Certain PluginManager methods will read plugin info from disk,
while others just use cached info. There's no obvious way to
tell which is which, and we ended up calling the wrong one.
Now we actually know about plugins that're installed, we can
extract the bundled ones. Yay.
Change-Id: I995f0a5bec8ef06db887127119d4f0f9209bf4bf
Fixes-Issue: CLIENT-498
Reviewed-on: http://gerrit.dmdirc.com/3374
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Handle errors when creating defaults dirs properly
If we can't create the defaults directory it's a Very Bad Sign™, and
we should bail out immediately. It probably means the user is running
from a directory they don't have write access to, and if we can't
write defaults then the client isn't going to work very well at all.
Previous behaviour tried to carry on and failed a precondition check
and died even more painfully.
Change-Id: Id72fb63c014939ac384ee03b9eb0f14baf6e18fe
Fixes-Issue: CLIENT-488
Reviewed-on: http://gerrit.dmdirc.com/3335
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
If we pass required = false then the config manager will happily
return null if it encounters a disabled optional setting. We
don't accept null so that's a bit daft.
Change-Id: I37934ba15877b8c0caf188b5f80e3353c8555134
Fixes-Issue: CLIENT-491
Reviewed-on: http://gerrit.dmdirc.com/3333
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Move error reporting logic from ProgramError into a new ErrorReporter.
Also add methods for reporting on mode alias issues (currently unused).
Issue: CLIENT-476
Change-Id: I23a25e6cc594003cf2afee7cfda714a9082acc3b
Reviewed-on: http://gerrit.dmdirc.com/3332
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Only send errors to Sentry. Pretend ever error is a shiny new one.
We should remove the fixed status at some point.
Change-Id: I1ae79eca54a417182cdf1ecb560b59c1674be549
Fixes-Issue: CLIENT-475
Reviewed-on: http://gerrit.dmdirc.com/3329
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
The current implementation has its own low priority thread pool.
We're already executing it in a thread ourselves, so just send
them right away.
I think this causes us to not log fatal errors to Sentry sometimes.
Change-Id: Ib4a105711e71be254e73b9aad1b244fc59fc79a4
Reviewed-on: http://gerrit.dmdirc.com/3328
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
If callers specify an implementation then it's the return type they're
concerned about, not the class providing it.
Change-Id: I9d2aa23de47373323cabb362042995f822cd9311
Reviewed-on: http://gerrit.dmdirc.com/3284
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Greg Holmes
Chris Smith