Chris Smith
3091940b40
Lots of typo fixes.
Change-Id: I362e53fc9f05497f48dac4951991b79daebfdb81
Depends-On: Ide5afea6d4e7ba04cf3226f10e1ea530e1a60c10
Depends-On: Ic2a1b97aa44e9168bae4a1e28941208e7711bb46
Reviewed-on: http://gerrit.dmdirc.com/3743
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
0e5475a7e0
Fix some javadoc.
Change-Id: I032d0438d70d5f519c7a1c0e9ec8282b67f72d38
Reviewed-on: http://gerrit.dmdirc.com/3739
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
Chris Smith
6822ce209c
Tidy suppressions/annotations.
Change-Id: I860ce026d7d0c06aa86ee71a51bd449108a8d256
Reviewed-on: http://gerrit.dmdirc.com/3737
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 gadus atpakaļ
6b670e2be4
Switch to maven central version of mig base64.
Change-Id: Icab0ac1a0d109e119262d10b92d7c01822d1e729
Reviewed-on: http://gerrit.dmdirc.com/3733
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
1b73adba74
Manual factories.
Change-Id: I21ea78e482fca3ab01a50671392ffc294d5bf043
Reviewed-on: http://gerrit.dmdirc.com/3730
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
cfd973b1c2
More eventbus logging.
Change-Id: I4bff4b79fd325d6e2d1b7f0a4dc55f10cdb237e5
Reviewed-on: http://gerrit.dmdirc.com/3729
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
5e7e2602ab
Add some eventbus logging.
Change-Id: I46497ad96d16de68370c353c7141a0b15857b664
Reviewed-on: http://gerrit.dmdirc.com/3728
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
254d176f6c
EventBus logging for Updater
Change-Id: Ib5d580dc932bd72647444ae2ff9bc355a4d884cb
Reviewed-on: http://gerrit.dmdirc.com/3720
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
Chris Smith
03f85acf46
Manually create the server factory.
Change-Id: I95836b7bb40bcfef25b2504fe50c5f63a723975b
Reviewed-on: http://gerrit.dmdirc.com/3699
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 gadus atpakaļ
Chris Smith
5321ea8492
Style/inspection fixes.
Change-Id: Icd1b2e56b740d27af85f82563f9eef06f33a1914
Reviewed-on: http://gerrit.dmdirc.com/3698
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
8176ecd3c1
Typo fixes.
Change-Id: I402d52e9bd09192fee54584e24f0eff33fd581e4
Depends-On: I2028d8c1ddd14b276f373b9400265b25f0e5e939
Reviewed-on: http://gerrit.dmdirc.com/3697
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 gadus atpakaļ
Chris Smith
05c552a0e3
Actions tidying.
Change-Id: I77c22319367b42840431e18ee998011a730ac6af
Reviewed-on: http://gerrit.dmdirc.com/3695
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
b1f373c5be
Fix various inspection errors.
Change-Id: Iaa5067d7b9276cc58b40f1338d5be2f25f44ddc3
Reviewed-on: http://gerrit.dmdirc.com/3693
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 gadus atpakaļ
Chris Smith
29700a0fea
Various bits of tidying up.
Change-Id: I08c0f6fc74d448051145807275426395629f50be
Reviewed-on: http://gerrit.dmdirc.com/3686
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
223cb69bba
Add a MessageEncoder factory.
Tidy up some Server code based on IDEA inspections.
Change-Id: Icdcdbecb6500fc08f24a5f8d15b36078c14e24d4
Reviewed-on: http://gerrit.dmdirc.com/3692
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
7cb8ebe6d3
Manually create some factories.
Change-Id: I94b86d126bee18237692072b7a4debb008ef3fda
Reviewed-on: http://gerrit.dmdirc.com/3691
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 gadus atpakaļ
Chris Smith
3560db6d68
Remove unused ServerManager from actions system.
Change-Id: I9ca2e2ef9cb03fbf5de8177eeaeb99f0e14f2d3a
Reviewed-on: http://gerrit.dmdirc.com/3690
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
e412e0343a
Simplify some conditionals
Change-Id: I13a00bf966dd5fb333dcdd408602a4b37385f27c
Reviewed-on: http://gerrit.dmdirc.com/3682
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
3ba3aed30a
EventBus logging for URLBuilder.
Change-Id: If1f98b4007a50f66c2dcd6f0a7744d24b2139555
Reviewed-on: http://gerrit.dmdirc.com/3673
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
6574ec6aba
EventBus logging for URLHandler.
Change-Id: Ia567cd685338bd7e8ff05aac4577611dd5a125cb
Reviewed-on: http://gerrit.dmdirc.com/3672
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
a103c85bf6
EventBus logging for ActionManager.
Change-Id: I83fb4560621b42b6e4fb78c561734e50c68edc52
Reviewed-on: http://gerrit.dmdirc.com/3671
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
57a5219569
EventBus logging for PluginInfo.
Change-Id: I990f72046f0fe7975192fe30f0e86f5af69bf58d
Reviewed-on: http://gerrit.dmdirc.com/3670
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
38e6bd70b4
EventBus logging for PluginManager
Change-Id: I542d4b727f18f940ada5ecff1498d1f2f9927dd5
Reviewed-on: http://gerrit.dmdirc.com/3669
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
Chris Smith
a4921dd375
Start work on 'auto commands'.
This is going to replace the perform wrappers. Better name
suggestions on a postcard.
Change-Id: I19fc055d275d25cf9c24fe8a56cba73ea24c2b6a
Reviewed-on: http://gerrit.dmdirc.com/3664
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
81465e0c3e
Eventbus logging for ServerEventHandler
Change-Id: I680785129229a8546faaaf144f681f30bd1ff04a
Reviewed-on: http://gerrit.dmdirc.com/3663
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
566e045cfb
Use eventbus logging in CorePluginExtractor.
Change-Id: I45e0932172bbe08d1fd115377f00174f0c380aaa
Reviewed-on: http://gerrit.dmdirc.com/3660
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
b8fcac016b
Use EventBus logging in ParserFactory.
Change-Id: Ia42d1a8c6783d2db5100c8a41c6ad46582022530
Reviewed-on: http://gerrit.dmdirc.com/3661
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
c366f0a60f
Eventbus logging for IdentityManager.
Change-Id: Ib6f32187dadab7a704b280290e8fac4947cbc12e
Reviewed-on: http://gerrit.dmdirc.com/3659
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
ec5145a9ec
Eventbus logging for PerformWrapper.
Change-Id: I363468c5a1a475a132dcc8266406485e23c7237d
Reviewed-on: http://gerrit.dmdirc.com/3658
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
Chris Smith
33fe5cebb0
Inject ActionManager.
Change-Id: I2291575c5f9fedc98b1924501b56572c9efd4522
Reviewed-on: http://gerrit.dmdirc.com/3657
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
184e2190ef
Start using eventbus logger in MessageEncoder.
Change-Id: I1fc16db32b0e86fdd288197266d7c623ef7d17f6
Reviewed-on: http://gerrit.dmdirc.com/3652
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
57d53d0f5b
Add ability to post user and app errors to the event bus.
Change-Id: Ieeaac3ed96926c4e80a852a090bedbd0ddec7e8c
Reviewed-on: http://gerrit.dmdirc.com/3651
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
b1c0ceb8fb
Give fatal error dialog an icon.
Not using IconManager to minimise dependencies and reduce causes
of further errors.
Change-Id: I1e8dbfab5705e9965ee24c05f116891271b87326
Fixes-Issue: CLIENT-526
Reviewed-on: http://gerrit.dmdirc.com/3650
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 gadus atpakaļ
Chris Smith
a53bf89625
Deprecate PluginManager.getDirectory().
This is injectable - you shouldn't need a PluginManager to know
where the files are.
Also give CorePluginExtractor an injectable ctor instead of having
a useless provides method.
Change-Id: Id96f671dbd55a5ad8f130f45d4d2eb7ca3d2c9ab
Reviewed-on: http://gerrit.dmdirc.com/3649
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
c247196227
Remove old alias wrapper.
Change-Id: I52684c3c812d7fc3c13cde8a08d1f4bc65a6f821
Reviewed-on: http://gerrit.dmdirc.com/3646
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
5f5889887a
Strip prefixes from multi-line aliases.
When migrating make sure that existing multi-line aliases get
command chars (and any following silence chars) removed, rather
than just doing it from the first line.
Change-Id: I08b7081cd3f582901909001586048b209acbfa31
Fixes-Issue: CLIENT-512
Reviewed-on: http://gerrit.dmdirc.com/3645
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
b04565f32f
Don't leak streams when installing aliases.
Change-Id: I31ee806e231fad5f81c55aaa51e90728c2a031b5
Fixes-Issue: CLIENT-522
Reviewed-on: http://gerrit.dmdirc.com/3644
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
8fc8b6cf98
Remove obsolete domainUpdated method.
Change-Id: Iaaf6a3932768e7e8e8a5ab225437d0c8340e4d5f
Reviewed-on: http://gerrit.dmdirc.com/3643
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 gadus atpakaļ
Chris Smith
db706b6de8
Minor tidying.
Disable some new 'controversial' PMD rules, and enable some of the
others we had suppressed.
Change-Id: Ia15d78858617e8b4dcc71c47b91d9975118206a9
Reviewed-on: http://gerrit.dmdirc.com/3642
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
c57658f07d
Dependency inject message sinks.
Change-Id: I124087eeaac00d68892c5d425618c80f853fb6a7
Reviewed-on: http://gerrit.dmdirc.com/3641
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 gadus atpakaļ
Chris Smith
55beb5b4d7
Fix checkParser ordering.
Not much point throwing an exception if the server's state has
already been mucked up.
Change-Id: I3c64b46ab8c8f432a8276cb717b8816af1bea56a
Reviewed-on: http://gerrit.dmdirc.com/3640
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
47c6026c45
Fix CTCP responses.
Only squelsh the response if the event *has* been handled by
something else.
Change-Id: I173e89c26470c1f605ce56f3e6c04b0d29476b35
Reviewed-on: http://gerrit.dmdirc.com/3639
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 gadus atpakaļ
Chris Smith
ea2da6d8bb
Use ConfigBinding in Channel.
Not sure why we didn't do this before.
Also unregister the config listener when the channel is closed,
because not leaking things is Good.
Change-Id: I76aaf1f9dad22c2066f78d66a0d87da24320e2a0
Reviewed-on: http://gerrit.dmdirc.com/3638
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
7b5f61e81a
Wrap channel management in a utility class.
Change-Id: I4702f024dc3bf4114c0f4ad63f51e06751eab547
Reviewed-on: http://gerrit.dmdirc.com/3637
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 gadus atpakaļ
e0c0491dec
Some changes to the profile dialog model.
Change-Id: I29df5d4140fa494495f2230cd5dcc24ecacf0736
Reviewed-on: http://gerrit.dmdirc.com/3635
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
2ffe10767d
Add a workaround to fix invite actions (and probably others)
Change-Id: I4d518a7ce698a31633c88e2255b3402ee0b9385a
Reviewed-on: http://gerrit.dmdirc.com/3633
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
d32eda6cf4
Dont change selection if new value matches old value.
Change-Id: Ia64ebd397d2c5093ef1aacb2063baebcfa236af8
Fixes-Issue: CLIENT-519
Reviewed-on: http://gerrit.dmdirc.com/3632
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
e74208dc4d
An alias is valid is none is selected.
Change-Id: Id853197d3884ad18d8c90e53e930f9680170e994
Fixes-Issue: CLIENT-518
Reviewed-on: http://gerrit.dmdirc.com/3629
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
10 gadus atpakaļ
413c3b8e40
Fix up CoreAliasDialogModel
Change-Id: I20df1c9c0b1db6ceece276a96382196ed13cedd8
Depends-On: d1f48e58e8
Reviewed-on: http://gerrit.dmdirc.com/3621
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
5aae1e9dd6
Finish CoreProfilesDialogModel.
This model should happily cope with the existing profiles wrapper
being rewritten and when the UI uses this model should mean no UI
changes required to add support.
Change-Id: Iea3b7838cef94514865ecb77064c133ca4556030
Reviewed-on: http://gerrit.dmdirc.com/3619
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
Chris Smith
Greg Holmes