Chris Smith
6ae693893d
Enable PMD in gradle + apply fixes.
Change-Id: I3665cac8af833da793ca418953d934cc3a333459
Depends-On: I348b37a14097439f8a56b0a671794410e46201ca
Depends-On: Ifc4aa601de14ca2526646f499f60329ed7c5935e
Reviewed-on: http://gerrit.dmdirc.com/3939
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 9 Jahren
06179bfd89
Use FrameClosingEvents in WindowManager.
Change-Id: Iba5bc03ad28b1bb28def0b7a1f27c9cf4e2fe7d0
Reviewed-on: http://gerrit.dmdirc.com/3813
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
vor 9 Jahren
Chris Smith
1ec3b56141
FrameContainer parents are Optional.
Change-Id: Ibaf13d210cd01e73adf08bac359244b14faef088
Depends-On: Ief9fccad45d654ffaee9d7a124ebc39f7af56166
Reviewed-on: http://gerrit.dmdirc.com/3470
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 10 Jahren
Chris Smith
168b2c8af6
Remove deprecated methods
Change-Id: I1f04df7e9dd8dc0e7e2feac701d614a8a888b13c
Reviewed-on: http://gerrit.dmdirc.com/3013
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 10 Jahren
12b39dc0f8
Update Copyright to 2014
Change-Id: Id0904867640e49e12fca5c1c7c5b9e72c78e3a1b
Reviewed-on: http://gerrit.dmdirc.com/2976
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 10 Jahren
Chris Smith
65b308c877
Make the WindowManager test sane.
Don't use a dummy UI and massive chunks of real objects.
Change-Id: I73ecf45760397d477137f13f1bdb210fa25cad97
Reviewed-on: http://gerrit.dmdirc.com/2710
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 10 Jahren
Chris Smith
d92598e079
Inject StatusBarManager and MessageSinkManager.
Pass the MSM into Main so it actually gets created, as the few
places that refer to it aren't being inflated by dagger yet.
Change-Id: Ic92f88aac29d4c68fdbc062a582b3e44ecd23637
Reviewed-on: http://gerrit.dmdirc.com/2691
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 10 Jahren
Chris Smith
e86677fa6d
Inject the CommandManager.
Separate out the constructor and initialisation logic in line
with other managers.
Change-Id: Ie5d2f12b838213a6500f0a87e44e56254b8d5916
Reviewed-on: http://gerrit.dmdirc.com/2689
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 10 Jahren
Chris Smith
2e121ed421
Remove CommandManager.getMain().
Pass in the relevant dependencies in all cases except for the Quit
command, which does actually need a Main (but it can access it
statically, for now).
Change-Id: I056a0782b9d073622c04343ebba103d0880b9567
Reviewed-on: http://gerrit.dmdirc.com/2661
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 10 Jahren
b87e3ba335
Update copyright for 2013
Change-Id: Idf38f5027a92166daf99039de75b759d47431de1
Reviewed-on: http://gerrit.dmdirc.com/2607
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 11 Jahren
7b67f19db2
Revert "Continue main removal"
Revert "Begin work on removing CommandManager singleton"
This reverts commit e93538e9dc .
Change-Id: I8eb4f70f80292d66e3bdbe9f32766b5f427413c2
Depends-On: Iba86c7f2bf870684e0d41f88d82f16b43d43fe80
Reviewed-on: http://gerrit.dmdirc.com/2601
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 11 Jahren
e93538e9dc
Continue main removal
Change-Id: I28c660092aabbc8eeebd9ed4dcc80cb9f3940aaf
Depends-On: I28c660092aabbc8eeebd9ed4dcc80cb9f3940aaf
Reviewed-on: http://gerrit.dmdirc.com/2589
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
vor 11 Jahren
4edc853bbf
Desingleton PluginManager (and as a side-effect, ServerManager).
Depends-On: I72fe837b5ea2352ae0c695948336efcdd92c09c8
Change-Id: I4a3d9b78a5f80aab0330d0906e8c76d00813c97c
Reviewed-on: http://gerrit.dmdirc.com/2523
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 11 Jahren
792f3cc7dc
Make main less static.
Don't ask Main for the config directory.
Remove getMain() from Main.
Everything that needs a main now either gets given it, or asks something else.
Unfortunately, a few more dependencies on the static IdentityManager.getIdentityManager()
were introduced, but they can be tackled separately.
Fix unit tests for the above.
Change-Id: I9e42ac7f74453b739209a681d0a31f50c1be2a04
Depends-On: Ib5a9fdea5a2e25d5471d0b849f4f65fa0286d1f8
Reviewed-on: http://gerrit.dmdirc.com/2520
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 11 Jahren
ab45825e88
De-singleton + unit test
Change-Id: Iadcf92d4390034828d005a9c9e92d9a8ba189c99
Depends-On: I17790a0e71a6c004a088a6eb51332293b23062a4
Reviewed-on: http://gerrit.dmdirc.com/2455
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
vor 12 Jahren
a02b2fb548
Add more unit tests for WindowManager
Change-Id: I32f8d56e54888007c66f16ec593172bda0d62ee0
Reviewed-on: http://gerrit.dmdirc.com/2448
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
vor 12 Jahren
d26602c9dc
Update Copyright for 2012
Change-Id: I0d40c3ac86b9e06fad3f29bc36612b4162e54d1c
Reviewed-on: http://gerrit.dmdirc.com/2287
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 12 Jahren
Chris Smith
ebbd1daff5
Import fixing!
Change-Id: Ia90cb759b0777cf8d30eb6bfe30a5bece0105d24
Reviewed-on: http://gerrit.dmdirc.com/2281
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 12 Jahren
Chris Smith
41304ccecb
More deprecation fixes
Change-Id: If418fcbcafa64857e6a656bee08fef7399b6a2e3
Reviewed-on: http://gerrit.dmdirc.com/2280
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 12 Jahren
60d9db2dcf
Centralised interfaces packages.
Depends-On: I862891efc407a64559788812ee039a9ec565a973
Change-Id: If624693f050e1aa9cf4cabcd5264518604eb8bcd
Reviewed-on: http://gerrit.dmdirc.com/2167
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
vor 13 Jahren
Chris Smith
1011d7136a
Remove window class from frame containers
Change-Id: I6c243840a40655bbbdd7a32ab707a7f2e15880ae
Depends-On: I32d75cc6dee8dce03390a2d29026f70e5ebf2bc4
Reviewed-on: http://gerrit.dmdirc.com/2096
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
vor 13 Jahren
d04e2bea4f
Change header?
Change-Id: I635e0d111ed182713132145e4d5fb1654f776ec4
Reviewed-on: http://gerrit.dmdirc.com/2071
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
vor 13 Jahren
Chris Smith
bb70d16d7b
Remove unused private fields
Make having unused fields or formal params a PMD error
Change-Id: Ief1c8e499af7e3a43328046dc140ba941d8cb010
Depends-On: I970b49db0abac46d15a11e2b71dc0b50bd3a8faf
Reviewed-on: http://gerrit.dmdirc.com/2034
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 13 Jahren
Chris Smith
d76efc309f
Make WindowManager non-static
CLIENT-84
Change-Id: I4f8df35efbb7ce266d6e8b1239c646a0a9c92107
Depends-On: Ia9b45bc4ff7f17af9e1eed758c0a659f6ab47251
Reviewed-on: http://gerrit.dmdirc.com/1987
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 13 Jahren
Chris Smith
198a1597cc
Rework FrameContainer/UI interaction
- FrameContainers are no longer parameterised
- Introduced notion of window "Components"
- Removed per-window interfaces - fixes CLIENT-218
Change-Id: Ieefbf2d1e157e3638dbe8fdedbd4f32642061329
Depends-On: Iecbb2941c99a3412dc2eb3b7f56fc584d2db483e
Reviewed-on: http://gerrit.dmdirc.com/1885
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
vor 13 Jahren
acdd8268bc
Remove deprecations.
Depends-On: Ic938a7785a30477f47074e574ec8311723d803a9
Change-Id: I5ebf0bd52682cd0b1798d1b1b54353e5e65e793f
Reviewed-on: http://gerrit.dmdirc.com/1838
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
vor 13 Jahren
fd83b6b2a9
Update Copyright
Change-Id: I7f63fdd02ea0109fe31e55c44b078edae3862f32
Reviewed-on: http://gerrit.dmdirc.com/1726
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
vor 13 Jahren
Chris Smith
6e42762d67
Style fixes
Change-Id: Icfab1de147645d80a999c3678daf268e7e115066
Reviewed-on: http://gerrit.dmdirc.com/1331
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
vor 14 Jahren
Chris Smith
f27ff89ece
Fix window manager unit tests
Fixes issue 4139
Fixes issue 4140
Fixes issue 4141
Fixes issue 4142
Change-Id: I14af970b5b008eb87ed070544e9c0d18cc0e282c
Reviewed-on: http://gerrit.dmdirc.com/1240
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
vor 14 Jahren
Chris Smith
f4bbdb48fe
Massive window changes.
Highlights:
- FrameContainers are now generic, according to their window type
- Writable frame containers now handle their tab completers
- Redirect plugin works again
- Windows are no longer actively requested from the UI; the UI
creates and adds them in response to events from the WindowManager
fixes issue 3997, fixes issue 4000, fixes issue 4012, fixes issue 4030
fixes issue 4027, fixes issue 4028, fixes issue 4029, fixes issue 4031
fixes issue 4032, fixes issue 4033
Change-Id: Ife307728e46bd3b6dcd189be6886ab8b6fbd9212
Reviewed-on: http://gerrit.dmdirc.com/1144
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
Automatic-Compile: Gregory Holmes <greg@dmdirc.com >
vor 14 Jahren
7b0c1f8cc3
Work on opening windows in the background
issue 141
issue 3570
Change-Id: Iafe1ca912fceec5f5251cf0bdbe539a93e625dbd
Reviewed-on: http://gerrit.dmdirc.com/1131
Automatic-Compile: Chris Smith <chris@dmdirc.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
vor 14 Jahren
Chris Smith
6588c4d9f8
Fix broken unit test
Change-Id: I466b5203c8455f7717f9bfe502d3aca7aa6c6d74
Reviewed-on: http://gerrit.dmdirc.com/1111
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
vor 14 Jahren
Chris Smith
a130e303c0
Update unit tests for Styliser changes
Change-Id: I8629a358ac76ae6017d7eef1231e358ffaa63e9d
Reviewed-on: http://gerrit.dmdirc.com/529
Reviewed-by: Gregory Holmes <greboid@dmdirc.com >
Automatic-Compile: Gregory Holmes <greboid@dmdirc.com >
vor 14 Jahren
b691b14491
Update the copyright date on all files.
UpdateCopyright.sh now works out the year automatically.
UpdateCopyright.sh now ignores .git aswell as .svn
UpdateCopyright.sh now excludes Binary Files from being matched during the initial search, rather than as an afterthought.
Change-Id: I2cfc56851a4217a4c85cbc7361c7a90421aae717
Reviewed-on: http://gerrit.dmdirc.com/202
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Tested-by: Shane Mc Cormack <shane@dmdirc.com >
vor 14 Jahren
Chris Smith
1b2ec9d230
Fix broken unit test
vor 15 Jahren
Chris Smith
8d0b6c83a0
Replace TestFrameManager with a mock, make the WritableFrameContainer
harness close windows properly
vor 15 Jahren
Chris Smith
b435501251
Fix some broken unit tests
Remove junit 3 stuff
vor 15 Jahren
Chris Smith
7912d6fe02
Initial work on moving UI to a plugin
vor 15 Jahren
ad6cddbba0
Update copyright header to 2009
vor 15 Jahren
Chris Smith
cae8773e08
Using nulls in unit tests is all well and good until you go and add code which tries to dereference them.
git-svn-id: http://svn.dmdirc.com/trunk@4207 00569f92 -eb28-0410-84fd-f71c24880f
vor 16 Jahren
Chris Smith
8fbd16a57e
WindowManager unit test (issue 1106)
git-svn-id: http://svn.dmdirc.com/trunk@3957 00569f92 -eb28-0410-84fd-f71c24880f
vor 16 Jahren
Chris Smith
1a352f8726
Unit tests
git-svn-id: http://svn.dmdirc.com/trunk@3260 00569f92 -eb28-0410-84fd-f71c24880f
vor 16 Jahren
Chris Smith
Greg Holmes