Chris Smith
68fe71042b
Don't depend on the IRC parser...
Sensible build systems break when we do this! :)
Change-Id: I7ebd886556377ffaa002d8148a61399f8f97f981
Reviewed-on: http://gerrit.dmdirc.com/4026
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 jaren geleden
Chris Smith
6ae693893d
Enable PMD in gradle + apply fixes.
Change-Id: I3665cac8af833da793ca418953d934cc3a333459
Depends-On: I348b37a14097439f8a56b0a671794410e46201ca
Depends-On: Ifc4aa601de14ca2526646f499f60329ed7c5935e
Reviewed-on: http://gerrit.dmdirc.com/3939
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 jaren geleden
8e404a59b8
Add a qualifier for ColourManager.
Change-Id: Icf9c64b84ddc129fe54765a4a3cac475c58cf1de
Depends-On: I81484e5df7b5dfeb7067ba211c11f2df198ac43c
Reviewed-on: http://gerrit.dmdirc.com/3893
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
9 jaren geleden
Chris Smith
38b5e683a5
Replace loads of servers with connections.
Change-Id: Ia569d12d8d53797ef7378ceab2ba1f5bda3affdc
Depends-On: I11efabb2757d8e62127b6487cbeb62d240cbd891
Reviewed-on: http://gerrit.dmdirc.com/3873
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 jaren geleden
Chris Smith
7f222c800f
Introduce a ConnectionManager.
Remove most references to Server.
Change-Id: I8888522d58ff4d332c4a477702442c29a82d12ff
Depends-On: Ic0e6e5f95adc30e773945c95e73d321d589503d2
Reviewed-on: http://gerrit.dmdirc.com/3872
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 jaren geleden
Chris Smith
fa4a3d6dbc
Move /alias command over to new AliasManager.
Change-Id: Idcc9a9cb937302916998900cfc8a00f59d63cc08
Reviewed-on: http://gerrit.dmdirc.com/3536
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 jaren geleden
Chris Smith
09cb002be2
Always specify an origin when parsing commands.
Where commands are executed globally, pass in a GlobalWindow.
Make the GlobalWindow a singleton that persists, and is simply
added/removed from the WindowManager when the user wants to
show/hide it.
Change-Id: Iac94848487442509bdbf8ec98f67983e313ed743
Reviewed-on: http://gerrit.dmdirc.com/3451
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
Chris Smith
ff9c4160d0
Couple of test additions/improvements
Change-Id: Id0c8eedd2654afd9590cc2520dcafa889b053e16
Reviewed-on: http://gerrit.dmdirc.com/3387
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
12b39dc0f8
Update Copyright to 2014
Change-Id: Id0904867640e49e12fca5c1c7c5b9e72c78e3a1b
Reviewed-on: http://gerrit.dmdirc.com/2976
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
2a44f2bdcd
Fix URIParser (has apparently been broken forever).
Add unit tests URI Parser.
Change-Id: I329f958024f70288f42862c02f9b2d7a4ff072ea
Reviewed-on: http://gerrit.dmdirc.com/2967
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 jaren geleden
Chris Smith
c870e6719a
Move URI parsing behaviour into a util class.
Doesn't make much sense having things calling static methods on a
random command.
This removes the long-deprecated "--ssl" flag for the newserver
command.
Change-Id: Ie75658c3bcf5c495dcc8b0548f080e1a12ac4a52
Reviewed-on: http://gerrit.dmdirc.com/2966
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
Chris Smith
c59e662ad4
FrameContainers should expose a Connection.
Anywhere that doesn't just work with a Connection, cast back to a Server for
now. These can be tidied up later.
Change-Id: I02a54b0bcfaef08d5757cc015c356f9779ec0371
Depends-On: Id55c3611173be7ed79fae8f9e976996d713b8646
Reviewed-on: http://gerrit.dmdirc.com/2950
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
Chris Smith
9591bda084
Inject GlobalCommandParser, and tidying up.
Rename ActionFactory methods to be consistent with @Factory-generated ones.
Change-Id: Iafd20682f2fb0a166c6d7502443b56c3263da85d
Depends-On: Ifa75714ab3445634e61df3d99792cdef602d319e
Reviewed-on: http://gerrit.dmdirc.com/2899
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
Chris Smith
ae888ef208
Die, TestMain, die.
It's been horrible knowing you.
Change-Id: Icd8eaeb9c4e481013dfbfa34757455f8d9e852f8
Reviewed-on: http://gerrit.dmdirc.com/2788
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
Chris Smith
1472299df3
Use injected ActionFactory everywhere.
Change-Id: I9593bfaf82ac22b629e9fde5380e08f3aa0eea86
Depends-On: Ifd939bc3411c8d738c893634f3143fe8132782c0
Reviewed-on: http://gerrit.dmdirc.com/2786
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
Chris Smith
14da0a2938
Remove ConfigManager references.
Change-Id: I065a771ff81e565b37689f9d6ea82d4057cec2f1
Reviewed-on: http://gerrit.dmdirc.com/2779
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
Chris Smith
d596e02ddc
Remove direct Identity usages.
Move static factory methods into IdentityFactory, and replace
almost every use of Identity with ConfigProvider.
Depends-On: I6a32f3592cb5fc3df99a23eee62ae961ce0fc143
Change-Id: I66b382d54b77ef030d88448e456a83eb98aca216
Reviewed-on: http://gerrit.dmdirc.com/2777
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
Chris Smith
a335bf1208
Use config interfaces where possible.
Change-Id: Iaabedda2fa68c4e5562bb069dcdf15fa0c3beeea
Depends-On: I5f140e89bfb8c57804d0a500bbc9f5c18555b0e9
Reviewed-on: http://gerrit.dmdirc.com/2768
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
Chris Smith
b354ebdb70
Move old config interfaces into config folder.
Change-Id: I8d791451ead4b37f9181a9741e127cbc8b514d46
Depends-On: I94416680dfa9f0ee4896f5a6518889c6eb891909
Reviewed-on: http://gerrit.dmdirc.com/2754
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
Chris Smith
0620e3d432
Make all core commands provide a controller.
Change-Id: Iaf2c2fbc2ccc32aa8b05fd1a309fad524b2baf94
Reviewed-on: http://gerrit.dmdirc.com/2724
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
Chris Smith
990b03ae2e
Fix some AliasWrapper references.
Remove HelpTest because it's a pretty lame test, not (and never
will be) an actual unit test, and a PITA to maintain.
Change-Id: Ibc15984a694a7b284e206ab337211ce471ac1913
Reviewed-on: http://gerrit.dmdirc.com/2706
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
Chris Smith
18e0c6b275
Tidy up some ColourManager refs and inject.
Change-Id: Ic3a60962dbfcebf195df000e38639619186c40b9
Reviewed-on: http://gerrit.dmdirc.com/2698
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
Chris Smith
fe114fb56f
Remove some more TestMain references.
Rework how Logger/ErrorManager interact so they can be half
mocked out (or, at least, used in a thread-safe-ish manner).
Change-Id: Ia5899640bdc101793819dab88c3fe6038a759abb
Reviewed-on: http://gerrit.dmdirc.com/2695
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 jaren geleden
Chris Smith
b37b954647
Inject the CommandLoader.
Create a proper LifecycleController implementation that can be
injected, move the interface to the interfaces package, and
then inject the CommandLoader instead of creating it in Main.
Change-Id: I4236b4668301f585544c8c6a9f17c39771290ea5
Reviewed-on: http://gerrit.dmdirc.com/2688
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
Chris Smith
68ce22ff7d
Pass IdentityManager into commands that use it.
Change-Id: Ieb89624746da92690df22b0938384141f42de8dd
Reviewed-on: http://gerrit.dmdirc.com/2676
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 jaren geleden
Chris Smith
1afcf20413
Add interface for things that want to quit.
Allows us to pass in a sensible reference to things like the /exit
command, instead of a Main object or calling a method statically.
Change-Id: I3a794339cbf0c2052ff1d7bf377dacb6171bf1f7
Reviewed-on: http://gerrit.dmdirc.com/2662
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 jaren geleden
Chris Smith
2e121ed421
Remove CommandManager.getMain().
Pass in the relevant dependencies in all cases except for the Quit
command, which does actually need a Main (but it can access it
statically, for now).
Change-Id: I056a0782b9d073622c04343ebba103d0880b9567
Reviewed-on: http://gerrit.dmdirc.com/2661
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 jaren geleden
b87e3ba335
Update copyright for 2013
Change-Id: Idf38f5027a92166daf99039de75b759d47431de1
Reviewed-on: http://gerrit.dmdirc.com/2607
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
11 jaren geleden
7b67f19db2
Revert "Continue main removal"
Revert "Begin work on removing CommandManager singleton"
This reverts commit e93538e9dc .
Change-Id: I8eb4f70f80292d66e3bdbe9f32766b5f427413c2
Depends-On: Iba86c7f2bf870684e0d41f88d82f16b43d43fe80
Reviewed-on: http://gerrit.dmdirc.com/2601
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
11 jaren geleden
f9c93121a9
Begin work on removing CommandManager singleton
Change-Id: Ieb44f09699a2304fa5b07f474989823f02fc78b0
Depends-On: I04e90afc89211eee412a511b12baeedf0361b414
Reviewed-on: http://gerrit.dmdirc.com/2584
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
11 jaren geleden
792f3cc7dc
Make main less static.
Don't ask Main for the config directory.
Remove getMain() from Main.
Everything that needs a main now either gets given it, or asks something else.
Unfortunately, a few more dependencies on the static IdentityManager.getIdentityManager()
were introduced, but they can be tackled separately.
Fix unit tests for the above.
Change-Id: I9e42ac7f74453b739209a681d0a31f50c1be2a04
Depends-On: Ib5a9fdea5a2e25d5471d0b849f4f65fa0286d1f8
Reviewed-on: http://gerrit.dmdirc.com/2520
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
11 jaren geleden
Chris Smith
a9631ebf02
Commands clean up
Reduce dependency on CommandManager singleton
Use Lombok and delete loads of boilerplate code
Change-Id: Id178d20df1838eef99abdc0c3ca12b6dbd2a062f
Reviewed-on: http://gerrit.dmdirc.com/2310
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 jaren geleden
Chris Smith
9ff3b302a6
Move loading of core commands out of CommandManager
Change-Id: Id8a9fde29d189e1c3cd025a3b9f30f2b575a7280
Depends-On: I2838ac60f809408480d985123fde9427e1e5f0e4
Reviewed-on: http://gerrit.dmdirc.com/2309
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 jaren geleden
d26602c9dc
Update Copyright for 2012
Change-Id: I0d40c3ac86b9e06fad3f29bc36612b4162e54d1c
Reviewed-on: http://gerrit.dmdirc.com/2287
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 jaren geleden
Chris Smith
5c64a29c45
Deprecations
Change-Id: I1aa33d6e360f6050b02b7fe3f7db1312451c93fb
Reviewed-on: http://gerrit.dmdirc.com/2282
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 jaren geleden
Chris Smith
ebbd1daff5
Import fixing!
Change-Id: Ia90cb759b0777cf8d30eb6bfe30a5bece0105d24
Reviewed-on: http://gerrit.dmdirc.com/2281
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 jaren geleden
Chris Smith
41304ccecb
More deprecation fixes
Change-Id: If418fcbcafa64857e6a656bee08fef7399b6a2e3
Reviewed-on: http://gerrit.dmdirc.com/2280
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 jaren geleden
Chris Smith
2f4649f388
More deprecations go byebye
Change-Id: I4d171421aee23c200e65c1eec89fa21974d42160
Reviewed-on: http://gerrit.dmdirc.com/2160
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 jaren geleden
Chris Smith
6dc3dcde13
Add a ServerFactory and unit test /newserver sanely
Change-Id: I5f2a3113c14d1822d50a17138f4b3e9bd0612a10
Reviewed-on: http://gerrit.dmdirc.com/2156
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 jaren geleden
d04e2bea4f
Change header?
Change-Id: I635e0d111ed182713132145e4d5fb1654f776ec4
Reviewed-on: http://gerrit.dmdirc.com/2071
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 jaren geleden
Chris Smith
7cd4171bf1
Add BasicCommandInfo and make core commands use it
Change-Id: I24e8daf8cc076d90328f7c38cf539420566bf14e
Fixes-Issue: CLIENT-262
Reviewed-on: http://gerrit.dmdirc.com/2009
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
13 jaren geleden
Chris Smith
949770857a
Make CommandManager a singleton
CLIENT-84
Change-Id: I48182a9cd7c8f49612025ba208ae90d3bb19ee2b
Depends-On: Ib62d32dbfdadaf38930ceacf667ff533de047599
Reviewed-on: http://gerrit.dmdirc.com/1996
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 jaren geleden
Chris Smith
198a1597cc
Rework FrameContainer/UI interaction
- FrameContainers are no longer parameterised
- Introduced notion of window "Components"
- Removed per-window interfaces - fixes CLIENT-218
Change-Id: Ieefbf2d1e157e3638dbe8fdedbd4f32642061329
Depends-On: Iecbb2941c99a3412dc2eb3b7f56fc584d2db483e
Reviewed-on: http://gerrit.dmdirc.com/1885
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 jaren geleden
Chris Smith
4b8bf0c056
Unit tests
Change-Id: I1c1b4dab1b62c2d14879aace25fbf92d91f9629f
Reviewed-on: http://gerrit.dmdirc.com/1796
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 jaren geleden
fd83b6b2a9
Update Copyright
Change-Id: I7f63fdd02ea0109fe31e55c44b078edae3862f32
Reviewed-on: http://gerrit.dmdirc.com/1726
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 jaren geleden
936792f136
Remove debug command from client, moved to a plugin.
Change-Id: I0828dd46c1315a4ae475d23a6152dc8183e1ab09
Reviewed-on: http://gerrit.dmdirc.com/1698
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 jaren geleden
Chris Smith
da78032175
Add command flag utility classes and make /echo and /set use them.
Fixes CLIENT-119
Fixes CLIENT-120
Change-Id: I2e7ad2c3b8f0db591031fc281a24aa6627331a6e
Reviewed-on: http://gerrit.dmdirc.com/1680
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 jaren geleden
Chris Smith
5d584f2068
Style fixes
Change-Id: Idffa6c2559bcc2112c9657b15349aa80579ab83a
Reviewed-on: http://gerrit.dmdirc.com/1336
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 jaren geleden
Chris Smith
6e42762d67
Style fixes
Change-Id: Icfab1de147645d80a999c3678daf268e7e115066
Reviewed-on: http://gerrit.dmdirc.com/1331
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 jaren geleden
Chris Smith
2edf699e02
Introduce command contexts.
Fixes issue 4152
Fixes issue 4002
Change-Id: I664124ecb0994a808e2de359a38507c3b5f16452
Reviewed-on: http://gerrit.dmdirc.com/1250
Automatic-Compile: Shane Mc Cormack <shane@dmdirc.com >
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
14 jaren geleden
Chris Smith
Greg Holmes