Chris Smith
7333fc3f2e
Move more initialisation into dagger.
Fully initialise the PluginManager instead of passing around
one in various states of existance.
Move plugin extraction logic into a CorePluginExtractor class.
Inject UpdateManager where appropriate.
Change-Id: I6c15f7682cccd93b40dcc189a0a8466d067095f0
Reviewed-on: http://gerrit.dmdirc.com/2692
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 anni fa
ea301900fa
hacky check for plugin download validity
Change-Id: Ibcf92364d4db791ee4e01ad9fa163147280f6b52
Reviewed-on: http://gerrit.dmdirc.com/2608
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
11 anni fa
b87e3ba335
Update copyright for 2013
Change-Id: Idf38f5027a92166daf99039de75b759d47431de1
Reviewed-on: http://gerrit.dmdirc.com/2607
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
11 anni fa
792f3cc7dc
Make main less static.
Don't ask Main for the config directory.
Remove getMain() from Main.
Everything that needs a main now either gets given it, or asks something else.
Unfortunately, a few more dependencies on the static IdentityManager.getIdentityManager()
were introduced, but they can be tackled separately.
Fix unit tests for the above.
Change-Id: I9e42ac7f74453b739209a681d0a31f50c1be2a04
Depends-On: Ib5a9fdea5a2e25d5471d0b849f4f65fa0286d1f8
Reviewed-on: http://gerrit.dmdirc.com/2520
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
11 anni fa
Chris Smith
c4cb789cae
Apparently we want a working client. Who knew?
Change-Id: I5aafd69701ff7ce3ba9fe74cdf019715425b328a
Reviewed-on: http://gerrit.dmdirc.com/2483
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 anni fa
Chris Smith
568688caef
Skip lists ftw.
Change-Id: Idf0e6eac6ea3f58119cc46c701657db28f2d900c
Fixes-issue: CLIENT-366
Reviewed-on: http://gerrit.dmdirc.com/2482
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 anni fa
Chris Smith
6800ed773b
Handle update responses more defensively.
Change-Id: Ib767f3843ad93a575a1ecb63a21a7102c9fb341a
Fixes-issue: CLIENT-365
Reviewed-on: http://gerrit.dmdirc.com/2480
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 anni fa
Chris Smith
df0f4ba6df
Unit test for LegacyInstallationStrategy.
Tidying
Change-Id: I187cd3546cef668ffd37d678cc71e18840c2cbf7
Reviewed-on: http://gerrit.dmdirc.com/2442
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 anni fa
Chris Smith
5bdf9caece
Don't remove retrieval result on success
We still need it around to get at the version number etc
Change-Id: Ibe4ac35c57b6284e86382b57121ea6a8088f25f0
Fixes-Issue: CLIENT-344
Reviewed-on: http://gerrit.dmdirc.com/2387
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 anni fa
Chris Smith
cab5631bef
Stop components registering themselves in constructors
Change-Id: I00147e129abae032e1087766e60581f89378eb81
Reviewed-on: http://gerrit.dmdirc.com/2383
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 anni fa
Chris Smith
b0445f8470
Rewrote the updater system from scratch
Change-Id: Ia92ef9058621aa0a3cb67dc1fb30a13642580303
Depends-On: Iab5db6ba7738102fbe45e37670f6cfd3c705fd9c
Reviewed-on: http://gerrit.dmdirc.com/2381
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 anni fa
d26602c9dc
Update Copyright for 2012
Change-Id: I0d40c3ac86b9e06fad3f29bc36612b4162e54d1c
Reviewed-on: http://gerrit.dmdirc.com/2287
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 anni fa
Chris Smith
5c64a29c45
Deprecations
Change-Id: I1aa33d6e360f6050b02b7fe3f7db1312451c93fb
Reviewed-on: http://gerrit.dmdirc.com/2282
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 anni fa
Chris Smith
ebbd1daff5
Import fixing!
Change-Id: Ia90cb759b0777cf8d30eb6bfe30a5bece0105d24
Reviewed-on: http://gerrit.dmdirc.com/2281
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 anni fa
Chris Smith
d4507e0b3a
Deprecation fixes
Sprinkle some annotations over the CommandManager
More fiddling with NB7.1 settings
Change-Id: I2a0b751798249d4cc3e527f6d2e5525d1936f0e1
Reviewed-on: http://gerrit.dmdirc.com/2278
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 anni fa
Chris Smith
228b8b5ea2
Don't unload plugins when updating
Change-Id: I2ab78cf7c9e901f4d6848a22bbf09286a0ca72e6
Reviewed-on: http://gerrit.dmdirc.com/2263
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 anni fa
Chris Smith
a7a57eca29
Fix fallout from util changes
Change-Id: I0bfd2dc61096dd9670b269463c27d9b00fd9a917
Depends-On: I6d0665e57f6e0e2ff2fb6a18742acb99010e79bf
Depends-On: Ia8de3c1a5fdc1eb9cfaa8b29a32bb3efb6d8ce6f
Reviewed-on: http://gerrit.dmdirc.com/2242
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 anni fa
6b74c56291
Switch plugin updating to require a restart if the plugin is loaded.
This currently has loads of annoying side effects, especially now the
UIs support this, we can do this properly again once we've fixed plugin
dependencies.
Change-Id: Ia727c4a8776d3f197d70502d6058b8f71a132749
Reviewed-on: http://gerrit.dmdirc.com/2205
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
12 anni fa
a4031bdad2
Add getMetaData method to PluginInfo and use it
Change-Id: I0bf84a236b3d4a3a86bb3cdceadbfb972b7dec27
Reviewed-on: http://gerrit.dmdirc.com/2089
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 anni fa
Chris Smith
6a06e9abae
Get rid of @author tags
Change-Id: Ib8d0b8886b769777267f0b757faea00787c149f7
Reviewed-on: http://gerrit.dmdirc.com/2080
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 anni fa
d04e2bea4f
Change header?
Change-Id: I635e0d111ed182713132145e4d5fb1654f776ec4
Reviewed-on: http://gerrit.dmdirc.com/2071
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 anni fa
Chris Smith
2c840ab707
Remove unused ctors
Make unused ctors a PMD error
Change-Id: I10f7350e9435179e1c6f89e01233778ddffa648a
Reviewed-on: http://gerrit.dmdirc.com/2029
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
13 anni fa
Chris Smith
77b570a30f
Style fixes
Change-Id: If63e94dcf0aec9e9aa99e84f9962879fca46051f
Reviewed-on: http://gerrit.dmdirc.com/1931
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 anni fa
Chris Smith
f2018c541b
Remove trailing spaces
Change-Id: I9f382ab3d7b078fb759cbaca618bec5d21b8b5d9
Reviewed-on: http://gerrit.dmdirc.com/1919
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 anni fa
Chris Smith
68b0ed1d1f
Style fixes
Change-Id: I94a245fd1824ba6a5c8c32e66a45a0c9be806aa1
Reviewed-on: http://gerrit.dmdirc.com/1750
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 anni fa
fd83b6b2a9
Update Copyright
Change-Id: I7f63fdd02ea0109fe31e55c44b078edae3862f32
Reviewed-on: http://gerrit.dmdirc.com/1726
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 anni fa
b1a7c9ae67
PMD fixes for core
Change-Id: Ibc0ba49cc98404888dd4ee2834822d9bf7cce1cf
Reviewed-on: http://gerrit.dmdirc.com/1701
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 anni fa
a1c4dde046
Fix some PMD errors.
Change-Id: Ia8c864cc8abab3bfdcabeac30b41f6fb29233e73
Reviewed-on: http://gerrit.dmdirc.com/1689
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 anni fa
19f82d3f13
Make launcher component accept git versions.
Change-Id: Ie79ae5248a5823bee7e20e8eb1e365235c26ec60
Reviewed-on: http://gerrit.dmdirc.com/1669
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 anni fa
Chris Smith
37be1d2d6f
Update checker now caches updates between restarts
Fixes issue 557
Change-Id: I714b28a5a79fb3f0f85c0464522960c8a11ebbcf
Reviewed-on: http://gerrit.dmdirc.com/1476
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
Automatic-Compile: Chris Smith <chris@dmdirc.com >
14 anni fa
Chris Smith
5d584f2068
Style fixes
Change-Id: Idffa6c2559bcc2112c9657b15349aa80579ab83a
Reviewed-on: http://gerrit.dmdirc.com/1336
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 anni fa
Chris Smith
6e42762d67
Style fixes
Change-Id: Icfab1de147645d80a999c3678daf268e7e115066
Reviewed-on: http://gerrit.dmdirc.com/1331
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 anni fa
0fba0b83cc
Import order fixing
Change-Id: I279e36a0c62eee8e1922da83f9e00fc92794a2c2
Reviewed-on: http://gerrit.dmdirc.com/1325
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
14 anni fa
672ea9ff10
Unload the plugin before we delete it!
Probably fixes issue 4077
Probably fixes issue 4079
Change-Id: I80b8bc7251e02e402dcd7f430a0295b5dd82afda
Reviewed-on: http://gerrit.dmdirc.com/1225
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
14 anni fa
05c46ce373
Add some methods to update components to indicate if a restart of the client is needed before the user updates
fixes issue 642
Change-Id: I64f23ddcd75e97700a02e1c65d97ae91e48734f5
Reviewed-on: http://gerrit.dmdirc.com/1057
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
14 anni fa
Chris Smith
06dc20795b
Action packs can have non-numeric versions
Fixes issue 3943
Depends-On: I9f769f243178022528da65fe4c15abbd62d9e49c
Change-Id: I1419fa74d8da7f3f5d96a00dea559329db008b0e
Reviewed-on: http://gerrit.dmdirc.com/1047
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Automatic-Compile: Shane Mc Cormack <shane@dmdirc.com >
14 anni fa
Chris Smith
73a2fb41aa
More style changes
Change-Id: Idaf5f21e20e9775cbb104c30bb2e51e5b947d0b5
Reviewed-on: http://gerrit.dmdirc.com/823
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 anni fa
Chris Smith
e5763b824c
Style improvements
Change-Id: I50c85748a8d1535b109307e22376f21a5f754cea
Reviewed-on: http://gerrit.dmdirc.com/819
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
Automatic-Compile: Gregory Holmes <greg@dmdirc.com >
14 anni fa
aa043ca32a
This might fix issue 3411.
It might also fix the pluginmanager not always updating the metadata correctly.
Change-Id: I193f520f409337cc56e7032e7ea4a0e371e7473b
Reviewed-on: http://gerrit.dmdirc.com/802
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
14 anni fa
b5fc95bf5c
Remove references to git from build scripts and the like.
Would appreviate a full review of this to make sure I didn't miss anything or delete the wrong stuff!
Change-Id: Iff32442f0fe317955f5122ced3d6cf95c4436982
Reviewed-on: http://gerrit.dmdirc.com/238
Reviewed-by: Gregory Holmes <greboid@dmdirc.com >
Tested-by: Gregory Holmes <greboid@dmdirc.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
14 anni fa
Chris Smith
9e60c0f8a6
Allow non-integer mode alias versions
Issue 2734
Change-Id: I8877ae0b2f721fc817ac418f1e14617bba4477fd
Reviewed-on: http://gerrit.dmdirc.com/225
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Tested-by: Shane Mc Cormack <shane@dmdirc.com >
14 anni fa
b691b14491
Update the copyright date on all files.
UpdateCopyright.sh now works out the year automatically.
UpdateCopyright.sh now ignores .git aswell as .svn
UpdateCopyright.sh now excludes Binary Files from being matched during the initial search, rather than as an afterthought.
Change-Id: I2cfc56851a4217a4c85cbc7361c7a90421aae717
Reviewed-on: http://gerrit.dmdirc.com/202
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Tested-by: Shane Mc Cormack <shane@dmdirc.com >
14 anni fa
Chris Smith
6b944efeea
Fix stupid bug in launcher component
Change-Id: I9b6436e7fb4add500ff2dd5232faf11e228962ce
Reviewed-on: http://gerrit.dmdirc.com/93
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Tested-by: Shane Mc Cormack <shane@dmdirc.com >
14 anni fa
58d139e795
Client support for launcher options. (Currently jsut ignores them because the website doesn't understand them)
Also fixes a missing 'then' from gerrit being annoying!
Change-Id: I387c62616126c744f2c5129cabd2554004ff9db8
Reviewed-on: http://gerrit.dmdirc.com/45
Reviewed-by: Gregory Holmes <greboid@dmdirc.com >
Tested-by: Gregory Holmes <greboid@dmdirc.com >
14 anni fa
Chris Smith
e2dfa656bd
Fix various updater component settings problems.
UI was setting the wrong setting (using full names).
Core was checking wrong settintgs (missing "enable-").
Fixes issue 3045.
Change-Id: I4d8bfc18d24de8b2bb09edfb802e0c7433d9a064
Reviewed-on: http://gerrit.dmdirc.com/7
Reviewed-by: Gregory Holmes <greboid@dmdirc.com >
Tested-by: Chris Smith <chris@dmdirc.com >
14 anni fa
2099e80d17
Some Error Checking.
15 anni fa
30a9e449ca
Show what plugin caused an error, Fixes issue 3017.
15 anni fa
fd1ff77312
wrong stash
15 anni fa
1709ba6b5e
fixes issue 2983
15 anni fa
Chris Smith
537061a0e0
Oh dear god the craziness.
Fixes version comparison for versions with letters in.
15 anni fa
Chris Smith
Greg Holmes