瀏覽代碼

Minor readability fixes

master
Ricardo Branco 6 年之前
父節點
當前提交
cf2aa01e44
共有 1 個文件被更改,包括 14 次插入13 次删除
  1. 14
    13
      clean_registry.py

+ 14
- 13
clean_registry.py 查看文件

41
     error("Please install PyYaml with: pip3 install pyyaml")
41
     error("Please install PyYaml with: pip3 install pyyaml")
42
 
42
 
43
 VERSION = "1.2"
43
 VERSION = "1.2"
44
+REGISTRY_DIR = "REGISTRY_STORAGE_FILESYSTEM_ROOTREGISTRY_DIR"
44
 
45
 
45
 
46
 
46
 def dockerized():
47
 def dockerized():
158
             except (APIError, exceptions.ConnectionError) as err:
159
             except (APIError, exceptions.ConnectionError) as err:
159
                 error(err)
160
                 error(err)
160
             if dockerized():
161
             if dockerized():
161
-                if not os.getenv("REGISTRY_STORAGE_FILESYSTEM_ROOTDIRECTORY"):
162
-                    os.environ['REGISTRY_STORAGE_FILESYSTEM_ROOTDIRECTORY'] = "/var/lib/registry"
163
-                self.registry_dir = os.environ['REGISTRY_STORAGE_FILESYSTEM_ROOTDIRECTORY']
162
+                try:
163
+                    self.registry_dir = os.environ[REGISTRY_DIR]
164
+                except KeyError:
165
+                    self.registry_dir = "/var/lib/registry"
164
             return
166
             return
165
 
167
 
166
         try:
168
         try:
177
 
179
 
178
         self.registry_dir = self.get_registry_dir()
180
         self.registry_dir = self.get_registry_dir()
179
 
181
 
180
-        if dockerized() and not os.getenv("REGISTRY_STORAGE_FILESYSTEM_ROOTDIRECTORY"):
181
-            os.environ['REGISTRY_STORAGE_FILESYSTEM_ROOTDIRECTORY'] = self.registry_dir
182
+        if dockerized():
183
+            os.environ[REGISTRY_DIR] = self.registry_dir
182
 
184
 
183
     def __call__(self):
185
     def __call__(self):
184
         try:
186
         try:
206
     def get_file(self, filename):
208
     def get_file(self, filename):
207
         '''Returns the contents of the specified file from the container'''
209
         '''Returns the contents of the specified file from the container'''
208
         try:
210
         try:
209
-            with self.docker.api.get_archive(self.container, filename)[0] as tar_stream:
210
-                with BytesIO(tar_stream.data) as buf:
211
+            with self.docker.api.get_archive(self.container, filename)[0] as tar:
212
+                with BytesIO(tar.data) as buf:
211
                     with tarfile.open(fileobj=buf) as tarf:
213
                     with tarfile.open(fileobj=buf) as tarf:
212
                         with tarf.extractfile(os.path.basename(filename)) as f:
214
                         with tarf.extractfile(os.path.basename(filename)) as f:
213
                             data = f.read()
215
                             data = f.read()
217
 
219
 
218
     def get_registry_dir(self):
220
     def get_registry_dir(self):
219
         '''Gets the Registry directory'''
221
         '''Gets the Registry directory'''
220
-        registry_dir = os.getenv("REGISTRY_STORAGE_FILESYSTEM_ROOTDIRECTORY")
222
+        registry_dir = os.getenv(REGISTRY_DIR)
221
         if registry_dir:
223
         if registry_dir:
222
             return registry_dir
224
             return registry_dir
223
 
225
 
224
-        registry_dir = ""
225
         for env in self.info['Config']['Env']:
226
         for env in self.info['Config']['Env']:
226
             var, value = env.split("=", 1)
227
             var, value = env.split("=", 1)
227
-            if var == "REGISTRY_STORAGE_FILESYSTEM_ROOTDIRECTORY":
228
+            if var == REGISTRY_DIR:
228
                 registry_dir = value
229
                 registry_dir = value
229
                 break
230
                 break
230
 
231
 
246
     def get_image_version(self):
247
     def get_image_version(self):
247
         '''Gets the Docker distribution version running on the container'''
248
         '''Gets the Docker distribution version running on the container'''
248
         if self.info['State']['Running']:
249
         if self.info['State']['Running']:
249
-            data = self.docker.containers.get(self.container).exec_run("/bin/registry --version").decode('utf-8')
250
+            data = self.docker.containers.get(self.container).exec_run("/bin/registry --version")
250
         else:
251
         else:
251
-            data = self.docker.containers.run(self.info["Image"], command="--version", remove=True).decode('utf-8')
252
-        return data.split()[2]
252
+            data = self.docker.containers.run(self.info["Image"], command="--version", remove=True)
253
+        return data.decode('utf-8').split()[2]
253
 
254
 
254
     def garbage_collect(self):
255
     def garbage_collect(self):
255
         '''Runs garbage-collect'''
256
         '''Runs garbage-collect'''

Loading…
取消
儲存