Browse Source

shorten type names to 10 chars

tags/v2.1.0-rc1
Shivaram Lingamneni 4 years ago
parent
commit
f4f7a8afaa
6 changed files with 27 additions and 12 deletions
  1. 1
    1
      conventional.yaml
  2. 2
    2
      irc/client.go
  3. 1
    1
      irc/gateways.go
  4. 18
    3
      irc/logger/logger.go
  5. 4
    4
      irc/server.go
  6. 1
    1
      oragono.yaml

+ 1
- 1
conventional.yaml View File

606
     #   # example of a file log that avoids logging IP addresses
606
     #   # example of a file log that avoids logging IP addresses
607
     #   method: file
607
     #   method: file
608
     #   filename: ircd.log
608
     #   filename: ircd.log
609
-    #   type: "* -userinput -useroutput -localconnect -localconnect-ip"
609
+    #   type: "* -userinput -useroutput -connect-ip"
610
     #   level: debug
610
     #   level: debug
611
 
611
 
612
 # debug options
612
 # debug options

+ 2
- 2
irc/client.go View File

277
 		return
277
 		return
278
 	}
278
 	}
279
 
279
 
280
-	server.logger.Info("localconnect-ip", fmt.Sprintf("Client connecting from %v", realIP))
280
+	server.logger.Info("connect-ip", fmt.Sprintf("Client connecting from %v", realIP))
281
 
281
 
282
 	now := time.Now().UTC()
282
 	now := time.Now().UTC()
283
 	config := server.Config()
283
 	config := server.Config()
1263
 			client.server.connectionLimiter.RemoveClient(ip)
1263
 			client.server.connectionLimiter.RemoveClient(ip)
1264
 			source = ip.String()
1264
 			source = ip.String()
1265
 		}
1265
 		}
1266
-		client.server.logger.Info("localconnect-ip", fmt.Sprintf("disconnecting session of %s from %s", details.nick, source))
1266
+		client.server.logger.Info("connect-ip", fmt.Sprintf("disconnecting session of %s from %s", details.nick, source))
1267
 	}
1267
 	}
1268
 
1268
 
1269
 	// decrement stats if we have no more sessions, even if the client will not be destroyed
1269
 	// decrement stats if we have no more sessions, even if the client will not be destroyed

+ 1
- 1
irc/gateways.go View File

80
 	client.server.connectionLimiter.RemoveClient(session.realIP)
80
 	client.server.connectionLimiter.RemoveClient(session.realIP)
81
 
81
 
82
 	// given IP is sane! override the client's current IP
82
 	// given IP is sane! override the client's current IP
83
-	client.server.logger.Info("localconnect-ip", "Accepted proxy IP for client", parsedProxiedIP.String())
83
+	client.server.logger.Info("connect-ip", "Accepted proxy IP for client", parsedProxiedIP.String())
84
 
84
 
85
 	client.stateMutex.Lock()
85
 	client.stateMutex.Lock()
86
 	defer client.stateMutex.Unlock()
86
 	defer client.stateMutex.Unlock()

+ 18
- 3
irc/logger/logger.go View File

46
 		LogWarning: "warn",
46
 		LogWarning: "warn",
47
 		LogError:   "error",
47
 		LogError:   "error",
48
 	}
48
 	}
49
+
50
+	// these are old names for log types that might still appear in yaml configs,
51
+	// but have been replaced in the code. this is used for canonicalization when
52
+	// loading configs, but not during logging.
53
+	typeAliases = map[string]string{
54
+		"localconnect":    "connect",
55
+		"localconnect-ip": "connect-ip",
56
+	}
49
 )
57
 )
50
 
58
 
59
+func resolveTypeAlias(typeName string) (result string) {
60
+	if canonicalized, ok := typeAliases[typeName]; ok {
61
+		return canonicalized
62
+	}
63
+	return typeName
64
+}
65
+
51
 // Manager is the main interface used to log debug/info/error messages.
66
 // Manager is the main interface used to log debug/info/error messages.
52
 type Manager struct {
67
 type Manager struct {
53
 	configMutex     sync.RWMutex
68
 	configMutex     sync.RWMutex
100
 	for _, logConfig := range config {
115
 	for _, logConfig := range config {
101
 		typeMap := make(map[string]bool)
116
 		typeMap := make(map[string]bool)
102
 		for _, name := range logConfig.Types {
117
 		for _, name := range logConfig.Types {
103
-			typeMap[name] = true
118
+			typeMap[resolveTypeAlias(name)] = true
104
 		}
119
 		}
105
 		excludedTypeMap := make(map[string]bool)
120
 		excludedTypeMap := make(map[string]bool)
106
 		for _, name := range logConfig.ExcludedTypes {
121
 		for _, name := range logConfig.ExcludedTypes {
107
-			excludedTypeMap[name] = true
122
+			excludedTypeMap[resolveTypeAlias(name)] = true
108
 		}
123
 		}
109
 
124
 
110
 		sLogger := singleLogger{
125
 		sLogger := singleLogger{
227
 	// assemble full line
242
 	// assemble full line
228
 
243
 
229
 	var rawBuf bytes.Buffer
244
 	var rawBuf bytes.Buffer
230
-	// XXX magic number here: 9 is len("listeners"), the longest log category name
245
+	// XXX magic number here: 10 is len("connect-ip"), the longest log category name
231
 	// in current use. it's not a big deal if this number gets out of date.
246
 	// in current use. it's not a big deal if this number gets out of date.
232
 	fmt.Fprintf(&rawBuf, "%s : %-5s : %-10s : ", time.Now().UTC().Format("2006-01-02T15:04:05.000Z"), LogLevelDisplayNames[level], logType)
247
 	fmt.Fprintf(&rawBuf, "%s : %-5s : %-10s : ", time.Now().UTC().Format("2006-01-02T15:04:05.000Z"), LogLevelDisplayNames[level], logType)
233
 	for i, p := range messageParts {
248
 	for i, p := range messageParts {

+ 4
- 4
irc/server.go View File

177
 	// check DLINEs
177
 	// check DLINEs
178
 	isBanned, info := server.dlines.CheckIP(ipaddr)
178
 	isBanned, info := server.dlines.CheckIP(ipaddr)
179
 	if isBanned {
179
 	if isBanned {
180
-		server.logger.Info("localconnect-ip", fmt.Sprintf("Client from %v rejected by d-line", ipaddr))
180
+		server.logger.Info("connect-ip", fmt.Sprintf("Client from %v rejected by d-line", ipaddr))
181
 		return true, info.BanMessage("You are banned from this server (%s)")
181
 		return true, info.BanMessage("You are banned from this server (%s)")
182
 	}
182
 	}
183
 
183
 
185
 	err := server.connectionLimiter.AddClient(ipaddr)
185
 	err := server.connectionLimiter.AddClient(ipaddr)
186
 	if err == connection_limits.ErrLimitExceeded {
186
 	if err == connection_limits.ErrLimitExceeded {
187
 		// too many connections from one client, tell the client and close the connection
187
 		// too many connections from one client, tell the client and close the connection
188
-		server.logger.Info("localconnect-ip", fmt.Sprintf("Client from %v rejected for connection limit", ipaddr))
188
+		server.logger.Info("connect-ip", fmt.Sprintf("Client from %v rejected for connection limit", ipaddr))
189
 		return true, "Too many clients from your network"
189
 		return true, "Too many clients from your network"
190
 	} else if err == connection_limits.ErrThrottleExceeded {
190
 	} else if err == connection_limits.ErrThrottleExceeded {
191
 		duration := server.Config().Server.IPLimits.BanDuration
191
 		duration := server.Config().Server.IPLimits.BanDuration
199
 
199
 
200
 		// this might not show up properly on some clients, but our objective here is just to close it out before it has a load impact on us
200
 		// this might not show up properly on some clients, but our objective here is just to close it out before it has a load impact on us
201
 		server.logger.Info(
201
 		server.logger.Info(
202
-			"localconnect-ip",
202
+			"connect-ip",
203
 			fmt.Sprintf("Client from %v exceeded connection throttle, d-lining for %v", ipaddr, duration))
203
 			fmt.Sprintf("Client from %v exceeded connection throttle, d-lining for %v", ipaddr, duration))
204
 		return true, throttleMessage
204
 		return true, throttleMessage
205
 	} else if err != nil {
205
 	} else if err != nil {
380
 	c := session.client
380
 	c := session.client
381
 	// continue registration
381
 	// continue registration
382
 	d := c.Details()
382
 	d := c.Details()
383
-	server.logger.Info("localconnect", fmt.Sprintf("Client connected [%s] [u:%s] [r:%s]", d.nick, d.username, d.realname))
383
+	server.logger.Info("connect", fmt.Sprintf("Client connected [%s] [u:%s] [r:%s]", d.nick, d.username, d.realname))
384
 	server.snomasks.Send(sno.LocalConnects, fmt.Sprintf("Client connected [%s] [u:%s] [h:%s] [ip:%s] [r:%s]", d.nick, d.username, session.rawHostname, session.IP().String(), d.realname))
384
 	server.snomasks.Send(sno.LocalConnects, fmt.Sprintf("Client connected [%s] [u:%s] [h:%s] [ip:%s] [r:%s]", d.nick, d.username, session.rawHostname, session.IP().String(), d.realname))
385
 
385
 
386
 	// send welcome text
386
 	// send welcome text

+ 1
- 1
oragono.yaml View File

627
     #   # example of a file log that avoids logging IP addresses
627
     #   # example of a file log that avoids logging IP addresses
628
     #   method: file
628
     #   method: file
629
     #   filename: ircd.log
629
     #   filename: ircd.log
630
-    #   type: "* -userinput -useroutput -localconnect -localconnect-ip"
630
+    #   type: "* -userinput -useroutput -connect-ip"
631
     #   level: debug
631
     #   level: debug
632
 
632
 
633
 # debug options
633
 # debug options

Loading…
Cancel
Save