fix #1284

irc/getters.go

@@ -11,6 +11,7 @@ import (
 
 	"github.com/oragono/oragono/irc/languages"
 	"github.com/oragono/oragono/irc/modes"
+	"github.com/oragono/oragono/irc/utils"
 )
 
 func (server *Server) Config() (config *Config) {
@@ -71,6 +72,7 @@ type SessionData struct {
 	hostname  string
 	certfp    string
 	deviceID  string
+	connInfo  string
 	sessionID int64
 }
 
@@ -91,6 +93,7 @@ func (client *Client) AllSessionData(currentSession *Session) (data []SessionDat
 			certfp:    session.certfp,
 			deviceID:  session.deviceID,
 			sessionID: session.sessionID,
+			connInfo:  utils.DescribeConn(session.socket.conn.UnderlyingConn().Conn),
 		}
 		if session.proxiedIP != nil {
 			data[i].ip = session.proxiedIP

irc/nickserv.go

@@ -12,7 +12,6 @@ import (
 
 	"github.com/goshuirc/irc-go/ircfmt"
 
-	"github.com/oragono/oragono/irc/modes"
 	"github.com/oragono/oragono/irc/passwd"
 	"github.com/oragono/oragono/irc/sno"
 	"github.com/oragono/oragono/irc/utils"
@@ -1099,20 +1098,19 @@ func nsClientsHandler(server *Server, client *Client, command string, params []s
 		nsClientsLogoutHandler(server, client, params, rb)
 	default:
 		nsNotice(rb, client.t("Invalid parameters"))
-		return
 	}
 }
 
 func nsClientsListHandler(server *Server, client *Client, params []string, rb *ResponseBuffer) {
 	target := client
+	hasPrivs := client.HasRoleCapabs("accreg")
 	if 0 < len(params) {
 		target = server.clients.Get(params[0])
 		if target == nil {
 			nsNotice(rb, client.t("No such nick"))
 			return
 		}
-		// same permissions check as RPL_WHOISACTUALLY for now:
-		if target != client && !client.HasMode(modes.Operator) {
+		if target != client && !hasPrivs {
 			nsNotice(rb, client.t("Command restricted"))
 			return
 		}
@@ -1131,6 +1129,9 @@ func nsClientsListHandler(server *Server, client *Client, params []string, rb *R
 		}
 		nsNotice(rb, fmt.Sprintf(client.t("IP address:  %s"), session.ip.String()))
 		nsNotice(rb, fmt.Sprintf(client.t("Hostname:    %s"), session.hostname))
+		if hasPrivs {
+			nsNotice(rb, fmt.Sprintf(client.t("Connection:  %s"), session.connInfo))
+		}
 		nsNotice(rb, fmt.Sprintf(client.t("Created at:  %s"), session.ctime.Format(time.RFC1123)))
 		nsNotice(rb, fmt.Sprintf(client.t("Last active: %s"), session.atime.Format(time.RFC1123)))
 		if session.certfp != "" {

irc/utils/net.go

@@ -5,6 +5,7 @@
 package utils
 
 import (
+	"fmt"
 	"net"
 	"regexp"
 	"strings"
@@ -193,3 +194,11 @@ func HandleXForwardedFor(remoteAddr string, xForwardedFor string, whitelist []ne
 	// or nil:
 	return
 }
+
+func DescribeConn(conn net.Conn) string {
+	// XXX for unix domain sockets, this is not informative enough for an operator
+	// to determine who holds the other side of the connection. there seems to be
+	// no way to get either the correct file descriptor of the connection, or the
+	// udiag_ino from `man 7 sock_diag`. maybe there's something else we can do?
+	return fmt.Sprintf("%s <-> %s", conn.LocalAddr().String(), conn.RemoteAddr().String())
+}