remove unnecessary special-casing for ASCII

irc/strings.go

@@ -8,7 +8,6 @@ package irc
 import (
 	"fmt"
 	"strings"
-	"unicode"
 
 	"github.com/oragono/confusables"
 	"golang.org/x/text/cases"
@@ -192,15 +191,11 @@ func CanonicalizeMaskWildcard(userhost string) (expanded string, err error) {
 		nick = "*"
 	}
 	if nick != "*" {
-		// XXX allow nick wildcards in pure ASCII, but not in unicode,
+		// XXX wildcards are not accepted with most unicode nicks,
 		// because the * character breaks casefolding
-		if IsPureASCII(nick) {
-			nick = strings.ToLower(nick)
-		} else {
-			nick, err = Casefold(nick)
-			if err != nil {
-				return "", err
-			}
+		nick, err = Casefold(nick)
+		if err != nil {
+			return "", err
 		}
 	}
 	if user == "" {
@@ -217,12 +212,3 @@ func CanonicalizeMaskWildcard(userhost string) (expanded string, err error) {
 	}
 	return fmt.Sprintf("%s!%s@%s", nick, user, host), nil
 }
-
-func IsPureASCII(str string) bool {
-	for i := 0; i < len(str); i++ {
-		if unicode.MaxASCII < str[i] {
-			return false
-		}
-	}
-	return true
-}

irc/strings_test.go

@@ -212,4 +212,6 @@ func TestCanonicalizeMaskWildcard(t *testing.T) {
 	tester("slingamn!", "slingamn!*@*", nil)
 	tester("shivaram*@good-fortune", "*!shivaram*@good-fortune", nil)
 	tester("shivaram*", "shivaram*!*@*", nil)
+	tester("Shivaram*", "shivaram*!*@*", nil)
+	tester("*SHIVARAM*", "*shivaram*!*@*", nil)
 }