Browse Source

review fix

tags/v0.12.0
Shivaram Lingamneni 6 years ago
parent
commit
abbbd2c899
2 changed files with 4 additions and 4 deletions
  1. 1
    1
      irc/channel.go
  2. 3
    3
      irc/modes.go

+ 1
- 1
irc/channel.go View File

@@ -690,7 +690,7 @@ func (channel *Channel) applyModeToMember(client *Client, mode modes.Mode, op mo
690 690
 	channel.stateMutex.Lock()
691 691
 	modeset, exists := channel.members[target]
692 692
 	if exists {
693
-		if applied := modeset.SetMode(mode, op == modes.Add); applied {
693
+		if modeset.SetMode(mode, op == modes.Add) {
694 694
 			result = &modes.ModeChange{
695 695
 				Op:   op,
696 696
 				Mode: mode,

+ 3
- 3
irc/modes.go View File

@@ -34,7 +34,7 @@ func ApplyUserModeChanges(client *Client, changes modes.ModeChanges, force bool)
34 34
 					continue
35 35
 				}
36 36
 
37
-				if changed := client.SetMode(change.Mode, true); changed {
37
+				if client.SetMode(change.Mode, true) {
38 38
 					if change.Mode == modes.Invisible {
39 39
 						client.server.stats.ChangeInvisible(1)
40 40
 					} else if change.Mode == modes.Operator || change.Mode == modes.LocalOperator {
@@ -44,7 +44,7 @@ func ApplyUserModeChanges(client *Client, changes modes.ModeChanges, force bool)
44 44
 				}
45 45
 
46 46
 			case modes.Remove:
47
-				if changed := client.SetMode(change.Mode, false); changed {
47
+				if client.SetMode(change.Mode, false) {
48 48
 					if change.Mode == modes.Invisible {
49 49
 						client.server.stats.ChangeInvisible(-1)
50 50
 					} else if change.Mode == modes.Operator || change.Mode == modes.LocalOperator {
@@ -216,7 +216,7 @@ func (channel *Channel) ApplyChannelModeChanges(client *Client, isSamode bool, c
216 216
 				continue
217 217
 			}
218 218
 
219
-			if changed := channel.flags.SetMode(change.Mode, change.Op == modes.Add); changed {
219
+			if channel.flags.SetMode(change.Mode, change.Op == modes.Add) {
220 220
 				applied = append(applied, change)
221 221
 			}
222 222
 

Loading…
Cancel
Save