Browse Source

make quit logging more consistent

Log it at level INFO for parity with connect / connect-ip
tags/v2.10.0-rc1
Shivaram Lingamneni 2 years ago
parent
commit
42883972a8
1 changed files with 1 additions and 5 deletions
  1. 1
    5
      irc/client.go

+ 1
- 5
irc/client.go View File

@@ -1179,7 +1179,6 @@ func (client *Client) destroy(session *Session) {
1179 1179
 	client.stateMutex.Lock()
1180 1180
 
1181 1181
 	details := client.detailsNoMutex()
1182
-	wasReattach := session != nil && session.client != client
1183 1182
 	sessionRemoved := false
1184 1183
 	registered := client.registered
1185 1184
 	// XXX a temporary (reattaching) client can be marked alwaysOn when it logs in,
@@ -1294,10 +1293,6 @@ func (client *Client) destroy(session *Session) {
1294 1293
 	client.server.semaphores.ClientDestroy.Acquire()
1295 1294
 	defer client.server.semaphores.ClientDestroy.Release()
1296 1295
 
1297
-	if !wasReattach {
1298
-		client.server.logger.Debug("quit", fmt.Sprintf("%s is no longer on the server", details.nick))
1299
-	}
1300
-
1301 1296
 	if registered {
1302 1297
 		client.server.whoWas.Append(client.WhoWas())
1303 1298
 	}
@@ -1347,6 +1342,7 @@ func (client *Client) destroy(session *Session) {
1347 1342
 
1348 1343
 	if registered {
1349 1344
 		client.server.snomasks.Send(sno.LocalQuits, fmt.Sprintf(ircfmt.Unescape("%s$r exited the network"), details.nick))
1345
+		client.server.logger.Info("quit", fmt.Sprintf("%s is no longer on the server", details.nick))
1350 1346
 	}
1351 1347
 }
1352 1348
 

Loading…
Cancel
Save