Browse Source

review fixes

tags/v1.1.0-rc1
Shivaram Lingamneni 5 years ago
parent
commit
15289bd7db
3 changed files with 5 additions and 5 deletions
  1. 1
    1
      gencapdefs.py
  2. 1
    1
      irc/caps/defs.go
  3. 3
    3
      irc/history/history.go

+ 1
- 1
gencapdefs.py View File

@@ -163,7 +163,7 @@ CAPDEFS = [
163 163
         identifier="EventPlayback",
164 164
         name="draft/event-playback",
165 165
         url="https://github.com/ircv3/ircv3-specifications/pull/362",
166
-        standard="Draft IRCv3",
166
+        standard="Proposed IRCv3",
167 167
     ),
168 168
 ]
169 169
 

+ 1
- 1
irc/caps/defs.go View File

@@ -109,7 +109,7 @@ const (
109 109
 	// https://wiki.znc.in/Query_buffers
110 110
 	ZNCSelfMessage Capability = iota
111 111
 
112
-	// EventPlayback is the Draft IRCv3 capability named "draft/event-playback":
112
+	// EventPlayback is the Proposed IRCv3 capability named "draft/event-playback":
113 113
 	// https://github.com/ircv3/ircv3-specifications/pull/362
114 114
 	EventPlayback Capability = iota
115 115
 )

+ 3
- 3
irc/history/history.go View File

@@ -25,8 +25,8 @@ const (
25 25
 	Nick
26 26
 )
27 27
 
28
-// a Tagmsg that consists entirely of junk tags is not stored
29
-var junkTags = map[string]bool{
28
+// a Tagmsg that consists entirely of transient tags is not stored
29
+var transientTags = map[string]bool{
30 30
 	"+draft/typing": true,
31 31
 	"+typing":       true, // future-proofing
32 32
 }
@@ -60,7 +60,7 @@ func (item *Item) HasMsgid(msgid string) bool {
60 60
 func (item *Item) isStorable() bool {
61 61
 	if item.Type == Tagmsg {
62 62
 		for name := range item.Tags {
63
-			if !junkTags[name] {
63
+			if !transientTags[name] {
64 64
 				return true
65 65
 			}
66 66
 		}

Loading…
Cancel
Save