Browse Source

Merge pull request #195 from slingamn/stopevent

clean up stopEvent (requires go v1.10)
tags/v0.11.0-beta
Daniel Oaks 6 years ago
parent
commit
04d7792ed2
No account linked to committer's email address
1 changed files with 0 additions and 6 deletions
  1. 0
    6
      irc/server.go

+ 0
- 6
irc/server.go View File

@@ -79,8 +79,6 @@ type ListenerWrapper struct {
79 79
 	listener   net.Listener
80 80
 	tlsConfig  *tls.Config
81 81
 	shouldStop bool
82
-	// lets the ListenerWrapper inform the server that it has stopped:
83
-	stopEvent chan bool
84 82
 	// protects atomic update of tlsConfig and shouldStop:
85 83
 	configMutex sync.Mutex // tier 1
86 84
 }
@@ -364,7 +362,6 @@ func (server *Server) createListener(addr string, tlsConfig *tls.Config) *Listen
364 362
 		listener:   listener,
365 363
 		tlsConfig:  tlsConfig,
366 364
 		shouldStop: false,
367
-		stopEvent:  make(chan bool, 1),
368 365
 	}
369 366
 
370 367
 	var shouldStop bool
@@ -395,7 +392,6 @@ func (server *Server) createListener(addr string, tlsConfig *tls.Config) *Listen
395 392
 
396 393
 			if shouldStop {
397 394
 				listener.Close()
398
-				wrapper.stopEvent <- true
399 395
 				return
400 396
 			}
401 397
 		}
@@ -1085,8 +1081,6 @@ func (server *Server) setupListeners(config *Config) {
1085 1081
 		} else {
1086 1082
 			// tell the listener it should stop by interrupting its Accept() call:
1087 1083
 			currentListener.listener.Close()
1088
-			// TODO(golang1.10) delete stopEvent once issue #21856 is released
1089
-			<-currentListener.stopEvent
1090 1084
 			delete(server.listeners, addr)
1091 1085
 			server.logger.Info("listeners", fmt.Sprintf("stopped listening on %s.", addr))
1092 1086
 		}

Loading…
Cancel
Save