channel invite mode/list

irc/channel.go

@@ -323,29 +323,40 @@ func (channel *Channel) applyModeMember(client *Client, mode ChannelMode,
 	return false
 }
 
-func (channel *Channel) applyModeMask(client *Client, mode ChannelMode, op ModeOp, mask string) bool {
-	if !channel.ClientIsOperator(client) {
-		client.ErrChanOPrivIsNeeded(channel)
-		return false
+func (channel *Channel) ShowMaskList(client *Client, mode ChannelMode) {
+	for lmask := range channel.lists[mode].masks {
+		client.RplMaskList(mode, channel, lmask)
 	}
+	client.RplEndOfMaskList(mode, channel)
+}
 
+func (channel *Channel) applyModeMask(client *Client, mode ChannelMode, op ModeOp,
+	mask string) bool {
 	list := channel.lists[mode]
 	if list == nil {
 		// This should never happen, but better safe than panicky.
 		return false
 	}
 
+	if (op == List) || (mask == "") {
+		channel.ShowMaskList(client, mode)
+		return false
+	}
+
+	if !channel.ClientIsOperator(client) {
+		client.ErrChanOPrivIsNeeded(channel)
+		return false
+	}
+
 	if op == Add {
-		list.Add(mask)
-	} else if op == Remove {
-		list.Remove(mask)
+		return list.Add(mask)
 	}
 
-	for lmask := range channel.lists[mode].masks {
-		client.RplMaskList(mode, channel, lmask)
+	if op == Remove {
+		return list.Remove(mask)
 	}
-	client.RplEndOfMaskList(mode, channel)
-	return true
+
+	return false
 }
 
 func (channel *Channel) applyMode(client *Client, change *ChannelModeChange) bool {
@@ -353,7 +364,7 @@ func (channel *Channel) applyMode(client *Client, change *ChannelModeChange) boo
 	case BanMask, ExceptMask, InviteMask:
 		return channel.applyModeMask(client, change.mode, change.op, change.arg)
 
-	case Moderated, NoOutside, OpOnlyTopic, Persistent, Private:
+	case InviteOnly, Moderated, NoOutside, OpOnlyTopic, Persistent, Private:
 		return channel.applyModeFlag(client, change.mode, change.op)
 
 	case Key:

irc/client_lookup_set.go

@@ -194,14 +194,22 @@ func NewUserMaskSet() *UserMaskSet {
 	}
 }
 
-func (set *UserMaskSet) Add(mask string) {
+func (set *UserMaskSet) Add(mask string) bool {
+	if set.masks[mask] {
+		return false
+	}
 	set.masks[mask] = true
 	set.setRegexp()
+	return true
 }
 
-func (set *UserMaskSet) Remove(mask string) {
+func (set *UserMaskSet) Remove(mask string) bool {
+	if !set.masks[mask] {
+		return false
+	}
 	delete(set.masks, mask)
 	set.setRegexp()
+	return true
 }
 
 func (set *UserMaskSet) Match(userhost string) bool {