Explorar el Código

Tidy up util classes

Change-Id: I6d0665e57f6e0e2ff2fb6a18742acb99010e79bf
Depends-On: I0bfd2dc61096dd9670b269463c27d9b00fd9a917
Depends-On: Ia8de3c1a5fdc1eb9cfaa8b29a32bb3efb6d8ce6f
Reviewed-on: http://gerrit.dmdirc.com/2240
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
tags/0.7rc1
Chris Smith hace 12 años
padre
commit
7e0b83a0c8
Se han modificado 30 ficheros con 52 adiciones y 46 borrados
  1. 1
    1
      src/com/dmdirc/util/collections/DoubleMap.java
  2. 1
    1
      src/com/dmdirc/util/collections/EquatableWeakReference.java
  3. 1
    1
      src/com/dmdirc/util/collections/ListObserver.java
  4. 1
    1
      src/com/dmdirc/util/collections/ListenerList.java
  5. 1
    1
      src/com/dmdirc/util/collections/MapList.java
  6. 1
    1
      src/com/dmdirc/util/collections/ObservableList.java
  7. 1
    1
      src/com/dmdirc/util/collections/ObservableListDecorator.java
  8. 1
    1
      src/com/dmdirc/util/collections/QueuedLinkedHashSet.java
  9. 1
    1
      src/com/dmdirc/util/collections/RollingList.java
  10. 1
    1
      src/com/dmdirc/util/collections/WeakList.java
  11. 1
    1
      src/com/dmdirc/util/collections/WeakMapList.java
  12. 2
    1
      src/com/dmdirc/util/io/ConfigFile.java
  13. 1
    1
      src/com/dmdirc/util/io/DownloadListener.java
  14. 5
    5
      src/com/dmdirc/util/io/Downloader.java
  15. 1
    1
      src/com/dmdirc/util/io/InvalidConfigFileException.java
  16. 2
    2
      src/com/dmdirc/util/io/StreamReader.java
  17. 3
    3
      src/com/dmdirc/util/io/StreamUtils.java
  18. 5
    5
      src/com/dmdirc/util/io/TextFile.java
  19. 2
    1
      test/com/dmdirc/util/collections/DoubleMapTest.java
  20. 2
    1
      test/com/dmdirc/util/collections/EquatableWeakReferenceTest.java
  21. 2
    1
      test/com/dmdirc/util/collections/InvalidConfigFileExceptionTest.java
  22. 2
    1
      test/com/dmdirc/util/collections/MapListTest.java
  23. 4
    1
      test/com/dmdirc/util/collections/ObservableListDecoratorTest.java
  24. 2
    1
      test/com/dmdirc/util/collections/RollingListTest.java
  25. 2
    1
      test/com/dmdirc/util/collections/WeakListTest.java
  26. 1
    1
      test/com/dmdirc/util/io/ConfigFileTest.java
  27. 5
    9
      test/com/dmdirc/util/io/TextFileTest.java
  28. 0
    0
      test/com/dmdirc/util/io/test1.txt
  29. 0
    0
      test/com/dmdirc/util/io/test2.txt
  30. 0
    0
      test/com/dmdirc/util/io/test3.txt

src/com/dmdirc/util/DoubleMap.java → src/com/dmdirc/util/collections/DoubleMap.java Ver fichero

@@ -19,7 +19,7 @@
19 19
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
20 20
  * SOFTWARE.
21 21
  */
22
-package com.dmdirc.util;
22
+package com.dmdirc.util.collections;
23 23
 
24 24
 import java.util.AbstractMap.SimpleEntry;
25 25
 import java.util.ArrayList;

src/com/dmdirc/util/EquatableWeakReference.java → src/com/dmdirc/util/collections/EquatableWeakReference.java Ver fichero

@@ -20,7 +20,7 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.collections;
24 24
 
25 25
 import java.lang.ref.Reference;
26 26
 import java.lang.ref.WeakReference;

src/com/dmdirc/util/ListObserver.java → src/com/dmdirc/util/collections/ListObserver.java Ver fichero

@@ -20,7 +20,7 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.collections;
24 24
 
25 25
 /**
26 26
  * Interface for objects interested in being updated about changes to an

src/com/dmdirc/util/ListenerList.java → src/com/dmdirc/util/collections/ListenerList.java Ver fichero

@@ -20,7 +20,7 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.collections;
24 24
 
25 25
 import java.lang.reflect.InvocationHandler;
26 26
 import java.lang.reflect.InvocationTargetException;

src/com/dmdirc/util/MapList.java → src/com/dmdirc/util/collections/MapList.java Ver fichero

@@ -20,7 +20,7 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.collections;
24 24
 
25 25
 import java.util.ArrayList;
26 26
 import java.util.Collection;

src/com/dmdirc/util/ObservableList.java → src/com/dmdirc/util/collections/ObservableList.java Ver fichero

@@ -20,7 +20,7 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.collections;
24 24
 
25 25
 import java.util.List;
26 26
 

src/com/dmdirc/util/ObservableListDecorator.java → src/com/dmdirc/util/collections/ObservableListDecorator.java Ver fichero

@@ -20,7 +20,7 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.collections;
24 24
 
25 25
 import java.util.Collection;
26 26
 import java.util.Iterator;

src/com/dmdirc/util/QueuedLinkedHashSet.java → src/com/dmdirc/util/collections/QueuedLinkedHashSet.java Ver fichero

@@ -20,7 +20,7 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.collections;
24 24
 
25 25
 import java.util.Iterator;
26 26
 import java.util.LinkedHashSet;

src/com/dmdirc/util/RollingList.java → src/com/dmdirc/util/collections/RollingList.java Ver fichero

@@ -19,7 +19,7 @@
19 19
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
20 20
  * SOFTWARE.
21 21
  */
22
-package com.dmdirc.util;
22
+package com.dmdirc.util.collections;
23 23
 
24 24
 import java.util.ArrayList;
25 25
 import java.util.List;

src/com/dmdirc/util/WeakList.java → src/com/dmdirc/util/collections/WeakList.java Ver fichero

@@ -20,7 +20,7 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.collections;
24 24
 
25 25
 import java.lang.ref.WeakReference;
26 26
 import java.util.ArrayList;

src/com/dmdirc/util/WeakMapList.java → src/com/dmdirc/util/collections/WeakMapList.java Ver fichero

@@ -20,7 +20,7 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.collections;
24 24
 
25 25
 import java.util.List;
26 26
 

src/com/dmdirc/util/ConfigFile.java → src/com/dmdirc/util/io/ConfigFile.java Ver fichero

@@ -20,8 +20,9 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.io;
24 24
 
25
+import com.dmdirc.util.collections.MapList;
25 26
 import java.io.File;
26 27
 import java.io.IOException;
27 28
 import java.io.InputStream;

src/com/dmdirc/util/DownloadListener.java → src/com/dmdirc/util/io/DownloadListener.java Ver fichero

@@ -20,7 +20,7 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.io;
24 24
 
25 25
 /**
26 26
  * Defines the method that objects interested in receiving download progress

src/com/dmdirc/util/Downloader.java → src/com/dmdirc/util/io/Downloader.java Ver fichero

@@ -20,7 +20,7 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.io;
24 24
 
25 25
 import java.io.BufferedReader;
26 26
 import java.io.DataOutputStream;
@@ -91,7 +91,7 @@ public final class Downloader {
91 91
                 }
92 92
             } while (line != null);
93 93
         } finally {
94
-            StreamUtil.close(in);
94
+            StreamUtils.close(in);
95 95
         }
96 96
 
97 97
         return res;
@@ -175,8 +175,8 @@ public final class Downloader {
175 175
                 }
176 176
             } while (count > 0);
177 177
         } finally {
178
-            StreamUtil.close(input);
179
-            StreamUtil.close(output);
178
+            StreamUtils.close(input);
179
+            StreamUtils.close(output);
180 180
         }
181 181
     }
182 182
 
@@ -211,7 +211,7 @@ public final class Downloader {
211 211
                 out.writeBytes(postData);
212 212
                 out.flush();
213 213
             } finally {
214
-                StreamUtil.close(out);
214
+                StreamUtils.close(out);
215 215
             }
216 216
         }
217 217
 

src/com/dmdirc/util/InvalidConfigFileException.java → src/com/dmdirc/util/io/InvalidConfigFileException.java Ver fichero

@@ -20,7 +20,7 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.io;
24 24
 
25 25
 /**
26 26
  * Thrown to indicate that a config file is invalid.

src/com/dmdirc/util/StreamReader.java → src/com/dmdirc/util/io/StreamReader.java Ver fichero

@@ -20,7 +20,7 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.io;
24 24
 
25 25
 import java.io.BufferedReader;
26 26
 import java.io.IOException;
@@ -106,7 +106,7 @@ public class StreamReader extends Thread {
106 106
         } catch (IOException ex) {
107 107
             // OH WELL
108 108
         } finally {
109
-            StreamUtil.close(stream);
109
+            StreamUtils.close(stream);
110 110
         }
111 111
     }
112 112
 }

src/com/dmdirc/util/StreamUtil.java → src/com/dmdirc/util/io/StreamUtils.java Ver fichero

@@ -20,7 +20,7 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.io;
24 24
 
25 25
 import java.io.Closeable;
26 26
 import java.io.IOException;
@@ -30,10 +30,10 @@ import java.io.IOException;
30 30
  *
31 31
  * @since 0.6.3m2
32 32
  */
33
-public final class StreamUtil {
33
+public final class StreamUtils {
34 34
 
35 35
     /** Shouldn't be called. */
36
-    private StreamUtil() {
36
+    private StreamUtils() {
37 37
         super();
38 38
     }
39 39
 

src/com/dmdirc/util/TextFile.java → src/com/dmdirc/util/io/TextFile.java Ver fichero

@@ -20,7 +20,7 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.io;
24 24
 
25 25
 import java.io.BufferedReader;
26 26
 import java.io.BufferedWriter;
@@ -141,9 +141,9 @@ public class TextFile {
141 141
                 lines.add(line);
142 142
             }
143 143
         } finally {
144
-            StreamUtil.close(reader);
145
-            StreamUtil.close(inputReader);
146
-            StreamUtil.close(inputStream);
144
+            StreamUtils.close(reader);
145
+            StreamUtils.close(inputReader);
146
+            StreamUtils.close(inputStream);
147 147
         }
148 148
     }
149 149
 
@@ -178,7 +178,7 @@ public class TextFile {
178 178
                 writer.newLine();
179 179
             }
180 180
         } finally {
181
-            StreamUtil.close(writer);
181
+            StreamUtils.close(writer);
182 182
         }
183 183
     }
184 184
 

test/com/dmdirc/util/DoubleMapTest.java → test/com/dmdirc/util/collections/DoubleMapTest.java Ver fichero

@@ -20,8 +20,9 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.collections;
24 24
 
25
+import com.dmdirc.util.collections.DoubleMap;
25 26
 import org.junit.Test;
26 27
 import static org.junit.Assert.*;
27 28
 

test/com/dmdirc/util/EquatableWeakReferenceTest.java → test/com/dmdirc/util/collections/EquatableWeakReferenceTest.java Ver fichero

@@ -19,8 +19,9 @@
19 19
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
20 20
  * SOFTWARE.
21 21
  */
22
-package com.dmdirc.util;
22
+package com.dmdirc.util.collections;
23 23
 
24
+import com.dmdirc.util.collections.EquatableWeakReference;
24 25
 import java.lang.ref.Reference;
25 26
 import java.lang.ref.WeakReference;
26 27
 import org.junit.Test;

test/com/dmdirc/util/InvalidConfigFileExceptionTest.java → test/com/dmdirc/util/collections/InvalidConfigFileExceptionTest.java Ver fichero

@@ -19,8 +19,9 @@
19 19
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
20 20
  * SOFTWARE.
21 21
  */
22
-package com.dmdirc.util;
22
+package com.dmdirc.util.collections;
23 23
 
24
+import com.dmdirc.util.io.InvalidConfigFileException;
24 25
 import org.junit.Test;
25 26
 import static org.junit.Assert.*;
26 27
 

test/com/dmdirc/util/MapListTest.java → test/com/dmdirc/util/collections/MapListTest.java Ver fichero

@@ -20,8 +20,9 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.collections;
24 24
 
25
+import com.dmdirc.util.collections.MapList;
25 26
 import java.util.ArrayList;
26 27
 import java.util.List;
27 28
 import org.junit.Test;

test/com/dmdirc/util/ObservableListDecoratorTest.java → test/com/dmdirc/util/collections/ObservableListDecoratorTest.java Ver fichero

@@ -20,8 +20,11 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.collections;
24 24
 
25
+import com.dmdirc.util.collections.ObservableListDecorator;
26
+import com.dmdirc.util.collections.ObservableList;
27
+import com.dmdirc.util.collections.ListObserver;
25 28
 import java.util.Arrays;
26 29
 import java.util.List;
27 30
 import org.junit.Test;

test/com/dmdirc/util/RollingListTest.java → test/com/dmdirc/util/collections/RollingListTest.java Ver fichero

@@ -20,8 +20,9 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.collections;
24 24
 
25
+import com.dmdirc.util.collections.RollingList;
25 26
 import org.junit.Test;
26 27
 import static org.junit.Assert.*;
27 28
 

test/com/dmdirc/util/WeakListTest.java → test/com/dmdirc/util/collections/WeakListTest.java Ver fichero

@@ -20,8 +20,9 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.collections;
24 24
 
25
+import com.dmdirc.util.collections.WeakList;
25 26
 import org.junit.Test;
26 27
 import static org.junit.Assert.*;
27 28
 

test/com/dmdirc/util/ConfigFileTest.java → test/com/dmdirc/util/io/ConfigFileTest.java Ver fichero

@@ -21,7 +21,7 @@
21 21
  * SOFTWARE.
22 22
  */
23 23
 
24
-package com.dmdirc.util;
24
+package com.dmdirc.util.io;
25 25
 
26 26
 import java.io.File;
27 27
 import java.io.IOException;

test/com/dmdirc/util/TextFileTest.java → test/com/dmdirc/util/io/TextFileTest.java Ver fichero

@@ -20,7 +20,7 @@
20 20
  * SOFTWARE.
21 21
  */
22 22
 
23
-package com.dmdirc.util;
23
+package com.dmdirc.util.io;
24 24
 
25 25
 import java.io.File;
26 26
 import java.io.IOException;
@@ -37,8 +37,7 @@ public class TextFileTest {
37 37
     @Test
38 38
     public void testGetLines() throws IOException {
39 39
         final TextFile file =
40
-                new TextFile(getClass().getClassLoader().
41
-                getResource("com/dmdirc/util/test1.txt").openStream());
40
+                new TextFile(getClass().getResourceAsStream("test1.txt"));
42 41
         final List<String> lines = file.getLines();
43 42
 
44 43
         assertEquals(7, lines.size());
@@ -48,8 +47,7 @@ public class TextFileTest {
48 47
     @Test
49 48
     public void testGetLines2() throws IOException {
50 49
         final TextFile file =
51
-                new TextFile(getClass().getClassLoader().
52
-                getResource("com/dmdirc/util/test1.txt").openStream());
50
+                new TextFile(getClass().getResourceAsStream("test1.txt"));
53 51
         final List<String> lines = file.getLines();
54 52
 
55 53
         assertEquals(7, lines.size());
@@ -76,8 +74,7 @@ public class TextFileTest {
76 74
     @Test(expected=UnsupportedOperationException.class)
77 75
     public void testIllegalWrite() throws IOException {
78 76
         final TextFile file =
79
-                new TextFile(getClass().getClassLoader().
80
-                getResource("com/dmdirc/util/test1.txt").openStream());
77
+                new TextFile(getClass().getResourceAsStream("test1.txt"));
81 78
         file.writeLines(Arrays.asList(new String[]{
82 79
             "hello", "this is a test", "meep"
83 80
         }));
@@ -86,8 +83,7 @@ public class TextFileTest {
86 83
     @Test(expected=UnsupportedOperationException.class)
87 84
     public void testIllegalDelete() throws IOException {
88 85
         final TextFile file =
89
-                new TextFile(getClass().getClassLoader().
90
-                getResource("com/dmdirc/util/test1.txt").openStream());
86
+                new TextFile(getClass().getResourceAsStream("test1.txt"));
91 87
         file.delete();
92 88
     }
93 89
     

test/com/dmdirc/util/test1.txt → test/com/dmdirc/util/io/test1.txt Ver fichero


test/com/dmdirc/util/test2.txt → test/com/dmdirc/util/io/test2.txt Ver fichero


test/com/dmdirc/util/test3.txt → test/com/dmdirc/util/io/test3.txt Ver fichero


Loading…
Cancelar
Guardar