Style fixes

Change-Id: I5a1b323d7ed9f83ff30ad4c2da1f1a7de1662757
Reviewed-on: http://gerrit.dmdirc.com/1945
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

src/com/dmdirc/util/ConfigFile.java

@@ -109,8 +109,8 @@ public class ConfigFile extends TextFile {
         for (String line : getLines()) {
             String tline = line;
 
-            while (!tline.isEmpty() && (tline.charAt(0) == '\t' ||
-                    tline.charAt(0) == ' ')) {
+            while (!tline.isEmpty() && (tline.charAt(0) == '\t'
+                    || tline.charAt(0) == ' ')) {
                 tline = tline.substring(1);
             }
 
@@ -140,8 +140,8 @@ public class ConfigFile extends TextFile {
             } else if (domain != null && !keydomain) {
                 flatdomains.add(domain, unescape(tline));
             } else {
-                throw new InvalidConfigFileException("Unknown or unexpected" +
-                        " line encountered: " + tline);
+                throw new InvalidConfigFileException("Unknown or unexpected"
+                        + " line encountered: " + tline);
             }
         }
     }
@@ -369,4 +369,4 @@ public class ConfigFile extends TextFile {
 
         return -1;
     }
-}
+}

src/com/dmdirc/util/DateUtils.java

@@ -74,8 +74,8 @@ public final class DateUtils {
 
         int seconds = duration;
 
-        seconds -= doDuration(buff, seconds, 60*60*24, "day");
-        seconds -= doDuration(buff, seconds, 60*60, "hour");
+        seconds -= doDuration(buff, seconds, 60 * 60 * 24, "day");
+        seconds -= doDuration(buff, seconds, 60 * 60, "hour");
         seconds -= doDuration(buff, seconds, 60, "minute");
         seconds -= doDuration(buff, seconds, 1, "second");
 

src/com/dmdirc/util/DoubleMap.java

@@ -38,7 +38,7 @@ import java.util.Set;
  * @param <A> The first type of data to be mapped
  * @param <B> The second type of data to be mapped
  */
-public class DoubleMap<A,B> implements Map<A,B> {
+public class DoubleMap<A,B> implements Map<A, B> {
 
     /** The keys in this map. */
     protected final List<A> keys = new ArrayList<A>();
@@ -158,7 +158,7 @@ public class DoubleMap<A,B> implements Map<A,B> {
     /** {@inheritDoc} */
     @Override
     public Set<Entry<A, B>> entrySet() {
-        final HashSet<Entry<A, B>> set = new HashSet<Entry<A, B>>();
+        final Set<Entry<A, B>> set = new HashSet<Entry<A, B>>();
         for (A key : keys) {
             set.add(new SimpleEntry<A, B>(key, getValue(key)));
         }

src/com/dmdirc/util/Downloader.java

@@ -53,11 +53,9 @@ public final class Downloader {
      *
      * @param url The URL to retrieve
      * @return A list of lines received from the server
-     * @throws java.net.MalformedURLException If the URL is malformed
      * @throws java.io.IOException If there's an I/O error while downloading
      */
-    public static List<String> getPage(final String url)
-            throws MalformedURLException, IOException {
+    public static List<String> getPage(final String url) throws IOException {
 
         return getPage(url, "");
     }
@@ -68,11 +66,10 @@ public final class Downloader {
      * @param url The URL to retrieve
      * @param postData The raw POST data to send
      * @return A list of lines received from the server
-     * @throws java.net.MalformedURLException If the URL is malformed
      * @throws java.io.IOException If there's an I/O error while downloading
      */
     public static List<String> getPage(final String url, final String postData)
-            throws MalformedURLException, IOException {
+            throws IOException {
 
         final List<String> res = new ArrayList<String>();
 
@@ -106,12 +103,10 @@ public final class Downloader {
      * @param url The URL to retrieve
      * @param postData A map of post data that should be sent
      * @return A list of lines received from the server
-     * @throws java.net.MalformedURLException If the URL is malformed
      * @throws java.io.IOException If there's an I/O error while downloading
      */
     public static List<String> getPage(final String url,
-            final Map<String, String> postData)
-            throws MalformedURLException, IOException {
+            final Map<String, String> postData) throws IOException {
         final StringBuilder data = new StringBuilder();
 
         for (Map.Entry<String, String> entry : postData.entrySet()) {
@@ -223,4 +218,4 @@ public final class Downloader {
         return urlConn;
     }
 
-}
+}

src/com/dmdirc/util/ReturnableThread.java

@@ -25,7 +25,7 @@ package com.dmdirc.util;
 /**
  * Normal thread with the potential to return a value.
  *
- * @param T Type to be returned
+ * @param <T> Type to be returned
  */
 public abstract class ReturnableThread<T> extends Thread {
 

src/com/dmdirc/util/RollingList.java

@@ -39,7 +39,7 @@ public class RollingList<T> {
     /** Whether or not to add a fake empty item to the end of this list. */
     private final boolean addEmpty;
     /** This list's position pointer. */
-    private int position = 0;
+    private int position;
     /** The "empty" item to be added. */
     private T empty;
 

src/com/dmdirc/util/StreamReader.java

@@ -36,9 +36,9 @@ public class StreamReader extends Thread {
     /** This is the Input Stream we are reading. */
     private final InputStream stream;
     /** List to store output in. */
-    private List<String> list = null;
+    private List<String> list;
     /** StringBuffer to store output in. */
-    private StringBuffer buffer = null; //NOPMD
+    private StringBuffer buffer; // NOPMD
 
     /**
      * Create a new Stream Reader that discards output.
@@ -87,7 +87,7 @@ public class StreamReader extends Thread {
     }
 
     /**
-     * Wait for input on stream, and output/throw away/save to list
+     * Wait for input on stream, and output/throw away/save to list.
      */
     @Override
     public void run() {

src/com/dmdirc/util/WeakList.java

@@ -244,4 +244,4 @@ public class WeakList<T> implements List<T> {
     public List<T> subList(final int fromIndex, final int toIndex) {
         return dereferenceList(list.subList(fromIndex, toIndex));
     }
-}
+}

src/com/dmdirc/util/WeakMapList.java

@@ -33,7 +33,7 @@ import java.util.List;
  * @param <S> the type of keys maintained by this map
  * @param <T> the type of mapped values
  */
-public class WeakMapList<S,T> extends MapList<S,T> {
+public class WeakMapList<S,T> extends MapList<S, T> {
 
     /**
      * Retrieves the list of values associated with the specified key, creating

src/com/dmdirc/util/validators/PortValidator.java

@@ -23,8 +23,6 @@ package com.dmdirc.util.validators;
 
 /**
  * Validates a port number.
- *
- * @author chris
  */
 public class PortValidator extends NumericalValidator {
 
@@ -34,6 +32,9 @@ public class PortValidator extends NumericalValidator {
     /** The maximum port number. */
     private static final int MAX_PORT = 65535;
 
+    /**
+     * Creates a new port validator.
+     */
     public PortValidator() {
         super(MIN_PORT, MAX_PORT);
     }