Previously it only released the instance if the window was closed by the user
interacting with it through the window manager, rather than if it was closed
programatically (through an OK/Cancel button, for example).
Change-Id: I07ef95ebf4e47279c027747b03c5adcd1b37eea4
Reviewed-on: http://gerrit.dmdirc.com/3091
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
This removes the need for cinch, so also removes the related code,
this also lays the foundation for adding a binding framework in
the future.
Change-Id: I62f7c66b25361c56fbb95fa28c74544d894ea476
Fixes-Issue: CLIENT-422
Reviewed-on: http://gerrit.dmdirc.com/3086
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
Use a factory where available, and horrible singleton where not.
(ConfigManager was using a horrible singleton anyway, under the hood,
so it's not that much worse)
Change-Id: I82d215bf22b68d0359fce4c33976a9bf68d2bfda
Reviewed-on: http://gerrit.dmdirc.com/3080
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
For the minute this means the prefs dialog no longer
saves state, it also means there may be some layout
changes with the height loss and parenting change for
sub dialogs launched from preferences settings.
Change-Id: I9c46e6f03920866022cfe063c500f9523a11db6e
Reviewed-on: http://gerrit.dmdirc.com/3071
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
Bundle them up in a static class to avoid having to pass a million deps
around in each and every subclass.
Change-Id: I581e39f9da6f7a4b79ab69d043de4c81111e9b52
Reviewed-on: http://gerrit.dmdirc.com/3064
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Remove the legacy code, which was used in far fewer places than I thought.
Change-Id: I72cfa09e92110163e16a8a43f18a4127560a65c1
Reviewed-on: http://gerrit.dmdirc.com/3063
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Replace remaining legitimate usages with [Keyed]DialogProviders.
Remove the DialogManager itself, all the getters for it, all the places keeping
references around to it, all the dialogs taking it in the constructor, and all
the partridges in pear trees that had one hidden away.
Change-Id: I0a1234960a4e08c0a7c6afc08a5432102b17c125
Reviewed-on: http://gerrit.dmdirc.com/3048
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
This fixes the issues with injection of dialogs and the behaviour of @Singleton.
Move the swing injection related classes into a new package (a new DialogModule
will follow shortly to make use of the DialogProvider).
Also introduce a SwingPreconditions class for asserting method calls are made
on/off the EDT.
Change-Id: I92010f61f2289579603a239ab46b0a304799dedc
Reviewed-on: http://gerrit.dmdirc.com/3044
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Also deprecate the getters in the SwingController that should be
avoided in favour of injection.
Change-Id: I0a6ccc960a4e08d0a7c6afc08a75b89d2b17c125
Reviewed-on: http://gerrit.dmdirc.com/3035
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Down with static methods! Temporarily up with deprecated methods on horrible
global state objects!
Change-Id: Ia279f9199e8ca40dc3031234569a44da042fc617
Reviewed-on: http://gerrit.dmdirc.com/3027
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Move to injecting various things in the addon browser.
Add a deprecated method to the SwingController/Manager to avoid having
to propagate the changes all the way up through the prefs dialog.
Add dependency on the annotation processor library for factories.
Change-Id: I420b85ed73ba6ea02bbbb5fe18411fa18d994011
Reviewed-on: http://gerrit.dmdirc.com/3023
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Greg Holmes