The topic bar should only change the topic when the server informs it
the topic has changed, currently this was changing the text regardless
of whether the topic change was allowed.
Change-Id: Ib4979c324e05a29c2f0b066714f4b410d6a7ca77
Reviewed-on: http://gerrit.dmdirc.com/2303
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
This call is redundant and in the wrong place anyway, so remove it.
(copy creates the dir anyway)
Change-Id: I396799564f93230a547b6aa9faf76e053c5ebe2c
Reviewed-on: http://gerrit.dmdirc.com/2273
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Speed up git version retrieval by using jgit-describe.jar (Built from https://github.com/ShaneMcC/jgit-describe) to describe the git tag rather than shelling out.
This stops plugin jar building taking 2-5 seconds per plugin by shelling out.
Whilst not a fix exactly for CLIENT-330 - it will make it less of a pressing concern. It would still be nice to fix it though.
Change-Id: I23030c6e060ab651e5ecd4aab6d671aa762ac8ac
Reviewed-on: http://gerrit.dmdirc.com/2267
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
Fix for issue CLIENT-312 - Parser shouldn't extend runnable
The parser now defines some new methods:
- connect()
- connect(threadName)
- interrupt()
connect([threadName]) is responsible for creating any required threads
for the parser to run in and maintaining them internally.
interrupt() allows for interrupting these thread if they exist and if
required.
A new base class for parsers has been added to accomodate this with
minimum changes required elsewhere - ThreadedParser which BaseParser
now extends.
ThreadedParser handles the creation of a single controlThread and allows
interrupting it, and also defines an abstract void run() method (which
all existing parsers will already have from extending runnable in the
past) which is used by the controlThread.
Change-Id: I90ac61d56eb623165d3c4211f1c3247fcba823c8
Depends-On: Ib3e884407181adc362394b23fe59f8e3b401d692
Depends-On: I5ef8ea1e988fe9591df0054ad0016c409fc34b3f
Reviewed-on: http://gerrit.dmdirc.com/2257
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
Mass singleton removal spree. Minor tidying in edited classes.
This tidying introduces a DialogManager class which ensures only a
single instance of a dialog can exist at any one time. This will be
expanded in the future to support management of all dialogs.
Change-Id: I506d7dde623628e38fddcd5f81221d9f2cc832ca
Reviewed-on: http://gerrit.dmdirc.com/2246
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
Rewrite Profile wrapper class
Add tests for ProfileManagerModel
Change-Id: I47a5b0bff4754916967b254854929499d73fc69e
Reviewed-on: http://gerrit.dmdirc.com/2238
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
Reorderable list should not be final
Validating textfield doesn't need to take an icon manager, I will fully remove this in a later commit.
Change-Id: I0412f79b951b37d6e72a4fc70d41f0d512731c99
Reviewed-on: http://gerrit.dmdirc.com/2236
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
I touched the mainframe status bar launching, I therefore broken the
client. Bad Greg.
Change-Id: I853ad7d34a42cdba067b9aea6b7d1c6f77850ea3
Reviewed-on: http://gerrit.dmdirc.com/2207
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Expand settings add option renderer should handle nulls.
It is possible for the option list to be empty, when this is the case
the value will be null, this should be handled gracefully.
Fixes CLIENT-320
Change-Id: I15275e2e23f08d0f3bd393528189c5236a956b81
Reviewed-on: http://gerrit.dmdirc.com/2189
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
Chris Smith
Greg Holmes