Speed up git version retrieval by using jgit-describe.jar (Built from https://github.com/ShaneMcC/jgit-describe) to describe the git tag rather than shelling out.
This stops plugin jar building taking 2-5 seconds per plugin by shelling out.
Whilst not a fix exactly for CLIENT-330 - it will make it less of a pressing concern. It would still be nice to fix it though.
Change-Id: I23030c6e060ab651e5ecd4aab6d671aa762ac8ac
Reviewed-on: http://gerrit.dmdirc.com/2267
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
Fix for issue CLIENT-312 - Parser shouldn't extend runnable
The parser now defines some new methods:
- connect()
- connect(threadName)
- interrupt()
connect([threadName]) is responsible for creating any required threads
for the parser to run in and maintaining them internally.
interrupt() allows for interrupting these thread if they exist and if
required.
A new base class for parsers has been added to accomodate this with
minimum changes required elsewhere - ThreadedParser which BaseParser
now extends.
ThreadedParser handles the creation of a single controlThread and allows
interrupting it, and also defines an abstract void run() method (which
all existing parsers will already have from extending runnable in the
past) which is used by the controlThread.
Change-Id: I90ac61d56eb623165d3c4211f1c3247fcba823c8
Depends-On: Ib3e884407181adc362394b23fe59f8e3b401d692
Depends-On: I5ef8ea1e988fe9591df0054ad0016c409fc34b3f
Reviewed-on: http://gerrit.dmdirc.com/2257
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
Mass singleton removal spree. Minor tidying in edited classes.
This tidying introduces a DialogManager class which ensures only a
single instance of a dialog can exist at any one time. This will be
expanded in the future to support management of all dialogs.
Change-Id: I506d7dde623628e38fddcd5f81221d9f2cc832ca
Reviewed-on: http://gerrit.dmdirc.com/2246
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
Rewrite Profile wrapper class
Add tests for ProfileManagerModel
Change-Id: I47a5b0bff4754916967b254854929499d73fc69e
Reviewed-on: http://gerrit.dmdirc.com/2238
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
Reorderable list should not be final
Validating textfield doesn't need to take an icon manager, I will fully remove this in a later commit.
Change-Id: I0412f79b951b37d6e72a4fc70d41f0d512731c99
Reviewed-on: http://gerrit.dmdirc.com/2236
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
I touched the mainframe status bar launching, I therefore broken the
client. Bad Greg.
Change-Id: I853ad7d34a42cdba067b9aea6b7d1c6f77850ea3
Reviewed-on: http://gerrit.dmdirc.com/2207
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Expand settings add option renderer should handle nulls.
It is possible for the option list to be empty, when this is the case
the value will be null, this should be handled gracefully.
Fixes CLIENT-320
Change-Id: I15275e2e23f08d0f3bd393528189c5236a956b81
Reviewed-on: http://gerrit.dmdirc.com/2189
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
PrefsComponentFactory checkboxes now have transparent backgrounds.
Doing this fixes several UI inconsistancies where the background colour
of the checkbox is incorrect, transparency solves this issue without
needing to change the background colour sindividually.
Fixes CLIENT-310
Change-Id: Ia7da36ffdfadfc2744322203d123fc6805513504
Reviewed-on: http://gerrit.dmdirc.com/2177
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
This unit test has always been flakey, now it appears to just fail,
remove.
Change-Id: I2eae74bfa11ada5535a9ac87fe6fe884c5258261
Reviewed-on: http://gerrit.dmdirc.com/2170
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>
At some point I simplified StandardDialog to handle prepending DMDirc:
to all dialogs, I apparently didn't alter all the dialogs to take this
into account.
Fixes CLIENT-309
Change-Id: I9ed1937b5f09541c775820b9dc17872fb3dd5b5c
Reviewed-on: http://gerrit.dmdirc.com/2161
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Plugin icons are now shown in the plugins panel, this will need to be
changed at a later date when CLIENT-221 is finished and themes are
integrated into this panel.
Issue CLIENT-33
Change-Id: I102920e35ec1a5aa7c49da36894f143458e21331
Reviewed-on: http://gerrit.dmdirc.com/2154
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
Add support for identifying sub plugins to plugin prefs panel.
The sub plugins are now listed, indented, underneath their parent plugin
in the plugins prefs dialog.
Issue CLIENT-33
Change-Id: I71ab1c874ed1359fbce6f2da2e0a46ec5cf899e1
Reviewed-on: http://gerrit.dmdirc.com/2152
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>
For the minute this uses the same font as the textpane, in a later
in a later commit I will rename the setting and add support for custom
fonts in other components.
Change-Id: I7ce0e20e59b880688989cc1e6d52894826eb529b
Reviewed-on: http://gerrit.dmdirc.com/2153
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>
Initial work on redesigning the plugin panel in the prefs dialog.
This iteration brings the plugin information into a panel at the bottom,
it also changes the enable button into a checkbox. This has code added
for improvements later on but the UI elements for this commented out.
Issue CLIENT-33
Change-Id: I6835f140b74e6f8e6ab815e6277504a3aaa0ed47
Reviewed-on: http://gerrit.dmdirc.com/2147
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
Testing of the latest changes to trigger selection meant I didn't test
editing actions, fix the stupid obvious error.
Fixes CLIENT-295
Change-Id: Iddbf28a6377df3e41ab3bdc11c3c7f83e37c428a
Reviewed-on: http://gerrit.dmdirc.com/2139
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
This unit test has become increasingly flakey and increasingly worthless
remove!
Change-Id: I0c2d65923518daf82e69c0420e547bf6679fa9a2
Reviewed-on: http://gerrit.dmdirc.com/2141
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Shane Mc Cormack
Chris Smith