87ee1481d4
Fix some errors in the PMD.
Validate profile names for uniqueness as well as filenames.
Remove spaces from auto generated nickname on creation of profile.
Change-Id: Icae82a9deaceccefd7b87e00215dfa28aa065a1b
Fixes-Issue: CLIENT-461
Fixes-Issue: CLIENT-462
Reviewed-on: http://gerrit.dmdirc.com/3206
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 vuotta sitten
Chris Smith
65918db29d
Basic tests for the conditional execute command.
Change-Id: If958c913451c81321f85f971639d2cbaa98591dc
Reviewed-on: http://gerrit.dmdirc.com/3202
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 vuotta sitten
29a766679d
DI identd plugin
Change-Id: Iddd0d935753c8f9ac45e540e876fec9a0e6a31d0
Reviewed-on: http://gerrit.dmdirc.com/3197
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 vuotta sitten
2e7fbace7d
Ask user for profile name on creation.
Change-Id: Id8f99a90564e09d64d12e0a9edfdccb5a5a25524
Fixes-Issue: CLIENT-434
Reviewed-on: http://gerrit.dmdirc.com/3149
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 vuotta sitten
0379847954
Fix some oddities in the new PMD
Change-Id: I36aaf1c69dfc534a66f921b774f2614092faed68
Reviewed-on: http://gerrit.dmdirc.com/3131
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 vuotta sitten
9195a8a78c
Remove url catcher plugin
Change-Id: Ic2dee5645b5f66972c2f2522fe2a7a679bae42d1
Reviewed-on: http://gerrit.dmdirc.com/3115
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 vuotta sitten
Chris Smith
266876cfa3
Plugin support for FrameContainer changes.
Change-Id: Ida8887d4065db2f26080986a4c426c6de700d65c
Depends-On: I3b95185db3f7e6ef09a6c4f91cd28c88d2c601ba
Reviewed-on: http://gerrit.dmdirc.com/3106
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 vuotta sitten
c7990ef968
Update Copyright to 2014
Change-Id: I3e4fd86a0d19f5167506df5986f7ec256b224820
Reviewed-on: http://gerrit.dmdirc.com/2979
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 vuotta sitten
516f190942
Add test for creating a new profile
Change-Id: Ie888cc35ccae052f73b92885c3fbb17d00c3f529
Reviewed-on: http://gerrit.dmdirc.com/2958
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 vuotta sitten
Chris Smith
0401839790
DI the debug plugin.
Change-Id: I2f2fc47110945c1a35a1b4286cfef4b7a37e4663
Reviewed-on: http://gerrit.dmdirc.com/2929
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 vuotta sitten
Chris Smith
d7ace42485
Use proper Styliser ctor.
Change-Id: I54f787fe528f6a4ddda376b1900a2a0de4ff8605
Reviewed-on: http://gerrit.dmdirc.com/2924
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 vuotta sitten
a9354e7b54
Java 7 conversions
Change-Id: Ic204dbad72378455b5cd9dbd66d29dacf31ddd9c
Reviewed-on: http://gerrit.dmdirc.com/2895
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 vuotta sitten
Chris Smith
956e2267cc
Remove MessageSinkManager singleton.
Change-Id: I1cd8a5676beab1f3aba7f62b064dd5b2c2ce0f61
Depends-On: Iaafcea914d16f33ce98c331084cd3e9c8fdbbeda
Reviewed-on: http://gerrit.dmdirc.com/2822
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 vuotta sitten
3ce4e9f633
Remove most singleton uses of WindowManager.
Change-Id: I1f054c7423106afe3fc49db8dc44613ec11c35bb
Depends-On: Idd97b752328310b4f829a45a43de5fdf6f5712a5
Reviewed-on: http://gerrit.dmdirc.com/2817
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 vuotta sitten
Chris Smith
c6ed9e1029
Pass in CommandControllers to some plugin commands
I got bored about half way through, so more to go at some point.
Change-Id: Id1d18950a69090439ee66ae9e5c8ae874bd30fc4
Reviewed-on: http://gerrit.dmdirc.com/2807
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 vuotta sitten
Chris Smith
d5c2ead64c
Use IdentityFactory in profile dialog.
Change-Id: I3ec770d446faeab2e9b0da14afb4d9e46ff16ee1
Reviewed-on: http://gerrit.dmdirc.com/2782
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 vuotta sitten
Chris Smith
9b258533c7
Remove ConfigManager references.
Change-Id: I583aea35418847062f4b529d9eda809d2e932760
Reviewed-on: http://gerrit.dmdirc.com/2780
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 vuotta sitten
Chris Smith
475117244a
Remove direct Identity usages.
Change-Id: I6a32f3592cb5fc3df99a23eee62ae961ce0fc143
Depends-On: I66b382d54b77ef030d88448e456a83eb98aca216
Reviewed-on: http://gerrit.dmdirc.com/2776
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 vuotta sitten
Chris Smith
526cb3e37b
Use config interfaces where possible.
Change-Id: I5f140e89bfb8c57804d0a500bbc9f5c18555b0e9
Depends-On: Iaabedda2fa68c4e5562bb069dcdf15fa0c3beeea
Reviewed-on: http://gerrit.dmdirc.com/2767
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 vuotta sitten
Chris Smith
28e3529e08
Handle stuff moving.
Change-Id: I94416680dfa9f0ee4896f5a6518889c6eb891909
Depends-On: I8d791451ead4b37f9181a9741e127cbc8b514d46
Reviewed-on: http://gerrit.dmdirc.com/2753
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 vuotta sitten
Chris Smith
0e4e578f75
Remove all IdentityManager references from plugins
Everything now references an IdentityController or IdentityFactory,
and obtains them by injection (or local plugin state) rather than
using a singleton method.
Change-Id: I641e1e0a84f96d928affa310a4e43a42f93d13d4
Reviewed-on: http://gerrit.dmdirc.com/2751
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 vuotta sitten
Chris Smith
23276790c4
Tidy up some plugins
Change-Id: I613acb4e089072dfea68f682aa2c81366c66e1c6
Reviewed-on: http://gerrit.dmdirc.com/2730
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 vuotta sitten
Chris Smith
5fdc06f334
Fix up debug command tests.
Change-Id: I62dfab20d1d457af0af44ccdddd0b584d2406da7
Reviewed-on: http://gerrit.dmdirc.com/2683
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 vuotta sitten
Chris Smith
b3bc4cf09b
Fix the URL Catcher plugin tests.
Change-Id: I1c7a931e6db3dceedf21ffb0b681046655765585
Reviewed-on: http://gerrit.dmdirc.com/2684
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 vuotta sitten
Chris Smith
1c2905d0f6
Make the RedirectCommandTest work sanely.
Mock out everything that it uses, remove dependency on lots of
global state, and re-implement the actual test which was @Ignored.
Change-Id: I40c15e1a624b810a69c678a53fc0741bcec9e8b6
Depends-On: I63879db5c13517cfa60941fce73a2ba01e63f1cd
Reviewed-on: http://gerrit.dmdirc.com/2682
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 vuotta sitten
2ca4779a17
Add base command plugins
Change-Id: I8bb1e5bc9e2ca965ff3687d365a167c9b5ccc746
Depends-On: I1d49bc2e572e44466193b4851646edb01d303998
Reviewed-on: http://gerrit.dmdirc.com/2613
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
11 vuotta sitten
d30f7690e4
Update copyright for 2013
Change-Id: I1eea04000294c228a8f66464c89f92c1a7cd5321
Reviewed-on: http://gerrit.dmdirc.com/2605
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
11 vuotta sitten
ca45e4719f
Revert "Continue main removal"
Revert "Begin removing CommandManager singleton."
This reverts commit eefba0d347 .
Change-Id: Iba86c7f2bf870684e0d41f88d82f16b43d43fe80
Depends-On: I8eb4f70f80292d66e3bdbe9f32766b5f427413c2
Reviewed-on: http://gerrit.dmdirc.com/2600
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
11 vuotta sitten
a0a4b2cb23
Revert "Stop using deprecated Command constructor"
This reverts commit 561acbc78c
Change-Id: I5c5ee3725f681451c74c05f8bd007d5eb7178049
Reviewed-on: http://gerrit.dmdirc.com/2594
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
11 vuotta sitten
561acbc78c
Stop using deprecated Command constructor
Change-Id: I65539646852b5e1542f23a069a1fe2d68cbf4fa6
Reviewed-on: http://gerrit.dmdirc.com/2591
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
11 vuotta sitten
7e7836aa81
Begin removing CommandManager singleton.
Change-Id: I04e90afc89211eee412a511b12baeedf0361b414
Depends-On: Ieb44f09699a2304fa5b07f474989823f02fc78b0
Reviewed-on: http://gerrit.dmdirc.com/2585
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
11 vuotta sitten
b591d5a331
Make main less static.
Don't ask Main for the config directory.
Remove getMain() from Main.
Everything that needs a main now either gets given it, or asks something else.
Unfortunately, a few more dependencies on the static IdentityManager.getIdentityManager()
were introduced, but they can be tackled separately.
Fix unit tests for the above.
Depends-On: I9e42ac7f74453b739209a681d0a31f50c1be2a04
Change-Id: Ib5a9fdea5a2e25d5471d0b849f4f65fa0286d1f8
Reviewed-on: http://gerrit.dmdirc.com/2521
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
11 vuotta sitten
ee95cbe633
Tidy up ident plugin and unit test.
Change-Id: I8a054844c36807361cf46629e1a225fcd1c5f3dc
Depends-On: I34aa3a772f7f777aa31ca6a243ad51bdc86fbb8e
Reviewed-on: http://gerrit.dmdirc.com/2458
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
12 vuotta sitten
ec14d94f2e
Improve unit tests for profile manager dialog, fix bugs they found.
Change-Id: I9741fee955a4eef2449ed2f93a06b8b7b80c5504
Reviewed-on: http://gerrit.dmdirc.com/2435
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
12 vuotta sitten
8e8a1096d9
Remove some more swing tests
Change-Id: I160300dd7e35f3214e3e6bc8d7214cf2fe1c7f51
Reviewed-on: http://gerrit.dmdirc.com/2376
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
12 vuotta sitten
7bba0a8eca
Removes tests that rely on xvfb
Change-Id: I08bb88bdd484bffe076bd6a463bdfa89096e38bd
Reviewed-on: http://gerrit.dmdirc.com/2374
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
12 vuotta sitten
Chris Smith
63edf422d5
Use ReverseFileReader from utils
Change-Id: I3e0c3adb302ee5f4584f3e9040ae6b5edfc447c8
Depends-On: I8fcf1d9e686834dfad9d93c177b97b0ea19fd742
Reviewed-on: http://gerrit.dmdirc.com/2326
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 vuotta sitten
Chris Smith
d5947a33be
Fix some unit tests after Command Parser changes
Change-Id: I2838ac60f809408480d985123fde9427e1e5f0e4
Depends-On: Id8a9fde29d189e1c3cd025a3b9f30f2b575a7280
Reviewed-on: http://gerrit.dmdirc.com/2306
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 vuotta sitten
f40fbcff29
Update copyright for 2012
Change-Id: I559bbd9a7e6abdfc73068d4934cfb0fc9f7ce84c
Reviewed-on: http://gerrit.dmdirc.com/2289
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 vuotta sitten
Chris Smith
fda9c21381
Bye bye deprecations!
Change-Id: Ice72ddf69bba77d321f6037f45793b67847d71b3
Reviewed-on: http://gerrit.dmdirc.com/2284
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 vuotta sitten
Chris Smith
7e7214a8a6
Remove crappy logging plugin tests
Change-Id: I4cb619a3c231d653668a0aa8af9f57c6b760b942
Reviewed-on: http://gerrit.dmdirc.com/2274
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 vuotta sitten
256c07d0fc
Tidy up Logging plugin.
Change-Id: I3b08c6e8316f03d2636802eb43d00350d5be01a0
Reviewed-on: http://gerrit.dmdirc.com/2262
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
12 vuotta sitten
4d80c32e27
Mass singleton removal spree. Minor tidying in edited classes.
This tidying introduces a DialogManager class which ensures only a
single instance of a dialog can exist at any one time. This will be
expanded in the future to support management of all dialogs.
Change-Id: I506d7dde623628e38fddcd5f81221d9f2cc832ca
Reviewed-on: http://gerrit.dmdirc.com/2246
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
12 vuotta sitten
4f724a294c
Rewrite profile manager dialog with Cinch.
Rewrite Profile wrapper class
Add tests for ProfileManagerModel
Change-Id: I47a5b0bff4754916967b254854929499d73fc69e
Reviewed-on: http://gerrit.dmdirc.com/2238
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
12 vuotta sitten
Chris Smith
c7e9a3c076
Fix fallout from util changes
Change-Id: Ia8de3c1a5fdc1eb9cfaa8b29a32bb3efb6d8ce6f
Depends-On: I0bfd2dc61096dd9670b269463c27d9b00fd9a917
Depends-On: I6d0665e57f6e0e2ff2fb6a18742acb99010e79bf
Reviewed-on: http://gerrit.dmdirc.com/2241
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 vuotta sitten
14540d9688
Begin to remove deprecated IdentityManager methods.
Change-Id: I1fc7086057871a9b5f5f6d0ec790ec28b7ee067f
Depends-On: I7c24baa6f2e64302406e656a8931390aff9d3c9d
Reviewed-on: http://gerrit.dmdirc.com/2204
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 vuotta sitten
35424de69a
Remove flakey unit test
This unit test has always been flakey, now it appears to just fail,
remove.
Change-Id: I2eae74bfa11ada5535a9ac87fe6fe884c5258261
Reviewed-on: http://gerrit.dmdirc.com/2170
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
12 vuotta sitten
41c77ef7ed
Move interfaces to a central location.
Depends-On: If624693f050e1aa9cf4cabcd5264518604eb8bcd
Change-Id: I862891efc407a64559788812ee039a9ec565a973
Reviewed-on: http://gerrit.dmdirc.com/2166
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
13 vuotta sitten
Chris Smith
d6a7f72b50
Make some plugins dependency inject the action manager
Change-Id: I4e17c971b445f71363cb434db233eca42131745c
Reviewed-on: http://gerrit.dmdirc.com/2165
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 vuotta sitten
ac5937d6b2
Remove flakey unit test.
This unit test has become increasingly flakey and increasingly worthless
remove!
Change-Id: I0c2d65923518daf82e69c0420e547bf6679fa9a2
Reviewed-on: http://gerrit.dmdirc.com/2141
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
13 vuotta sitten
Greg Holmes
Chris Smith