Make local variables final where appropriate

Change-Id: Ied3a5a2d993bd74c04eaa357bcbef7218871f529
Reviewed-on: http://gerrit.dmdirc.com/2082
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

src/com/dmdirc/addons/dcc/DCCPlugin.java

@@ -150,45 +150,45 @@ public final class DCCPlugin extends BasePlugin implements ActionListener {
                 if (!handleExists(send, jc, nickname, parser,reverse, token)) {
                     return;
                 }
-                boolean resume = handleResume(jc);
-                    if (reverse && !token.isEmpty()) {
-                        new TransferContainer(DCCPlugin.this, send,
-                                "*Receive: " + nickname, nickname, null);
-                        send.setToken(token);
-                        if (resume) {
-                            if (IdentityManager.getGlobalConfig().getOptionBool(
-                                    getDomain(), "receive.reverse.sendtoken")) {
-                                parser.sendCTCP(nickname, "DCC", "RESUME "
-                                        + send.getShortFileName() + " 0 "
-                                        + jc.getSelectedFile().length() + " "
-                                        + token);
-                            } else {
-                                parser.sendCTCP(nickname, "DCC", "RESUME "
-                                        + send.getShortFileName() + " 0 "
-                                        + jc.getSelectedFile().length());
-                            }
+                final boolean resume = handleResume(jc);
+                if (reverse && !token.isEmpty()) {
+                    new TransferContainer(DCCPlugin.this, send,
+                            "*Receive: " + nickname, nickname, null);
+                    send.setToken(token);
+                    if (resume) {
+                        if (IdentityManager.getGlobalConfig().getOptionBool(
+                                getDomain(), "receive.reverse.sendtoken")) {
+                            parser.sendCTCP(nickname, "DCC", "RESUME "
+                                    + send.getShortFileName() + " 0 "
+                                    + jc.getSelectedFile().length() + " "
+                                    + token);
                         } else {
-                            if (listen(send)) {
-                                parser.sendCTCP(nickname, "DCC", "SEND "
-                                        + send.getShortFileName() + " "
-                                        + DCC.ipToLong(getListenIP(parser))
-                                        + " " + send.getPort() + " "
-                                        + send.getFileSize() + " " + token);
-                            }
+                            parser.sendCTCP(nickname, "DCC", "RESUME "
+                                    + send.getShortFileName() + " 0 "
+                                    + jc.getSelectedFile().length());
                         }
                     } else {
-                        new TransferContainer(DCCPlugin.this, send, "Receive: "
-                                + nickname, nickname, null);
-                        if (resume) {
-                            parser.sendCTCP(nickname, "DCC", "RESUME "
+                        if (listen(send)) {
+                            parser.sendCTCP(nickname, "DCC", "SEND "
                                     + send.getShortFileName() + " "
-                                    + send.getPort() + " "
-                                    + jc.getSelectedFile().length());
-                        } else {
-                            send.connect();
+                                    + DCC.ipToLong(getListenIP(parser))
+                                    + " " + send.getPort() + " "
+                                    + send.getFileSize() + " " + token);
                         }
                     }
+                } else {
+                    new TransferContainer(DCCPlugin.this, send, "Receive: "
+                            + nickname, nickname, null);
+                    if (resume) {
+                        parser.sendCTCP(nickname, "DCC", "RESUME "
+                                + send.getShortFileName() + " "
+                                + send.getPort() + " "
+                                + jc.getSelectedFile().length());
+                    } else {
+                        send.connect();
+                    }
                 }
+            }
 
         }, "saveFileThread: " + send.getShortFileName()).start();
     }
@@ -454,7 +454,7 @@ public final class DCCPlugin extends BasePlugin implements ActionListener {
 
         // Ignore incorrect ports, or non-numeric IP/Port
         try {
-            int portInt = Integer.parseInt(port);
+            final int portInt = Integer.parseInt(port);
             if (portInt > 65535 || portInt < 0) {
                 return;
             }

src/com/dmdirc/addons/dcc/TransferContainer.java

@@ -154,7 +154,7 @@ public class TransferContainer extends FrameContainer implements
             percent = getPercent();
         }
 
-        boolean percentageInTitle = IdentityManager.getGlobalConfig()
+        final boolean percentageInTitle = IdentityManager.getGlobalConfig()
                 .getOptionBool(plugin.getDomain(), "general.percentageInTitle");
 
         if (percentageInTitle) {

src/com/dmdirc/addons/dcc/io/DCCTransfer.java

@@ -454,8 +454,8 @@ public class DCCTransfer extends DCC {
     protected boolean handleSend() {
         try {
             final byte[] data = new byte[blockSize];
-            int bytesRead = fileIn.read(data);
-            readSize = readSize + bytesRead;
+            final int bytesRead = fileIn.read(data);
+            readSize += bytesRead;
 
             if (bytesRead > 0) {
                 for (DCCTransferHandler handler : handlers.get(DCCTransferHandler.class)) {

src/com/dmdirc/addons/lagdisplay/PingHistoryPanel.java

@@ -92,9 +92,10 @@ public class PingHistoryPanel extends JPanel {
         g.setFont(g.getFont().deriveFont(10f));
 
         float lastX = -1, lastY = -1;
-        float pixelsperpointX = (getWidth() - 3) / (float) (history.getList().size() == 1 ? 1
+        final float pixelsperpointX = (getWidth() - 3)
+                / (float) (history.getList().size() == 1 ? 1
                 : history.getList().size() - 1);
-        float pixelsperpointY = (getHeight() - 10) / (float) maximum;
+        final float pixelsperpointY = (getHeight() - 10) / (float) maximum;
 
         if (history.isEmpty()) {
             g.drawString("No data", getWidth() / 2 - 25, getHeight() / 2 + 5);
@@ -107,8 +108,8 @@ public class PingHistoryPanel extends JPanel {
         for (int i = 0; i < list.size(); i++) {
             final Long value = list.get(i);
 
-            float x = lastX == -1 ? 2 : lastX + pixelsperpointX;
-            float y = getHeight() - 5 - value * pixelsperpointY;
+            final float x = lastX == -1 ? 2 : lastX + pixelsperpointX;
+            final float y = getHeight() - 5 - value * pixelsperpointY;
 
             if (lastX > -1) {
                 g.drawLine((int) lastX, (int) lastY, (int) x, (int) y);
@@ -125,7 +126,7 @@ public class PingHistoryPanel extends JPanel {
                 final int diffy = (int) (last1 - (10 + rect.getHeight()) / pixelsperpointY);
 
                 float posX = lastX - width + 7;
-                float posY = (float) (lastY + rect.getHeight() / 2) - 1;
+                final float posY = (float) (lastY + rect.getHeight() / 2) - 1;
                 boolean failed = posX < 0;
 
                 // Check left

src/com/dmdirc/addons/logging/LoggingPlugin.java

@@ -579,7 +579,7 @@ public class LoggingPlugin extends BasePlugin implements ActionListener,
         BufferedWriter out = null;
         try {
             if (openFiles.containsKey(filename)) {
-                OpenFile of = openFiles.get(filename);
+                final OpenFile of = openFiles.get(filename);
                 of.lastUsedTime = System.currentTimeMillis();
                 out = of.writer;
             } else {

src/com/dmdirc/addons/parserdebug/ParserDebugCommand.java

@@ -68,7 +68,8 @@ public final class ParserDebugCommand extends Command {
     public void execute(final FrameContainer origin, final CommandArguments commandArgs, final CommandContext context) {
         final boolean isSilent = commandArgs.isSilent();
 
-        Parser parser = ((ServerCommandContext) context).getServer().getParser();
+        final Parser parser = ((ServerCommandContext) context).getServer()
+                .getParser();
 
         if (parser == null) {
             sendLine(origin, isSilent, FORMAT_ERROR, "Unable to get a parser for this window.");
@@ -77,7 +78,7 @@ public final class ParserDebugCommand extends Command {
         if (myPlugin.registeredParsers.containsKey(parser)) {
             try {
                 parser.getCallbackManager().delCallback(DebugInfoListener.class, myPlugin);
-                DebugWindow window = myPlugin.registeredParsers.get(parser);
+                final DebugWindow window = myPlugin.registeredParsers.get(parser);
                 window.addLine("======================", true);
                 window.addLine("No Longer Monitoring: " + parser + " (User Requested)", true);
                 window.addLine("======================", true);
@@ -89,7 +90,8 @@ public final class ParserDebugCommand extends Command {
         } else {
             try {
                 parser.getCallbackManager().addCallback(DebugInfoListener.class, myPlugin);
-                DebugWindow window = new DebugWindow(myPlugin, "Parser Debug", parser, origin.getServer());
+                final DebugWindow window = new DebugWindow(myPlugin,
+                        "Parser Debug", parser, origin.getServer());
                 myPlugin.registeredParsers.put(parser, window);
                 sendLine(origin, isSilent, FORMAT_OUTPUT, "Adding callback ok");
                 window.addLine("======================", true);

src/com/dmdirc/addons/ui_swing/UIUtilities.java

@@ -332,7 +332,7 @@ public final class UIUtilities {
         int width = SwingUtilities.computeStringWidth(fm, clipString);
 
         int nChars = 0;
-        for (int max = string.length(); nChars < max; nChars++) {
+        for (final int max = string.length(); nChars < max; nChars++) {
             width += fm.charWidth(string.charAt(nChars));
             if (width > avaiableWidth) {
                 break;

src/com/dmdirc/addons/ui_swing/components/vetoable/VetoableComboBoxModel.java

@@ -86,7 +86,7 @@ public class VetoableComboBoxModel extends DefaultComboBoxModel {
      */
     protected boolean fireVetoableSelectionChange(final Object newValue) {
         boolean result = true;
-        VetoableChangeEvent event = new VetoableChangeEvent(this, newValue);
+        final VetoableChangeEvent event = new VetoableChangeEvent(this, newValue);
         for (VetoableComboBoxSelectionListener listener :
             listeners.get(VetoableComboBoxSelectionListener.class)) {
                 result &= listener.selectionChanged(event);

src/com/dmdirc/addons/ui_swing/dialogs/prefs/CategoryPanel.java

@@ -131,7 +131,7 @@ public class CategoryPanel extends JPanel {
             @Override
             public void correctBounds(final ComponentWrapper cw) {
                 if (cw.getComponent() == scrollPane) {
-                    int newSize = Math.max(parent.getPanelHeight(),
+                    final int newSize = Math.max(parent.getPanelHeight(),
                             scrollPane.getViewport().getExtentSize().height);
                     parent.setPanelHeight((int) (newSize * 0.95));
                 }

src/com/dmdirc/addons/ui_swing/dialogs/prefs/PrefsCategoryLoader.java

@@ -192,7 +192,7 @@ public class PrefsCategoryLoader extends LoggingSwingWorker<JPanel, Object> {
         final TextLabel label = new TextLabel(setting.getTitle() + ": ", false);
 
 
-        JComponent option = UIUtilities.invokeAndWait(
+        final JComponent option = UIUtilities.invokeAndWait(
                 new ReturnableThread<JComponent>() {
 
             /** {@inheritDoc} */

src/com/dmdirc/addons/ui_swing/dialogs/serversetting/PerformTab.java

@@ -84,15 +84,16 @@ public final class PerformTab extends JPanel implements ActionListener {
 
         add(target, "growx, pushx, wrap");
 
-        Collection<PerformDescription> performList = new ArrayList<PerformDescription>();
+        final Collection<PerformDescription> performList
+                = new ArrayList<PerformDescription>();
 
-        PerformDescription networkPerform = new PerformDescription(
+        final PerformDescription networkPerform = new PerformDescription(
                 PerformType.NETWORK, server.getNetwork());
-        PerformDescription networkProfilePerform = new PerformDescription(
+        final PerformDescription networkProfilePerform = new PerformDescription(
                 PerformType.NETWORK, server.getNetwork() ,server.getProfile().getName());
-        PerformDescription serverPerform = new PerformDescription(
+        final PerformDescription serverPerform = new PerformDescription(
                 PerformType.SERVER, server.getAddress());
-        PerformDescription serverProfilePerform = new PerformDescription(
+        final PerformDescription serverProfilePerform = new PerformDescription(
                 PerformType.SERVER, server.getAddress() ,server.getProfile().getName());
 
         model.addElement(networkPerform);
@@ -130,8 +131,8 @@ public final class PerformTab extends JPanel implements ActionListener {
      */
     @Override
     public void actionPerformed(final ActionEvent e) {
-        PerformDescription perform = (PerformDescription)((JComboBox) e.getSource())
-                .getSelectedItem();
+        final PerformDescription perform
+                = (PerformDescription)((JComboBox) e.getSource()).getSelectedItem();
         performPanel.switchPerform(perform);
     }
 

src/com/dmdirc/addons/ui_swing/dialogs/sslcertificate/CertificateInfoPanel.java

@@ -87,13 +87,13 @@ public class CertificateInfoPanel extends JScrollPane {
                         "alignx right");
                 final TextLabel text = new TextLabel(info.getValue(), false);
                 if (info.isInvalid()) {
-                    SimpleAttributeSet sas = new SimpleAttributeSet();
+                    final SimpleAttributeSet sas = new SimpleAttributeSet();
                     StyleConstants.setForeground(sas, Color.RED);
                     text.getDocument().setParagraphAttributes(0, info.getValue().
                             length(), sas, true);
                 }
                 if (info.isMissing()) {
-                    SimpleAttributeSet sas = new SimpleAttributeSet();
+                    final SimpleAttributeSet sas = new SimpleAttributeSet();
                     StyleConstants.setItalic(sas, true);
                     text.getDocument().setParagraphAttributes(0, info.getValue().
                             length(), sas, true);

src/com/dmdirc/addons/ui_swing/framemanager/windowmenu/WindowMenuFrameManager.java

@@ -254,7 +254,7 @@ public final class WindowMenuFrameManager extends JMenu implements
     }
 
     private JMenu getParentMenu(final FrameContainer window) {
-        FrameContainer parent = window.getParent();
+        final FrameContainer parent = window.getParent();
 
         if (parent == null) {
             return this;

src/com/dmdirc/addons/ui_swing/wizard/StepLayout.java

@@ -171,14 +171,15 @@ public class StepLayout implements LayoutManager2, Serializable {
             }
         }
         synchronized (parent.getTreeLock()) {
-            int componentCount = parent.getComponentCount();
+            final int componentCount = parent.getComponentCount();
             for (int i = 0; i < componentCount; i++) {
-                Component comp = parent.getComponent(i);
+                final Component comp = parent.getComponent(i);
                 if (comp.isVisible()) {
                     comp.setVisible(false);
                     break;
                 }
             }
+
             if (componentCount > 0) {
                 currentStep = stepNumber;
                 parent.getComponent(currentStep).setVisible(true);
@@ -249,14 +250,14 @@ public class StepLayout implements LayoutManager2, Serializable {
     @Override
     public Dimension preferredLayoutSize(final Container parent) {
         synchronized (parent.getTreeLock()) {
-            Insets insets = parent.getInsets();
-            int componentCount = parent.getComponentCount();
+            final Insets insets = parent.getInsets();
+            final int componentCount = parent.getComponentCount();
             int width = 0;
             int height = 0;
 
             for (int i = 0; i < componentCount; i++) {
-                Component comp = parent.getComponent(i);
-                Dimension preferredDimension = comp.getPreferredSize();
+                final Component comp = parent.getComponent(i);
+                final Dimension preferredDimension = comp.getPreferredSize();
                 if (preferredDimension.width > width) {
                     width = preferredDimension.width;
                 }
@@ -277,14 +278,14 @@ public class StepLayout implements LayoutManager2, Serializable {
     @Override
     public Dimension minimumLayoutSize(final Container parent) {
         synchronized (parent.getTreeLock()) {
-            Insets insets = parent.getInsets();
-            int componentCount = parent.getComponentCount();
+            final Insets insets = parent.getInsets();
+            final int componentCount = parent.getComponentCount();
             int width = 0;
             int height = 0;
 
             for (int i = 0; i < componentCount; i++) {
-                Component comp = parent.getComponent(i);
-                Dimension minimumDimension = comp.getMinimumSize();
+                final Component comp = parent.getComponent(i);
+                final Dimension minimumDimension = comp.getMinimumSize();
                 if (minimumDimension.width > width) {
                     width = minimumDimension.width;
                 }
@@ -340,15 +341,15 @@ public class StepLayout implements LayoutManager2, Serializable {
      */
     @Override
     public void invalidateLayout(final Container target) {
-    //Ignore
+        //Ignore
     }
 
     /** {@inheritDoc} */
     @Override
     public void layoutContainer(final Container parent) {
         synchronized (parent.getTreeLock()) {
-            Insets insets = parent.getInsets();
-            int componentCount = parent.getComponentCount();
+            final Insets insets = parent.getInsets();
+            final int componentCount = parent.getComponentCount();
             Component comp = null;
             boolean currentFound = false;
 

src/com/dmdirc/addons/ui_web/DynamicRequestHandler.java

@@ -185,7 +185,7 @@ public class DynamicRequestHandler extends AbstractHandler {
             List<Event> myEvents = client.retrieveEvents();
 
             if (myEvents.isEmpty()) {
-                Continuation continuation = ContinuationSupport
+                final Continuation continuation = ContinuationSupport
                         .getContinuation(request, client.getMutex());
                 client.setContinuation(continuation);
                 continuation.suspend(30000L);