Remove warnings in plugins

Change-Id: Ib35a1f83250d697cd8af514a6d646e49e79234b8
Reviewed-on: http://gerrit.dmdirc.com/3178
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

src/com/dmdirc/addons/notifications/NotificationConfig.java

@@ -43,14 +43,10 @@ import net.miginfocom.swing.MigLayout;
  */
 public class NotificationConfig extends JPanel implements PreferencesInterface {
 
-    /**
-     * A version number for this class. It should be changed whenever the class structure is changed
-     * (or anything else that would prevent serialized objects being unserialized with the new
-     * class).
-     */
+    /** A version number for this class. */
     private static final long serialVersionUID = 1;
     /** Notification method order list. */
-    private ReorderableJList list;
+    private ReorderableJList<String> list;
     /** Notification methods. */
     private final List<String> methods;
     /** The plugin that owns this panel. */
@@ -80,7 +76,7 @@ public class NotificationConfig extends JPanel implements PreferencesInterface {
      * Initialises the components.
      */
     private void initComponents() {
-        list = new ReorderableJList();
+        list = new ReorderableJList<>();
 
         for (String method : methods) {
             list.getModel().addElement(method);
@@ -96,7 +92,7 @@ public class NotificationConfig extends JPanel implements PreferencesInterface {
 
         panel.add(new JLabel("Drag and drop items to reorder"), "wrap");
         panel.add(new JScrollPane(list), "growx, pushx");
-        panel.add(new ListReorderButtonPanel(list), "");
+        panel.add(new ListReorderButtonPanel<>(list), "");
 
         add(panel, "growx, wrap");
 

src/com/dmdirc/addons/nowplaying/ConfigPanel.java

@@ -57,14 +57,10 @@ import net.miginfocom.swing.MigLayout;
 public class ConfigPanel extends JPanel implements PreferencesInterface,
         KeyListener {
 
-    /**
-     * A version number for this class. It should be changed whenever the class structure is changed
-     * (or anything else that would prevent serialized objects being unserialized with the new
-     * class).
-     */
+    /** A version number for this class. */
     private static final long serialVersionUID = 1;
     /** Media source order list. */
-    private ReorderableJList list;
+    private ReorderableJList<String> list;
     /** Media sources. */
     private final List<String> sources;
     /** The plugin that owns this panel. */
@@ -109,7 +105,7 @@ public class ConfigPanel extends JPanel implements PreferencesInterface,
      * Initialises the components.
      */
     private void initComponents() {
-        list = new ReorderableJList();
+        list = new ReorderableJList<>();
 
         for (String source : sources) {
             list.getModel().addElement(source);
@@ -130,7 +126,7 @@ public class ConfigPanel extends JPanel implements PreferencesInterface,
 
         panel.add(new JLabel("Drag and drop items to reorder"), "wrap");
         panel.add(new JScrollPane(list), "growx, pushx");
-        panel.add(new ListReorderButtonPanel(list), "");
+        panel.add(new ListReorderButtonPanel<>(list), "");
 
         add(panel, "growx, wrap");
 
@@ -192,10 +188,10 @@ public class ConfigPanel extends JPanel implements PreferencesInterface,
     public List<String> getSources() {
         final List<String> newSources = new LinkedList<>();
 
-        final Enumeration<?> values = list.getModel().elements();
+        final Enumeration<String> values = list.getModel().elements();
 
         while (values.hasMoreElements()) {
-            newSources.add((String) values.nextElement());
+            newSources.add(values.nextElement());
         }
 
         return newSources;

src/com/dmdirc/addons/scriptplugin/ScriptCommand.java

@@ -134,7 +134,7 @@ public class ScriptCommand extends Command implements IntelligentCommand {
                             final Class<?> logger = Class.forName("com.dmdirc.logger.Logger");
                             if (logger != null) {
                                 final Method exceptionToStringArray = logger.getDeclaredMethod(
-                                        "exceptionToStringArray", new Class[]{Throwable.class});
+                                        "exceptionToStringArray", new Class<?>[]{Throwable.class});
                                 exceptionToStringArray.setAccessible(true);
 
                                 final String[] stacktrace = (String[]) exceptionToStringArray.

src/com/dmdirc/addons/serverlistdialog/Profiles.java

@@ -50,7 +50,7 @@ public class Profiles extends JPanel implements ServerListListener {
     /** Server list model. */
     private final ServerListModel model;
     /** Combo boxes. */
-    private final Map<ServerGroupItem, JComboBox> combos = new HashMap<>();
+    private final Map<ServerGroupItem, JComboBox<ConfigProvider>> combos = new HashMap<>();
     /** Info label. */
     private final JLabel label;
     /** Controller to use to get profiles. */
@@ -102,9 +102,9 @@ public class Profiles extends JPanel implements ServerListListener {
      *
      * @return The server group item's associated profile selection box
      */
-    private JComboBox getComboBox(final ServerGroupItem item) {
+    private JComboBox<ConfigProvider> getComboBox(final ServerGroupItem item) {
         if (!combos.containsKey(item)) {
-            final DefaultComboBoxModel comboModel = new VetoableComboBoxModel();
+            final DefaultComboBoxModel<ConfigProvider> comboModel = new VetoableComboBoxModel<>();
 
             ConfigProvider selectedItem = null;
             comboModel.addElement(null);
@@ -116,7 +116,7 @@ public class Profiles extends JPanel implements ServerListListener {
                 }
             }
             comboModel.setSelectedItem(selectedItem);
-            combos.put(item, new JComboBox(comboModel));
+            combos.put(item, new JComboBox<>(comboModel));
         }
         return combos.get(item);
     }
@@ -125,7 +125,7 @@ public class Profiles extends JPanel implements ServerListListener {
     @Override
     public void dialogClosed(final boolean save) {
         if (save) {
-            for (Entry<ServerGroupItem, JComboBox> entry : combos.entrySet()) {
+            for (Entry<ServerGroupItem, JComboBox<ConfigProvider>> entry : combos.entrySet()) {
                 if (entry.getKey() != null) {
                     if (entry.getValue().getSelectedItem() == null) {
                         entry.getKey().setProfile(null);