Style fixes

Change-Id: Ib8fa12f91b38aecd30fc22b89fba624200c8e22a
Reviewed-on: http://gerrit.dmdirc.com/1946
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

src/com/dmdirc/addons/audio/AudioCommand.java

@@ -33,18 +33,9 @@ import java.io.File;
 
 /**
  * The Audio Command allows playing of audio files.
- *
- * @author Shane "Dataforce" Mc Cormack
  */
 public final class AudioCommand extends Command implements CommandInfo {
 
-    /**
-     * Creates a new instance of LoggingCommand.
-     */
-    public AudioCommand() {
-        super();
-    }
-
     /** {@inheritDoc} */
     @Override
     public void execute(final FrameContainer origin,

src/com/dmdirc/addons/audio/BeepCommand.java

@@ -33,18 +33,9 @@ import java.awt.Toolkit;
 
 /**
  * The Beep Command emits a beep
- *
- * @author Shane "Dataforce" Mc Cormack
  */
 public final class BeepCommand extends Command implements CommandInfo {
 
-    /**
-     * Creates a new instance of BeepCommand.
-     */
-    public BeepCommand() {
-        super();
-    }
-
     /** {@inheritDoc} */
     @Override
     public void execute(final FrameContainer origin,
@@ -77,4 +68,3 @@ public final class BeepCommand extends Command implements CommandInfo {
     }
 
 }
-

src/com/dmdirc/addons/dcc/io/DCC.java

@@ -31,29 +31,21 @@ import java.util.concurrent.atomic.AtomicBoolean;
 /**
  * This class manages the socket and low-level I/O functionality for all
  * types of DCC. Subclasses process the data received by this class.
- *
- * @author Shane 'Dataforce' McCormack
  */
 public abstract class DCC implements Runnable {
 
     /** Address. */
     protected long address = 0;
-
     /** Port. */
     protected int port = 0;
-
     /** Socket used to communicate with. */
     protected Socket socket;
-
     /** The Thread in use for this. */
     private volatile Thread myThread;
-
     /** Are we already running? */
     protected final AtomicBoolean running = new AtomicBoolean();
-
     /** Are we a listen socket? */
     protected boolean listen = false;
-
     /**
      * The current socket in use if this is a listen socket.
      * This reference may be changed if and only if exactly one permit from the
@@ -61,7 +53,6 @@ public abstract class DCC implements Runnable {
      * held by the thread doing the modification.
      */
     private ServerSocket serverSocket;
-
     /**
      * Semaphore to control write access to ServerSocket.
      * If an object acquires a permit from the {@link #serverSocketSem}, then
@@ -70,7 +61,6 @@ public abstract class DCC implements Runnable {
      * acquires a permit from the {@link #serverListeningSem}.
      */
     private final Semaphore serverSocketSem = new Semaphore(1);
-
     /**
      * Semaphore used when we're blocking waiting for connections.
      * If an object acquires a permit from the {@link #serverListeningSem},
@@ -82,13 +72,6 @@ public abstract class DCC implements Runnable {
      */
     private final Semaphore serverListeningSem = new Semaphore(0);
 
-    /**
-     * Creates a new instance of DCC.
-     */
-    public DCC() {
-        super();
-    }
-
     /**
      * Connect this dcc.
      */

src/com/dmdirc/addons/dcc/io/DCCChat.java

@@ -23,6 +23,7 @@
 package com.dmdirc.addons.dcc.io;
 
 import com.dmdirc.addons.dcc.DCCChatHandler;
+
 import java.io.BufferedReader;
 import java.io.IOException;
 import java.io.InputStreamReader;
@@ -30,30 +31,18 @@ import java.io.PrintWriter;
 
 /**
  * This class handles a DCC Chat
- *
- * @author Shane 'Dataforce' McCormack
  */
 public class DCCChat extends DCC {
 
     /** The handler for this DCCChat. */
     private DCCChatHandler handler = null;
-
     /** Used to send data out the socket. */
     private PrintWriter out;
-
     /** Used to read data from the socket. */
     private BufferedReader in;
-
     /** Are we active? */
     private boolean active = false;
 
-    /**
-     * Creates a new instance of DCCChat.
-     */
-    public DCCChat() {
-        super();
-    }
-
     /**
      * Change the handler for this DCC Chat.
      *

src/com/dmdirc/addons/dcop/DcopCommand.java

@@ -33,17 +33,9 @@ import java.util.List;
 
 /**
  * The dcop command retrieves information from a dcop application.
- * @author chris
  */
 public final class DcopCommand extends Command implements CommandInfo {
 
-    /**
-     * Creates a new instance of DcopCommand.
-     */
-    public DcopCommand() {
-        super();
-    }
-
     /** {@inheritDoc} */
     @Override
     public void execute(final FrameContainer origin,

src/com/dmdirc/addons/dcop/DcopPlugin.java

@@ -33,18 +33,12 @@ import java.util.List;
 
 /**
  * Allows the user to execute dcop commands (and read the results).
- *
- * @author chris
  */
 public final class DcopPlugin extends BasePlugin {
+
     /** The DcopCommand we created */
     private DcopCommand command = null;
 
-    /** Creates a new instance of DcopPlugin. */
-    public DcopPlugin() {
-        super();
-    }
-
     /**
      * Retrieves the result from executing the specified command.
      *

src/com/dmdirc/addons/dns/DNSCommand.java

@@ -37,11 +37,6 @@ import java.util.TimerTask;
  */
 public final class DNSCommand extends Command implements CommandInfo {
 
-    /** Creates a new instance of DNSCommand. */
-    public DNSCommand() {
-        super();
-    }
-
     /** {@inheritDoc} */
     @Override
     public void execute(final FrameContainer origin,

src/com/dmdirc/addons/dns/DNSPlugin.java

@@ -39,11 +39,6 @@ public final class DNSPlugin extends BasePlugin {
     /** The DNSCommand we've registered. */
     private DNSCommand command;
 
-    /** Creates a new instance of DNSPlugin. */
-    public DNSPlugin() {
-        super();
-    }
-
     /** {@inheritDoc} */
     @Override
     public void onLoad() {

src/com/dmdirc/addons/freedesktop_notifications/FreeDesktopNotificationsPlugin.java

@@ -47,7 +47,9 @@ import org.apache.commons.lang.StringEscapeUtils;
 /**
  * This plugin adds freedesktop Style Notifications to dmdirc.
  */
-public final class FreeDesktopNotificationsPlugin extends BasePlugin implements ConfigChangeListener {
+public final class FreeDesktopNotificationsPlugin extends BasePlugin
+        implements ConfigChangeListener {
+
     /** The DcopCommand we created */
     private FDNotifyCommand command = null;
     /** notification timeout. */
@@ -61,13 +63,6 @@ public final class FreeDesktopNotificationsPlugin extends BasePlugin implements
     /** Strip codes. */
     private boolean stripcodes;
 
-    /**
-     * Creates a new instance of the FreeDesktopNotifications Plugin.
-     */
-    public FreeDesktopNotificationsPlugin() {
-        super();
-    }
-
     /**
      * Used to show a notification using this plugin.
      *

src/com/dmdirc/addons/mediasource_dcop/AmarokSource.java

@@ -29,16 +29,9 @@ import java.util.List;
 
 /**
  * Uses DCOP to retrieve now playing info from Amarok.
- *
- * @author chris
  */
 public class AmarokSource implements MediaSource {
 
-    /** Instantiates the media source. */
-    public AmarokSource() {
-        //Do nothing
-    }
-
     /** {@inheritDoc} */
     @Override
     public MediaSourceState getState() {

src/com/dmdirc/addons/mediasource_dcop/KaffeineSource.java

@@ -29,16 +29,9 @@ import java.util.List;
 
 /**
  * Uses DCOP to retrieve now playing info from Kaffeine.
- *
- * @author chris
  */
 public class KaffeineSource implements MediaSource {
 
-    /** Instantiates the media source. */
-    public KaffeineSource() {
-        //Do nothing
-    }
-
     /** {@inheritDoc} */
     @Override
     public MediaSourceState getState() {

src/com/dmdirc/addons/mediasource_dcop/NoatunSource.java

@@ -29,16 +29,9 @@ import java.util.List;
 
 /**
  * Uses DCOP to retrieve now playing info from Noatun.
- *
- * @author chris
  */
 public class NoatunSource implements MediaSource {
 
-    /** Instantiates the media source. */
-    public NoatunSource() {
-        //Do nothing
-    }
-
     /** {@inheritDoc} */
     @Override
     public MediaSourceState getState() {

src/com/dmdirc/addons/mediasource_mplayer/MplayerMediaSourcePlugin.java

@@ -35,18 +35,9 @@ import java.util.List;
 /**
  * Provides a media source for mplayer which uses lsof to hackily see what
  * mplayer is currently accessing.
- *
- * @author chris
  */
 public class MplayerMediaSourcePlugin extends BasePlugin implements MediaSource {
 
-    /**
-     * Creates a new instance of MplayerMediaSourcePlugin.
-     */
-    public MplayerMediaSourcePlugin() {
-        super();
-    }
-
     /** {@inheritDoc} */
     @Override
     public void onLoad() {

src/com/dmdirc/addons/notifications/NotificationsPlugin.java

@@ -52,13 +52,6 @@ public class NotificationsPlugin extends BasePlugin implements ActionListener {
     /** The user's preferred order for method usage. */
     private List<String> order;
 
-    /**
-     * Creates a new notifications plugin.
-     */
-    public NotificationsPlugin() {
-        super();
-    }
-
     /** {@inheritDoc} */
     @Override
     public void onLoad() {

src/com/dmdirc/addons/parserdebug/DebugPlugin.java

@@ -39,8 +39,6 @@ import java.util.Map;
 
 /**
  * This causes parser debugging to be spammed to the console.
- *
- * @author Shane 'Dataforce' McCormack
  */
 public final class DebugPlugin extends BasePlugin implements DebugInfoListener, ActionListener {
 
@@ -51,11 +49,6 @@ public final class DebugPlugin extends BasePlugin implements DebugInfoListener,
     protected final Map<Parser, DebugWindow> registeredParsers
             = new HashMap<Parser, DebugWindow>();
 
-    /**
-     * Creates a new instance of the Debug Plugin.
-     */
-    public DebugPlugin() { super(); }
-
     /** {@inheritDoc} */
     @Override
     public void onLoad() {
@@ -73,7 +66,7 @@ public final class DebugPlugin extends BasePlugin implements DebugInfoListener,
         for (Parser parser : registeredParsers.keySet()) {
             try {
                 parser.getCallbackManager().delCallback(DebugInfoListener.class, this);
-                DebugWindow window = registeredParsers.get(parser);
+                final DebugWindow window = registeredParsers.get(parser);
                 windowList.add(window);
             } catch (Exception e) { }
         }
@@ -86,7 +79,7 @@ public final class DebugPlugin extends BasePlugin implements DebugInfoListener,
     /** {@inheritDoc} */
     @Override
     public void onDebugInfo(final Parser parser, final Date date, final int level, final String data) {
-        DebugWindow window = registeredParsers.get(parser);
+        final DebugWindow window = registeredParsers.get(parser);
         if (window != null) {
             window.addLine(String.format("[%d] %s%n", level, data), true);
         }
@@ -100,7 +93,7 @@ public final class DebugPlugin extends BasePlugin implements DebugInfoListener,
             final Parser parser = thisServer.getParser();
             if (registeredParsers.containsKey(parser)) {
                 try {
-                    DebugWindow window = registeredParsers.get(parser);
+                    final DebugWindow window = registeredParsers.get(parser);
                     registeredParsers.remove(parser);
                     window.unsetParser();
                     parser.getCallbackManager().delCallback(DebugInfoListener.class, this);

src/com/dmdirc/addons/relaybot/RelayBotPlugin.java

@@ -51,20 +51,12 @@ import java.util.Map;
 
 /**
  * This plugin makes certain relay bots less obnoxious looking.
- *
- * @author shane
  */
 public class RelayBotPlugin extends BasePlugin implements ActionListener, ConfigChangeListener {
+
     /** Known RelayChannelHandlers. */
     private final Map<Channel, RelayChannelHandler> handlers = new HashMap<Channel, RelayChannelHandler>();
 
-    /**
-     * Creates a new instance of the RelayBotPlugin.
-     */
-    public RelayBotPlugin() {
-        super();
-    }
-
     /** {@inheritDoc} */
     @Override
     public void onLoad() {

src/com/dmdirc/addons/time/TimePlugin.java

@@ -33,27 +33,18 @@ import java.util.TimerTask;
 
 /**
  * Provides various time-related features.
- * @author chris
  */
 public final class TimePlugin  extends BasePlugin {
 
     /** Have we registered our types already? */
     private static boolean registered;
-
     /** The timer to use for scheduling. */
     private Timer timer;
-
     /** The TimerCommand we've registered. */
     private TimerCommand command;
-
     /** The Manager to use for managing timers. */
     private TimerManager manager;
 
-    /** Creates a new instance of TimePlugin. */
-    public TimePlugin() {
-        super();
-    }
-
     /** {@inheritDoc} */
     @Override
     public void onLoad() {

src/com/dmdirc/addons/ui_swing/dialogs/actionsmanager/ActionsManagerDialog.java

@@ -142,8 +142,8 @@ public final class ActionsManagerDialog extends StandardDialog implements
                 getOptionInt("dialogstate", "actionsmanagerdialog");
         if (selected >= 0 && selected < me.groups.getModel().getSize()) {
             me.groups.setSelectedIndex(selected);
-            me.changeActiveGroup((ActionGroup) me.groups.getModel().getElementAt(
-                    selected));
+            me.changeActiveGroup((ActionGroup) me.groups.getModel()
+                    .getElementAt(selected));
         }
     }
 
@@ -175,9 +175,9 @@ public final class ActionsManagerDialog extends StandardDialog implements
     private void initComponents() {
         orderButtons(new JButton(), new JButton());
         infoLabel = new TextLabel("Actions allow you to make DMDirc"
-                + " intelligently respond to various events.  Action groups are "
-                + "there for you to organise groups, add or remove them "
-                + "to suit your needs.");
+                + " intelligently respond to various events.  Action groups are"
+                + " there for you to organise groups, add or remove them"
+                + " to suit your needs.");
         groups = new JList(new SortedListModel<ActionGroup>(
                 new ActionGroupNameComparator()));
         actions = new ActionsGroupPanel(this, null);
@@ -192,14 +192,11 @@ public final class ActionsManagerDialog extends StandardDialog implements
         groupPanel.setName("Groups");
 
         groupPanel.setBorder(BorderFactory.createTitledBorder(UIManager.
-                getBorder("TitledBorder.border"),
-                "Groups"));
+                getBorder("TitledBorder.border"), "Groups"));
         info.setBorder(BorderFactory.createTitledBorder(UIManager.getBorder(
-                "TitledBorder.border"),
-                "Information"));
+                "TitledBorder.border"), "Information"));
         actions.setBorder(BorderFactory.createTitledBorder(UIManager.getBorder(
-                "TitledBorder.border"),
-                "Actions"));
+                "TitledBorder.border"), "Actions"));
 
         groups.setCellRenderer(new ActionGroupListCellRenderer());
         groups.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
@@ -280,7 +277,8 @@ public final class ActionsManagerDialog extends StandardDialog implements
      */
     private void reloadGroups(final ActionGroup selectedGroup) {
         ((DefaultListModel) groups.getModel()).clear();
-        for (ActionGroup group : ActionManager.getActionManager().getGroupsMap().values()) {
+        for (ActionGroup group : ActionManager.getActionManager()
+                .getGroupsMap().values()) {
             ((DefaultListModel) groups.getModel()).addElement(group);
         }
         groups.setSelectedValue(selectedGroup, true);
@@ -348,11 +346,7 @@ public final class ActionsManagerDialog extends StandardDialog implements
                 ModalityType.DOCUMENT_MODAL, "New action group",
                 "Please enter the name of the new action group", validator) {
 
-            /**
-             * A version number for this class. It should be changed whenever the class
-             * structure is changed (or anything else that would prevent serialized
-             * objects being unserialized with the new class).
-             */
+            /** Java Serialisation verion ID. */
             private static final long serialVersionUID = 1;
 
             /** {@inheritDoc} */
@@ -392,11 +386,7 @@ public final class ActionsManagerDialog extends StandardDialog implements
                 ModalityType.DOCUMENT_MODAL, "Edit action group",
                 "Please enter the new name of the action group", validator) {
 
-            /**
-             * A version number for this class. It should be changed whenever the class
-             * structure is changed (or anything eloh blese that would prevent serialized
-             * objects being unserialized with the new class).
-             */
+            /** Java Serialisation verion ID. */
             private static final long serialVersionUID = 1;
 
             /** {@inheritDoc} */
@@ -437,11 +427,7 @@ public final class ActionsManagerDialog extends StandardDialog implements
                 "Are you sure you wish to delete the '" + group
                 + "' group and all actions within it?") {
 
-            /**
-             * A version number for this class. It should be changed whenever the class
-             * structure is changed (or anything else that would prevent serialized
-             * objects being unserialized with the new class).
-             */
+            /** Java Serialisation verion ID. */
             private static final long serialVersionUID = 1;
 
             /** {@inheritDoc} */

src/com/dmdirc/addons/ui_swing/dialogs/aliases/AliasManagerDialog.java

@@ -153,8 +153,10 @@ public final class AliasManagerDialog extends StandardDialog implements
         tableModel = new AliasTableModel(getTableData());
         table = new PackingTable(tableModel, false, scrollPane, false) {
 
+            /** Java Serialisation verion ID. */
             private static final long serialVersionUID = 1;
 
+            /** {@inheritDoc} */
             @Override
             public TableCellRenderer getCellRenderer(final int row,
                     final int column) {
@@ -309,15 +311,10 @@ public final class AliasManagerDialog extends StandardDialog implements
             if (checkForDuplicates()) {
                 final StandardQuestionDialog dialog = new StandardQuestionDialog(
                         this, ModalityType.APPLICATION_MODAL,
-                        "Duplicate Aliases",
-                        "There are duplicate aliases in the table, these need "
-                        + "to be removed before saving") {
-
-                    /**
-                     * A version number for this class. It should be changed whenever the class
-                     * structure is changed (or anything else that would prevent serialized
-                     * objects being unserialized with the new class).
-                     */
+                        "Duplicate Aliases", "There are duplicate aliases in "
+                        + "the table, these need to be removed before saving") {
+
+                    /** Java Serialisation verion ID. */
                     private static final long serialVersionUID = 1;
 
                     /** {@inheritDoc} */
@@ -329,7 +326,7 @@ public final class AliasManagerDialog extends StandardDialog implements
                     /** {@inheritDoc} */
                     @Override
                     public void cancelled() {
-                        return;
+                        //Ignore
                     }
                 };
                 dialog.getOkButton().setVisible(false);

src/com/dmdirc/addons/ui_swing/dialogs/channelsetting/ChannelListModesPane.java

@@ -310,7 +310,7 @@ public final class ChannelListModesPane extends JPanel implements ActionListener
             /** {@inheritDoc} */
             @Override
             public void cancelled() {
-                return;
+                //Ignore
             }
         }.display();
     }

src/com/dmdirc/addons/ui_swing/dialogs/profiles/Profile.java

@@ -373,12 +373,6 @@ public class Profile {
         return hash;
     }
 
-    /** {@inheritDoc} */
-    @Override
-    protected Object clone() throws CloneNotSupportedException {
-        throw new CloneNotSupportedException();
-    }
-
     /** {@inheritDoc} */
     @Override
     public String toString() {

src/com/dmdirc/addons/ui_swing/dialogs/profiles/ProfileDetailPanel.java

@@ -67,6 +67,10 @@ public final class ProfileDetailPanel extends JPanel implements ActionListener,
      * objects being unserialized with the new class).
      */
     private static final long serialVersionUID = 2;
+    /** Main frame. */
+    private final MainFrame mainFrame;
+    /** Parent window. */
+    private final Window parentWindow;
     /** Displayed profile. */
     private Profile profile;
     /** The profile list model. */
@@ -89,14 +93,10 @@ public final class ProfileDetailPanel extends JPanel implements ActionListener,
     private JButton delButton;
     /** Edit button. */
     private JButton editButton;
-    /** Main frame. */
-    private MainFrame mainFrame;
     /** List border. */
     private Border passBorder;
     /** Validation failed border. */
     private Border failBorder;
-    /** Parent window. */
-    private Window parentWindow;
 
     /**
      * Creates a new profile detail panel.
@@ -315,7 +315,7 @@ public final class ProfileDetailPanel extends JPanel implements ActionListener,
                 /** {@inheritDoc} */
                 @Override
                 public void cancelled() {
-                //Ignore
+                    //Ignore
                 }
             };
             dialog.setText((String) nicknames.getSelectedValue());
@@ -344,7 +344,7 @@ public final class ProfileDetailPanel extends JPanel implements ActionListener,
                 /** {@inheritDoc} */
                 @Override
                 public void cancelled() {
-                    return;
+                    //Ignore
                 }
             }.display();
         }

src/com/dmdirc/addons/ui_swing/dialogs/profiles/ProfileManagerDialog.java

@@ -50,8 +50,7 @@ import net.miginfocom.swing.MigLayout;
 
 /** Profile editing dialog. */
 public final class ProfileManagerDialog extends StandardDialog implements
-        ActionListener,
-        ListSelectionListener {
+        ActionListener, ListSelectionListener {
 
     /**
      * A version number for this class. It should be changed whenever the class
@@ -61,6 +60,8 @@ public final class ProfileManagerDialog extends StandardDialog implements
     private static final long serialVersionUID = 2;
     /** Previously created instance of ProfileEditorDialog. */
     private static volatile ProfileManagerDialog me;
+    /** main frame. */
+    private final MainFrame mainFrame;
     /** Profile list. */
     private JList profileList;
     /** Profile list mode. */
@@ -77,8 +78,6 @@ public final class ProfileManagerDialog extends StandardDialog implements
     private int selectedIndex;
     /** Deleted profiles. */
     private final List<Profile> deletedProfiles;
-    /** main frame. */
-    private MainFrame mainFrame;
 
     /**
      * Creates a new instance of ProfileEditorDialog.
@@ -267,7 +266,7 @@ public final class ProfileManagerDialog extends StandardDialog implements
                 /** {@inheritDoc} */
                 @Override
                 public void cancelled() {
-                    return;
+                    //Ignore
                 }
             }.display();
         }

src/com/dmdirc/addons/ui_swing/dialogs/serversetting/IgnoreListPanel.java

@@ -62,6 +62,8 @@ public final class IgnoreListPanel extends JPanel implements ActionListener,
     private static final long serialVersionUID = 2;
     /** Parent server. */
     private final Server server;
+    /** Parent window. */
+    private final Window parentWindow;
     /** Add button. */
     private JButton addButton;
     /** Remove button. */
@@ -76,8 +78,6 @@ public final class IgnoreListPanel extends JPanel implements ActionListener,
     private IgnoreList cachedIgnoreList;
     /** Ignore list model . */
     private IgnoreListModel listModel;
-    /** Parent window. */
-    private final Window parentWindow;
 
     /**
      * Creates a new instance of IgnoreList.
@@ -235,7 +235,7 @@ public final class IgnoreListPanel extends JPanel implements ActionListener,
                 /** {@inheritDoc} */
                 @Override
                 public void cancelled() {
-                    return;
+                    //Ignore
                 }
             }.display();
         } else if (e.getSource() == viewToggle) {

src/com/dmdirc/addons/ui_swing/framemanager/tree/Tree.java

@@ -59,16 +59,16 @@ public class Tree extends JTree implements MouseMotionListener,
      * objects being unserialized with the new class).
      */
     private static final long serialVersionUID = 1;
+    /** Tree frame manager. */
+    private final TreeFrameManager manager;
+    /** UI Controller. */
+    private final SwingController controller;
     /** Drag selection enabled? */
     private boolean dragSelect;
     /** Drag button 1? */
     private boolean dragButton;
     /** Show handles. */
     private boolean showHandles;
-    /** Tree frame manager. */
-    private TreeFrameManager manager;
-    /** UI Controller. */
-    private SwingController controller;
 
     /**
      * Specialised JTree for frame manager.