Browse Source

Move initUISettings into plugin load

Change-Id: I97c35e939f99fd6df6dc3da51bcda8c1d5579143
Reviewed-on: http://gerrit.dmdirc.com/3309
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
changes/09/3309/2
Greg Holmes 10 years ago
parent
commit
da6f6d8207

+ 2
- 3
src/com/dmdirc/addons/ui_swing/SwingController.java View File

@@ -248,9 +248,6 @@ public class SwingController extends BaseCommandPlugin implements UIController {
248 248
     public void load(final PluginInfo pluginInfo, final ObjectGraph graph) {
249 249
         super.load(pluginInfo, graph);
250 250
 
251
-        // Init the UI settings before we start any DI, as we might create frames etc.
252
-        initUISettings();
253
-
254 251
         setObjectGraph(graph.plus(new SwingModule(this, pluginInfo.getDomain())));
255 252
         getObjectGraph().validate();
256 253
         swingManager = getObjectGraph().get(SwingManager.class);
@@ -269,6 +266,8 @@ public class SwingController extends BaseCommandPlugin implements UIController {
269 266
                     "Swing UI can't be run in a headless environment");
270 267
         }
271 268
 
269
+        // Init the UI settings before we start any DI, as we might create frames etc.
270
+        initUISettings();
272 271
         swingManager.load();
273 272
 
274 273
         UIUtilities.invokeAndWait(new Runnable() {

+ 16
- 16
src/com/dmdirc/addons/ui_swing/SwingManager.java View File

@@ -54,12 +54,12 @@ public class SwingManager {
54 54
     /** The event queue to use. */
55 55
     private final DMDircEventQueue eventQueue;
56 56
     /** The window factory in use. */
57
-    private final SwingWindowFactory windowFactory;
57
+    private final Provider<SwingWindowFactory> windowFactory;
58 58
     /** The status bar manager to register our status bar with. */
59 59
     private final StatusBarManager statusBarManager;
60
-    private final MenuBar menuBar;
60
+    private final Provider<MenuBar> menuBar;
61 61
     /** The status bar in use. */
62
-    private final SwingStatusBar statusBar;
62
+    private final Provider<SwingStatusBar> statusBar;
63 63
     /** The window manager to listen on for events. */
64 64
     private final WindowManager windowManager;
65 65
     private final CtrlTabWindowManager ctrlTabManager;
@@ -82,7 +82,7 @@ public class SwingManager {
82 82
     /** The provider to use to create new main frames. */
83 83
     private final Provider<MainFrame> mainFrameProvider;
84 84
     /** Swing window manager. */
85
-    private final SwingWindowManager swingWindowManager;
85
+    private final Provider<SwingWindowManager> swingWindowManager;
86 86
     /** The main frame of the Swing UI. */
87 87
     private MainFrame mainFrame;
88 88
 
@@ -110,12 +110,12 @@ public class SwingManager {
110 110
     @Inject
111 111
     public SwingManager(
112 112
             final DMDircEventQueue eventQueue,
113
-            final SwingWindowFactory windowFactory,
113
+            final Provider<SwingWindowFactory> windowFactory,
114 114
             final WindowManager windowManager,
115 115
             final StatusBarManager statusBarManager,
116 116
             final Provider<MainFrame> mainFrameProvider,
117
-            final MenuBar menuBar,
118
-            final SwingStatusBar statusBar,
117
+            final Provider<MenuBar> menuBar,
118
+            final Provider<SwingStatusBar> statusBar,
119 119
             final CtrlTabWindowManager ctrlTabManager,
120 120
             final DialogKeyListener dialogKeyListener,
121 121
             final Provider<FirstRunWizardExecutor> firstRunExecutor,
@@ -125,7 +125,7 @@ public class SwingManager {
125 125
             final EventBus eventBus,
126 126
             final TreeFrameManagerProvider treeProvider,
127 127
             final ButtonBarProvider buttonProvider,
128
-            final SwingWindowManager swingWindowManager) {
128
+            final Provider<SwingWindowManager> swingWindowManager) {
129 129
         this.eventQueue = eventQueue;
130 130
         this.windowFactory = windowFactory;
131 131
         this.windowManager = windowManager;
@@ -150,16 +150,16 @@ public class SwingManager {
150 150
      */
151 151
     public void load() {
152 152
         this.mainFrame = mainFrameProvider.get();
153
-        this.mainFrame.setMenuBar(menuBar);
153
+        this.mainFrame.setMenuBar(menuBar.get());
154 154
         this.mainFrame.setWindowManager(ctrlTabManager);
155
-        this.mainFrame.setStatusBar(statusBar);
155
+        this.mainFrame.setStatusBar(statusBar.get());
156 156
         this.mainFrame.initComponents();
157 157
 
158 158
         installEventQueue();
159 159
         installKeyListener();
160 160
 
161
-        windowManager.addListenerAndSync(windowFactory);
162
-        statusBarManager.registerStatusBar(statusBar);
161
+        windowManager.addListenerAndSync(windowFactory.get());
162
+        statusBarManager.registerStatusBar(statusBar.get());
163 163
         eventBus.register(linkHandler);
164 164
     }
165 165
 
@@ -170,13 +170,13 @@ public class SwingManager {
170 170
         uninstallEventQueue();
171 171
         uninstallKeyListener();
172 172
 
173
-        for (final Window window : swingWindowManager.getTopLevelWindows()) {
173
+        for (final Window window : swingWindowManager.get().getTopLevelWindows()) {
174 174
             window.dispose();
175 175
         }
176
-        windowManager.removeListener(windowFactory);
177
-        windowFactory.dispose();
176
+        windowManager.removeListener(windowFactory.get());
177
+        windowFactory.get().dispose();
178 178
         mainFrame.dispose();
179
-        statusBarManager.unregisterStatusBar(statusBar);
179
+        statusBarManager.unregisterStatusBar(statusBar.get());
180 180
         eventBus.unregister(linkHandler);
181 181
     }
182 182
 

+ 0
- 2
src/com/dmdirc/addons/ui_swing/components/statusbar/SwingStatusBar.java View File

@@ -65,8 +65,6 @@ public class SwingStatusBar extends JPanel implements StatusBar {
65 65
     /**
66 66
      * Creates a new instance of SwingStatusBar.
67 67
      *
68
-     * @param controller   Swing controller
69
-     * @param mainFrame    Main frame
70 68
      * @param inviteLabel  The invite label to add to the status bar.
71 69
      * @param updaterLabel The updater label to add to the status bar.
72 70
      * @param errorLabel   The error label to add to the status bar.

Loading…
Cancel
Save