Tidy up icky method.

Change-Id: Icfb8b73ebd18e936523c291b6fc3ac0e9c1bb352
Reviewed-on: http://gerrit.dmdirc.com/3992
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

windowstatus/src/com/dmdirc/addons/windowstatus/WindowStatusManager.java

@@ -40,8 +40,6 @@ import com.dmdirc.parser.interfaces.ChannelInfo;
 import com.dmdirc.parser.interfaces.ClientInfo;
 import com.dmdirc.plugins.PluginDomain;
 
-import java.util.HashMap;
-import java.util.Map;
 import java.util.concurrent.Callable;
 
 import javax.inject.Inject;
@@ -164,50 +162,32 @@ public class WindowStatusManager implements ConfigChangeListener, SelectionListe
     private String updateStatusChannel(final Channel frame) {
         final StringBuilder textString = new StringBuilder();
         final ChannelInfo chan = frame.getChannelInfo();
-        final Map<Integer, String> names = new HashMap<>();
-        final Map<Integer, Integer> types = new HashMap<>();
 
         textString.append(chan.getName());
         textString.append(" - Nicks: ");
         textString.append(chan.getChannelClientCount());
         textString.append(" (");
 
+        final String channelUserModes = ' ' + chan.getParser().getChannelUserModes();
+        final int[] usersWithMode = new int[channelUserModes.length()];
         for (ChannelClientInfo client : chan.getChannelClients()) {
-            String mode = client.getImportantModePrefix();
-            final Integer im = client.getClient().getParser()
-                    .getChannelUserModes().indexOf(mode);
-
-            if (!names.containsKey(im)) {
-                if (mode.isEmpty()) {
-                    if (shownone) {
-                        mode = nonePrefix;
-                    } else {
-                        continue;
-                    }
-                }
-                names.put(im, mode);
-            }
-
-            Integer count = types.get(im);
-
-            if (count == null) {
-                count = 1;
-            } else {
-                count++;
-            }
-            types.put(im, count);
+            final String mode = client.getImportantModePrefix();
+            final int index = channelUserModes.indexOf(mode);
+            usersWithMode[index]++;
         }
 
         boolean isFirst = true;
-
-        for (Map.Entry<Integer, Integer> entry : types.entrySet()) {
-            if (isFirst) {
+        for (int i = channelUserModes.length() - 1; i >= 0; i--) {
+            final int count = usersWithMode[i];
+            if (count > 0 && (shownone || i > 0)) {
+                if (!isFirst) {
+                    textString.append(' ');
+                }
+                final String name = i > 0 ?
+                        Character.toString(channelUserModes.charAt(i)) : nonePrefix;
+                textString.append(count).append(name);
                 isFirst = false;
-            } else {
-                textString.append(' ');
             }
-            textString.append(names.get(entry.getKey()));
-            textString.append(entry.getValue());
         }
 
         textString.append(')');