I'm almost tempted to class this as a bug, but equally i'm not... Add support for hyperlink events in WrapEditorKit so the topic bar URLs are exposed and clickable.

Fixes issue 3739: Topic bar URLs don't appear to work

Change-Id: I8c5412e5e5d6b87b14e0b841ce50be2b204a747e
Reviewed-on: http://gerrit.dmdirc.com/851
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>

src/com/dmdirc/addons/ui_swing/components/TopicBar.java

@@ -265,7 +265,7 @@ public class TopicBar extends JComponent implements ActionListener,
     @Override
     public void hyperlinkUpdate(final HyperlinkEvent e) {
         if (e.getEventType() == HyperlinkEvent.EventType.ACTIVATED) {
-            URLHandler.getURLHander().launchApp(e.getURL());
+            URLHandler.getURLHander().launchApp(e.getDescription());
         }
     }
 

src/com/dmdirc/addons/ui_swing/components/text/WrapEditorKit.java

@@ -1,25 +1,169 @@
 /*
  * @author Stanislav Lapitsky
  * @version 1.0
+ *
+ * Extended for Hyperlink events
  */
 
 package com.dmdirc.addons.ui_swing.components.text;
 
+import com.dmdirc.ui.messages.IRCTextAttribute;
+
+import java.awt.Cursor;
+import java.awt.event.MouseEvent;
+import java.awt.event.MouseListener;
+import java.awt.event.MouseMotionListener;
+
+import javax.swing.JEditorPane;
+import javax.swing.SwingUtilities;
+import javax.swing.event.HyperlinkEvent;
+import javax.swing.text.Element;
+import javax.swing.text.StyledDocument;
 import javax.swing.text.StyledEditorKit;
 import javax.swing.text.ViewFactory;
 
 /**
  * @author Stanislav Lapitsky
  * @version 1.0
+ *
+ * Extended for Hyperlink events
  */
-public class WrapEditorKit extends StyledEditorKit {
+public class WrapEditorKit extends StyledEditorKit implements MouseListener,
+        MouseMotionListener {
 
     private static final long serialVersionUID = 1;
+    /** Wrap column factory. */
     private ViewFactory defaultFactory = new WrapColumnFactory();
+    /** Hand cursor. */
+    private static final Cursor HAND_CURSOR = new Cursor(Cursor.HAND_CURSOR);
+    /** Associated Component. */
+    private JEditorPane editorPane;
+
+    /** {@inheritDoc} */
+    @Override
+    public void install(final JEditorPane c) {
+        super.install(c);
+        editorPane = c;
+        c.addMouseListener(this);
+        c.addMouseMotionListener(this);
+    }
+
+    /** {@inheritDoc} */
+    @Override
+    public void deinstall(final JEditorPane c) {
+        c.removeMouseListener(this);
+        c.removeMouseMotionListener(this);
+        editorPane = null;
+        super.deinstall(c);
+    }
 
     /** {@inheritDoc} */
     @Override
     public ViewFactory getViewFactory() {
         return defaultFactory;
     }
-}
+
+    /**
+     * {@inheritDoc}
+     *
+     * @param e Mouse Event
+     */
+    @Override
+    public void mouseMoved(final MouseEvent e) {
+        if (editorPane == null) {
+            return;
+        }
+        if (!editorPane.isEditable()) {
+            Object target = characterElementAt(e).getAttributes().getAttribute(
+                    IRCTextAttribute.HYPERLINK);
+            if (target != null) {
+                editorPane.setCursor(HAND_CURSOR);
+                return;
+            }
+        }
+        editorPane.setCursor(Cursor.getDefaultCursor());
+    }
+
+    /**
+     * {@inheritDoc}
+     *
+     * @param e Mouse Event
+     */
+    @Override
+    public void mouseReleased(final MouseEvent e) {
+        if (!SwingUtilities.isLeftMouseButton(e) || editorPane == null) {
+            return;
+        }
+        if (!editorPane.isEditable()) {
+            Object target = characterElementAt(e).getAttributes().getAttribute(
+                    IRCTextAttribute.HYPERLINK);
+            if (target != null) {
+                editorPane.fireHyperlinkUpdate(new HyperlinkEvent(editorPane,
+                    HyperlinkEvent.EventType.ACTIVATED, null,
+                    (String) target));
+            }
+        }
+    }
+
+    /**
+     * {@inheritDoc}
+     *
+     * @param e Mouse Event
+     */
+    @Override
+    public void mouseClicked(final MouseEvent e) {
+        //Ignore
+    }
+
+    /**
+     * {@inheritDoc}
+     *
+     * @param e Mouse Event
+     */
+    @Override
+    public void mousePressed(final MouseEvent e) {
+        //Ignore
+    }
+
+    /**
+     * {@inheritDoc}
+     *
+     * @param e Mouse Event
+     */
+    @Override
+    public void mouseEntered(final MouseEvent e) {
+        //Ignore
+    }
+
+    /**
+     * {@inheritDoc}
+     *
+     * @param e Mouse Event
+     */
+    @Override
+    public void mouseExited(final MouseEvent e) {
+        //Ignore
+    }
+
+    /**
+     * {@inheritDoc}
+     *
+     * @param e Mouse Event
+     */
+    @Override
+    public void mouseDragged(final MouseEvent e) {
+        //Ignore
+    }
+
+    /**
+     * Returns the character element for the positition of the mouse event.
+     *
+     * @param e Mouse event to get position from
+     *
+     * @return Character element at mouse event
+     */
+    private Element characterElementAt(final MouseEvent e) {
+        return ((StyledDocument) editorPane.getDocument()).getCharacterElement(
+                editorPane.getUI().viewToModel(editorPane, e.getPoint()));
+    }
+}