Ver código fonte

Tidy up some more getConnection calls.

pull/163/head
Chris Smith 9 anos atrás
pai
commit
bd7182d434

+ 2
- 1
logging/src/com/dmdirc/addons/logging/HistoryWindow.java Ver arquivo

76
     }
76
     }
77
 
77
 
78
     @Override
78
     @Override
79
+    @Deprecated
79
     public Connection getConnection() {
80
     public Connection getConnection() {
80
         return getParent().map(FrameContainer::getConnection).orElse(null);
81
         return getParent().map(FrameContainer::getConnection).orElse(null);
81
     }
82
     }
82
 
83
 
83
     @Override
84
     @Override
84
     public Optional<Connection> getOptionalConnection() {
85
     public Optional<Connection> getOptionalConnection() {
85
-        return getParent().map(FrameContainer::getConnection);
86
+        return getParent().flatMap(FrameContainer::getOptionalConnection);
86
     }
87
     }
87
 
88
 
88
 }
89
 }

+ 3
- 3
logging/src/com/dmdirc/addons/logging/LoggingManager.java Ver arquivo

218
 
218
 
219
     @Handler
219
     @Handler
220
     public void handleQueryOpened(final QueryOpenedEvent event) {
220
     public void handleQueryOpened(final QueryOpenedEvent event) {
221
-        final Parser parser = event.getQuery().getConnection().getParser();
221
+        final Parser parser = event.getQuery().getOptionalConnection().get().getParser();
222
         final ClientInfo client = parser.getClient(event.getQuery().getHost());
222
         final ClientInfo client = parser.getClient(event.getQuery().getHost());
223
         final String filename = getLogFile(client);
223
         final String filename = getLogFile(client);
224
         if (autobackbuffer) {
224
         if (autobackbuffer) {
234
 
234
 
235
     @Handler
235
     @Handler
236
     public void handleQueryClosed(final QueryClosedEvent event) {
236
     public void handleQueryClosed(final QueryClosedEvent event) {
237
-        final Parser parser = event.getQuery().getConnection().getParser();
237
+        final Parser parser = event.getQuery().getOptionalConnection().get().getParser();
238
         final ClientInfo client = parser.getClient(event.getQuery().getHost());
238
         final ClientInfo client = parser.getClient(event.getQuery().getHost());
239
         final String filename = getLogFile(client);
239
         final String filename = getLogFile(client);
240
 
240
 
764
         if (target instanceof Channel) {
764
         if (target instanceof Channel) {
765
             descriptor = target.getName();
765
             descriptor = target.getName();
766
         } else if (target instanceof Query) {
766
         } else if (target instanceof Query) {
767
-            final Parser parser = target.getConnection().getParser();
767
+            final Parser parser = target.getOptionalConnection().get().getParser();
768
             descriptor = parser.getClient(((PrivateChat) target).getHost()).getNickname();
768
             descriptor = parser.getClient(((PrivateChat) target).getHost()).getNickname();
769
         } else {
769
         } else {
770
             // Unknown component
770
             // Unknown component

+ 3
- 3
nickcolours/src/com/dmdirc/addons/nickcolours/NickColourManager.java Ver arquivo

60
     /** Event bus to subscribe to events on . */
60
     /** Event bus to subscribe to events on . */
61
     private final DMDircMBassador eventBus;
61
     private final DMDircMBassador eventBus;
62
     /** "Random" colours to use to colour nicknames. */
62
     /** "Random" colours to use to colour nicknames. */
63
-    private String[] randColours = new String[]{
63
+    private String[] randColours = {
64
         "E90E7F", "8E55E9", "B30E0E", "18B33C", "58ADB3", "9E54B3", "B39875", "3176B3",};
64
         "E90E7F", "8E55E9", "B30E0E", "18B33C", "58ADB3", "9E54B3", "B39875", "3176B3",};
65
     private boolean useowncolour;
65
     private boolean useowncolour;
66
     private String owncolour;
66
     private String owncolour;
81
     @Handler
81
     @Handler
82
     public void handleChannelNames(final ChannelGotnamesEvent event) {
82
     public void handleChannelNames(final ChannelGotnamesEvent event) {
83
         final ChannelInfo chanInfo = event.getChannel().getChannelInfo();
83
         final ChannelInfo chanInfo = event.getChannel().getChannelInfo();
84
-        final String network = event.getChannel().getConnection().getNetwork();
84
+        final String network = event.getChannel().getOptionalConnection().get().getNetwork();
85
 
85
 
86
         for (ChannelClientInfo client : chanInfo.getChannelClients()) {
86
         for (ChannelClientInfo client : chanInfo.getChannelClients()) {
87
             colourClient(network, client);
87
             colourClient(network, client);
90
 
90
 
91
     @Handler
91
     @Handler
92
     public void handleChannelJoin(final ChannelJoinEvent event) {
92
     public void handleChannelJoin(final ChannelJoinEvent event) {
93
-        final String network = event.getChannel().getConnection().getNetwork();
93
+        final String network = event.getChannel().getOptionalConnection().get().getNetwork();
94
         colourClient(network, event.getClient());
94
         colourClient(network, event.getClient());
95
     }
95
     }
96
 
96
 

+ 4
- 2
parserdebug/src/com/dmdirc/addons/parserdebug/ParserDebugCommand.java Ver arquivo

31
 import com.dmdirc.commandparser.commands.context.CommandContext;
31
 import com.dmdirc.commandparser.commands.context.CommandContext;
32
 import com.dmdirc.commandparser.commands.context.ServerCommandContext;
32
 import com.dmdirc.commandparser.commands.context.ServerCommandContext;
33
 import com.dmdirc.interfaces.CommandController;
33
 import com.dmdirc.interfaces.CommandController;
34
+import com.dmdirc.interfaces.Connection;
34
 import com.dmdirc.parser.interfaces.Parser;
35
 import com.dmdirc.parser.interfaces.Parser;
35
 
36
 
36
 import javax.annotation.Nonnull;
37
 import javax.annotation.Nonnull;
76
             final CommandContext context) {
77
             final CommandContext context) {
77
         final boolean isSilent = commandArgs.isSilent();
78
         final boolean isSilent = commandArgs.isSilent();
78
 
79
 
79
-        final Parser parser = ((ServerCommandContext) context).getConnection().getParser();
80
+        final Connection connection = ((ServerCommandContext) context).getConnection();
81
+        final Parser parser = connection.getParser();
80
 
82
 
81
         if (parser == null) {
83
         if (parser == null) {
82
             sendLine(origin, isSilent, FORMAT_ERROR, "Unable to get a parser for this window.");
84
             sendLine(origin, isSilent, FORMAT_ERROR, "Unable to get a parser for this window.");
89
                 sendLine(origin, isSilent, FORMAT_ERROR, "Removing callback failed");
91
                 sendLine(origin, isSilent, FORMAT_ERROR, "Removing callback failed");
90
             }
92
             }
91
         } else {
93
         } else {
92
-            if (parserDebugManager.addParser(parser, origin.getConnection())) {
94
+            if (parserDebugManager.addParser(parser, connection)) {
93
                 sendLine(origin, isSilent, FORMAT_OUTPUT, "Adding callback ok");
95
                 sendLine(origin, isSilent, FORMAT_OUTPUT, "Adding callback ok");
94
             } else {
96
             } else {
95
                 sendLine(origin, isSilent, FORMAT_ERROR, "Adding callback failed");
97
                 sendLine(origin, isSilent, FORMAT_ERROR, "Adding callback failed");

+ 5
- 3
windowstatus/src/com/dmdirc/addons/windowstatus/WindowStatusManager.java Ver arquivo

41
 import com.dmdirc.parser.interfaces.ClientInfo;
41
 import com.dmdirc.parser.interfaces.ClientInfo;
42
 import com.dmdirc.plugins.PluginDomain;
42
 import com.dmdirc.plugins.PluginDomain;
43
 
43
 
44
+import java.util.Optional;
45
+
44
 import javax.inject.Inject;
46
 import javax.inject.Inject;
45
 
47
 
46
 import net.engio.mbassy.listener.Handler;
48
 import net.engio.mbassy.listener.Handler;
192
     private String updateStatusQuery(final Query frame) {
194
     private String updateStatusQuery(final Query frame) {
193
         final StringBuilder textString = new StringBuilder();
195
         final StringBuilder textString = new StringBuilder();
194
         textString.append(frame.getHost());
196
         textString.append(frame.getHost());
195
-        if (showname && frame.getConnection().getParser() != null) {
196
-            final ClientInfo client = frame.getConnection().getParser()
197
-                    .getClient(frame.getHost());
197
+        final Optional<Connection> connection = frame.getOptionalConnection();
198
+        if (showname && connection.isPresent()) {
199
+            final ClientInfo client = connection.get().getParser().getClient(frame.getHost());
198
             final String realname = client.getRealname();
200
             final String realname = client.getRealname();
199
             if (realname != null && !realname.isEmpty()) {
201
             if (realname != null && !realname.isEmpty()) {
200
                 textString.append(" - ");
202
                 textString.append(" - ");

Carregando…
Cancelar
Salvar